Repository navigation
fix(samples): use Entra report downloads and enable default telemetry - #1162
Draft
JiahuiGu (Jiahui-Gu) wants to merge 1 commit into
Draft
JiahuiGu (Jiahui-Gu) wants to merge 1 commit into
JiahuiGu (Jiahui-Gu) wants to merge 1 commit into
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on #1107 to use Microsoft Entra ID for both report uploads and downloads, and make telemetry logging enabled by default without enabling sensitive-content recording.
download_report.py, which uses the caller'sDefaultAzureCredentialand verifies the report digest before writing the output. Reject SAS/query strings and non-Azure Blob endpoints; require a private report container for publication.User-visible changes
Reports no longer use one-hour SAS bearer links. Downloaders must sign in with their own Entra identity and have Blob read access; opening the URL directly in a browser does not automatically authenticate. The README includes Azure CLI and Python download instructions.
The publishing identity needs container-scoped Storage Blob Data Contributor. Download-only users need Storage Blob Data Reader. The revised sample does not require Storage Blob Delegator, account keys, or SAS signing. Container-level Reader access is not per-user report isolation; existing shared CI grants are not revoked by this change.
INFO logs and telemetry instrumentation are enabled by default. Export to Application Insights still requires
APPLICATIONINSIGHTS_CONNECTION_STRING(or configure an OTLP destination); sensitive model/tool content remains opt-in. Standard hosted samples already using the host telemetry setup do not receive a second tracer/provider.Dependency scope
Deep Agents dependencies are unchanged. The three custom runtimes add
microsoft-opentelemetry==1.3.8and compatible frozen locks. This requires OpenTelemetry 1.43 and FastAPI 0.141.1; unchanged package artifact metadata is preserved. Frozen installation and dependency compatibility checks pass for all three runtimes.Validation
Container validation uses the real SDK/host and telemetry distribution, with external model/project/Blob boundaries simulated where needed. Test-owned ACR images have been cleaned up; shared CI resources and IAM are unchanged.
Remaining acceptance
AuthorizationPermissionMismatchfor the current testing identity. Container properties are readable and the container is private; successful live Entra upload/download has not been verified with this identity.Kept as draft pending cloud acceptance and CI review.