Repository navigation
docs: clarify lifecycle registration fallbacks - #2796
Open
Aditya Reddy (adityareddy-dev) wants to merge 1 commit into
Open
Aditya Reddy (adityareddy-dev) wants to merge 1 commit into
Aditya Reddy (adityareddy-dev) wants to merge 1 commit into
Conversation
Aditya Reddy (adityareddy-dev)
requested a review
from a team
as a code owner
November 5, 2026 07:29
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the page lifecycle documentation update.
No open issues 🎉
What changed in this PR
Clarifies the SDK’s page lifecycle documentation, addressing the Chrome unload deprecation context in #2220 and removing claims of guaranteed telemetry delivery.
Changes:
- Documents listener registration order and retries without exclusions.
- Distinguishes successful registration from event dispatch and telemetry delivery.
- Updates Chrome unload guidance and clarifies that configuration examples prefer, rather than enforce, modern events.
| File | Description |
|---|---|
docs/PageUnloadEvents.md |
Clarifies lifecycle registration fallbacks, best-effort delivery, and Chrome unload behavior. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lifecycle guide said the SDK detects events that never fire and guarantees final telemetry delivery.
I clarified the registration order, exclusion retries, and best-effort delivery, and updated the Chrome unload guidance.
Related to #2220