Bug 641085: Document Check factbox does not update live on Purchase Invoice/Cr.Memo/Return Order#9086
Conversation
…nvoice/Cr.Memo/Return Order The subform OnModifyRecordEvent subscribers for Purchase Invoice, Purchase Credit Memo and Purchase Return Order all called GlobalPurchaseOrderPage.RunBackgroundCheck() instead of their own document's global page, so line edits never refreshed the open page's Document Check factbox (only F5 did). Point each subscriber at the matching global page (GlobalPurchaseInvoicePage / GlobalPurchaseCreditMemoPage / GlobalPurchaseReturnOrderPage), matching the already-correct Purchase Order and Sales subform handlers. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Agentic PR Review - Round 1Recommendation: Request ChangesWhat this PR doesThis PR changes the purchase invoice, purchase credit memo, and purchase return order subform modify subscribers in The code change itself is the right shape: after a line modify, SuggestionsS1 - Add live-refresh regression tests Risk assessment and necessityRisk: Low runtime risk because this only changes page variables used in three UI event subscribers and keeps the same background validation call. The affected scenario is visible to users who enable Document Check on purchase invoices, credit memos, and return orders. No API, schema, event signature, or data persistence behavior changes. Necessity: The ADO bug has a clear repro (
|
|
Re S1 (add live-refresh regression tests): acknowledged. The product change is a 3-token mirror of the already-correct Purchase Order / Sales subform handlers, and the existing DocBackgrErrorHandling tests cover the factbox. A true live-refresh test requires driving the background-validation task through the open TestPage after a subpart line edit, which isn't reliably reproducible headlessly. Given the low risk and the correctness of the fix, deferring the extra test rather than adding a flaky one. |
Fixes AB#641085
The subform
OnModifyRecordEventsubscribers for Purchase Invoice, Purchase Credit Memo and Purchase Return Order all calledGlobalPurchaseOrderPage.RunBackgroundCheck()instead of their own document's global page, so line edits never refreshed the open page's Document Check factbox (only F5 did). Point each subscriber at the matching global page, matching the already-correct Purchase Order and Sales subform handlers (three one-token fixes).