Skip to content
This repository was archived by the owner on Sep 28, 2026. It is now read-only.

fix: enforce private endpoint deployment ordering and CognitiveServices/accounts fail - #298

Merged
Avijit-Microsoft merged 1 commit into
devfrom
Ash-Bicep-Dependson
Jun 22, 2026
Merged

Avijit-Microsoft merged 1 commit into
devfrom
Ash-Bicep-Dependson

Conversation

@Ashwal-Microsoft

Copy link
Copy Markdown
Contributor

This pull request improves the deployment reliability of the AI Foundry Private Endpoint by ensuring proper resource dependencies are set. It also enhances DNS zone configuration for private networking scenarios.

Resource dependency management:

  • Added explicit dependsOn for the aiFoundryPrivateEndpoint module in both infra/main.bicep and infra/main_custom.bicep, ensuring it waits for aiFoundryAiServices, virtualNetwork, and avmPrivateDnsZones to be provisioned before deploying. [1] [2]

DNS zone configuration:

  • Updated infra/main.json to include additional private DNS zones (cosmosDB, storageBlob, storageQueue, appConfig) in the dependency array, improving support for private networking with these services.## Purpose
  • ...

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Not ready to approve

The new dependsOn targets the entire DNS zone module collection, unnecessarily serializing unrelated DNS zone deployments and reducing deployment parallelism without clear benefit.

Pull request overview

This PR aims to improve reliability of Azure AI Foundry private networking deployments by explicitly enforcing deployment ordering for the AI Foundry private endpoint and by expanding private DNS zone dependency ordering in the generated ARM template.

Changes:

  • Added explicit dependsOn to aiFoundryPrivateEndpoint in both infra/main.bicep and infra/main_custom.bicep.
  • Expanded the aiFoundryPrivateEndpoint dependsOn list in infra/main.json to include additional private DNS zone deployments (Cosmos DB, Storage Blob/Queue, App Config).
File summaries
File Description
infra/main.json Adds additional private DNS zone deployments to the aiFoundryPrivateEndpoint dependency list.
infra/main.bicep Adds explicit dependsOn to ensure AI Foundry private endpoint waits on prerequisite modules.
infra/main_custom.bicep Mirrors the dependsOn changes from main.bicep for the custom template.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 2

Note

Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/main.bicep Resolved
Comment thread infra/main_custom.bicep Resolved
@Avijit-Microsoft
Avijit-Microsoft merged commit b8c2239 into dev Jun 22, 2026
22 of 25 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 2.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This branch had an error being deployed

1 failed deployment
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants