Repository navigation
fix: enforce private endpoint deployment ordering and CognitiveServices/accounts fail - #298
Conversation
There was a problem hiding this comment.
⚠️ Not ready to approve
The new dependsOn targets the entire DNS zone module collection, unnecessarily serializing unrelated DNS zone deployments and reducing deployment parallelism without clear benefit.
Pull request overview
This PR aims to improve reliability of Azure AI Foundry private networking deployments by explicitly enforcing deployment ordering for the AI Foundry private endpoint and by expanding private DNS zone dependency ordering in the generated ARM template.
Changes:
- Added explicit
dependsOntoaiFoundryPrivateEndpointin bothinfra/main.bicepandinfra/main_custom.bicep. - Expanded the
aiFoundryPrivateEndpointdependsOnlist ininfra/main.jsonto include additional private DNS zone deployments (Cosmos DB, Storage Blob/Queue, App Config).
File summaries
| File | Description |
|---|---|
| infra/main.json | Adds additional private DNS zone deployments to the aiFoundryPrivateEndpoint dependency list. |
| infra/main.bicep | Adds explicit dependsOn to ensure AI Foundry private endpoint waits on prerequisite modules. |
| infra/main_custom.bicep | Mirrors the dependsOn changes from main.bicep for the custom template. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 2
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 2.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This pull request improves the deployment reliability of the AI Foundry Private Endpoint by ensuring proper resource dependencies are set. It also enhances DNS zone configuration for private networking scenarios.
Resource dependency management:
dependsOnfor theaiFoundryPrivateEndpointmodule in bothinfra/main.bicepandinfra/main_custom.bicep, ensuring it waits foraiFoundryAiServices,virtualNetwork, andavmPrivateDnsZonesto be provisioned before deploying. [1] [2]DNS zone configuration:
infra/main.jsonto include additional private DNS zones (cosmosDB,storageBlob,storageQueue,appConfig) in the dependency array, improving support for private networking with these services.## PurposeDoes this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information