Repository navigation
Fix custom marshaller namespaces for root metadata types - #1849
Merged
Merged
Conversation
Avoid empty namespace segments in native typedef and associated enum marshallers. Add build-task generation and compilation coverage for root and nested metadata namespaces on .NET 8 through .NET 10. Fixes #1848 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ad80cd5b-a9a2-4cee-aa3d-030ab5462c4d
Jevan Saks (jevansaks)
marked this pull request as ready for review
October 8, 2026 21:14
Sergio Pedri (Sergio0694)
approved these changes
Oct 8, 2026
Jevan Saks (jevansaks)
enabled auto-merge (squash)
October 8, 2026 21:48
Jevan Saks (jevansaks)
deleted the
jevansaks-flat-namespace-marshallers
branch
October 8, 2026 22:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1848; also addresses the malformed namespace reported in #1632.
InteropServices, avoiding leading dots in namespace declarations and doubled dots in qualified marshaller references.Validation
The root typedef and enum cases reproduced
CS1001: Identifier expectedbefore the fix. After the fix, all 12 new regression cases and 3 neighboring typedef/SafeHandle regression cases pass, with no build warnings or errors.