fix(container-loader): capture websocket ops in full container state - #28009
Draft
Abram Sanderson (Abe27342) wants to merge 2 commits into
Draft
fix(container-loader): capture websocket ops in full container state#28009Abram Sanderson (Abe27342) wants to merge 2 commits into
Abram Sanderson (Abe27342) wants to merge 2 commits into
Conversation
added 2 commits
August 18, 2026 13:53
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 91ea7114-ec37-4f23-9d93-23cca2a2dd50
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 91ea7114-ec37-4f23-9d93-23cca2a2dd50
github-actions
Bot
added
area: tools
area: loader
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (364 lines, 6 files), I've queued these reviewers:
How this works
|
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How contribute to this repo.
Guidelines for Pull Requests.
Description
captureFullContainerStatepreviously retrieved operations only from delta storage. On services such as ODSP, recently sequenced operations may still be available through the delta stream but not yet persisted to storage, causing the captured state to omit recent changes.This change reuses the container load path's
DeltaManagerandConnectionManagerconstruction to merge operations from storage and the live delta stream. Capture waits through the latest sequence known by the connection, then disposes the delta manager to freeze the operation set before serializing the artifact.The added coverage includes a deterministic socket-only operation test and a real-service frozen offline round-trip test. Against ODSP, the new test passes with this change and fails against the previous implementation because the captured artifact contains no post-snapshot operations.
Reviewer Guidance
The review process is outlined in the pull request guidelines.
Please focus on the synchronization and cutoff semantics in
captureFullContainerState, particularly whether disposing the delta manager immediately after catch-up provides the intended stable capture boundary.