Test for text with recursive atom type - #28013
Merged
Joshua Smithrud (Josmithr) merged 1 commit intoAug 19, 2026
Merged
Conversation
Craig Macomber (Microsoft) (CraigMacomber)
requested a review
from a team
as a code owner
August 19, 2026 01:30
github-actions
Bot
added
area: tools
area: dds
Copilot started reviewing on behalf of
Craig Macomber (Microsoft) (CraigMacomber)
August 19, 2026 01:31
View session
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (33 lines, 1 files), I've queued these reviewers:
How this works
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test to ensure FormattedText.createSchema supports additional atom schemas that are recursively defined (i.e., an atom can contain nested formatted text of the same schema), validating behavior for richer inline objects that embed formatted text.
Changes:
- Add a new unit test that defines a recursive
FormattedText.TextAtomwhose schema references the formatted-text schema that includes it. - Validate the recursive schema at compile time via
ValidateRecursiveSchema. - Exercise runtime behavior by inserting a recursive atom and asserting correct
fullString()and extracted atom content.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
brrichards
approved these changes
Aug 19, 2026
Joshua Smithrud (Josmithr)
approved these changes
Aug 19, 2026
Joshua Smithrud (Josmithr)
pushed a commit
to Josmithr/FluidFramework
that referenced
this pull request
Aug 20, 2026
## Description Test for text with recursive atom type ## Reviewer Guidance The review process is outlined in [the pull request guidelines](../docs/content/Contributing/PR-Guidelines.md#guidelines).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test for text with recursive atom type
Reviewer Guidance
The review process is outlined in the pull request guidelines.