Repository navigation
feat: add attributed comments to file previews - #358
Merged
Merged
Conversation
Reuse the existing Preview Comment staging and destination workflow for readonly CodeMirror selections. Preserve source-device path, filesystem version, loaded range and context without importing or rereading the file. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progresses #351 with the approved File Reference Preview Comment phase, following the merged Note Comment phase (#352) and read-only File Explorer (#355).
contentVersion, UTF-16 selection range and loaded-document extent/completeness. Extend the canonical shared quote schema and escaped source-specific renderer; preserve metadata through dispatch, retry, draft consumption/restoration, durable envelopes, transcript/history and browser hydration.PreviewCommentEditor; reuse the same existing-conversation picker, ownership/busy/fork rules and hidden-draft View input notification. Do not create/realize Agents, automatically send or navigate.Scope boundaries
Chat and Note retain existing behavior. Ink/Lasso, raw Note source mode, PDF/Web/Office/media previews and bootstrap execution-machine identity are unchanged. No new endpoint, dependency, subtree modification, remote file write/import or permission expansion. A source-device path is not a claim that the receiving Agent can access that device. The filesystem version is not a content hash or retained historical revision.
Validation
pnpm typecheck,pnpm format,pnpm lint:fix: passed. Lint reports zero errors and 337 existing warnings; focused lint on new implementation/tests is clean. Final affected web/server type checks and formatting/whitespace checks passed.git diff --check: passed.Known limitations
This is a new phase PR to
alpha; it does not merge a PR, close the issue, deploy or release.