Skip to content

fix: resolve nodel version issue - #1181

Merged
Roopan-Microsoft merged 1 commit into
mainfrom
psl-node-update
Oct 28, 2026
Merged

Roopan-Microsoft merged 1 commit into
mainfrom
psl-node-update

Conversation

@NirajC3-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request updates dependencies and improves security for both the frontend and backend environments. The most significant changes are upgrading Node.js and related type packages, as well as applying OS security patches during Docker image builds.

Dependency and Environment Updates:

  • Upgraded Node.js base image in the frontend Dockerfile from node:20-alpine to node:24-alpine to ensure compatibility with newer dependencies and improved performance.
  • Updated @types/node dependency to version ^24.0.0 in both package.json and package-lock.json, and updated undici-types to 7.24.6 for improved type support and compatibility. [1] [2] [3] [4] [5] [6]

Security and Maintenance Improvements:

  • Modified both src/App/Dockerfile and src/mcp_server/Dockerfile to apply OS security patches (apt-get upgrade -y) before installing curl for health checks, ensuring up-to-date system packages and reducing vulnerabilities in the built images. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the Node.js 24 and runtime OS package updates.

No open issues 🎉

1 file not reviewed
  • src/App/package-lock.json: Generated file
What changed in this PR

This PR updates the frontend’s Node.js build environment and type dependencies, and adds OS package upgrades to the App and MCP server runtime images.

Changes:

  • Upgrades the frontend build image from Node.js 20 to 24.
  • Aligns @types/node with Node.js 24 and updates the locked undici-types dependency.
  • Runs apt-get upgrade -y before installing health-check dependencies in both runtime images.
File Description
src/​mcp_server/​Dockerfile Adds OS package upgrades to the final image.
src/​App/​package.json Updates both @types/node declarations to ^24.0.0.
src/​App/​package-lock.json Locks updated Node.js and Undici type packages.
src/​App/​Dockerfile Uses Node.js 24 for frontend builds and upgrades runtime OS packages.

Review effort: Balanced

@Roopan-Microsoft
Roopan-Microsoft merged commit d33fa56 into main Oct 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants