Repository navigation
fix: resolve nodel version issue - #1181
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the Node.js 24 and runtime OS package updates.
No open issues 🎉
1 file not reviewed
src/App/package-lock.json: Generated file
What changed in this PR
This PR updates the frontend’s Node.js build environment and type dependencies, and adds OS package upgrades to the App and MCP server runtime images.
Changes:
- Upgrades the frontend build image from Node.js 20 to 24.
- Aligns
@types/nodewith Node.js 24 and updates the lockedundici-typesdependency. - Runs
apt-get upgrade -ybefore installing health-check dependencies in both runtime images.
| File | Description |
|---|---|
src/mcp_server/Dockerfile |
Adds OS package upgrades to the final image. |
src/App/package.json |
Updates both @types/node declarations to ^24.0.0. |
src/App/package-lock.json |
Locks updated Node.js and Undici type packages. |
src/App/Dockerfile |
Uses Node.js 24 for frontend builds and upgrades runtime OS packages. |
Review effort: Balanced
Roopan-Microsoft
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates dependencies and improves security for both the frontend and backend environments. The most significant changes are upgrading Node.js and related type packages, as well as applying OS security patches during Docker image builds.
Dependency and Environment Updates:
node:20-alpinetonode:24-alpineto ensure compatibility with newer dependencies and improved performance.@types/nodedependency to version^24.0.0in bothpackage.jsonandpackage-lock.json, and updatedundici-typesto7.24.6for improved type support and compatibility. [1] [2] [3] [4] [5] [6]Security and Maintenance Improvements:
src/App/Dockerfileandsrc/mcp_server/Dockerfileto apply OS security patches (apt-get upgrade -y) before installingcurlfor health checks, ensuring up-to-date system packages and reducing vulnerabilities in the built images. [1] [2]Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information