fix: preserve and retry simulation checkpoints after save failures - #169
Open
林SO (Linxiushen) wants to merge 1 commit into
Open
林SO (Linxiushen) wants to merge 1 commit into
林SO (Linxiushen) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the simulation cache is on a different filesystem from the system temporary directory,
Simulation.checkpoint()cannot replace the destination. The failure also clearshas_unsaved_cache_changes, so another checkpoint silently skips the pending trace. Failed writes leave temporary files behind.This change creates the temporary file beside the destination, clears the dirty flag only after successful replacement, and removes temporary files after failures. Existing cache contents remain intact if JSON serialization fails, and the next checkpoint can retry after the destination is repaired.
Validation:
WinError 17, no cache file, and dirty flag cleared; after, the complete trace is saved successfully.python -m pytest tests/unit/test_control_checkpoint.py -q --tb=short -o addopts='': 3 failed / 2 passed before the fix; 5 passed after the fix (Python 3.11, Windows).git diff --check: passed.