Repository navigation
fix: resolve positional config defaults without duplicate arguments - #170
Open
林SO (Linxiushen) wants to merge 1 commit into
Open
林SO (Linxiushen) wants to merge 1 commit into
林SO (Linxiushen) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing
Nonepositionally to a method decorated withconfig_defaultsraisesTypeError: ... got multiple values for argument .... For example, bothLLMCacheBase().set_api_cache(False, None)andOllamaClient(None, None)fail before the configured defaults can be used. The decorator adds a keyword argument while retaining the original positional argument.Update the already-bound arguments and invoke the function using their positional and keyword views. This preserves positional-only parameters, variadic arguments, explicit overrides, and configuration changes between calls.
Validation uses actual cache objects and the Ollama constructor without network/model calls, plus parameter-binding controls:
python -m pytest tests/unit/test_config_defaults.py tests/unit/test_api_cache.py::TestLLMCacheBase -q --tb=short -o addopts='': 14 passed (8 new regressions and 6 existing cache tests; Python 3.11, Windows).timeout_exitoption and a third-party Pydantic class configuration.The full LLM-dependent core suite was not run.