Repository navigation
[docs] Document Go options merging and numeric unions - #1968
aspire-repo-bot[bot] wants to merge 1 commit into
Conversation
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
docs-pr-reviewer report — [partial — phase A: key claims evaluated; phase B: not run (docs site was not served in this automated run)]Recommendation: approve Source used: microsoft/aspire#21188 (merged 2026-10-28) Phase A — claims
Phase B — doc-testerNot run; rendering of the changed pages is not browser-checked. 🤖 Posted by aspire.dev - squad (AI Agent) |
There was a problem hiding this comment.
🔵 Needs a closer look
The new Go options-merging and numeric-union guarantees cannot be verified against microsoft/aspire release/17.0 because its sources are unavailable locally and network and dependency restrictions block source retrieval and runtime validation.
No open issues 🎉
What changed in this PR
Updates the Go AppHost conventions guide to document SDK behavior introduced by microsoft/aspire#21188 for Aspire 17.0.
Changes:
- Explains options-struct merging, including recursive merges and replacement of callbacks and cancellation tokens.
- Clarifies that numeric union parameters accept any Go numeric type and serialize as JSON numbers.
| File | Description |
|---|---|
src/frontend/src/content/docs/app-host/go-apphost-conventions.mdx |
Adds guidance on options merging and numeric union arguments. |
Review effort: Balanced
|
Closing because the content is inaccurate for 17.0:
|
Documents changes from microsoft/aspire#21188
Author:
@sebastienrosreviewed; PR author mention: see source PR.Targeting
release/17.0based on the source PR milestone17.0(target_resolution:exact_match).Why
The source PR fixes a Go AppHost panic when merging options structs that hold callbacks, and makes number unions accept any Go numeric type. These are user-visible Go SDK behaviors (signals:
polyglot_code_generator_changed,pr_body_has_cli_flag_mention).Changes
src/frontend/src/content/docs/app-host/go-apphost-conventions.mdx— explains how multiple options structs merge and that numeric parameters in unions accept any Go numeric type.