Repository navigation
Fix broken links and raw INCLUDE in What's new 9.4/9.5 - #2011
Merged
David Pine (IEvangelist) merged 4 commits intoNov 1, 2026
Merged
Conversation
Replace bare relative cli-reference links, backtick link targets, stale anchors, and a leftover [!INCLUDE] directive with current targets, and add a unit test that scans docs markdown for these link patterns that the links validator does not catch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Frontend HTML artifact readyThe latest frontend build uploaded the This comment updates automatically when a new frontend build artifact is uploaded. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
David Fowler (davidfowl)
marked this pull request as ready for review
October 31, 2026 16:09
David Fowler (davidfowl)
requested a review
from David Pine (IEvangelist)
as a code owner
October 31, 2026 16:09
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The closing-fence check accepts delimiters shorter than the opening fence, prematurely ending a nested code sample and causing real “See also” links to be skipped.
1 open issue
What changed in this PR
This PR repairs migrated links and an unsupported include directive in the Aspire 9.4 and 9.5 release notes, and adds regression checks for Markdown patterns missed by the site’s links validator.
Changes:
- Corrects link paths and heading anchors, and removes an obsolete command-reference link.
- Replaces the raw
[!INCLUDE]directive with an inline feature-flag note. - Adds English-docs checks for malformed targets, anchored redirects, and broken absolute aspire.dev links.
| File | Description |
|---|---|
src/frontend/tests/unit/docs-markdown-link-targets.vitest.test.ts |
Adds Markdown link-target regression checks. |
src/frontend/src/content/docs/whats-new/aspire-9-5.mdx |
Repairs links and removes the obsolete aspire exec reference link. |
src/frontend/src/content/docs/whats-new/aspire-9-4.mdx |
Repairs links and replaces the unsupported include directive. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
David Pine (IEvangelist)
enabled auto-merge (squash)
November 1, 2026 14:48
David Pine (IEvangelist)
approved these changes
Nov 1, 2026
David Pine (IEvangelist)
deleted the
fix/whats-new-9-4-9-5-broken-links
branch
November 1, 2026 14:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The "What's new" pages for Aspire 9.4 and 9.5 contain links ported from the old docs site that don't work on aspire.dev, plus one
[!INCLUDE]directive that shows up as raw text. The site's links validator misses all of them. It runs witherrorOnRelativeLinks: false, treatshttps://aspire.dev/...as external, and accepts redirect sources.whats-new/aspire-9-4.mdx[Aspire SDK](`microsoft/aspire/sdk`)/get-started/aspire-sdk/cli-reference/aspire//reference/cli/commands/aspire/cli-reference/aspire-config//reference/cli/commands/aspire-config/[!INCLUDE [aspire exec feature flag note](cli/includes/exec-feature-flag-note/)]aspire deploynote on the same pagecli-reference/aspire-deploy//reference/cli/commands/aspire-deploy/fundamentals/orchestrate-resources.md#express-external-service-resources/reference/api/csharp/aspire.hosting/externalservicebuilderextensions/AddExternalService, so it links to the API referencehttps://aspire.dev/app-host/eventing/#apphost-life-cycle-events#apphost-eventinghttps://aspire.dev/app-host/configuration/#aspire-version-update-notifications#version-update-notificationswhats-new/aspire-9-5.mdx[Aspire SDK](`microsoft/aspire/sdk`)/get-started/aspire-sdk/cli-reference/aspire-config-set//reference/cli/commands/aspire-config-set/aspire execis no longer in the CLI, and/reference/cli/commands/aspire-exec/redirects toaspire-resource, which is a different command (#1814)cli-reference/aspire-config//reference/cli/commands/aspire-config//integrations/reverse-proxies/yarp/#multi-stage-docker-builds#static-file-serving/integrations/messaging/rabbitmq/rabbitmq-client/#auto-activation/integrations/messaging/rabbitmq/rabbitmq-connect/#auto-activation#auto-activationRegression test: the new
tests/unit/docs-markdown-link-targets.vitest.test.tsscans English docs markdown (skipping code fences) for these patterns:[!INCLUDEdirectiveshttps://aspire.dev/...links to missing pages or missing heading anchorsIt skips the same paths the links validator excludes (
/reference/api/,/hub/,/i18n/).Scope: open PR #1995 covers a different set of link gaps (dashboard anchors and Azure pages) and doesn't touch these lines. Other open PRs that edit these files (#1933, #1896, #1876) don't change these links either.
Third-party links and affiliations
None.
Validation
mainwith 15 problems across the two files, and passes with this change (2/2).bun run test:unit→ 85 files, 1122 passed, 1 skipped.bun run lintpasses.[!INCLUDEtext on 9.4).[!INCLUDEtext.mainCI.rabbitmq-client/#auto-activationlands onrabbitmq-connect/with an empty hash, so the anchor is lost.Before: the 9.4
aspire execsection renders the raw directive.After: the feature-flag note renders.
🤖 Posted by AspireAgent (AI Agent)