Repository navigation
Description
Is there an existing issue for this?
- I have searched the existing issues.
Describe the bug
Track two confirmed test-infrastructure findings from the direct merge of release/13.6 into release/17.0 in #22365. These are follow-up test fixes, not additional product security findings.
Servicing follow-up: intentionally non-blocking for #22365. Keep that PR a direct branch merge; address both items separately in 17.0 servicing rather than modifying release/13.6 for the merge.
-
Release-build repository detection breaks the response-file tests. In
tests/Aspire.Cli.Tests/Commands/Sdk/SdkResponseFileTests.cs,SdkCommands_IgnoreAutomaticResponseFilescallsAspireRepositoryDetector.DetectRepositoryRoot(AppContext.BaseDirectory)and asserts a non-null result. In Release builds, the detector only honorsASPIRE_REPO_ROOT; without it, all eight theory cases fail before testing response-file isolation. The realAppHostServerProjectFactoryalso requires repository detection to selectDotNetBasedAppHostServerProject; passing a restore configuration directory does not enable repository mode. Find the checkout independently and run each scenario in an isolated child process withASPIRE_REPO_ROOTset, followingSdkDumpCi_ForHostingProject_DoesNotEmitWarnings. Avoid process-wide environment mutation in the parallel test host. -
TypeScript generator changes do not select the new regression suite. The
generatecases dynamically build and loadAspire.Hosting.CodeGeneration.TypeScript. That runtime dependency is absent from the static test-project reference graph, andeng/github-ci/test-trigger-map.ymlhas no route from those generator inputs totest:Aspire.Cli.Tests. Add a test-consumerpath_rulesentry for the generator inputs and focused selector regression coverage.
Expected Behavior
- All eight response-file scenarios exercise the intended behavior in both Debug and Release without requiring an ambient
ASPIRE_REPO_ROOTor contaminating other tests. - TypeScript generator input changes select
Aspire.Cli.Teststhrough the production selector, in addition to existing consumers.
Steps To Reproduce
Findings were confirmed by source inspection at PR head 2150dde35623f6754e98af77ca930d1c8fecb313; no local reproduction run was performed.
- Build/run
SdkCommands_IgnoreAutomaticResponseFilesin Release withASPIRE_REPO_ROOTunset. The initial repository-root assertion fails before response-file isolation is exercised. - Trace selection for a source change under
src/Aspire.Hosting.CodeGeneration.TypeScript/: the current static references and curated routing do not selecttest:Aspire.Cli.Testsfor the runtime dependency.
Exceptions (if any)
Expected failure from source inspection: Assert.NotNull(repoRoot) in the Release-build scenarios. No captured exception or stack trace.
Aspire doctor output
N/A — test infrastructure and selective CI routing.
Anything else?
- Direct merge PR: Merge release/13.6 into release/17.0 after 13.6.5 security release #22365.
- Repository detection finding: Merge release/13.6 into release/17.0 after 13.6.5 security release #22365 (comment)
- Test-selection finding: Merge release/13.6 into release/17.0 after 13.6.5 security release #22365 (comment)
Acceptance: fix isolated-process setup, validate the targeted SDK scenarios in Debug and Release with the parent environment variable unset, and add/validate focused production-selector coverage for the runtime generator dependency.
Activity
Merge release/13.6 into release/17.0 after 13.6.5 security release (#…