Skip to content

Implement project-bound Git configuration sources for Aspire CLI - #20805

Merged
James Newton-King (JamesNK) merged 39 commits into
mainfrom
jamesnk/cli-config-sources-spec
Oct 26, 2026
Merged

James Newton-King (JamesNK) merged 39 commits into
mainfrom
jamesnk/cli-config-sources-spec

Conversation

@JamesNK

@JamesNK James Newton-King (JamesNK) commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Description

Implements project-bound Git configuration sources for the Aspire CLI so organizations can share approved defaults without changing SDK/channel identity or making a remote repository a runtime configuration provider.

Users can accept a proposed source during aspire new or aspire init. The CLI acquires and validates a Git snapshot, copies only allowlisted documentation settings into the application's aspire.config.json, and saves a configSource binding. Normal commands continue using saved application settings; source checks are advisory and never silently apply changes.

Implemented behavior

  • Select candidates from ASPIRE_INIT_SOURCE_URL, with optional repository-relative ASPIRE_INIT_SOURCE_PATH and branch/full-commit ASPIRE_INIT_SOURCE_REF, or the Microsoft default when the existing employee detector identifies an internal user. Detection supplies a default, not consent or authorization.
  • Require explicit consent before acquisition. Non-interactive creation uses --use-config-source true or false; an existing binding is reused without repeating consent, detection, or retargeting from the current environment.
  • Materialize only docs.llmsTxtUrl and docs.api.sitemapUrl. Preserve unrelated project settings, normalize supported flat/nested keys case-insensitively, and retain existing nested values when normalization encounters a conflicting flat key.
  • Keep bindings local to the configuration file that declares them. Materialized parent settings still inherit normally, but child projects do not inherit a parent's source binding or refresh its file. C# solution-mode init explicitly selects the solution-root configuration rather than creating a second binding under the generated AppHost.
  • Add aspire update --config-source to explicitly fetch and apply source settings, replacing local edits only at supplied allowlisted leaves. Explicit AppHost directories are resolved before configuration-only fallback.
  • Run due version checks in the background for resolved source-bound projects, using a 24-hour successful-check cadence. Defer completed notices/warnings until command exit, suppress them for machine-readable output, and cancel/join unfinished checks without blocking the foreground operation on remote acquisition.
  • Use normal Git authentication. Interactive fetches inherit terminal input/output so credential helpers can interact with the user. Unattended fetches disable Git terminal and GCM prompts; configured SSH launchers are preserved and can still prompt, with the two-minute timeout bounding the operation.
  • Preserve partial captured Git output on timeout and display only its final 64 Ki characters on stderr. Do not display configuration-file contents or put captured diagnostics into exception messages, logs, or telemetry. Bound process-tree shutdown and output draining.
  • Retain only the latest successfully fetched source snapshot and separate advisory-check metadata under Aspire home. Use locking and atomic writes, preserve destination permissions, and tolerate incomplete bindings during general settings loading while rejecting them when the source is used.
  • Wire saved documentation URLs into documentation acquisition/cache behavior, add focused regression tests, document the implementation and first-party scenarios, and add VS Code CLI debugging tasks/configuration.

Detailed source-driven skills, templates, integration acquisition, and their content schema remain proposed follow-up work; they are not implemented by this PR.

User-facing usage

$env:ASPIRE_INIT_SOURCE_URL = 'https://git.acme.example/aspire-init'
$env:ASPIRE_INIT_SOURCE_PATH = 'teams/platform.json'
$env:ASPIRE_INIT_SOURCE_REF = 'main'

aspire new aspire-starter --use-config-source true
aspire init --use-config-source true --non-interactive
aspire update --config-source --apphost .\MyApp.AppHost

Decline a proposed source with --use-config-source false. Subsequent commands use the saved binding, not the current initialization environment variables.

Relevant command-help options:

aspire init:
  --use-config-source  Accept or decline the proposed Git configuration source for this project.

aspire update:
  --config-source     Apply allowed settings from the project's saved Git configuration source,
                      replacing local edits to supplied settings, without updating packages or the CLI.
  --apphost <apphost>  The path to the Aspire AppHost project file or a directory to search

Screenshots / Recordings

This PR includes CLI interaction changes. TODO: add a recording of accepting/declining a proposed configuration source, interactive Git authentication, explicit refresh, and a deferred update/timeout notice. No screenshots or recordings have been uploaded.

Security considerations

This implementation makes outbound Git connections, invokes Git and its credential helpers, reads untrusted repository JSON, and writes application configuration and private tracking data under Aspire home. It validates repository addresses, repository-relative paths, refs, JSON shape, and allowlisted settings; rejects symlink configuration entries; and limits configuration files to 4 MiB. Remote data cannot select AppHost paths, SDK/channel settings, arbitrary features, or another configuration source.

Employee detection does not grant access. Authentication remains Git's responsibility. Unattended SSH prompting is an accepted limitation bounded by timeout, not a guarantee of prompt-free SSH. Interactive Git output and timeout-only diagnostics can contain private repository/authentication details and must not enter ordinary logs or telemetry. Formal threat modeling and security review remain outstanding.

Validation

Executed on Windows against the latest implementation:

$env:MSBUILDTERMINALLOGGER = 'false'
dotnet test --project .\tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-launch-profile --filter-class '*.ConfigSourceCommandTests' --filter-class '*.InitCommandTests' --filter-class '*.ConfigSourceServiceTests' --filter-class '*.ConfigSourceGitClientTests' --filter-class '*.ConfigurationHelperTests' --filter-class '*.AspireConfigFileTests' --filter-class '*.ProjectLocatorTests' --filter-class '*.AppHostConnectionResolverTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Passed: 489 tests; 10 platform-specific tests skipped; 0 failures. Coverage includes source consent/selection, real Git acquisition and cancellation, timeout diagnostics, advisory checks, explicit refresh, allowlisted merges, incomplete bindings, project selection, non-inherited bindings, solution-root initialization, and configuration persistence.

git --no-pager diff --check -- docs\specs\cli-config-sources.md src\Aspire.Cli\Commands\InitCommand.cs tests\Aspire.Cli.Tests\Commands\ConfigSourceCommandTests.cs tests\Aspire.Cli.Tests\TestServices\TestCertificateService.cs

Passed before committing the solution-root initialization fix.

The full repository suite, CLI terminal E2E scenarios, and interactive authentication recordings were not run as part of this update. An earlier broader CLI run encountered GuestAppHostProjectTests.RunAsync_SignalsBuildCompletionAfterGuestAppHostLaunches, which was also reproduced on the main-branch baseline.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20805

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20805"

@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot October 8, 2026 02:27
@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Git source validation and first-use consent behavior need clarification before the design is implementation-ready.

3 open findings
What changed in this PR

Adds a draft specification for organization-provided Aspire CLI configuration sources.

Changes:

  • Defines Git-based source selection, consent, caching, and refresh behavior.
  • Specifies template, integration, and skill acquisition.
  • Documents security, implementation, and testing requirements.
File Description
docs/​specs/​cli-config-sources.md Adds the CLI config-sources design specification.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

Comment thread docs/specs/cli-config-sources.md Resolved
Comment thread docs/specs/cli-config-sources.md Resolved
Comment thread docs/specs/cli-config-sources.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The specification needs corrections to its descriptions of current agent-init options, installation scope, and single-file AppHost dependencies.

5 open issues

Review effort: Balanced

Comment thread docs/specs/cli-config-sources.md Resolved
Comment thread docs/specs/cli-config-sources.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation-only proposal has no identified blocking issues; implementation and security validation remain deferred.

No open issues 🎉

5 resolved since last review

Review effort: Balanced

@JamesNK James Newton-King (JamesNK) changed the title Add CLI config sources design spec Specify project-bound remote configuration sources for Aspire CLI Oct 20, 2026

@mitchdenny Mitch Denny (mitchdenny) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need details on a new command to force refresh of the config source.

@JamesNK

Copy link
Copy Markdown
Member Author

Addressed Mitch Denny (@mitchdenny)'s force-refresh feedback in b3a92a4. The spec now defines aspire update --config-source as a refresh-only mode that bypasses the 24-hour cache window, uses the saved project binding, and leaves CLI/packages/content unchanged. It also covers project selection, non-interactive usage, incompatible options, failure/cancellation handling, and implementation validation.

Validation: git diff --check -- docs/specs/cli-config-sources.md passed; no tests run (documentation-only change).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The documentation proposal has no unresolved blocking findings and clearly identifies implementation follow-ups.

No open issues 🎉

Review effort: Balanced

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Configuration selection can use unrelated sources or replace saved settings, and global-command exclusions and cache retention need correction.

7 open issues
1 file not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Keep the source-bound configuration at the project root while moving the file-based AppHost and its run settings into a child directory for ancestor notification and refresh scenarios.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Align source checks and refreshes with settings discovery, preserve each binding's file path, and cover local/global source behavior. Share the source section name, use 30-second Git timeouts, and clarify command lifecycle behavior.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Recognize target-local legacy bindings during initialization without inheriting ancestor bindings. Serialize global configuration mutations with source refresh and add regression coverage for both fixes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove legacy-specific initialization fallback and tests, document unsupported legacy configuration, and retain shared discovery without adding rejection logic.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Handle partially flattened keys across nested and case-equivalent sections, add refresh regression coverage, and correct documentation command advisory-check expectations.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore constructor-time documentation service initialization, make unbound refresh an informational no-op, and clarify configuration source messages and error classification. Update related documentation, localization, and existing test expectations. Reuse shared PID-file polling to fix the process-shutdown test race on Windows.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Source acquisition rejects supported key collisions, and explicit refresh can modify configuration despite a nonexistent AppHost target.

2 open issues
1 file not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file

Review effort: Balanced

Use the existing long timeout for the real multi-file update transaction while preserving all persistence and rollback assertions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Validate explicit file and directory targets before resolving configuration sources. Preserve existing-directory fallback, document the behavior, and add regression coverage that verifies local and global bindings remain untouched.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Solution-mode initialization can hide the saved source binding, and Git operations use a shorter timeout than the documented budget.

2 open issues
1 previously missed issue

In code that hasn't changed since last review

Medium severity Use the documented two-minute timeout for Git operations

src/​Aspire.Cli/​Configuration/​ConfigSourceGitClient.cs:24

Both acquisition and advisory checks are cancelled after 30 seconds, rather than the two-minute timeout specified in the PR description and documented below. This also limits interactive credential-helper/MFA completion to 30 seconds, causing otherwise successful authentication or slower fetches to fail prematurely. Use the documented two-minute budget for these operations.

1 resolved since last review
1 file not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file

Review effort: Balanced

Comment thread src/Aspire.Cli/Commands/InitCommand.cs Resolved
@github-actions

This comment has been minimized.

Use one root-only normalizer for local and source settings, normalize source JSON before provider validation, and reject merged duplicate paths before writing. Update regression coverage and the configuration source specification.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Git authentication and untrusted configuration persistence warrant the outstanding security review and terminal end-to-end validation before approval.

1 open issue
1 resolved since last review
1 file not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file

Review effort: Balanced

Select and refresh configuration sources using the AppHost's effective configuration file while preserving template settings and parent configuration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Git authentication and untrusted configuration persistence still require the acknowledged human security review and terminal end-to-end validation.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Low severity Launch configuration creates a project instead of showing help

docs/​contributing.md:232

The checked-in launch configuration passes new, not --help (.vscode/launch.json:11–13). Following these debugging instructions therefore starts project creation rather than showing help. Please describe the actual default, or change the launch arguments to --help if a non-mutating default is intended.

1 resolved since last review
1 file not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file

Review effort: Balanced

Accept normal channel completion or cancellation during watcher shutdown while continuing to reject duplicate connection snapshots.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

3 / 100 PR test projects · 5 PR jobs, from 61 changed files.

Selected PR test projects (3 / 100)

Aspire.Cli.EndToEnd.Tests, Aspire.Cli.Tests, Infrastructure.Tests

Selected PR jobs (5)

cli-starter-validation, extension-e2e, extension-unit, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

📦 affected project Aspire.Cli
→ 1 test: Aspire.Cli.EndToEnd.Tests

🔧 src/Aspire.Cli/Resources/ConfigSourceStrings.resx (changed source)
→ 1 directly: Infrastructure.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/ConfigSourceTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/Helpers/ConfigSourceTestContext.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.Tests/Backchannel/AppHostConnectionResolverTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Backchannel/AuxiliaryBackchannelMonitorTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/AgentInitCommandTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/ConfigSourceCommandTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/InitCommandTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/UpdateCommandRepositoryToolsTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Configuration/AspireConfigFileTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Configuration/ConfigSourceGitClientTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Configuration/ConfigSourceServiceTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Configuration/ConfigurationHelperTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Configuration/ConfigurationServiceTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/NuGet/NuGetPackagePrefetcherTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Projects/ProjectLocatorTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigSourceGitClientTests.Acquire_PreservesLiteralDictionaryKeys.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigSourceServiceTests.Materialize_PreservesProjectSettingsAndCopiesOnlyAllowedLeaves.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigSourceServiceTests.Update_PreservesNestedLiteralKeys_flattenedSource=False.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigSourceServiceTests.Update_PreservesNestedLiteralKeys_flattenedSource=True.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigSourceServiceTests.Update_ReplacesLeavesInTheirExistingCaseInsensitiveSections.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigurationHelperTests.NormalizeSettings_PreservesNestedLiteralKeys.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigurationHelperTests.NormalizeSettings_PreservesParentCreationAndBlockedPaths.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigurationHelperTests.NormalizeSettings_PreservesPropertyOrderAndFirstMatchingCasing.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigurationHelperTests.RegisterSettingsFiles_NormalizesCompletePathsAcrossCaseEquivalentSections_persistNormalization=True.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/InitCommandTests.InitCommand_Help_ShowsFileBasedOption.verified.txt (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/TestServices/TestCertificateService.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/TestServices/TestConfigSourceServices.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Utils/CliTestHelper.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

Job reasons

Job Triggered by
cli-starter-validation affected project Aspire.Cli
extension-e2e • src/Aspire.Cli/Backchannel/AppHostConnectionResolver.cs, src/Aspire.Cli/CliConfigNames.cs, src/Aspire.Cli/Commands/BaseCommand.cs, src/Aspire.Cli/Commands/CommonCommandServices.cs, src/Aspire.Cli/Commands/InitCommand.cs, src/Aspire.Cli/Commands/NewCommand.cs, src/Aspire.Cli/Commands/UpdateCommand.cs, src/Aspire.Cli/Configuration/AspireConfigFile.cs, src/Aspire.Cli/Configuration/ConfigSource.cs, src/Aspire.Cli/Configuration/ConfigSourceGitClient.cs, src/Aspire.Cli/Configuration/ConfigSourceService.cs, src/Aspire.Cli/Configuration/ConfigurationService.cs, src/Aspire.Cli/JsonSourceGenerationContext.cs, src/Aspire.Cli/Program.cs, src/Aspire.Cli/Projects/ProjectLocator.cs, src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs, src/Aspire.Cli/Resources/ConfigSourceStrings.resx, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.cs.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.de.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.es.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.fr.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.it.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.ja.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.ko.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.pl.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.pt-BR.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.ru.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.tr.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.zh-Hans.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.zh-Hant.xlf, src/Aspire.Cli/Utils/ConfigurationHelper.cs
• affected project Aspire.Cli
extension-unit .vscode/launch.json, .vscode/tasks.json
polyglot affected project Aspire.Cli
typescript-api-compat affected project Aspire.Cli

Selection computed for commit a1e2a04.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Git authentication, untrusted configuration processing, and persistent settings changes still need human security review and terminal end-to-end validation.

No open issues 🎉

1 file not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #1948

Generated by PR Documentation Check · copilot · auto · 27.2 AIC · ⌖ 1.19 AIC · ⊞ 7.4K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#1948 targeting release/17.0.

Documented --use-config-source (init/new), --config-source (update), and the ASPIRE_INIT_SOURCE_* env vars. Signals: cli_command_file_changed, cli_option_added, cli_resource_strings_changed, pr_body_has_cli_flag_mention, pr_body_has_user_facing_section. Files: aspire-init.mdx, aspire-new.mdx, aspire-update.mdx.

Note

This draft PR needs human review before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants