Skip to content

Graduate filesystem APIs from experimental to stable - #20808

Merged
Mitch Denny (mitchdenny) merged 1 commit into
mainfrom
mitchdenny-stabilize-filesystem-apis
Oct 8, 2026
Merged

Mitch Denny (mitchdenny) merged 1 commit into
mainfrom
mitchdenny-stabilize-filesystem-apis

Conversation

@mitchdenny

Copy link
Copy Markdown
Member

Description

Consumers can use Aspire's filesystem services and temporary-file abstractions without suppressing ASPIREFILESYSTEM001.

Remove experimental status from IFileSystemService, ITempFileSystemService, TempDirectory, TempFile, and IDistributedApplicationBuilder.FileSystemService. A checkout-wide search found no additional declarations under this diagnostic. Remove obsolete suppressions from repository consumers while preserving every other suppressed diagnostic.

All APIs, signatures, optional defaults, implementations, cleanup semantics, and lifetime ownership remain unchanged. Generated api/*.cs baselines are intentionally untouched. No related documentation explicitly described this family as experimental, so no documentation changes were needed. Other experimental families and package/version settings are unchanged.

Fixes # (issue)

User-facing usage

Existing usage no longer needs an experimental-warning suppression:

var builder = DistributedApplication.CreateBuilder(args);
using var temporaryDirectory = builder.FileSystemService.TempDirectory.CreateTempSubdirectory();
using var temporaryFile = builder.FileSystemService.TempDirectory.CreateTempFile("config.json");

Validation

Validated on macOS arm64:

  • ./restore.sh — passed, 0 warnings and 0 errors.
  • MSBUILDTERMINALLOGGER=false dotnet test --project tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj --no-launch-profile -- --filter-class "*.FileSystemServiceTests" --filter-class "*.InteractionFileUploadStoreTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true" — passed, 68 tests. Includes five new metadata regression cases and existing temporary-file allocation, cleanup, preservation, disposal, and upload-store coverage. The initial attempt exposed blank lines left by pragma removal; those were fixed before the successful rerun.
  • MSBUILDTERMINALLOGGER=false dotnet build /Users/midenn/.copilot/session-state/28001ed6-c6b4-44d4-98a0-bb4bc1d0060a/files/filesystem-validation.slnf --no-restore /p:SkipNativeBuild=true --verbosity quiet — passed, 0 warnings and 0 errors. The session-local solution filter references Aspire.slnx and selects the eight affected production projects (Aspire.Hosting, .Azure, .Azure.Kubernetes, .Browsers, .Maui, .MySql, .Rust, .Testing) and six affected test projects (Aspire.Hosting.Tests, .Azure.Tests, .Blazor.Tests, .Browsers.Tests, .EntityFrameworkCore.Tests, .Maui.Tests), together with their project references. The filter is validation-only and is not committed.
  • git diff --check — passed. A baseline comparison confirmed changes outside the regression test consist only of this family's attributes/suppressions and associated unused-using/whitespace cleanup. git grep -n ASPIREFILESYSTEM001 finds only the five intentionally unchanged generated baseline attributes.

Full-suite, Windows/Linux runtime, and native-AOT validation were not run; runtime implementation is unchanged.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Remove ASPIREFILESYSTEM001 attributes and obsolete consumer suppressions while preserving the existing API and lifetime behavior. Add stability metadata regression coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20808

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20808"

@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot October 8, 2026 03:46
@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Tests selector

50 / 98 PR test projects · 4 PR jobs, from 49 changed files.

Selected PR test projects (50 / 98)

Aspire.Cli.EndToEnd.Tests, Aspire.Hosting.Analyzers.Tests, Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Kusto.Tests, Aspire.Hosting.Azure.Provisioning.Tests, Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Browsers.Tests, Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.CodeGeneration.TypeScript.Tests, Aspire.Hosting.Containers.Tests, Aspire.Hosting.DevTunnels.Tests, Aspire.Hosting.Docker.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.DotnetTool.Tests, Aspire.Hosting.EntityFrameworkCore.Tests, Aspire.Hosting.Foundry.Tests, Aspire.Hosting.Garnet.Tests, Aspire.Hosting.Go.Tests, Aspire.Hosting.Java.Tests, Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Kafka.Tests, Aspire.Hosting.Keycloak.Tests, Aspire.Hosting.Kubernetes.Tests, Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests, Aspire.Hosting.MongoDB.Tests, Aspire.Hosting.MySql.Tests, Aspire.Hosting.Nats.Tests, Aspire.Hosting.OpenAI.Tests, Aspire.Hosting.Oracle.Tests, Aspire.Hosting.Orleans.Tests, Aspire.Hosting.PostgreSQL.Tests, Aspire.Hosting.Python.Tests, Aspire.Hosting.Qdrant.Tests, Aspire.Hosting.RabbitMQ.Tests, Aspire.Hosting.Radius.Tests, Aspire.Hosting.Redis.Tests, Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests, Aspire.Hosting.Seq.Tests, Aspire.Hosting.SqlServer.Tests, Aspire.Hosting.Testing.Tests, Aspire.Hosting.Tests, Aspire.Hosting.Valkey.Tests, Aspire.Hosting.Yarp.Tests, Aspire.Playground.Tests

Selected PR jobs (4)

cli-starter-validation, extension-e2e, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

⚠️ 27 of the 50 selected test projects come from a single change — src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs.

🔧 src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs (changed source)
→ 1 directly: Aspire.Hosting.Testing.Tests
→ 26 via the project graph

show 26

Aspire.Hosting.Containers.Tests, Aspire.Hosting.DevTunnels.Tests (2 hops), Aspire.Hosting.DotnetTool.Tests (2 hops), Aspire.Hosting.Garnet.Tests (2 hops), Aspire.Hosting.Go.Tests (2 hops), Aspire.Hosting.Java.Tests (2 hops), Aspire.Hosting.JavaScript.Tests (2 hops), Aspire.Hosting.Kafka.Tests (2 hops), Aspire.Hosting.Keycloak.Tests (2 hops), Aspire.Hosting.Kubernetes.Tests (2 hops), Aspire.Hosting.Milvus.Tests (2 hops), Aspire.Hosting.MongoDB.Tests (2 hops), Aspire.Hosting.Nats.Tests (2 hops), Aspire.Hosting.OpenAI.Tests, Aspire.Hosting.Oracle.Tests (2 hops), Aspire.Hosting.Orleans.Tests (2 hops), Aspire.Hosting.PostgreSQL.Tests (2 hops), Aspire.Hosting.Python.Tests (2 hops), Aspire.Hosting.Qdrant.Tests (2 hops), Aspire.Hosting.RabbitMQ.Tests (2 hops), Aspire.Hosting.Redis.Tests (2 hops), Aspire.Hosting.Seq.Tests (2 hops), Aspire.Hosting.SqlServer.Tests (2 hops), Aspire.Hosting.Valkey.Tests (2 hops), Aspire.Hosting.Yarp.Tests (2 hops), Aspire.Playground.Tests

🔧 src/Aspire.Hosting/ApplicationModel/AspireStore.cs (changed source)
→ 6 via the project graph: Aspire.Hosting.Analyzers.Tests (2 hops), Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.RemoteHost.Tests

🔧 src/Aspire.Hosting.Azure/AzurePublishingContext.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests
→ 4 via the project graph: Aspire.Hosting.Azure.Kusto.Tests (2 hops), Aspire.Hosting.Azure.Provisioning.Tests (2 hops), Aspire.Hosting.Docker.Tests (2 hops), Aspire.Hosting.Foundry.Tests (2 hops)

🧪 tests/Aspire.Hosting.Tests/Dashboard/DashboardServiceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests
→ 2 via the project graph: Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.Radius.Tests

🔧 src/Aspire.Hosting.Azure.Kubernetes/AzureKubernetesEnvironmentResource.AksPipeline.cs (changed source)
→ 2 directly: Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Browsers/BrowserHost.cs (changed source)
→ 1 directly: Aspire.Hosting.Browsers.Tests
→ 1 via the project graph: Aspire.Hosting.CodeGeneration.TypeScript.Tests

📦 affected project Aspire.Hosting.MySql
→ 1 test: Aspire.Cli.EndToEnd.Tests

🔧 src/Aspire.Hosting.Azure/Provisioning/Provisioners/BicepProvisioner.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Browsers/BrowserHostRegistry.cs (changed source)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🔧 src/Aspire.Hosting.Browsers/BrowserLogsPipeBrowserProcessLauncher.Unix.cs (changed source)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🔧 src/Aspire.Hosting.Browsers/BrowserLogsPipeBrowserProcessLauncher.Windows.cs (changed source)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🔧 src/Aspire.Hosting.Browsers/BrowserLogsPipeBrowserProcessLauncher.cs (changed source)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🔧 src/Aspire.Hosting.Browsers/BrowserLogsRunningSession.cs (changed source)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🔧 src/Aspire.Hosting.Browsers/BrowserLogsSessionManager.cs (changed source)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🔧 src/Aspire.Hosting.Browsers/BrowserLogsUserDataDirectory.cs (changed source)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🔧 src/Aspire.Hosting.Maui/Utilities/MauiAndroidEnvironmentAnnotation.cs (changed source)
→ 1 directly: Aspire.Hosting.Maui.Tests

🔧 src/Aspire.Hosting.Maui/Utilities/MauiEnvironmentHelper.cs (changed source)
→ 1 directly: Aspire.Hosting.Maui.Tests

🔧 src/Aspire.Hosting.Maui/Utilities/MauiiOSEnvironmentAnnotation.cs (changed source)
→ 1 directly: Aspire.Hosting.Maui.Tests

🔧 src/Aspire.Hosting.MySql/MySqlBuilderExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.MySql.Tests

🔧 src/Aspire.Hosting.Rust/RustHostingExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Rust.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/AzureBicepProvisionerTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Blazor.Tests/BlazorHostedExtensionsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Blazor.Tests

🧪 tests/Aspire.Hosting.Browsers.Tests/BrowserHostTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🧪 tests/Aspire.Hosting.Browsers.Tests/BrowserLogsRunningSessionTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🧪 tests/Aspire.Hosting.Browsers.Tests/BrowserLogsSessionManagerTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Browsers.Tests

🧪 tests/Aspire.Hosting.EntityFrameworkCore.Tests/EFMigrationPipelineTests.cs (changed test)
→ 1 directly: Aspire.Hosting.EntityFrameworkCore.Tests

🧪 tests/Aspire.Hosting.Maui.Tests/MauiPlatformExtensionsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Maui.Tests

🧪 tests/Aspire.Hosting.Tests/Dashboard/InteractionFileUploadStoreTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Dcp/KubernetesServiceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/FileSystemServiceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/PublishAsDockerfileTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Publishing/ResourceContainerImageManagerTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/SecretsStoreTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Terminals/Hex1bAspireTerminalTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/UserSecretsParameterDefaultTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

Job reasons

Job Triggered by
cli-starter-validation affected project Aspire.Hosting.AppHost
extension-e2e • src/Aspire.Hosting/ApplicationModel/AspireStore.cs, src/Aspire.Hosting/ApplicationModel/DotnetProgramPublishing.cs, src/Aspire.Hosting/ContainerResourceBuilderExtensions.cs, src/Aspire.Hosting/Dashboard/DashboardServiceHost.cs, src/Aspire.Hosting/Dashboard/InteractionFileUploadStore.cs, src/Aspire.Hosting/Dcp/DcpHost.cs, src/Aspire.Hosting/Dcp/Locations.cs, src/Aspire.Hosting/DeveloperCertificateService.cs, src/Aspire.Hosting/DistributedApplicationBuilder.cs, src/Aspire.Hosting/IDistributedApplicationBuilder.cs, src/Aspire.Hosting/Pipelines/PipelineOutputService.cs, src/Aspire.Hosting/Publishing/ResourceContainerImageManager.cs, src/Aspire.Hosting/UserSecrets/UserSecretsManagerFactory.cs, src/Aspire.Hosting/Utils/FileSystemService.cs, src/Aspire.Hosting/Utils/IFileSystemService.cs
• affected project Aspire.Hosting
polyglot • affected project Aspire.Hosting.Azure.Kubernetes
• affected project Aspire.Hosting.Azure.Provisioning.ContainerService
typescript-api-compat affected project Aspire.Hosting.Azure.Kubernetes

Selection computed for commit d06091f.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The metadata-only graduation preserves runtime behavior, covers all five metadata changes with regression tests, and has no unresolved issues.

0 open findings

What changed in this PR

Promotes Aspire Hosting’s filesystem services and temporary-file abstractions to stable without changing signatures or runtime behavior.

Changes:

  • Removes experimental attributes from four types and the builder’s filesystem property.
  • Removes obsolete filesystem suppressions while preserving other diagnostics.
  • Adds five metadata regression cases; generated API baselines remain unchanged.
File Description
tests/​Shared/​TestFileSystemService.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​UserSecretsParameterDefaultTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​Terminals/​Hex1bAspireTerminalTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​SecretsStoreTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​Publishing/​ResourceContainerImageManagerTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​PublishAsDockerfileTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​FileSystemServiceTests.cs Adds stable-metadata regression tests.
tests/​Aspire.Hosting.Tests/​Dcp/​KubernetesServiceTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​Dashboard/​InteractionFileUploadStoreTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​Dashboard/​DashboardServiceTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Maui.Tests/​MauiPlatformExtensionsTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.EntityFrameworkCore.Tests/​EFMigrationPipelineTests.cs Removes filesystem diagnostic from suppression list.
tests/​Aspire.Hosting.Browsers.Tests/​BrowserLogsSessionManagerTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Browsers.Tests/​BrowserLogsRunningSessionTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Browsers.Tests/​BrowserHostTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Blazor.Tests/​BlazorHostedExtensionsTests.cs Removes filesystem diagnostic from suppression list.
tests/​Aspire.Hosting.Azure.Tests/​AzureBicepProvisionerTests.cs Removes obsolete suppression.
src/​Aspire.Hosting/​Utils/​IFileSystemService.cs Graduates four filesystem types to stable.
src/​Aspire.Hosting/​Utils/​FileSystemService.cs Removes obsolete suppression.
src/​Aspire.Hosting/​UserSecrets/​UserSecretsManagerFactory.cs Removes obsolete suppression.
src/​Aspire.Hosting/​Publishing/​ResourceContainerImageManager.cs Removes obsolete suppression.
src/​Aspire.Hosting/​Pipelines/​PipelineOutputService.cs Removes obsolete suppression.
src/​Aspire.Hosting/​IDistributedApplicationBuilder.cs Graduates filesystem property to stable.
src/​Aspire.Hosting/​DistributedApplicationBuilder.cs Removes obsolete suppression.
src/​Aspire.Hosting/​DeveloperCertificateService.cs Removes obsolete suppression.
src/​Aspire.Hosting/​Dcp/​Locations.cs Removes obsolete suppression.
src/​Aspire.Hosting/​Dcp/​DcpHost.cs Removes obsolete suppression.
src/​Aspire.Hosting/​Dashboard/​InteractionFileUploadStore.cs Removes obsolete suppression.
src/​Aspire.Hosting/​Dashboard/​DashboardServiceHost.cs Removes obsolete suppression.
src/​Aspire.Hosting/​ContainerResourceBuilderExtensions.cs Removes obsolete suppression.
src/​Aspire.Hosting/​ApplicationModel/​DotnetProgramPublishing.cs Removes obsolete suppression.
src/​Aspire.Hosting/​ApplicationModel/​AspireStore.cs Removes obsolete suppression.
src/​Aspire.Hosting.Testing/​DistributedApplicationTestingBuilder.cs Removes obsolete suppression.
src/​Aspire.Hosting.Rust/​RustHostingExtensions.cs Removes filesystem disable/restore pragmas.
src/​Aspire.Hosting.MySql/​MySqlBuilderExtensions.cs Removes obsolete suppression.
src/​Aspire.Hosting.Maui/​Utilities/​MauiiOSEnvironmentAnnotation.cs Removes obsolete suppression.
src/​Aspire.Hosting.Maui/​Utilities/​MauiEnvironmentHelper.cs Removes obsolete suppression.
src/​Aspire.Hosting.Maui/​Utilities/​MauiAndroidEnvironmentAnnotation.cs Removes obsolete suppression.
src/​Aspire.Hosting.Browsers/​BrowserLogsUserDataDirectory.cs Removes obsolete suppression.
src/​Aspire.Hosting.Browsers/​BrowserLogsSessionManager.cs Removes obsolete suppression.
src/​Aspire.Hosting.Browsers/​BrowserLogsRunningSession.cs Removes obsolete suppression.
src/​Aspire.Hosting.Browsers/​BrowserLogsPipeBrowserProcessLauncher.Windows.cs Removes obsolete suppression.
src/​Aspire.Hosting.Browsers/​BrowserLogsPipeBrowserProcessLauncher.Unix.cs Removes obsolete suppression.
src/​Aspire.Hosting.Browsers/​BrowserLogsPipeBrowserProcessLauncher.cs Removes obsolete suppression.
src/​Aspire.Hosting.Browsers/​BrowserHostRegistry.cs Removes obsolete suppression.
src/​Aspire.Hosting.Browsers/​BrowserHost.cs Removes obsolete suppression.
src/​Aspire.Hosting.Azure/​Provisioning/​Provisioners/​BicepProvisioner.cs Removes obsolete suppression.
src/​Aspire.Hosting.Azure/​AzurePublishingContext.cs Removes obsolete suppression.
src/​Aspire.Hosting.Azure.Kubernetes/​AzureKubernetesEnvironmentResource.AksPipeline.cs Removes obsolete suppression.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all 49 changed files and relevant surrounding declarations, consumers, and existing regression coverage at d06091f. No concrete issues or unresolved review findings found. Runtime behavior and other diagnostic suppressions are unchanged; five new metadata cases cover the graduated surfaces. Local validation: patch whitespace check and baseline-invariance comparison passed; no local builds/tests run. GitHub CI reports 282 passing and 16 skipped checks, with both final-result checks successful. Author reports 68 focused tests and affected-project builds passed on macOS.

@mitchdenny
Mitch Denny (mitchdenny) merged commit cabbbb6 into main Oct 8, 2026
586 of 589 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.0 milestone Oct 8, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #1846

Generated by PR Documentation Check · copilot · auto · 53.7 AIC · ⌖ 13.2 AIC · ⊞ 20.4K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#1846 targeting release/17.0.

PR #20808 graduates IFileSystemService, ITempFileSystemService, TempDirectory, TempFile, and IDistributedApplicationBuilder.FileSystemService from experimental (ASPIREFILESYSTEM001) to stable, matching triggered signals pr_body_has_deprecation_marker ("Remove obsolete suppressions...") and pr_body_has_user_facing_section ("Existing usage no longer needs an experimental-warning suppression"). Updated src/frontend/src/content/docs/diagnostics/aspirefilesystem001.mdx with an <Aside> note (following the established ASPIREAZURE002/ASPIRECOSMOSDB001 graduation pattern) stating these APIs are no longer experimental as of Aspire 17.0 and no longer trigger the diagnostic.

Note

This draft PR needs human review before merging.

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants