Repository navigation
Graduate filesystem APIs from experimental to stable - #20808
Conversation
Remove ASPIREFILESYSTEM001 attributes and obsolete consumer suppressions while preserving the existing API and lifetime behavior. Add stability metadata regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20808Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20808" |
Tests selector50 / 98 PR test projects · 4 PR jobs, from 49 changed files. Selected PR test projects (50 / 98)
Selected PR jobs (4)
How these were chosen — grouped by what changed
🔧 show 26
🔧 🔧 🧪 🔧 🔧 📦 affected project 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 Job reasons
Selection computed for commit |
There was a problem hiding this comment.
🟢 Approval recommended
The metadata-only graduation preserves runtime behavior, covers all five metadata changes with regression tests, and has no unresolved issues.
0 open findings
What changed in this PR
Promotes Aspire Hosting’s filesystem services and temporary-file abstractions to stable without changing signatures or runtime behavior.
Changes:
- Removes experimental attributes from four types and the builder’s filesystem property.
- Removes obsolete filesystem suppressions while preserving other diagnostics.
- Adds five metadata regression cases; generated API baselines remain unchanged.
| File | Description |
|---|---|
| tests/Shared/TestFileSystemService.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Tests/UserSecretsParameterDefaultTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Tests/Terminals/Hex1bAspireTerminalTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Tests/SecretsStoreTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Tests/Publishing/ResourceContainerImageManagerTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Tests/PublishAsDockerfileTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Tests/FileSystemServiceTests.cs | Adds stable-metadata regression tests. |
| tests/Aspire.Hosting.Tests/Dcp/KubernetesServiceTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Tests/Dashboard/InteractionFileUploadStoreTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Tests/Dashboard/DashboardServiceTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Maui.Tests/MauiPlatformExtensionsTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.EntityFrameworkCore.Tests/EFMigrationPipelineTests.cs | Removes filesystem diagnostic from suppression list. |
| tests/Aspire.Hosting.Browsers.Tests/BrowserLogsSessionManagerTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Browsers.Tests/BrowserLogsRunningSessionTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Browsers.Tests/BrowserHostTests.cs | Removes obsolete suppression. |
| tests/Aspire.Hosting.Blazor.Tests/BlazorHostedExtensionsTests.cs | Removes filesystem diagnostic from suppression list. |
| tests/Aspire.Hosting.Azure.Tests/AzureBicepProvisionerTests.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/Utils/IFileSystemService.cs | Graduates four filesystem types to stable. |
| src/Aspire.Hosting/Utils/FileSystemService.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/UserSecrets/UserSecretsManagerFactory.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/Publishing/ResourceContainerImageManager.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/Pipelines/PipelineOutputService.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/IDistributedApplicationBuilder.cs | Graduates filesystem property to stable. |
| src/Aspire.Hosting/DistributedApplicationBuilder.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/DeveloperCertificateService.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/Dcp/Locations.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/Dcp/DcpHost.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/Dashboard/InteractionFileUploadStore.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/Dashboard/DashboardServiceHost.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/ContainerResourceBuilderExtensions.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/ApplicationModel/DotnetProgramPublishing.cs | Removes obsolete suppression. |
| src/Aspire.Hosting/ApplicationModel/AspireStore.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Testing/DistributedApplicationTestingBuilder.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Rust/RustHostingExtensions.cs | Removes filesystem disable/restore pragmas. |
| src/Aspire.Hosting.MySql/MySqlBuilderExtensions.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Maui/Utilities/MauiiOSEnvironmentAnnotation.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Maui/Utilities/MauiEnvironmentHelper.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Maui/Utilities/MauiAndroidEnvironmentAnnotation.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Browsers/BrowserLogsUserDataDirectory.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Browsers/BrowserLogsSessionManager.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Browsers/BrowserLogsRunningSession.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Browsers/BrowserLogsPipeBrowserProcessLauncher.Windows.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Browsers/BrowserLogsPipeBrowserProcessLauncher.Unix.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Browsers/BrowserLogsPipeBrowserProcessLauncher.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Browsers/BrowserHostRegistry.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Browsers/BrowserHost.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Azure/Provisioning/Provisioners/BicepProvisioner.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Azure/AzurePublishingContext.cs | Removes obsolete suppression. |
| src/Aspire.Hosting.Azure.Kubernetes/AzureKubernetesEnvironmentResource.AksPipeline.cs | Removes obsolete suppression. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
James Newton-King (JamesNK)
left a comment
There was a problem hiding this comment.
Reviewed all 49 changed files and relevant surrounding declarations, consumers, and existing regression coverage at d06091f. No concrete issues or unresolved review findings found. Runtime behavior and other diagnostic suppressions are unchanged; five new metadata cases cover the graduated surfaces. Local validation: patch whitespace check and baseline-invariance comparison passed; no local builds/tests run. GitHub CI reports 282 passing and 16 skipped checks, with both final-result checks successful. Author reports 68 focused tests and affected-project builds passed on macOS.
|
Pull request created: #1846
|
|
📝 Documentation has been drafted in microsoft/aspire.dev#1846 targeting PR #20808 graduates Note This draft PR needs human review before merging. |
Description
Consumers can use Aspire's filesystem services and temporary-file abstractions without suppressing
ASPIREFILESYSTEM001.Remove experimental status from
IFileSystemService,ITempFileSystemService,TempDirectory,TempFile, andIDistributedApplicationBuilder.FileSystemService. A checkout-wide search found no additional declarations under this diagnostic. Remove obsolete suppressions from repository consumers while preserving every other suppressed diagnostic.All APIs, signatures, optional defaults, implementations, cleanup semantics, and lifetime ownership remain unchanged. Generated
api/*.csbaselines are intentionally untouched. No related documentation explicitly described this family as experimental, so no documentation changes were needed. Other experimental families and package/version settings are unchanged.Fixes # (issue)
User-facing usage
Existing usage no longer needs an experimental-warning suppression:
Validation
Validated on macOS arm64:
./restore.sh— passed, 0 warnings and 0 errors.MSBUILDTERMINALLOGGER=false dotnet test --project tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj --no-launch-profile -- --filter-class "*.FileSystemServiceTests" --filter-class "*.InteractionFileUploadStoreTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"— passed, 68 tests. Includes five new metadata regression cases and existing temporary-file allocation, cleanup, preservation, disposal, and upload-store coverage. The initial attempt exposed blank lines left by pragma removal; those were fixed before the successful rerun.MSBUILDTERMINALLOGGER=false dotnet build /Users/midenn/.copilot/session-state/28001ed6-c6b4-44d4-98a0-bb4bc1d0060a/files/filesystem-validation.slnf --no-restore /p:SkipNativeBuild=true --verbosity quiet— passed, 0 warnings and 0 errors. The session-local solution filter referencesAspire.slnxand selects the eight affected production projects (Aspire.Hosting,.Azure,.Azure.Kubernetes,.Browsers,.Maui,.MySql,.Rust,.Testing) and six affected test projects (Aspire.Hosting.Tests,.Azure.Tests,.Blazor.Tests,.Browsers.Tests,.EntityFrameworkCore.Tests,.Maui.Tests), together with their project references. The filter is validation-only and is not committed.git diff --check— passed. A baseline comparison confirmed changes outside the regression test consist only of this family's attributes/suppressions and associated unused-using/whitespace cleanup.git grep -n ASPIREFILESYSTEM001finds only the five intentionally unchanged generated baseline attributes.Full-suite, Windows/Linux runtime, and native-AOT validation were not run; runtime implementation is unchanged.
Checklist
<remarks />and<code />elements on your triple slash comments?