Repository navigation
Graduate core Azure deployment APIs to stable - #20820
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20820Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20820" |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are scoped to the authorized experimental attributes and suppressions without altering signatures or behavior.
0 open findings
What changed in this PR
Graduates five core Azure deployment APIs from experimental status while preserving runtime behavior and keeping pipeline contracts experimental.
Changes:
- Removes
ASPIREAZURE001attributes from the authorized APIs. - Retains required pipeline diagnostic suppressions.
- Removes obsolete Azure suppressions from consumers, tests, and playgrounds.
| File | Description |
|---|---|
tests/Aspire.Hosting.Foundry.Tests/ToolboxTests.cs |
Removes obsolete Azure suppression. |
tests/Aspire.Hosting.Foundry.Tests/PromptAgentTests.cs |
Removes obsolete Azure suppression. |
tests/Aspire.Hosting.Azure.Tests/AzureUserAssignedIdentityTests.cs |
Removes obsolete Azure suppression. |
tests/Aspire.Hosting.Azure.Tests/AzureRunAsEmulatorModeTests.cs |
Removes obsolete Azure suppression. |
tests/Aspire.Hosting.Azure.Tests/AzureEnvironmentResourceTests.cs |
Removes Azure suppression while retaining pipeline suppression. |
tests/Aspire.Hosting.Azure.Tests/AzureEnvironmentResourceExtensionsTests.cs |
Removes Azure suppression while retaining pipeline suppressions. |
tests/Aspire.Hosting.Azure.Tests/AzureDeployerTests.cs |
Removes obsolete Azure suppression. |
tests/Aspire.Hosting.Azure.Tests/AzureContainerAppExpressEndpointTests.cs |
Removes obsolete Azure suppression. |
tests/Aspire.Hosting.Azure.Tests/AzureBicepResourceTests.cs |
Removes obsolete Azure suppression. |
tests/Aspire.Hosting.Azure.Kubernetes.Tests/AzureKubernetesInfrastructureTests.cs |
Removes obsolete Azure suppression. |
src/Shared/CrossScopeAcrPullIdentityPreparer.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Foundry/Aspire.Hosting.Foundry.csproj |
Removes ASPIREAZURE001 from NoWarn. |
src/Aspire.Hosting.Azure/Provisioning/AzureProvisionerExtensions.cs |
Removes local suppression around AddAzureEnvironment. |
src/Aspire.Hosting.Azure/AzureResourcePreparer.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure/AzurePublishingContext.cs |
Graduates the type and suppresses its experimental pipeline dependency. |
src/Aspire.Hosting.Azure/AzureProvisioningController.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure/AzureEnvironmentResourceExtensions.cs |
Graduates the three environment extension methods. |
src/Aspire.Hosting.Azure/AzureEnvironmentResource.cs |
Graduates the resource and adds required pipeline suppressions. |
src/Aspire.Hosting.Azure/AzureBicepResource.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure.Kubernetes/AzureKubernetesEnvironmentResource.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure.Kubernetes/AzureKubernetesEnvironmentResource.AksPipeline.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure.Kubernetes/AzureKubernetesEnvironmentExtensions.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure.ContainerRegistry/AzureContainerRegistryHelpers.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure.AppService/AzureAppServiceWebSiteResource.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppResource.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppExtensions.cs |
Removes obsolete Azure suppression. |
src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs |
Removes obsolete Azure suppression. |
playground/publishers/Publishers.AppHost/AppHost.cs |
Removes obsolete Azure suppression. |
playground/pipelines/Pipelines.Library/DistributedApplicationPipelineExtensions.cs |
Removes obsolete Azure suppression. |
playground/FoundryAgentEnterprise/FoundryAgentEnterprise.AppHost/FoundryAgentEnterprise.AppHost.csproj |
Removes ASPIREAZURE001 from NoWarn. |
playground/FoundryAgentBasic/FoundryAgentBasic.AppHost/FoundryAgentBasic.AppHost.csproj |
Removes ASPIREAZURE001 from NoWarn. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
James Newton-King (JamesNK)
left a comment
There was a problem hiding this comment.
Reviewed all 32 changed files, surrounding Azure consumers, diagnostic declarations, existing review threads, and relevant regression coverage. No concrete issues found. Local normalized full-file comparison confirms only the five intended experimental-attribute removals and related suppression/import cleanup; diff whitespace check passed. GitHub CI reports 108 successful and 24 skipped checks; author-reported targeted tests are separate evidence. No local builds/tests or live Azure deployment were run because runtime code, signatures, defaults, and ATS exports are unchanged.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🟢 Approval recommended
The changes are consistently attribute-only, preserve pipeline diagnostics, and match the explicitly authorized scope.
0 open findings
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
Remove ASPIREAZURE001 from the five long-standing core Azure declarations and clean obsolete consumer suppressions. Keep Sandbox files and pipeline APIs unchanged, retaining the pipeline diagnostics needed on main. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
a9b483f to
1bf766f
Compare
Tests selector12 / 98 PR test projects · 3 PR jobs, from 32 changed files. Selected PR test projects (12 / 98)
Selected PR jobs (3)
How these were chosen — grouped by what changed
🔧 🔧 🔧 🔧 🔧 🔧 📄 📄 📄 📄 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🔧 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 Job reasons
Selection computed for commit |
|
Pull request created: #1851
|
|
📝 Documentation has been drafted in microsoft/aspire.dev#1851 targeting Triggered signals: Found an existing docs example in Note This draft PR needs human review before merging. |
Description
Consumers should no longer need
ASPIREAZURE001suppressions to use the long-standing core Azure deployment APIs. This is the explicitly authorized, attribute-only graduation ofAzurePublishingContext,AzureEnvironmentResource, andAzureEnvironmentResourceExtensions.AddAzureEnvironment,WithLocation, andWithResourceGroupinAspire.Hosting.Azure.Remove obsolete
ASPIREAZURE001suppressions from consumers that use only these core APIs. Preserve every signature, default, compatibility member, ATS export, method body, and provisioning/deployment behavior. Azure Sandboxes and its suppressions are untouched, as are other experimental declarations and generated*/api/*.csfiles. No directly related documentation labels these five APIs experimental, so no documentation change is needed.Dependency: Core pipeline graduation #20809 has merged into
main. This PR has been rebased onto that change, preserving its independent graduation and suppression cleanup.AzurePublishingContextexposes the now-stableIReportingStepin its unchanged constructor;ASPIREPIPELINES001suppression is no longer needed. Retain the still-requiredASPIREPIPELINES002suppression for deployment state management and all other remaining experimental diagnostics. This PR graduates only the five core Azure declarations, not additional pipeline or Sandbox APIs.User-facing usage
Existing Azure environment configuration no longer requires
ASPIREAZURE001suppression:Validation
Run on macOS, with quarantined and outerloop tests excluded. The targeted tests and both playground builds were repeated successfully after rebasing onto the merged pipeline graduation.
Passed during initial validation: local SDK setup and repository restore; 0 warnings, 0 errors.
Passed after rebase: 209 tests, 0 failures, 0 skipped. Existing tests compile without the removed core Azure suppressions.
Passed after rebase: 45 tests, 0 failures, 0 skipped.
Passed after rebase: 76 tests, 0 failures, 0 skipped.
Both passed after rebase: 0 warnings, 0 errors.
Passed. An additional normalized-diff check against latest
mainconfirmed exactly five authorized attributes removed and no changes to signatures, defaults, method bodies, ATS exports, compatibility members, unrelated diagnostics, Sandbox files, or generated API files.No live Azure deployment or full repository test suite was run; this change does not alter runtime behavior. No new tests are added; existing targeted tests cover the preserved behavior.
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?