Skip to content

Graduate Dockerfile builder APIs - #20823

Merged
Eric Erhardt (eerhardt) merged 2 commits into
mainfrom
mitchdenny-stable-dockerfile-builder-apis
Oct 9, 2026
Merged

Eric Erhardt (eerhardt) merged 2 commits into
mainfrom
mitchdenny-stable-dockerfile-builder-apis

Conversation

@mitchdenny

@mitchdenny Mitch Denny (mitchdenny) commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Description

Consumers can use the existing Dockerfile builder API family without suppressing ASPIREDOCKERFILEBUILDER001. This is an attribute-only graduation accepting the existing API shape; no redesign or behavior change is included.

Remove all 34 source markers in Aspire.Hosting and the two additional markers on JavaScript package-manager Dockerfile stage callbacks. Remove 44 obsolete disable/restore pragmas across production, tests, and the Dockerfile playground, together with now-unused imports. No diagnostic-specific build suppressions were found.

Preserve every signature/default, public class extensibility, mutable DockerfileStage.Statements, callback ordering/composition, cancellation, Dockerfile output/encoding/newlines, base-image/container-file behavior, and run/publish semantics. ATS exports and wrappers are unchanged. Update authoring guidance and the TypeScript codegen snapshot to remove experimental documentation for the graduated family; the snapshot's generated code is unchanged. Other experimental diagnostics and generated */api/*.cs baselines are untouched.

This branch starts independently from main. No new dependencies.

User-facing usage

Existing C# usage now works without an experimental diagnostic suppression:

builder.AddDockerfileBuilder("mycontainer", "path/to/context", context =>
{
    context.Builder.From("alpine:latest")
        .WorkDir("/app")
        .Copy(".", ".")
        .Cmd(["./myapp"]);
});

Validation

Executed on macOS arm64. All test commands exclude quarantined and outerloop tests. Initial validation commands below compile the changes; post-rebase tests use --no-build only after a successful full managed build. Commands below were run with MSBUILDTERMINALLOGGER=false.

Exact command Result
./restore.sh Passed; 0 warnings/errors.
dotnet test --project tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj --no-launch-profile -- --filter-namespace 'Aspire.Hosting.Tests.ApplicationModel.Docker' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 115 builder, stage, statements, callback, edge-case, annotation, and integration tests.
dotnet test --project tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj --no-launch-profile -- --filter-method '*.DockerfileResource_*' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 3 image-builder Dockerfile run/publish/default-image tests.
dotnet test --project tests/Aspire.Hosting.JavaScript.Tests/Aspire.Hosting.JavaScript.Tests.csproj --no-launch-profile -- --filter-method '*Dockerfile*' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 125 Dockerfile, custom-image, and container-file consumer tests.
dotnet test --project tests/Aspire.Hosting.Python.Tests/Aspire.Hosting.Python.Tests.csproj --no-launch-profile -- --filter-method '*Dockerfile*' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 8 tests.
dotnet test --project tests/Aspire.Hosting.Go.Tests/Aspire.Hosting.Go.Tests.csproj --no-launch-profile -- --filter-method '*Dockerfile*' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 6 tests.
dotnet test --project tests/Aspire.Hosting.Java.Tests/Aspire.Hosting.Java.Tests.csproj --no-launch-profile -- --filter-method '*Dockerfile*' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 4 tests.
dotnet test --project tests/Aspire.Hosting.Rust.Tests/Aspire.Hosting.Rust.Tests.csproj --no-launch-profile -- --filter-method '*Dockerfile*' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 25 tests.
dotnet test --project tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests.csproj --no-launch-profile -- --filter-class '*.AtsTypeScriptCodeGeneratorTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed on rerun: 119 tests. Initial run updated the expected snapshot; reviewed all changes as removal of 59 experimental documentation tags, with identical generated code.
dotnet test --project tests/Aspire.Hosting.CodeGeneration.Go.Tests/Aspire.Hosting.CodeGeneration.Go.Tests.csproj --no-launch-profile -- --filter-class '*.AtsGoCodeGeneratorTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 32 tests; snapshot unchanged.
dotnet test --project tests/Aspire.Hosting.CodeGeneration.Python.Tests/Aspire.Hosting.CodeGeneration.Python.Tests.csproj --no-launch-profile -- --filter-class '*.AtsPythonCodeGeneratorTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 25 tests; snapshot unchanged.
dotnet test --project tests/Aspire.Hosting.CodeGeneration.Rust.Tests/Aspire.Hosting.CodeGeneration.Rust.Tests.csproj --no-launch-profile -- --filter-class '*.AtsRustCodeGeneratorTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 20 tests; snapshot unchanged.
dotnet test --project tests/Aspire.Hosting.CodeGeneration.Java.Tests/Aspire.Hosting.CodeGeneration.Java.Tests.csproj --no-launch-profile -- --filter-method '*.TwoPassScanning_GeneratesWithEnvironmentOnTestRedisBuilder' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 1 complete generated Java SDK snapshot; unchanged.
dotnet build playground/withdockerfile/WithDockerfile.AppHost/WithDockerfile.AppHost.csproj --no-restore Passed; 0 warnings/errors.
dotnet build tests/Aspire.Hosting.Blazor.Tests/Aspire.Hosting.Blazor.Tests.csproj --no-restore -v:q Passed; 0 warnings/errors.
dotnet build tests/Aspire.Hosting.Go.Tests/Aspire.Hosting.Go.Tests.csproj --no-restore -v:q Passed; 0 warnings/errors.
dotnet build tests/Aspire.Hosting.Java.Tests/Aspire.Hosting.Java.Tests.csproj --no-restore -v:q Passed; 0 warnings/errors.
dotnet build tests/Aspire.Hosting.Rust.Tests/Aspire.Hosting.Rust.Tests.csproj --no-restore -v:q Passed; 0 warnings/errors.
dotnet build tests/Aspire.Hosting.MongoDB.Tests/Aspire.Hosting.MongoDB.Tests.csproj --no-restore -v:q Passed; 0 warnings/errors.
dotnet build tests/Aspire.Hosting.Azure.Tests/Aspire.Hosting.Azure.Tests.csproj --no-restore -v:q Passed; 0 warnings/errors.
git diff --check Passed.
git grep -n ASPIREDOCKERFILEBUILDER001 -- ':!**/api/*.cs' No matches (expected exit 1); diagnostic remains only in shipped generated API baselines.

Additional scope checks confirmed exactly 36 source attributes and 44 pragmas removed, all other nonblank C# code lines unchanged apart from unused imports, and no generated API baseline edits.

Validation after rebasing onto main

Rebased onto main at a0353f1506ccbc689d1000ce2eb6ba5a0abc196a as the single graduation commit 59b5ed4756fe3c261ba0ce50600d2a4c24b252a3. The worktree remains clean and no unrelated build fixes were added.

Exact command Result
./build.sh --rebuild Failed: eng/OuterPreBuild.proj has no Rebuild target; native steps also require full Xcode rather than the active CommandLineTools directory. Switched to artifact cleanup plus normal build without changing repository infrastructure.
./build.sh --clean Passed; removed only this worktree's local artifacts directory.
./restore.sh Passed after cleanup; 0 warnings/errors.
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer ./build.sh --build Failed: native CLI and dashboard linking is blocked by the installed Xcode license not having been accepted. 3 errors and 2 framework IL2026 trimming warnings. No license acceptance or system-wide developer-directory change was performed.
./build.sh --build /p:SkipNativeBuild=true Passed: full managed repository build, 0 warnings and 0 errors. Native outputs remain unvalidated.
dotnet test --project tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj --no-build --no-launch-profile -- --filter-namespace 'Aspire.Hosting.Tests.ApplicationModel.Docker' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 115 tests on rebased source.
dotnet test --project tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests.csproj --no-build --no-launch-profile -- --filter-namespace 'Aspire.Hosting.CodeGeneration.TypeScript.Tests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Passed: 133 tests on rebased source; no snapshot changes.
git diff --check origin/main Passed.

Environment limitations:

Exact command Result / blocker
dotnet test --project tests/Aspire.Hosting.CodeGeneration.Java.Tests/Aspire.Hosting.CodeGeneration.Java.Tests.csproj --no-launch-profile -- --filter-class '*.AtsJavaCodeGeneratorTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' 39 passed; 21 compiler/runtime probes failed because /usr/bin/javac reports "Unable to locate a Java Runtime." The focused Java SDK snapshot subsequently passed.
dotnet test --project tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj --no-launch-profile -- --filter-class '*.ResourceContainerImageBuilderTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' Stopped after several minutes without completion, while logging an actual file-app container-image build. Real container-image execution is unvalidated; the focused run/publish/default-image tests above passed.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 20823

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 20823"

@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot October 8, 2026 11:43
@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Oct 8, 2026
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes consistently remove the diagnostic while preserving implementation and generated API behavior.

0 open findings

What changed in this PR

Graduates the annotation-driven Dockerfile builder and polyglot APIs from experimental status without changing behavior or signatures.

Changes:

  • Removes ASPIREDOCKERFILEBUILDER001 attributes and suppressions.
  • Updates generated TypeScript documentation and authoring guidance.
  • Removes imports made unused by graduation.
File Description
tests/​Aspire.Hosting.Tests/​Publishing/​ResourceContainerImageManagerTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​ApplicationModel/​Docker/​WithDockerfileBuilderTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​ApplicationModel/​Docker/​DockerfileStatementsTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​ApplicationModel/​Docker/​DockerfileStageTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​ApplicationModel/​Docker/​DockerfileBuilderTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​ApplicationModel/​Docker/​DockerfileBuilderIntegrationTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​ApplicationModel/​Docker/​DockerfileBuilderEdgeCasesTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​ApplicationModel/​Docker/​DockerfileBuilderCallbackContextTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​ApplicationModel/​Docker/​DockerfileBuilderCallbackAnnotationTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Tests/​ApplicationModel/​Docker/​DockerfileBuildAnnotationTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Rust.Tests/​AddRustAppPublishTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Python.Tests/​AddUvicornAppTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Python.Tests/​AddPythonAppTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.MongoDB.Tests/​SingleMemberReplicaSetTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.JavaScript.Tests/​AddViteAppTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.JavaScript.Tests/​AddNodeAppTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.JavaScript.Tests/​AddDenoAppTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.JavaScript.Tests/​AddBunAppTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Java.Tests/​AddJavaAppPublishTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Go.Tests/​AddGoAppTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.CodeGeneration.TypeScript.Tests/​Snapshots/​TwoPassScanningGeneratedAspire.verified.ts Removes generated experimental tags.
tests/​Aspire.Hosting.Blazor.Tests/​AddBlazorGatewayTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Azure.Tests/​AzureDeployerTests.cs Removes obsolete suppression.
tests/​Aspire.Hosting.Azure.Tests/​AzureContainerAppsTests.cs Removes obsolete suppression.
src/​Aspire.Hosting/​Publishing/​ResourceContainerImageManager.cs Removes obsolete suppression.
src/​Aspire.Hosting/​ContainerResourceBuilderExtensions.cs Graduates public builder extensions.
src/​Aspire.Hosting/​Ats/​DockerfileBuilderExports.cs Removes obsolete suppression.
src/​Aspire.Hosting/​ApplicationModel/​DotnetProgramPublishing.cs Removes obsolete suppression.
src/​Aspire.Hosting/​ApplicationModel/​DockerfileBuilderCallbackContext.cs Graduates callback context.
src/​Aspire.Hosting/​ApplicationModel/​DockerfileBuilderCallbackAnnotation.cs Graduates callback annotation.
src/​Aspire.Hosting/​ApplicationModel/​DockerfileBaseImageAnnotation.cs Graduates base-image annotation.
src/​Aspire.Hosting/​ApplicationModel/​Docker/​DockerfileStatements.cs Removes obsolete suppression.
src/​Aspire.Hosting/​ApplicationModel/​Docker/​DockerfileStatement.cs Graduates statement base class.
src/​Aspire.Hosting/​ApplicationModel/​Docker/​DockerfileStage.cs Graduates stage APIs.
src/​Aspire.Hosting/​ApplicationModel/​Docker/​DockerfileBuilder.cs Graduates builder APIs.
src/​Aspire.Hosting/​ApplicationModel/​Docker/​ContainerFilesExtensions.cs Graduates container-file helpers.
src/​Aspire.Hosting.Yarp/​YarpResourceExtensions.cs Removes obsolete suppression.
src/​Aspire.Hosting.Rust/​RustHostingExtensions.cs Removes obsolete suppression pair.
src/​Aspire.Hosting.Rust/​RustDockerfileGenerator.cs Removes obsolete suppression pair.
src/​Aspire.Hosting.Redis/​RedisBuilderExtensions.cs Removes obsolete suppression.
src/​Aspire.Hosting.Python/​PythonAppResourceBuilderExtensions.cs Removes obsolete suppression.
src/​Aspire.Hosting.MongoDB/​MongoDBBuilderExtensions.cs Removes obsolete suppression.
src/​Aspire.Hosting.JavaScript/​JavaScriptPackageManagerAnnotation.cs Graduates Docker stage callbacks.
src/​Aspire.Hosting.JavaScript/​JavaScriptHostingExtensions.cs Removes obsolete suppression.
src/​Aspire.Hosting.Java/​JavaHostingExtensions.cs Removes obsolete suppression pair.
src/​Aspire.Hosting.Java/​JavaDockerfileGenerator.cs Removes obsolete suppression pair.
src/​Aspire.Hosting.Go/​GoHostingExtensions.cs Removes obsolete suppression.
src/​Aspire.Hosting.Blazor/​BlazorGatewayExtensions.cs Removes obsolete suppression.
playground/​withdockerfile/​WithDockerfile.AppHost/​AppHost.cs Removes obsolete playground suppression.
.agents/​skills/​hosting-integration-authoring/​resources/​api-naming-and-shape.md Documents stable Dockerfile APIs.

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes consistently graduate the API family while preserving signatures, behavior, exports, and generated code.

0 open findings

🧠 Review effort: Balanced


Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The metadata-only graduation preserves signatures and behavior, with comprehensive validation across affected surfaces.

0 open findings

🧠 Review effort: Balanced

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The attribute-only graduation is complete, preserves API behavior and ATS shape, and is supported by comprehensive validation.

0 open findings

🧠 Review effort: Balanced

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Remove ASPIREDOCKERFILEBUILDER001 attributes and obsolete suppressions without changing API shape or behavior. Update authoring guidance and generated TypeScript experimental documentation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The stable TypeScript projections still expose C#-only examples in generated JSDoc for three graduated exports.

1 open finding

🧠 Review effort: Balanced

Preserve the C# examples while overriding shared ATS remarks for Dockerfile builder and base-image exports. Regenerate the TypeScript documentation snapshot without changing generated code.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Tests selector

50 / 98 PR test projects · 4 PR jobs, from 49 changed files.

Selected PR test projects (50 / 98)

Aspire.Cli.EndToEnd.Tests, Aspire.Hosting.Analyzers.Tests, Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Kusto.Tests, Aspire.Hosting.Azure.Provisioning.Tests, Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Browsers.Tests, Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.CodeGeneration.TypeScript.Tests, Aspire.Hosting.Containers.Tests, Aspire.Hosting.DevTunnels.Tests, Aspire.Hosting.Docker.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.DotnetTool.Tests, Aspire.Hosting.EntityFrameworkCore.Tests, Aspire.Hosting.Foundry.Tests, Aspire.Hosting.Garnet.Tests, Aspire.Hosting.Go.Tests, Aspire.Hosting.Java.Tests, Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Kafka.Tests, Aspire.Hosting.Keycloak.Tests, Aspire.Hosting.Kubernetes.Tests, Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests, Aspire.Hosting.MongoDB.Tests, Aspire.Hosting.MySql.Tests, Aspire.Hosting.Nats.Tests, Aspire.Hosting.OpenAI.Tests, Aspire.Hosting.Oracle.Tests, Aspire.Hosting.Orleans.Tests, Aspire.Hosting.PostgreSQL.Tests, Aspire.Hosting.Python.Tests, Aspire.Hosting.Qdrant.Tests, Aspire.Hosting.RabbitMQ.Tests, Aspire.Hosting.Radius.Tests, Aspire.Hosting.Redis.Tests, Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests, Aspire.Hosting.Seq.Tests, Aspire.Hosting.SqlServer.Tests, Aspire.Hosting.Testing.Tests, Aspire.Hosting.Tests, Aspire.Hosting.Valkey.Tests, Aspire.Hosting.Yarp.Tests, Aspire.Playground.Tests

Selected PR jobs (4)

cli-starter-validation, extension-e2e, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

⚠️ 27 of the 50 selected test projects come from a single change — src/Aspire.Hosting/ApplicationModel/Docker/ContainerFilesExtensions.cs.

🔧 src/Aspire.Hosting/ApplicationModel/Docker/ContainerFilesExtensions.cs (changed source)
→ 27 via the project graph

show 27

Aspire.Hosting.Analyzers.Tests (2 hops), Aspire.Hosting.Azure.Kusto.Tests (2 hops), Aspire.Hosting.Azure.Provisioning.Tests (3 hops), Aspire.Hosting.Browsers.Tests (2 hops), Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.Containers.Tests (2 hops), Aspire.Hosting.DevTunnels.Tests (2 hops), Aspire.Hosting.DotnetTool.Tests (2 hops), Aspire.Hosting.Garnet.Tests (2 hops), Aspire.Hosting.Kafka.Tests (2 hops), Aspire.Hosting.Keycloak.Tests (2 hops), Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests (2 hops), Aspire.Hosting.MySql.Tests (2 hops), Aspire.Hosting.Nats.Tests (2 hops), Aspire.Hosting.OpenAI.Tests (2 hops), Aspire.Hosting.Oracle.Tests (2 hops), Aspire.Hosting.Orleans.Tests (2 hops), Aspire.Hosting.PostgreSQL.Tests (2 hops), Aspire.Hosting.Qdrant.Tests (2 hops), Aspire.Hosting.RabbitMQ.Tests (2 hops), Aspire.Hosting.Seq.Tests (2 hops), Aspire.Hosting.SqlServer.Tests (2 hops), Aspire.Hosting.Valkey.Tests (2 hops)

🔧 src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Redis.Tests
→ 4 via the project graph: Aspire.Hosting.Docker.Tests (2 hops), Aspire.Hosting.EntityFrameworkCore.Tests (2 hops), Aspire.Hosting.Kubernetes.Tests (2 hops), Aspire.Hosting.Testing.Tests (2 hops)

🔧 src/Aspire.Hosting.Blazor/BlazorGatewayExtensions.cs (changed source)
→ 3 directly: Aspire.Cli.EndToEnd.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Tests

🔧 src/Aspire.Hosting.MongoDB/MongoDBBuilderExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.MongoDB.Tests
→ 1 via the project graph: Aspire.Hosting.Radius.Tests

🔧 src/Aspire.Hosting.Python/PythonAppResourceBuilderExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Python.Tests
→ 1 via the project graph: Aspire.Hosting.Foundry.Tests

🔧 src/Aspire.Hosting.Yarp/YarpResourceExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Yarp.Tests
→ 1 via the project graph: Aspire.Hosting.RemoteHost.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/AzureContainerAppsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests
→ 1 via the project graph: Aspire.Hosting.Azure.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Tests/ApplicationModel/Docker/DockerfileBuildAnnotationTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests
→ 1 via the project graph: Aspire.Hosting.Dotnet.Tests

📦 affected project Aspire.Hosting.Blazor
→ 1 test: Aspire.Cli.EndToEnd.Tests

📄 playground/withdockerfile/WithDockerfile.AppHost/AppHost.cs (changed)
→ 1 directly: Aspire.Playground.Tests

🔧 src/Aspire.Hosting.Go/GoHostingExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Go.Tests

🔧 src/Aspire.Hosting.Java/JavaDockerfileGenerator.cs (changed source)
→ 1 directly: Aspire.Hosting.Java.Tests

🔧 src/Aspire.Hosting.Java/JavaHostingExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Java.Tests

🔧 src/Aspire.Hosting.JavaScript/JavaScriptHostingExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🔧 src/Aspire.Hosting.JavaScript/JavaScriptPackageManagerAnnotation.cs (changed source)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🔧 src/Aspire.Hosting.Rust/RustDockerfileGenerator.cs (changed source)
→ 1 directly: Aspire.Hosting.Rust.Tests

🔧 src/Aspire.Hosting.Rust/RustHostingExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Rust.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/AzureDeployerTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Blazor.Tests/AddBlazorGatewayTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Blazor.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.ts (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.TypeScript.Tests

🧪 tests/Aspire.Hosting.Go.Tests/AddGoAppTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Go.Tests

🧪 tests/Aspire.Hosting.Java.Tests/AddJavaAppPublishTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Java.Tests

🧪 tests/Aspire.Hosting.JavaScript.Tests/AddBunAppTests.cs (changed test)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🧪 tests/Aspire.Hosting.JavaScript.Tests/AddDenoAppTests.cs (changed test)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🧪 tests/Aspire.Hosting.JavaScript.Tests/AddNodeAppTests.cs (changed test)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🧪 tests/Aspire.Hosting.JavaScript.Tests/AddViteAppTests.cs (changed test)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🧪 tests/Aspire.Hosting.MongoDB.Tests/SingleMemberReplicaSetTests.cs (changed test)
→ 1 directly: Aspire.Hosting.MongoDB.Tests

🧪 tests/Aspire.Hosting.Python.Tests/AddPythonAppTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Python.Tests

🧪 tests/Aspire.Hosting.Python.Tests/AddUvicornAppTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Python.Tests

🧪 tests/Aspire.Hosting.Rust.Tests/AddRustAppPublishTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Rust.Tests

🧪 tests/Aspire.Hosting.Tests/ApplicationModel/Docker/DockerfileBuilderCallbackAnnotationTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ApplicationModel/Docker/DockerfileBuilderCallbackContextTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ApplicationModel/Docker/DockerfileBuilderEdgeCasesTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ApplicationModel/Docker/DockerfileBuilderIntegrationTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ApplicationModel/Docker/DockerfileBuilderTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ApplicationModel/Docker/DockerfileStageTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ApplicationModel/Docker/DockerfileStatementsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ApplicationModel/Docker/WithDockerfileBuilderTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Publishing/ResourceContainerImageManagerTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

Job reasons

Job Triggered by
cli-starter-validation affected project Aspire.Hosting.JavaScript
extension-e2e • src/Aspire.Hosting.Blazor/BlazorGatewayExtensions.cs, src/Aspire.Hosting.Java/JavaDockerfileGenerator.cs, src/Aspire.Hosting.Java/JavaHostingExtensions.cs, src/Aspire.Hosting.JavaScript/JavaScriptHostingExtensions.cs, src/Aspire.Hosting.JavaScript/JavaScriptPackageManagerAnnotation.cs, src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs, src/Aspire.Hosting/ApplicationModel/Docker/ContainerFilesExtensions.cs, src/Aspire.Hosting/ApplicationModel/Docker/DockerfileBuilder.cs, src/Aspire.Hosting/ApplicationModel/Docker/DockerfileStage.cs, src/Aspire.Hosting/ApplicationModel/Docker/DockerfileStatement.cs, src/Aspire.Hosting/ApplicationModel/Docker/DockerfileStatements.cs, src/Aspire.Hosting/ApplicationModel/DockerfileBaseImageAnnotation.cs, src/Aspire.Hosting/ApplicationModel/DockerfileBuilderCallbackAnnotation.cs, src/Aspire.Hosting/ApplicationModel/DockerfileBuilderCallbackContext.cs, src/Aspire.Hosting/ApplicationModel/DotnetProgramPublishing.cs, src/Aspire.Hosting/Ats/DockerfileBuilderExports.cs, src/Aspire.Hosting/ContainerResourceBuilderExtensions.cs, src/Aspire.Hosting/Publishing/ResourceContainerImageManager.cs
• affected project Aspire.Hosting.Blazor
polyglot • src/Aspire.Hosting.Blazor/BlazorGatewayExtensions.cs
• affected project Aspire.Hosting.Blazor
• affected project Aspire.Hosting.Azure.Provisioning.RedisEnterprise
typescript-api-compat affected project Aspire.Hosting.Blazor

Selection computed for commit ea12a9f.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Stable API projections expose invalid no-op and parameterless calls, while base-image and stage inputs permit malformed Dockerfiles.

3 open findings
1 resolved since last review

🧠 Review effort: Balanced

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the current revision. No net-new high-confidence issues found. The changes are limited to graduating the Dockerfile builder API family, removing corresponding suppressions, and updating generated documentation; executable generated TypeScript code is unchanged. Existing review threads were not duplicated, and all current PR checks pass or are skipped.

@eerhardt
Eric Erhardt (eerhardt) merged commit 6554654 into main Oct 9, 2026
582 of 588 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.0 milestone Oct 9, 2026
aspire-repo-bot Bot added a commit to microsoft/aspire.dev that referenced this pull request Oct 9, 2026
Removes ASPIREDOCKERFILEBUILDER001 suppression guidance from
app-host/withdockerfile.mdx, integrations/compute/docker.mdx,
integrations/frameworks/javascript.mdx, and deployment/docker-compose.mdx
now that AddDockerfileBuilder/WithDockerfileBuilder are generally
available. Updates the diagnostics overview table and
diagnostics/aspiredockerfilebuilder001.mdx with a graduation note,
and adds a What's new in Aspire 17.0 entry.

Documents microsoft/aspire#20823

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #1857

Generated by PR Documentation Check · copilot · auto · 149.7 AIC · ⌖ 17 AIC · ⊞ 20.4K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#1857 targeting release/17.0.

Triggered signals: pr_body_has_cli_flag_mention, pr_body_has_deprecation_marker, pr_body_has_user_facing_section (PR body has a "### User-facing usage" section showing AddDockerfileBuilder used without a suppression, plus deprecation/pragma-removal language). Updated docs to remove all ASPIREDOCKERFILEBUILDER001 suppression guidance (#pragma warning disable/restore, Aside callouts) from app-host/withdockerfile.mdx, integrations/compute/docker.mdx, integrations/frameworks/javascript.mdx, and deployment/docker-compose.mdx, since AddDockerfileBuilder/WithDockerfileBuilder no longer require suppression. Updated the diagnostics overview table row and rewrote diagnostics/aspiredockerfilebuilder001.mdx with a "Removed in Aspire 17.0" graduation note (following the aspireacadomains001.mdx precedent). Added a new "Dockerfile builder APIs are generally available" entry under a new "App model and AppHost" section in whats-new/aspire-17.mdx.

Note

This draft PR needs human review before merging.

@github-actions github-actions Bot locked and limited conversation to collaborators Nov 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants