Skip to content

Suppress registry analysis for nonshipping Compose web sample - #21240

Merged
Jose Perez Rodriguez (joperezr) merged 1 commit into
mainfrom
joperezr-playground-registry-suppression
Oct 22, 2026
Merged

Jose Perez Rodriguez (joperezr) merged 1 commit into
mainfrom
joperezr-playground-registry-suppression

Conversation

@joperezr

Copy link
Copy Markdown
Member

Description

Apply the existing playground-only container-analysis exception to the nonshipping Docker Compose web sample introduced in #20897. Its node:24-alpine base image currently produces an unapproved-registry warning in Secure Supply Chain Analysis.

Add the same first-line DisableDockerDetector comment used in #16245 to playground/NativeIntegrations/TypeScript/DockerCompose/AppHost/web/Dockerfile. The base image and all seven Dockerfile instructions are unchanged.

David Fowler (@davidfowl) tagging you as the author of #20897, which introduced this Dockerfile.

Security considerations

This deliberately disables Docker detector analysis for this one nonshipping sample application image. The native-hosting validation workflow exercises the sample, but the image is the application's web workload, not a CI runner or infrastructure image. This follows #16245's playground-only boundary; no automation images, pipeline settings, or shared security baselines are changed.

Validation

  • git diff --check - passed.
  • Source-level comparison with HEAD - passed: exactly one comment added; all seven original Dockerfile instructions are unchanged.
  • No build or runtime tests run because this is a Dockerfile-comment-only change.
  • SSCA/pipeline validation was not run; scanner clearance remains unverified.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Apply the playground-only DisableDockerDetector exception established in #16245 to the sample introduced in #20897.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2aec2a44-b56f-460c-adc9-7d5a851afd56
@github-actions github-actions Bot added the area-integrations Issues pertaining to Aspire Integrations packages label Oct 21, 2026
@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot October 21, 2026 10:11
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 21240

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 21240"

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

1 / 100 PR test projects · 0 PR jobs, from 1 changed file.

Selected PR test projects (1 / 100)

Aspire.Playground.Tests

Selected PR jobs (0)

none


How these were chosen — grouped by what changed

📄 playground/NativeIntegrations/TypeScript/DockerCompose/AppHost/web/Dockerfile (changed)
→ 1 directly: Aspire.Playground.Tests

Job reasons

none


Selection computed for commit d2b90d4.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The single-file suppression follows the existing sample exception without changing container build or runtime behavior.

No open issues 🎉

What changed in this PR

Applies the existing container-analysis exception to the nonshipping Compose web sample introduced in #20897.

Changes:

  • Adds a first-line DisableDockerDetector comment.
  • Leaves the base image and all Dockerfile instructions unchanged.

Scanner clearance remains unverified.

File Description
playground/​NativeIntegrations/​TypeScript/​DockerCompose/​AppHost/​web/​Dockerfile Suppresses Docker detector analysis for this playground sample.

Review effort: Balanced

@joperezr
Jose Perez Rodriguez (joperezr) merged commit 633b576 into main Oct 22, 2026
54 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.0 milestone Oct 22, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

✅ No documentation update needed.

Branch: docs_optional → build_or_ci_only (proven false positive).

  • Triggered signal: pr_body_has_cli_flag_mention. Its evidence is the validation text "git diff --check - passed" in the PR body. That is not a user-facing CLI flag.
  • The only changed file is playground/NativeIntegrations/TypeScript/DockerCompose/AppHost/web/Dockerfile, which matches playground/**. The change adds a single DisableDockerDetector comment line to a nonshipping sample. It has no user-facing behavior or API change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-integrations Issues pertaining to Aspire Integrations packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants