Repository navigation
Suppress registry analysis for nonshipping Compose web sample - #21240
Jose Perez Rodriguez (joperezr) merged 1 commit into
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 21240Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 21240" |
Tests selector1 / 100 PR test projects · 0 PR jobs, from 1 changed file. Selected PR test projects (1 / 100)
Selected PR jobs (0)none How these were chosen — grouped by what changed📄 Job reasonsnone Selection computed for commit |
There was a problem hiding this comment.
🟢 Approval recommended
The single-file suppression follows the existing sample exception without changing container build or runtime behavior.
No open issues 🎉
What changed in this PR
Applies the existing container-analysis exception to the nonshipping Compose web sample introduced in #20897.
Changes:
- Adds a first-line
DisableDockerDetectorcomment. - Leaves the base image and all Dockerfile instructions unchanged.
Scanner clearance remains unverified.
| File | Description |
|---|---|
| playground/NativeIntegrations/TypeScript/DockerCompose/AppHost/web/Dockerfile | Suppresses Docker detector analysis for this playground sample. |
Review effort: Balanced
|
✅ No documentation update needed. Branch: docs_optional → build_or_ci_only (proven false positive).
|
Description
Apply the existing playground-only container-analysis exception to the nonshipping Docker Compose web sample introduced in #20897. Its
node:24-alpinebase image currently produces an unapproved-registry warning in Secure Supply Chain Analysis.Add the same first-line
DisableDockerDetectorcomment used in #16245 toplayground/NativeIntegrations/TypeScript/DockerCompose/AppHost/web/Dockerfile. The base image and all seven Dockerfile instructions are unchanged.David Fowler (@davidfowl) tagging you as the author of #20897, which introduced this Dockerfile.
Security considerations
This deliberately disables Docker detector analysis for this one nonshipping sample application image. The native-hosting validation workflow exercises the sample, but the image is the application's web workload, not a CI runner or infrastructure image. This follows #16245's playground-only boundary; no automation images, pipeline settings, or shared security baselines are changed.
Validation
git diff --check- passed.HEAD- passed: exactly one comment added; all seven original Dockerfile instructions are unchanged.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?