Skip to content

Add browser-facing origin references for CORS and redirect configuration - #21260

Merged
David Negstad (danegsta) merged 24 commits into
mainfrom
danegsta-browser-endpoint-resolution
Nov 6, 2026
Merged

David Negstad (danegsta) merged 24 commits into
mainfrom
danegsta-browser-endpoint-resolution

Conversation

@danegsta

@danegsta David Negstad (danegsta) commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Description

Browser-facing URLs such as *.dev.localhost, customized public URLs, and Codespaces forwarding URLs can differ from physical endpoint addresses. Expose those origins as deferred endpoint references so CORS and authentication configuration can agree with the address the browser uses, without changing host/container service discovery.

var endpoint = frontend.GetEndpoint("https");
backend.WithEnvironment("FRONTEND_ORIGIN", endpoint.PrimaryBrowserOrigin);
backend.WithEnvironment("ALLOWED_ORIGINS", endpoint.BrowserOrigins);
entraWeb.WithRedirectUris(endpoint, "/signin-oidc");
  • PrimaryBrowserOrigin resolves to one preferred HTTP(S) origin.
  • BrowserOrigins resolves to a comma-separated list of distinct HTTP(S) origins.

In run mode, both use finalized endpoint URLs after customization and Codespaces projection, in URL display preference order. Origins exclude credentials, paths, queries, and fragments. The physical allocated HTTP(S) origin is retained after customized origins, even when its dashboard link is removed. The primary origin is the first entry in that same sequence, falling back to the allocated origin when no customized origins remain. Without any HTTP(S) origins, both values are empty. Resolution is independent of the reference's service-discovery network context.

Entra endpoint redirect helpers now consume PrimaryBrowserOrigin directly, removing the custom comma splitting from generated Bicep. Local resolution preserves the warned 30-second fallback to the allocated origin if URL finalization does not complete. Publish-mode resolution uses the compute environment's primary-browser-origin expression. The Node Entra playground uses the same scalar reference for its base URL; the playground launch-settings changes are included.

Both properties are also exposed through the generated TypeScript, Go, Java, Python, and Rust SDKs.

Publication

Local display URLs are not deployment addresses. Publishers interpret both properties through their deployed endpoint mappings:

  • Azure Container Apps and App Service: use public deployed HTTP(S) origins; unsupported internal or non-HTTP(S) references are rejected. Container Apps Express applies its public-endpoint visibility checks to both properties.
  • Docker Compose: uses independently configurable deployment inputs, defaulting to localhost and the explicit published port for external HTTP(S) endpoints. Unknown published ports require explicit input.
  • Kubernetes, including AKS-backed publishing: derives defaults from matching literal Ingress/Gateway hostnames and TLS configuration. The scalar default is the first origin from the same matching routes. Hostless, wildcard, or deferred hostname sources require explicit input.
  • Foundry: uses the authority of the deployed project endpoint.
  • Azure Sandboxes: resolves the authority of the deployed proxy URL after producer deployment.
  • Radius: uses required deployment inputs for external HTTP(S) workload endpoints rather than cluster-local DNS. Unsupported recipe-backed endpoints are rejected.

Compose, Kubernetes, and Radius keep scalar and list inputs separate: for example, Parameters:web-http-PrimaryBrowserOrigin contains one origin, while Parameters:web-http-BrowserOrigins contains the list. The scalar input is not obtained by splitting a configured list input.

The manifest publisher lowers both properties to required inputs, including references inside selected conditional branches, formatted expressions, and resource manifest callbacks. Existing supported endpoint tokens remain symbolic for azd.

Fixes #18819

Compatibility

The endpoint properties are additive, but this PR includes behavioral compatibility changes:

  • For allocations completed through DCP or PublishResourceEndpointsAllocatedAsync, WithUrls and WithUrlForEndpoint callbacks now finish before ResourceEndpointsAllocatedEvent handlers run. Code registering URL customization inside those handlers must move registration into model configuration. Physical endpoint allocation and host/container service discovery remain unchanged.
  • Custom endpoint allocators that call eventing.PublishAsync(new ResourceEndpointsAllocatedEvent(resource, services), cancellationToken) directly no longer trigger the orchestrator's URL processing: WithUrls / WithUrlForEndpoint callbacks do not run, generated dashboard URLs are not automatically published, and BrowserOrigins / PrimaryBrowserOrigin references can remain pending indefinitely unless canceled. After assigning the physical endpoints, use eventing.PublishResourceEndpointsAllocatedAsync(new ResourceEndpointsAllocatedEvent(resource, services), cancellationToken) to finalize URLs before notifying subscribers. Direct publication still dispatches the event and does not invalidate physical endpoint values. The existing MAUI synthetic OTLP stubs still use direct publication; browser-origin support for those stubs is not provided by this PR.
  • Manifest publication rejects unsupported :uri formatting on endpoint bindings and non-parameter connection-string references instead of silently dropping the format. For example, ReferenceExpression.Create($"https://login.example/?redirect_uri={web.GetEndpoint("https"):uri}") still resolves in run mode but fails manifest publication because azd cannot faithfully encode that reference. Use a parameter or infrastructure output for the full value that needs encoding, or configure the encoded value explicitly. Removing the format preserves the symbolic reference but does not encode it.

Security considerations

Origins can feed CORS allowlists and authentication redirect configuration. URL customization remains application-controlled; local vanity URLs are not silently reused as deployment addresses. No new listeners or authorization mechanisms are introduced.

Validation

Latest local validation covers implementation commit 14455757af; current head 317e1b82a9 additionally removes the browser-origin section from the core package README. Snapshot updates were reviewed and the affected tests rerun.

The repository SDK was used to build test projects. Tests were launched with the installed .NET 10 host because the repository-local SDK installation did not contain the required .NET 10 runtime. Quarantined and outerloop tests were excluded.

Exact local commands and results

Core endpoint references, manifest lowering, schema, and default compute-environment validation: passed, 195 tests.

$env:MSBUILDTERMINALLOGGER='false'
dotnet build tests\Aspire.Hosting.Tests\Aspire.Hosting.Tests.csproj --nologo -v:q
& 'C:\Program Files\dotnet\dotnet.exe' artifacts\bin\Aspire.Hosting.Tests\Debug\net10.0\Aspire.Hosting.Tests.dll --filter-class '*.EndpointReferenceTests' --filter-class '*.ManifestExpressionTests' --filter-class '*.SchemaTests' --filter-class '*.ComputeEnvironmentValidationTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Compose browser-origin coverage: passed, 15 tests. Kubernetes browser-origin coverage: passed, 40 tests. Radius browser-origin coverage: passed, 11 tests. Each corresponding project build succeeded. The test invocation below was executed for each listed project:

# $name: Aspire.Hosting.Docker.Tests, Aspire.Hosting.Kubernetes.Tests,
#        Aspire.Hosting.Radius.Tests
dotnet build "tests\$name\$name.csproj" --nologo -v:q
& 'C:\Program Files\dotnet\dotnet.exe' "artifacts\bin\$name\Debug\net10.0\$name.dll" --filter-method '*BrowserOrigin*' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Entra provisioning class: 133 passed initially; the remaining test reported an expected Bicep snapshot change removing first(split(...)). After reviewing the updated snapshot, its focused rerun passed. The project build succeeded.

dotnet build tests\Aspire.Hosting.Azure.EntraId.Tests\Aspire.Hosting.Azure.EntraId.Tests.csproj --nologo -v:q
& 'C:\Program Files\dotnet\dotnet.exe' artifacts\bin\Aspire.Hosting.Azure.EntraId.Tests\Debug\net10.0\Aspire.Hosting.Azure.EntraId.Tests.dll --filter-class '*.EntraIdProvisioningTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'
& 'C:\Program Files\dotnet\dotnet.exe' artifacts\bin\Aspire.Hosting.Azure.EntraId.Tests\Debug\net10.0\Aspire.Hosting.Azure.EntraId.Tests.dll --filter-method '*.Publish_EndpointRedirectUri_UsesContainerAppEnvironmentHostAndOutputs' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Generated SDK snapshots for TypeScript, Go, Java, Python, and Rust, plus the TypeScript browser-reference scanner check: passed, 6 tests in total. Each corresponding project build succeeded. The following invocation was executed for each language project after reviewing regenerated snapshots:

# $name: Aspire.Hosting.CodeGeneration.<TypeScript|Go|Java|Python|Rust>.Tests
dotnet build "tests\$name\$name.csproj" --nologo -v:q
& 'C:\Program Files\dotnet\dotnet.exe' "artifacts\bin\$name\Debug\net10.0\$name.dll" --filter-method '*.TwoPassScanning_GeneratesWithEnvironmentOnTestRedisBuilder' --filter-method '*.Scanner_HostingAssembly_BrowserUrlReferences' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Deployment E2E project and Entra playground AppHost: builds passed. The playground build reported existing ILCompiler package vulnerability warnings.

dotnet build tests\Aspire.Deployment.EndToEnd.Tests\Aspire.Deployment.EndToEnd.Tests.csproj --nologo -v:q
dotnet build playground\EntraId\EntraId.AppHost\EntraId.AppHost.csproj --nologo -v:q

The ACA starter and Foundry hosted-agent deployment scenarios now inject and assert PrimaryBrowserOrigin alongside BrowserOrigins, but live deployment E2E tests were not run for the latest implementation. Earlier smoke/deployment evidence is available in the testing report and deployment run; those results predate the latest changes and do not validate them. The earlier run included a failing Sandbox port-exposure scenario.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Finalize customized browser URLs before endpoint allocation observers, expose deferred origin and URL projections, and use them for Entra redirects. Lower manifest values through existing schema features while preserving selected-path evaluation and symbolic deployment references.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3d226ee-2c7f-4986-a0e4-a6d27b72f6ec
@danegsta David Negstad (danegsta) added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Oct 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 21260

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 21260"

@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Oct 21, 2026
@github-actions

This comment has been minimized.

@danegsta

Copy link
Copy Markdown
Member Author

Eric Erhardt (@eerhardt) I did a thing based on our discussion of how the browser URLs would need to work to be general purpose. This basically takes the work you did but makes it generalized and removes the callback order risk.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Unresolved manifest correctness issues and the breaking lifecycle and security-sensitive origin changes require fixes and final human review.

2 open issues
What changed in this PR

Adds browser-facing origin references for CORS and authentication redirects, addressing #18819 without changing host or container service discovery.

Changes:

  • Introduces preferred-origin, full-URL, collection, and custom projections with explicit deployment expressions.
  • Finalizes URL customization before endpoint-allocation observers and shares browser origins with Entra redirect helpers.
  • Extends manifest expression processing and adds lifecycle, publishing, schema, and export coverage.
File Description
tests/​Aspire.Hosting.Tests/​WithUrlsTests.cs Updates callback-order expectations.
tests/​Aspire.Hosting.Tests/​Utils/​TestManifestValue.cs Adds a configurable expression test helper.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.WrappersDiscoverSelectedConditionalAndUnsupportedLeafReferences.verified.json Records wrapped dependency processing.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.WrapperRewritesOnlyReferencedTokensAndIgnoresEscapedDependencies.verified.json Records escaped-token handling.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.UriFormattingExpandsOnlySelectedBrowserAndConditionalAliases.verified.json Records selected-alias URI formatting.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.UnsupportedEndpointPropertyBecomesConcreteInDirectAndSelectedValues_tlsEnabled=True.verified.json Records concrete TLS-enabled values.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.UnsupportedEndpointPropertyBecomesConcreteInDirectAndSelectedValues_tlsEnabled=False.verified.json Records concrete TLS-disabled values.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.UnsupportedCustomPropertyResolvesOnceWithoutResolvingAdjacentParameters.verified.json Records concrete and symbolic composition.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.SupportedCustomProviderRetainsSymbolicValueWithoutResolution.verified.json Records symbolic custom-provider output.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.LiteralManifestValuesAreFormattedWithoutResolvingProviders.verified.json Records literal URI formatting.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.DistinctProviderInstancesRetainValuesAndDeterministicNames.verified.json Records distinct provider identities.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.ConcreteNullValueRetainsEmptyStringBehavior.verified.json Records null-to-empty conversion.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.ConcreteNamesAvoidExistingModelResourceNames.verified.json Records generated-name collision handling.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.CompositeUriFormattingEncodesLiteralsAndDefersParameters.verified.json Records deferred parameter formatting.
tests/​Aspire.Hosting.Tests/​Snapshots/​ManifestExpressionTests.CompositeUriFormattingDefersInfrastructureOutputs.verified.json Records deferred output formatting.
tests/​Aspire.Hosting.Tests/​Snapshots/​ConditionalReferenceExpressionTests.ManifestSelectedBranchReusesFormattedParameters.verified.json Records formatted-parameter reuse.
tests/​Aspire.Hosting.Tests/​Snapshots/​ConditionalReferenceExpressionTests.ManifestSelectedBranchRetainsParameterReferences_conditionValue=True.verified.json Records symbolic true-branch output.
tests/​Aspire.Hosting.Tests/​Snapshots/​ConditionalReferenceExpressionTests.ManifestSelectedBranchRetainsParameterReferences_conditionValue=False.verified.json Records symbolic false-branch output.
tests/​Aspire.Hosting.Tests/​Snapshots/​ConditionalReferenceExpressionTests.ManifestSelectedBranchRetainsInfrastructureOutput.verified.json Records selected infrastructure references.
tests/​Aspire.Hosting.Tests/​Snapshots/​ConditionalReferenceExpressionTests.ManifestOnlyEvaluatesSelectedNestedConditions.verified.json Records nested conditional selection.
tests/​Aspire.Hosting.Tests/​Snapshots/​ConditionalReferenceExpressionTests.ManifestCallbackRegistersReferencedConditionalValues.verified.json Records callback dependency registration.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestUsesValueResourcesForCollectionAndConditionalPublishingExpressions.verified.json Records collection and conditional aliases.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestUsesPublisherExpressionForDirectAndInterpolatedValues.verified.json Records deployment-expression reuse.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestPreservesShortCircuitingForUnselectedNestedConditions.verified.json Records conditional short-circuiting.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestInactiveBrowserBranchDoesNotRequirePublishingSupport_browserInTrueBranch=True.verified.json Records inactive true-branch exclusion.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestInactiveBrowserBranchDoesNotRequirePublishingSupport_browserInTrueBranch=False.verified.json Records inactive false-branch exclusion.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestConditionalBrowserConditionReceivesPublishingContext.verified.json Records publishing-context selection.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestConditionalBrowserBranchesRetainDeploymentReferences.verified.json Records deferred browser references.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestBrowserInstancesPreserveFormattingAndWrappedTokens_reverseOrder=True.verified.json Records identities with reversed usage order.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestBrowserInstancesPreserveFormattingAndWrappedTokens_reverseOrder=False.verified.json Records identities with normal usage order.
tests/​Aspire.Hosting.Tests/​Snapshots/​BrowserUrlReferenceTests.ManifestBrowserInstancesPreserveDistinctPublishingProviders.verified.json Records distinct publishing providers.
tests/​Aspire.Hosting.Tests/​Schema/​SchemaTests.cs Adds mixed-expression schema coverage.
tests/​Aspire.Hosting.Tests/​Orchestrator/​ApplicationOrchestratorTests.cs Tests finalization, normalization, and recovery.
tests/​Aspire.Hosting.Tests/​ManifestExpressionTests.cs Tests expression processing and formatting.
tests/​Aspire.Hosting.Tests/​Eventing/​DistributedApplicationBuilderEventingTests.cs Tests preparation across dispatch modes.
tests/​Aspire.Hosting.Tests/​Dcp/​DcpExecutorTests.cs Tests batch-wide URL finalization.
tests/​Aspire.Hosting.Tests/​ConditionalReferenceExpressionTests.cs Tests selected-branch publication.
tests/​Aspire.Hosting.Kubernetes.Tests/​Snapshots/​KubernetesPublisherTests.BrowserUrlProjectionUsesPublisherExpression#01.verified.yaml Records Helm configuration values.
tests/​Aspire.Hosting.Kubernetes.Tests/​Snapshots/​KubernetesPublisherTests.BrowserUrlProjectionUsesPublisherExpression#00.verified.yaml Records ConfigMap expressions.
tests/​Aspire.Hosting.Kubernetes.Tests/​KubernetesPublisherTests.cs Tests native Kubernetes projection.
tests/​Aspire.Hosting.Docker.Tests/​Snapshots/​DockerComposePublisherTests.BrowserUrlProjectionUsesPublisherExpression.verified.yaml Records Compose deployment expressions.
tests/​Aspire.Hosting.Docker.Tests/​Snapshots/​DockerComposePublisherTests.BrowserUrlProjectionUsesPublisherExpression.verified.env Records deployment parameter declaration.
tests/​Aspire.Hosting.Docker.Tests/​DockerComposePublisherTests.cs Tests native Compose projection.
tests/​Aspire.Hosting.CodeGeneration.TypeScript.Tests/​AtsTypeScriptCodeGeneratorTests.cs Checks browser-reference exports.
tests/​Aspire.Hosting.Azure.Tests/​Snapshots/​AzureEnvironmentResourceTests.BrowserUrlProjectionUsesPublisherExpression.verified.bicep Records native Azure parameter composition.
tests/​Aspire.Hosting.Azure.Tests/​Snapshots/​AzureEnvironmentResourceTests.BrowserUrlProjectionsUseAzureWorkloadExpressions_appService=True.verified.json Records App Service manifest parameters.
tests/​Aspire.Hosting.Azure.Tests/​Snapshots/​AzureEnvironmentResourceTests.BrowserUrlProjectionsUseAzureWorkloadExpressions_appService=True.verified.bicep Records App Service settings.
tests/​Aspire.Hosting.Azure.Tests/​Snapshots/​AzureEnvironmentResourceTests.BrowserUrlProjectionsUseAzureWorkloadExpressions_appService=False.verified.json Records Container Apps manifest parameters.
tests/​Aspire.Hosting.Azure.Tests/​Snapshots/​AzureEnvironmentResourceTests.BrowserUrlProjectionsUseAzureWorkloadExpressions_appService=False.verified.bicep Records Container Apps environment values.
tests/​Aspire.Hosting.Azure.Tests/​AzureEnvironmentResourceTests.cs Tests native Azure projections.
tests/​Aspire.Hosting.Azure.EntraId.Tests/​Snapshots/​EntraIdProvisioningTests.WithRedirectUris_Expressions_PreserveDeferredValues.verified.bicep Records deferred redirect parameters.
tests/​Aspire.Hosting.Azure.EntraId.Tests/​Snapshots/​EntraIdProvisioningTests.Publish_BrowserOriginRedirectExpression_PreservesDeploymentParameter#01.verified.bicep Records registration redirect input.
tests/​Aspire.Hosting.Azure.EntraId.Tests/​Snapshots/​EntraIdProvisioningTests.Publish_BrowserOriginRedirectExpression_PreservesDeploymentParameter#00.verified.bicep Records deployment redirect composition.
tests/​Aspire.Hosting.Azure.EntraId.Tests/​EntraIdProvisioningTests.cs Tests shared origins and deferred redirects.
src/​Aspire.Hosting/​ResourceBuilderExtensions.cs Adds browser-origin helpers and lifecycle documentation.
src/​Aspire.Hosting/​README.md Documents projections and publishing behavior.
src/​Aspire.Hosting/​Publishing/​ManifestPublishingContext.cs Processes symbolic, concrete, and formatted values.
src/​Aspire.Hosting/​Publishing/​ManifestExpression.cs Adds manifest tokenization and vocabulary checks.
src/​Aspire.Hosting/​Orchestrator/​ApplicationOrchestrator.cs Captures finalized URLs before observers.
src/​Aspire.Hosting/​Eventing/​DistributedApplicationEventSubscription.cs Marks lifecycle preparation subscriptions.
src/​Aspire.Hosting/​Eventing/​DistributedApplicationEventing.cs Runs preparation before observer dispatch.
src/​Aspire.Hosting/​Dcp/​DcpExecutorEvents.cs Carries allocated-event batches.
src/​Aspire.Hosting/​Dcp/​DcpExecutor.cs Prepares batch URLs before notifications.
src/​Aspire.Hosting/​Aspire.Hosting.csproj Includes shared resource-name helpers.
src/​Aspire.Hosting/​ApplicationModel/​ResourceEndpointsAllocatedEvent.cs Tracks URL preparation and documents ordering.
src/​Aspire.Hosting/​ApplicationModel/​BrowserUrlSnapshotAnnotation.cs Stores and orders finalized browser URLs.
src/​Aspire.Hosting/​ApplicationModel/​BrowserOriginReference.cs Implements browser projections and deployment expressions.
src/​Aspire.Hosting.Azure.EntraId/​README.md Documents shared-origin redirects.
src/​Aspire.Hosting.Azure.EntraId/​EntraIdResourceExtensions.cs Adds expression redirects and shared-origin usage.
src/​Aspire.Hosting.Azure.EntraId/​EntraIdEndpointRedirectUri.cs Removes the separate redirect URL-capture implementation.
src/​Aspire.Hosting.Azure.EntraId/​EntraIdApplicationResource.cs Preserves redirect expressions during provisioning.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Lower complete structured expressions before token matching and reject ambiguous provider matches. Retain formatting alias metadata so nested URI encoding preserves each pass without resolving deployment parameters.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3d226ee-2c7f-4986-a0e4-a6d27b72f6ec
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Broad lifecycle and security-sensitive origin changes require human review, and the azd Bicep URI-formatting compatibility issue remains unresolved.

1 open issue
2 resolved since last review

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Replace browser-specific references with endpoint properties, finalize canonical URLs before allocation notifications, and handle publisher-owned origin inputs and defaults. Project Codespaces URLs before origin resolution while preserving physical endpoints.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3d226ee-2c7f-4986-a0e4-a6d27b72f6ec

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Invalid Helm YAML, endpoint-name casing failures, wildcard TLS origin mismatches, and incomplete MAUI URL finalization remain unresolved.

4 open issues
1 resolved since last review

Review effort: Balanced

Quote ConfigMap values after Helm evaluation, preserve canonical endpoint lookup names, and use HostString matching with the Ingress-specific wildcard restriction. Add rendered-chart and hostname-scope regressions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3d226ee-2c7f-4986-a0e4-a6d27b72f6ec

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Deployment E2E coverage must verify Container Apps origin values and Sandbox producer/consumer ordering against actual deployed authorities.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Medium severity Test deployed BrowserOrigins resolution between producer and consumer

src/​Aspire.Hosting.Azure.Sandboxes/​AzureSandboxEndpointPropertyValueProvider.cs:113

The new sandbox-origin test pre-populates Ports, so it verifies URI extraction but not that a browser-origin reference is resolved after its producer deploys and reaches the consuming workload. No deployment E2E currently consumes BrowserOrigins. Please extend tests/Aspire.Deployment.EndToEnd.Tests/AzureSandboxesDeploymentTests.cs with a producer/consumer scenario that injects these properties and compares the consumer's received values with the producer's actual deployed proxy authority; this would catch deployment-order and value-projection failures that the seeded-state test cannot detect.

4 resolved since last review

Review effort: Balanced

Preserve the Azure environment test imports and upstream experimental API suppression. Update the browser-origin Entra snapshot for the upstream service-principal tags.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3d226ee-2c7f-4986-a0e4-a6d27b72f6ec
@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot October 27, 2026 00:34
Keep custom browser origins first while retaining the allocated HTTP(S) origin. Reject unsupported private and non-HTTP(S) publisher references instead of allocating inputs, and clarify deployment diagnostics.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3d226ee-2c7f-4986-a0e4-a6d27b72f6ec
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Cross-publisher endpoint ordering affects security-sensitive CORS and redirect values, while deployment evidence predates later revisions and includes a Sandbox failure, requiring human confirmation of current-revision behavior.

No open issues 🎉

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The linked deployment run failed Sandbox port exposure and predates later revisions, leaving current cross-publisher origin/authentication handling and allocation-event ordering requiring human runtime verification.

No open issues 🎉

Review effort: Balanced

Use a scalar browser-origin reference for Entra redirect URIs and Node base URL configuration. Wire manifest inputs, native publishers, polyglot SDKs, documentation, and regression coverage while preserving the Entra playground launch settings changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Two Bicep snapshot baselines still expect comma-list projections instead of direct single-origin interpolation, causing the redirect and starter publish snapshot comparisons to fail.

2 open issues

Review effort: Balanced

Mark the polyglot redirect fixture endpoint external to match deployment requirements.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3d226ee-2c7f-4986-a0e4-a6d27b72f6ec
Include the resource identity and location outputs emitted by the updated App Service publisher.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3d226ee-2c7f-4986-a0e4-a6d27b72f6ec
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The latest lifecycle-ordering, origin-mapping, and Entra redirect changes lack live deployment validation against current head, particularly for the previously failing Sandbox port-exposure scenario.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review at 4c49f2ff89 from reading the code; nothing was compiled or run.

Both of my 11-04 threads are resolved. The 30-second Entra bound falls back to the allocated origin again, and the :uri manifest break is now listed under Compatibility.

The one inline comment is minor and fine as a follow-up.

Still open, and I'd want it settled before merge: the point from my 11-03 review about direct publishers hasn't been answered. ApplicationOrchestrator no longer subscribes to ResourceEndpointsAllocatedEvent, and MauiOtlpExtensions.cs still calls PublishAsync(new ResourceEndpointsAllocatedEvent(...)) at lines 209 and 524. Custom resources outside the repo that use that pattern lose their URLs and WithUrls callbacks, and BrowserOrigins references to their endpoints wait forever. The Compatibility section doesn't mention it. Either a guarded subscription or a Compatibility entry would settle it.

Submitting as a comment rather than an approval, since auto-merge is on and this review carries comments. That also means this comment won't hold the merge.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Check the compute environment's TLS property during infrastructure generation so HTTP endpoints with HTTPS upgrade disabled fail early. Preserve run-mode behavior and explicit TLS overrides, and cover ACA and App Service upgrade settings.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: b3d226ee-2c7f-4986-a0e4-a6d27b72f6ec
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Tests selector

53 / 101 PR test projects · 4 PR jobs, from 194 changed files.

Selected PR test projects (53 / 101)

Aspire.Cli.EndToEnd.Tests, Aspire.Hosting.Analyzers.Tests, Aspire.Hosting.Azure.EntraId.Tests, Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Kusto.Tests, Aspire.Hosting.Azure.Provisioning.Tests, Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Browsers.Tests, Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.CodeGeneration.TypeScript.Tests, Aspire.Hosting.Containers.Tests, Aspire.Hosting.DevTunnels.Tests, Aspire.Hosting.Docker.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.DotnetTool.Tests, Aspire.Hosting.EntityFrameworkCore.Tests, Aspire.Hosting.Foundry.Tests, Aspire.Hosting.Garnet.Tests, Aspire.Hosting.Go.Tests, Aspire.Hosting.Java.Tests, Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Kafka.Tests, Aspire.Hosting.Keycloak.Tests, Aspire.Hosting.Kubernetes.Tests, Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests, Aspire.Hosting.MongoDB.Tests, Aspire.Hosting.MySql.Tests, Aspire.Hosting.Nats.Tests, Aspire.Hosting.OpenAI.Tests, Aspire.Hosting.Oracle.Tests, Aspire.Hosting.Orleans.Tests, Aspire.Hosting.PostgreSQL.Tests, Aspire.Hosting.Python.Tests, Aspire.Hosting.Qdrant.Tests, Aspire.Hosting.RabbitMQ.Tests, Aspire.Hosting.Radius.Tests, Aspire.Hosting.Redis.Tests, Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests, Aspire.Hosting.Seq.Tests, Aspire.Hosting.SqlServer.Tests, Aspire.Hosting.Testing.Tests, Aspire.Hosting.Tests, Aspire.Hosting.Valkey.Tests, Aspire.Hosting.Yarp.Tests, Aspire.Playground.Tests, Aspire.Templates.Tests, Infrastructure.Tests

Selected PR jobs (4)

cli-starter-validation, extension-e2e, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

⚠️ 31 of the 53 selected test projects come from a single change — src/Aspire.Hosting/ApplicationModel/EndpointAnnotation.cs.

🔧 src/Aspire.Hosting/ApplicationModel/EndpointAnnotation.cs (changed source)
→ 31 via the project graph

show 31

Aspire.Hosting.Analyzers.Tests (2 hops), Aspire.Hosting.Browsers.Tests (2 hops), Aspire.Hosting.Containers.Tests (2 hops), Aspire.Hosting.DotnetTool.Tests (2 hops), Aspire.Hosting.EntityFrameworkCore.Tests (2 hops), Aspire.Hosting.Garnet.Tests (2 hops), Aspire.Hosting.Go.Tests (2 hops), Aspire.Hosting.Java.Tests (2 hops), Aspire.Hosting.JavaScript.Tests (2 hops), Aspire.Hosting.Kafka.Tests (2 hops), Aspire.Hosting.Keycloak.Tests (2 hops), Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests (2 hops), Aspire.Hosting.MongoDB.Tests (2 hops), Aspire.Hosting.MySql.Tests (2 hops), Aspire.Hosting.Nats.Tests (2 hops), Aspire.Hosting.OpenAI.Tests (2 hops), Aspire.Hosting.Oracle.Tests (2 hops), Aspire.Hosting.Orleans.Tests (2 hops), Aspire.Hosting.PostgreSQL.Tests (2 hops), Aspire.Hosting.Python.Tests (2 hops), Aspire.Hosting.Qdrant.Tests (2 hops), Aspire.Hosting.RabbitMQ.Tests (2 hops), Aspire.Hosting.Redis.Tests (2 hops), Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests (2 hops), Aspire.Hosting.Seq.Tests (2 hops), Aspire.Hosting.SqlServer.Tests (2 hops), Aspire.Hosting.Testing.Tests (2 hops), Aspire.Hosting.Valkey.Tests (2 hops), Aspire.Playground.Tests

🔧 src/Aspire.Hosting.Azure/AzureBicepResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests
→ 2 via the project graph: Aspire.Hosting.Azure.Kusto.Tests (2 hops), Aspire.Hosting.Azure.Provisioning.Tests (2 hops)

🧪 tests/Aspire.Hosting.Tests/AddParameterTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests
→ 2 via the project graph: Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Dotnet.Tests

📦 affected project Aspire.Hosting.Dotnet
→ 2 tests: Aspire.Cli.EndToEnd.Tests, Aspire.Templates.Tests

🔧 src/Aspire.Hosting.Azure.EntraId/EntraIdApplicationResource.cs (changed source)
→ 2 directly: Aspire.Hosting.Azure.EntraId.Tests, Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Azure.EntraId/EntraIdEndpointRedirectUri.cs (changed source)
→ 2 directly: Aspire.Hosting.Azure.EntraId.Tests, Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Azure.EntraId/EntraIdResourceExtensions.cs (changed source)
→ 2 directly: Aspire.Hosting.Azure.EntraId.Tests, Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Azure.EntraId/EntraIdRunModeBrowserOrigin.cs (changed source)
→ 2 directly: Aspire.Hosting.Azure.EntraId.Tests, Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Docker/Aspire.Hosting.Docker.csproj (changed source)
→ 1 directly: Aspire.Hosting.Docker.Tests
→ 1 via the project graph: Aspire.Hosting.Yarp.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/AzureContainerAppExpressEndpointTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests
→ 1 via the project graph: Aspire.Hosting.Azure.Kubernetes.Tests

📦 affected project Aspire.Hosting.Docker
→ 1 test: Aspire.Cli.EndToEnd.Tests

📄 playground/EntraId/EntraId.AppHost/AppHost.cs (changed)
→ 1 directly: Aspire.Playground.Tests

📄 playground/EntraId/EntraId.AppHost/Properties/launchSettings.json (changed)
→ 1 directly: Aspire.Playground.Tests

📄 playground/EntraId/EntraId.Web/Properties/launchSettings.json (changed)
→ 1 directly: Aspire.Playground.Tests

🔧 src/Aspire.Hosting.Azure.AppContainers/AzureContainerAppEnvironmentResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Azure.AppContainers/BaseContainerAppContext.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Azure.AppService/AzureAppServiceEnvironmentResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Azure.AppService/AzureAppServiceWebsiteContext.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Azure.Sandboxes/Aspire.Hosting.Azure.Sandboxes.csproj (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.Azure.Sandboxes/AzureSandboxEndpointPropertyValueProvider.cs (changed source)
→ 1 directly: Aspire.Hosting.Azure.Tests

🔧 src/Aspire.Hosting.DevTunnels/DevTunnelMonitor.cs (changed source)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests

🔧 src/Aspire.Hosting.DevTunnels/DevTunnelResourceBuilderExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests

🔧 src/Aspire.Hosting.Docker/DockerComposeEnvironmentResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Docker.Tests

🔧 src/Aspire.Hosting.Docker/DockerComposePublishingContext.cs (changed source)
→ 1 directly: Aspire.Hosting.Docker.Tests

🔧 src/Aspire.Hosting.Docker/DockerComposeServiceResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Docker.Tests

🔧 src/Aspire.Hosting.Docker/DockerComposeServiceResourceExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Docker.Tests

🔧 src/Aspire.Hosting.Foundry/Project/ProjectBuilderExtension.cs (changed source)
→ 1 directly: Aspire.Hosting.Foundry.Tests

🔧 src/Aspire.Hosting.Foundry/Project/ProjectResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Foundry.Tests

🔧 src/Aspire.Hosting.Kubernetes/Aspire.Hosting.Kubernetes.csproj (changed source)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🔧 src/Aspire.Hosting.Kubernetes/Extensions/HelmExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🔧 src/Aspire.Hosting.Kubernetes/Extensions/ResourceExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🔧 src/Aspire.Hosting.Kubernetes/KubernetesEnvironmentContext.cs (changed source)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🔧 src/Aspire.Hosting.Kubernetes/KubernetesResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🔧 src/Aspire.Hosting.Radius/Aspire.Hosting.Radius.csproj (changed source)
→ 1 directly: Aspire.Hosting.Radius.Tests

🔧 src/Aspire.Hosting.Radius/Publishing/RadiusInfrastructureBuilder.cs (changed source)
→ 1 directly: Aspire.Hosting.Radius.Tests

🔧 src/Aspire.Hosting.Radius/RadiusEnvironmentResource.cs (changed source)
→ 1 directly: Aspire.Hosting.Radius.Tests

🔧 src/Aspire.Hosting/Aspire.Hosting.csproj (changed source)
→ 1 directly: Infrastructure.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Aspire.Hosting.Azure.EntraId.Tests.csproj (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/EntraIdPolyglotTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/EntraIdProvisioningTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdPolyglotTests.Redirects_KeepEndpointValuesDeferred_operation=Publish.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdPolyglotTests.Redirects_KeepEndpointValuesDeferred_operation=Run.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdProvisioningTests.Publish_EndpointRedirectUri_UsesContainerAppEnvironmentHostAndOutputs#00.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdProvisioningTests.Publish_EndpointRedirectUri_UsesContainerAppEnvironmentHostAndOutputs#01.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdProvisioningTests.WithRedirectUris_Endpoint_PreservesDeferredValues.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdProvisioningTests.WithRedirectUris_Endpoint_PublishMode_UsesComputeEnvironmentHost.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdProvisioningTests.WithRedirectUris_Endpoint_RunMode_ClearedDisplayUrlsUseAllocatedOrigin.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdProvisioningTests.WithRedirectUris_Endpoint_RunMode_UsesAllocatedEndpointUrl.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdStarterScenarioPublishTests.Publish_StarterWithEntra_ConfiguresTheApiAndTheWebFrontEnd#00.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.EntraId.Tests/Snapshots/EntraIdStarterScenarioPublishTests.Publish_StarterWithEntra_ConfiguresTheApiAndTheWebFrontEnd#02.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.EntraId.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/AzureEnvironmentResourceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/AzureSandboxesTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureEnvironmentResourceTests.BrowserUrlProjectionsUseAzureWorkloadExpressions_appService=False.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureEnvironmentResourceTests.BrowserUrlProjectionsUseAzureWorkloadExpressions_appService=False.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureEnvironmentResourceTests.BrowserUrlProjectionsUseAzureWorkloadExpressions_appService=True.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/Snapshots/AzureEnvironmentResourceTests.BrowserUrlProjectionsUseAzureWorkloadExpressions_appService=True.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/Snapshots/FoundryExtensionsTests.AddProject_GeneratesEndpointFromParentFoundryApiEndpoint.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.Go.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.go (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.Go.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.Java.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.java (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.Java.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.Python.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.py (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.Python.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.Rust.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.rs (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.Rust.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/AtsTypeScriptCodeGeneratorTests.cs (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.TypeScript.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.ts (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.TypeScript.Tests

🧪 tests/Aspire.Hosting.DevTunnels.Tests/DevTunnelMonitorTests.cs (changed test)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/DockerComposePublisherTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserOriginInputsAvoidDeclaredParameterNames_originFirst=False_normalizedCollision=False.verified.env (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserOriginInputsAvoidDeclaredParameterNames_originFirst=False_normalizedCollision=True.verified.env (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserOriginInputsAvoidDeclaredParameterNames_originFirst=True_normalizedCollision=False.verified.env (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserOriginInputsAvoidDeclaredParameterNames_originFirst=True_normalizedCollision=True.verified.env (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserOriginInputsDefaultToPublishedLocalhost_overridden=False.verified.env (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserOriginInputsDefaultToPublishedLocalhost_overridden=True.verified.env (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserOriginInputsKeepDistinctEndpointIdentities_longNames=False.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserOriginInputsKeepDistinctEndpointIdentities_longNames=True.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserUrlProjectionUsesPublisherExpression#00.verified.env (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserUrlProjectionUsesPublisherExpression#01.verified.env (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Docker.Tests/Snapshots/DockerComposePublisherTests.BrowserUrlProjectionUsesPublisherExpression.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Docker.Tests

🧪 tests/Aspire.Hosting.Foundry.Tests/ProjectResourceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Foundry.Tests

🧪 tests/Aspire.Hosting.Foundry.Tests/Snapshots/ProjectResourceTests.BrowserOriginOutputRemovesProjectNavigationPath.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Foundry.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/HelmExtensionsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/KubernetesPublisherTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesDeployTests.ConditionalParameterWithoutDefault_EndToEnd_PublishAndResolve.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesDeployTests.DeferredValueProvider_EndToEnd_PublishAndResolve#01.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesEnvironmentResourceTests.MultipleKubernetesEnvironmentsSupported/env1/templates/ServiceA/config.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesEnvironmentResourceTests.MultipleKubernetesEnvironmentsSupported/env1/templates/env1-dashboard/config.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesEnvironmentResourceTests.MultipleKubernetesEnvironmentsSupported/env2/templates/ServiceB/config.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesEnvironmentResourceTests.MultipleKubernetesEnvironmentsSupported/env2/templates/env2-dashboard/config.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.BrowserOriginDefaultsAllowConfiguredOverride.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.BrowserOriginDefaultsFollowConfiguredPublicRoutes_gateway=False_tls=False.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.BrowserOriginDefaultsFollowConfiguredPublicRoutes_gateway=False_tls=True.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.BrowserOriginDefaultsFollowConfiguredPublicRoutes_gateway=True_tls=False.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.BrowserOriginDefaultsFollowConfiguredPublicRoutes_gateway=True_tls=True.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.BrowserOriginInputsKeepDistinctEndpointIdentities.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.BrowserUrlProjectionUsesPublisherExpression#00.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.BrowserUrlProjectionUsesPublisherExpression#01.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.BrowserUrlProjectionUsesPublisherExpression#02.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.KubernetesEndpointReferenceUsesServicePortNotTargetPort#02.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.KubernetesMapsPortsForBaitAndSwitchResources#06.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.KubernetesMapsPortsForBaitAndSwitchResources#08.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.KubernetesWithDotnetProjectUsesImageParameterAndProjectEndpoint#04.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.KubernetesWithProjectResources#06.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.KubernetesWithProjectResources#08.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_CompositeExpressionPreservesExpressionShape#01.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_ConditionalBranchesCaptureEmbeddedParameters#01.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_ConditionalWithParameterBranch_UsesIfElseSyntax#05.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_CustomWorkloadAndResourceType#06.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_EmbeddedParametersInEnvironmentExpressionsPopulateValues#01.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_EmbeddedParametersInEnvironmentExpressionsPopulateValues#02.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_GeneratesValidHelmChart#05.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_GeneratesValidHelmChart#08.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_GeneratesValidHelmChart#09.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_GeneratesValidHelmChart#10.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesConditionalReferenceExpression#05.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesConditionalReferenceExpressionWithParameterCondition#05.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesScalarEnvironmentVariableTypes#03.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesSpecialResourceName#05.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_HandlesSpecialResourceName#06.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_ProjectAndExecutableVolumesUseDefaultStorageAndEnvironmentPaths#00.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_ProjectAndExecutableVolumesUseDefaultStorageAndEnvironmentPaths#02.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_SharedEmbeddedParameterIsScopedPerResource#01.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_SharedEmbeddedParameterIsScopedPerResource#02.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_WithFirstClassPersistentVolume_EnvironmentUsesDeploymentMountPath#00.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_WithPersistentVolumeEnvironment_OnContainerAndExecutable#00.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Kubernetes.Tests/Snapshots/KubernetesPublisherTests.PublishAsync_WithPersistentVolumeEnvironment_OnContainerAndExecutable#03.verified.yaml (changed test)
→ 1 directly: Aspire.Hosting.Kubernetes.Tests

🧪 tests/Aspire.Hosting.Radius.Tests/Publishing/RadiusDeployParametersTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Radius.Tests

🧪 tests/Aspire.Hosting.Radius.Tests/RadiusEnvironmentResourceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Radius.Tests

🧪 tests/Aspire.Hosting.Radius.Tests/Snapshots/RadiusDeployParametersTests.BrowserOriginInputsKeepDistinctEndpointIdentities.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Radius.Tests

🧪 tests/Aspire.Hosting.Radius.Tests/Snapshots/RadiusDeployParametersTests.BrowserOriginsUseRequiredInputsAndStandardDeployBindings_configured=True.verified.bicep (changed test)
→ 1 directly: Aspire.Hosting.Radius.Tests

🧪 tests/Aspire.Hosting.Radius.Tests/Snapshots/RadiusDeployParametersTests.BrowserOriginsUseRequiredInputsAndStandardDeployBindings_configured=True.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Radius.Tests

🧪 tests/Aspire.Hosting.Tests/Codespaces/CodespacesUrlRewriterTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ComputeEnvironmentValidationTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ConditionalReferenceExpressionTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Dcp/DcpExecutorTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/EndpointReferenceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Eventing/DistributedApplicationBuilderEventingTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/ManifestExpressionTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Orchestrator/ApplicationOrchestratorTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Schema/SchemaTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ConditionalReferenceExpressionTests.ManifestCallbackRegistersReferencedConditionalValues.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ConditionalReferenceExpressionTests.ManifestOnlyEvaluatesSelectedNestedConditions.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ConditionalReferenceExpressionTests.ManifestSelectedBranchRetainsInfrastructureOutput.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ConditionalReferenceExpressionTests.ManifestSelectedBranchRetainsParameterReferences_conditionValue=False.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ConditionalReferenceExpressionTests.ManifestSelectedBranchRetainsParameterReferences_conditionValue=True.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ConditionalReferenceExpressionTests.ManifestSelectedBranchReusesFormattedParameters.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.CompositeUriFormattingDefersInfrastructureOutputs.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.CompositeUriFormattingEncodesLiteralsAndDefersParameters.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.ConcreteNamesAvoidExistingModelResourceNames.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.ConditionalDoesNotEvaluateUnselectedNestedCondition.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.CustomSecretProviderIsNeverMaterialized_dependencyOnly=False.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.CustomSecretProviderIsNeverMaterialized_dependencyOnly=True.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.DistinctProviderInstancesRetainValuesAndDeterministicNames.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.EndpointOriginInputsAreLoweredInResourceManifestCallbacks.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.EndpointOriginInputsAvoidExistingResourceNames.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.EndpointOriginPropertiesBecomeRequiredInputs_property=BrowserOrigins.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.EndpointOriginPropertiesBecomeRequiredInputs_property=PrimaryBrowserOrigin.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.LiteralManifestValuesAreFormattedWithoutResolvingProviders.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.NestedUriFormattingPreservesConcreteEncodingPasses.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.NestedUriFormattingPreservesParameterAndCompositeAliasOperations_composite=False.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.NestedUriFormattingPreservesParameterAndCompositeAliasOperations_composite=True.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.NullCustomProviderRetainsSymbolicValue.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.SupportedCustomProviderRetainsSymbolicValueWithoutResolution.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.SymbolicOnlyProvidersPreserveOpaqueTokensAlongsideLoweredOrigins.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.UnavailableCustomProviderIsNotEvaluated.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.UnselectedEndpointOriginDoesNotRequireDeploymentInput_originInTrueBranch=False.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.UnselectedEndpointOriginDoesNotRequireDeploymentInput_originInTrueBranch=True.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.UnsupportedCustomPropertyRemainsSymbolicAlongsideParameters.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.UnsupportedEndpointPropertyBecomesConcreteInDirectAndSelectedValues_tlsEnabled=False.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.UnsupportedEndpointPropertyBecomesConcreteInDirectAndSelectedValues_tlsEnabled=True.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.UriFormattingExpandsOnlySelectedConditionalAliases.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.WrappedRepeatedProviderIsNotAmbiguous.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.WrappedStructuredExpressionsPreserveProviderOccurrencesAndFormats_reverseOrder=False.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.WrappedStructuredExpressionsPreserveProviderOccurrencesAndFormats_reverseOrder=True.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.WrapperRewritesOnlyReferencedTokensAndIgnoresEscapedDependencies.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Snapshots/ManifestExpressionTests.WrappersDiscoverSelectedConditionalAndUnsupportedLeafReferences.verified.json (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Utils/TestManifestExpression.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/Utils/TestManifestValue.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

🧪 tests/Aspire.Hosting.Tests/WithUrlsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

Job reasons

Job Triggered by
cli-starter-validation affected project Aspire.Hosting.AppHost
extension-e2e • src/Aspire.Hosting.Docker/Aspire.Hosting.Docker.csproj, src/Aspire.Hosting.Docker/DockerComposeEnvironmentResource.cs, src/Aspire.Hosting.Docker/DockerComposePublishingContext.cs, src/Aspire.Hosting.Docker/DockerComposeServiceResource.cs, src/Aspire.Hosting.Docker/DockerComposeServiceResourceExtensions.cs, src/Aspire.Hosting/ApplicationModel/EndpointAnnotation.cs, src/Aspire.Hosting/ApplicationModel/EndpointReference.cs, src/Aspire.Hosting/ApplicationModel/IComputeEnvironmentResource.cs, src/Aspire.Hosting/ApplicationModel/ResourceEndpointsAllocatedEvent.cs, src/Aspire.Hosting/ApplicationModel/ResourceUrlsCallbackScope.cs, src/Aspire.Hosting/Aspire.Hosting.csproj, src/Aspire.Hosting/Dcp/DcpExecutor.cs, src/Aspire.Hosting/Dcp/DcpExecutorEvents.cs, src/Aspire.Hosting/Devcontainers/Codespaces/CodespacesResourceUrlRewriterService.cs, src/Aspire.Hosting/Devcontainers/Codespaces/CodespacesUrlRewriter.cs, src/Aspire.Hosting/DistributedApplicationEventingExtensions.cs, src/Aspire.Hosting/Orchestrator/ApplicationOrchestrator.cs, src/Aspire.Hosting/ParameterResourceBuilderExtensions.cs, src/Aspire.Hosting/Publishing/ManifestExpression.cs, src/Aspire.Hosting/Publishing/ManifestPublishingContext.cs, src/Aspire.Hosting/ResourceBuilderExtensions.cs
• affected project Aspire.Hosting.Docker
polyglot • affected project Aspire.Hosting.Azure.AppContainers
• affected project Aspire.Hosting.Azure.Provisioning.AppContainers
typescript-api-compat affected project Aspire.Hosting.Azure.AppContainers

Selection computed for commit 427943e.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because the new overload can expose secret parameter defaults in published manifests, creating a critical security risk.

No open issues 🎉

Review effort: Balanced

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #2068

Generated by PR Documentation Check · copilot · auto · 28.7 AIC · ⌖ 1.18 AIC · ⊞ 7.4K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#2068 targeting release/17.0.

Added a "Browser-facing origins" section to fundamentals/networking-overview.mdx covering PrimaryBrowserOrigin/BrowserOrigins, run/publish behavior, and compatibility notes. Signals: integration_readme_changed (Aspire.Hosting.Docker/Kubernetes/Foundry READMEs), pr_label_breaking_change (breaking-change), pr_body_has_security_marker, pr_body_has_cli_flag_mention (the last two are likely false positives from test commands).

Note

This draft PR needs human review before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication breaking-change Issue or PR that represents a breaking API or functional change over a prerelease.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot access the "public" URL of a resource when using the dev.localhost applicationUrls

4 participants