Repository navigation
Report configuration source availability in aspire doctor - #21677
Merged
James Newton-King (JamesNK) merged 2 commits intoNov 2, 2026
Merged
James Newton-King (JamesNK) merged 2 commits into
James Newton-King (JamesNK) merged 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
James Newton-King (JamesNK)
requested review from
David Fowler (davidfowl) and
Mitch Denny (mitchdenny)
as code owners
November 2, 2026 04:54
5 of 14 tasks
Mitch Denny (mitchdenny)
approved these changes
Nov 2, 2026
Mitch Denny (mitchdenny)
left a comment
Member
There was a problem hiding this comment.
Non-blocking: if employee detection fails or times out, the new diagnostic appears to report a green “No configuration source is available on this machine.” That could be misleading because availability is unknown rather than confirmed absent. Consider distinguishing inconclusive discovery from a genuine negative result, perhaps with a warning. Not blocking approval.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
James Newton-King (JamesNK)
merged commit Nov 2, 2026
d3b845e
into
jamesnk/config-source-brownfield
6 checks passed
4 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Existing AppHosts do not currently tell users when an organization configuration source is available but has not been adopted.
aspire doctornow reports machine source availability and the current AppHost's saved configuration-source choice, with a non-blocking suggestion to runaspire updatewhen no choice has been recorded.PR stack:
main-> #21678 (brownfield adoption) -> this doctor PR.Stacked PR: depends on #21678 and targets
jamesnk/config-source-brownfield, which contains brownfield adoption and persistedconfigSource.optOutsupport. This PR adds only the doctor diagnostics and their supporting discovery extraction, tests, localization, and documentation.Project diagnostics currently inspect the nearest local configuration. Reporting and accounting for saved global source bindings remains follow-up work; a project using global defaults can still receive the local-adoption warning.
User-facing usage
Relevant existing command help, also exercised by the doctor tests:
When a candidate is available and the AppHost has no recorded choice, doctor reports a warning with:
JSON output includes the
config-sourceenvironment check and, when applicable, theapphost-config-sourcecheck with abound,optedOut, orunconfiguredstate. An explicit opt-out is reported as an intentional choice, not something to fix.Screenshots / Recordings
TODO: Capture
aspire doctorwithASPIRE_INIT_SOURCE_URLset in an AppHost with no saved source choice, showing availability, the adoption warning, and its suggested fix. Also capture saved-binding and explicit-opt-out states. No visual capture was made during this change.Validation
Focused validation rerun after splitting the branches: passed, 52 succeeded, 0 failed, 0 skipped.
Broader doctor, creation, and config-source regression coverage, run before splitting the same implementation into commits: passed, 784 succeeded, 0 failed, 2 skipped.
Localization regeneration: passed, 0 warnings and 0 errors.
Doctor-only diff whitespace validation: passed.
The full repository suite and manual visual verification were not run.
Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?