Skip to content

Address CLI configuration-source threat model follow-ups - #21682

Merged
James Newton-King (JamesNK) merged 5 commits into
mainfrom
jamesnk/config-source-review-followups
Nov 3, 2026
Merged

James Newton-King (JamesNK) merged 5 commits into
mainfrom
jamesnk/config-source-review-followups

Conversation

@JamesNK

Copy link
Copy Markdown
Member

Description

Follow up on the configuration-source threat-model review by making source trust explicit and keeping configuration validation focused on correctness rather than treating it as a security boundary.

  • Share one localized warning across configuration-source creation, initialization, refresh, and runtime template inheritance; Git template discovery; template-source registration; and explicit package sources in aspire new and aspire add.
  • Preserve existing consent prompts and automation flags. Warnings use stderr, repeated acquisition does not repeat the warning, and background update checks remain quiet.
  • Remove the arbitrary 4 MiB limit and Git file-mode rejection. Read Git blobs directly without checking out or following symlinks, then apply ordinary JSON/configuration validation.
  • Explain that recursive configuration sources are rejected to reserve future support, not as a security restriction.
  • Exercise real SHA-1 and SHA-256 repositories in CLI E2E creation/refresh coverage, and snapshot explicit default-path persistence while continuing to omit unspecified refs.
  • Update related documentation, error messages, localization files, and interaction tests.

User-facing usage

With an initialization source configured, these existing commands display the shared warning:

aspire new aspire-starter --use-config-source
aspire init --use-config-source
aspire update --config-source --yes
Only use sources you trust. Content from these sources can run code on your machine.

The same wording is used when accepting template repositories and explicit package sources. --yes and --use-config-source retain their existing behavior; they do not suppress the warning.

Existing command-help excerpts (no options were added):

aspire init:
  --use-config-source  Use the proposed Git configuration source. Specify false to decline it.

aspire update:
  --config-source     Apply allowed settings from the nearest local and global saved Git configuration sources, replacing local edits to supplied settings, without updating packages or the CLI.

Security considerations

These changes implement follow-ups from the configuration-source threat-model review; they do not claim final security approval or add source-signing/attestation guarantees. Configuration sources and referenced templates, package feeds, and documentation must be trusted by the user. Content can execute code or influence AI agents.

Retained repository/path, Git-object, JSON, and configuration-shape checks enforce correctness, not source trust. Removing file-mode rejection does not enable symlink traversal: symlink-mode blob contents are validated directly as configuration.

Validation

Passed: 992 tests, 0 failures, 2 skipped.

dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class '*.ConfigSourceServiceTests' --filter-class '*.ConfigSourceServiceGitTests' --filter-class '*.ConfigSourceCommandTests' --filter-class '*.NewCommandLocalTemplateTests' --filter-class '*.TemplateEngineFactoryGitTests' --filter-class '*.AddCommandTests' --filter-class '*.NewCommandTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Passed: localization regeneration, 0 warnings/errors.

dotnet build /t:UpdateXlf src\Aspire.Cli\Aspire.Cli.csproj --no-restore -v minimal

Passed: E2E project compilation, 0 warnings/errors.

dotnet build tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-restore -v minimal

Linux/Docker E2E tests were not executed because Docker is unavailable in the local environment.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 21682

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 21682"

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Removing the size-limit test leaves successful acquisition of valid configurations larger than 4 MiB without regression coverage, while the retained test exercises only about 70 KiB.

1 open issue
3 files not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/SharedCommandStrings.Designer.cs: Generated file
What changed in this PR

This PR makes source trust explicit across Aspire CLI configuration, template, and package-source workflows, while keeping configuration validation focused on correctness rather than security guarantees.

Changes:

  • Adds a shared localized warning on stderr while preserving existing consent prompts and automation flags.
  • Removes the configuration size and Git file-mode restrictions, retaining direct blob reads and configuration validation.
  • Updates documentation, localization resources, interaction tests, and SHA-1/SHA-256 end-to-end coverage.
File Description
tests/​Aspire.Cli.Tests/​Templating/​TemplateEngineFactoryGitTests.cs Tests warnings before fresh and cached template acquisition.
tests/​Aspire.Cli.Tests/​Snapshots/​ConfigSourceServiceTests.Materialize_PersistsDefaultPathAndOmitsUnspecifiedRef.verified.json Records default-path persistence and omitted ref.
tests/​Aspire.Cli.Tests/​Configuration/​ConfigSourceServiceTests.cs Tests warning timing, deduplication, and persistence.
tests/​Aspire.Cli.Tests/​Configuration/​ConfigSourceServiceGitTests.cs Updates coverage for relaxed blob validation.
tests/​Aspire.Cli.Tests/​Commands/​NewCommandTests.cs Verifies explicit package-source warnings.
tests/​Aspire.Cli.Tests/​Commands/​NewCommandLocalTemplateTests.SourceManagement.cs Verifies warnings alongside consent behavior.
tests/​Aspire.Cli.Tests/​Commands/​NewCommandLocalTemplateTests.ConfiguredGitSources.cs Updates warning expectations for repository failures.
tests/​Aspire.Cli.Tests/​Commands/​NewCommandLocalTemplateTests.ConfiguredGitSourceObjects.cs Updates warning expectations across Git-source scenarios.
tests/​Aspire.Cli.Tests/​Commands/​AddCommandTests.cs Verifies warnings precede package discovery.
tests/​Aspire.Cli.EndToEnd.Tests/​Helpers/​ConfigSourceTestContext.cs Supports selecting the Git object format.
tests/​Aspire.Cli.EndToEnd.Tests/​CustomTemplateTests.cs Updates terminal expectations for separate warning and prompt.
tests/​Aspire.Cli.EndToEnd.Tests/​ConfigSourceTests.cs Adds SHA-256 creation and refresh coverage.
src/​Aspire.Cli/​Templating/​TemplateEngineFactory.cs Warns before Git-backed template discovery.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.zh-Hant.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.zh-Hans.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.tr.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.ru.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.pt-BR.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.pl.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.ko.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.ja.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.it.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.fr.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.es.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.de.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​SharedCommandStrings.cs.xlf Adds the shared warning localization entry.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.zh-Hant.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.zh-Hans.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.tr.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.ru.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.pt-BR.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.pl.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.ko.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.ja.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.it.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.fr.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.es.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.de.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​NewCommandStrings.cs.xlf Updates the separate trust-confirmation wording.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.zh-Hant.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.zh-Hans.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.tr.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.ru.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.pt-BR.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.pl.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.ko.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.ja.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.it.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.fr.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.es.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.de.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​xlf/​ConfigSourceStrings.cs.xlf Aligns validation messages with relaxed restrictions.
src/​Aspire.Cli/​Resources/​SharedCommandStrings.resx Defines the shared source-trust warning.
src/​Aspire.Cli/​Resources/​SharedCommandStrings.Designer.cs Exposes the shared warning resource.
src/​Aspire.Cli/​Resources/​NewCommandStrings.resx Separates trust confirmation from warning text.
src/​Aspire.Cli/​Resources/​NewCommandStrings.Designer.cs Synchronizes resource documentation comments.
src/​Aspire.Cli/​Resources/​ConfigSourceStrings.resx Updates configuration validation errors.
src/​Aspire.Cli/​Resources/​ConfigSourceStrings.Designer.cs Synchronizes validation-message documentation.
src/​Aspire.Cli/​Configuration/​ConfigSourceService.cs Adds warnings and removes size and file-mode restrictions.
src/​Aspire.Cli/​Commands/​TemplateManagementCommand.cs Warns before template-source confirmation.
src/​Aspire.Cli/​Commands/​NewCommand.cs Warns for explicit package sources.
src/​Aspire.Cli/​Commands/​AddCommand.cs Warns for explicit package sources.
docs/​specs/​git-templating.md Documents source trust and warning behavior.
docs/​specs/​cli-config-sources.md Clarifies trust, blob validation, and recursive-source restrictions.

Review effort: Balanced

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The added trust warning breaks a symlink-discovery test on symlink-capable hosts, and removing the 4 MiB limit lacks replacement real-Git regression coverage.

1 open issue
1 resolved since last review
3 files not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/SharedCommandStrings.Designer.cs: Generated file

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The added trust warning breaks the symlink-rejection test when symlink creation succeeds, and acquisition of valid configurations larger than 4 MiB lacks regression coverage.

1 open issue
3 files not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/SharedCommandStrings.Designer.cs: Generated file

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Only compilation was reported, leaving terminal interactions and Git interoperability in the revised consent flow and SHA-256 creation/refresh scenarios unverified pending Linux/Docker E2E testing.

1 open issue
3 files not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/SharedCommandStrings.Designer.cs: Generated file

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Removing the size-limit test leaves no regression coverage proving that a valid configuration source larger than 4 MiB is accepted and parsed correctly.

No open issues 🎉

1 resolved since last review
3 files not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/SharedCommandStrings.Designer.cs: Generated file

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… policy

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Handle the development URL prompt after interactive template selection and align consent assertions and snapshots with persisted opt-outs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Tests selector

3 / 100 PR test projects · 4 PR jobs, from 68 changed files.

Selected PR test projects (3 / 100)

Aspire.Cli.EndToEnd.Tests, Aspire.Cli.Tests, Infrastructure.Tests

Selected PR jobs (4)

cli-starter-validation, extension-e2e, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

📦 affected project Aspire.Cli
→ 1 test: Aspire.Cli.EndToEnd.Tests

🔧 src/Aspire.Cli/Resources/ConfigSourceStrings.resx (changed source)
→ 1 directly: Infrastructure.Tests

🔧 src/Aspire.Cli/Resources/NewCommandStrings.resx (changed source)
→ 1 directly: Infrastructure.Tests

🔧 src/Aspire.Cli/Resources/SharedCommandStrings.Designer.cs (changed source)
→ 1 via the project graph: Aspire.Cli.EndToEnd.Tests

🔧 src/Aspire.Cli/Resources/SharedCommandStrings.resx (changed source)
→ 1 directly: Infrastructure.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/ConfigSourceTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/CustomTemplateTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/Helpers/ConfigSourceTestContext.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.Tests/Commands/AddCommandTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/NewCommandLocalTemplateTests.ConfiguredGitSourceObjects.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/NewCommandLocalTemplateTests.ConfiguredGitSources.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/NewCommandLocalTemplateTests.InitConfig.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/NewCommandLocalTemplateTests.SourceManagement.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/NewCommandTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Configuration/ConfigSourceServiceGitTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Configuration/ConfigSourceServiceTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/ConfigSourceServiceTests.Materialize_PersistsDefaultPathAndOmitsUnspecifiedRef.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandLocalTemplateTests.InitConfigSources_DeclinedSourceDoesNotAffectGlobalTemplateDiscovery_consent=False.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandLocalTemplateTests.InitConfigSources_DeclinedSourceDoesNotAffectGlobalTemplateDiscovery_consent=null.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandLocalTemplateTests.InitConfigSources_SearchAndGenerateWithGlobalSourcesWithoutPersistingInheritedSources.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandLocalTemplateTests.InitConfigSources_SearchAndGenerateWithGlobalSourcesWithoutPersistingInheritedSources_materialize=False.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandLocalTemplateTests.InitConfigSources_SearchAndGenerateWithGlobalSourcesWithoutPersistingInheritedSources_materialize=True.verified.json (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Templating/TemplateEngineFactoryGitTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

Job reasons

Job Triggered by
cli-starter-validation affected project Aspire.Cli
extension-e2e • src/Aspire.Cli/Commands/AddCommand.cs, src/Aspire.Cli/Commands/NewCommand.cs, src/Aspire.Cli/Commands/TemplateManagementCommand.cs, src/Aspire.Cli/Configuration/ConfigSourceService.cs, src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs, src/Aspire.Cli/Resources/ConfigSourceStrings.resx, src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs, src/Aspire.Cli/Resources/NewCommandStrings.resx, src/Aspire.Cli/Resources/SharedCommandStrings.Designer.cs, src/Aspire.Cli/Resources/SharedCommandStrings.resx, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.cs.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.de.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.es.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.fr.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.it.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.ja.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.ko.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.pl.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.pt-BR.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.ru.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.tr.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.zh-Hans.xlf, src/Aspire.Cli/Resources/xlf/ConfigSourceStrings.zh-Hant.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.cs.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.de.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.es.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.fr.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.it.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.ja.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.ko.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.pl.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.pt-BR.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.ru.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.tr.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.zh-Hans.xlf, src/Aspire.Cli/Resources/xlf/NewCommandStrings.zh-Hant.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.cs.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.de.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.es.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.fr.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.it.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.ja.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.ko.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.pl.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.pt-BR.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.ru.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.tr.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.zh-Hans.xlf, src/Aspire.Cli/Resources/xlf/SharedCommandStrings.zh-Hant.xlf, src/Aspire.Cli/Templating/TemplateEngineFactory.cs
• affected project Aspire.Cli
polyglot affected project Aspire.Cli
typescript-api-compat affected project Aspire.Cli

Selection computed for commit 151bf96.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The changed consent/template-picker flows and SHA-256 creation/refresh scenarios were only compiled, leaving their Linux/Docker runtime behavior unvalidated pending a successful source-build E2E run.

No open issues 🎉

3 files not reviewed
  • src/Aspire.Cli/Resources/ConfigSourceStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/NewCommandStrings.Designer.cs: Generated file
  • src/Aspire.Cli/Resources/SharedCommandStrings.Designer.cs: Generated file

Review effort: Balanced

@radical Ankit Jain (radical) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[automated] Approving with two nonblocking follow-ups: regression coverage for configurations larger than 4 MiB, and clarification of the memory-consumption tradeoff.

Could we add a real-Git success test for valid configuration larger than 4 MiB, with a setting near the end verified through acquisition and materialization? This would cover the newly supported input range; the retained large-content test exercises about 70 KiB. This also follows up on the existing coverage request: #21682 (comment).

I have left the memory-consumption question inline. The symlink explanation addresses my earlier question.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@JamesNK
James Newton-King (JamesNK) merged commit 7cabd38 into main Nov 3, 2026
419 of 424 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.0 milestone Nov 3, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #2034

Generated by PR Documentation Check · copilot · auto · 28.6 AIC · ⌖ 1.15 AIC · ⊞ 7.1K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#2034 targeting release/17.0.

Adds the shared "Only use sources you trust" warning note to the aspire new, aspire init, aspire update, and aspire add reference pages. Signals: cli_command_file_changed (AddCommand/NewCommand/TemplateManagementCommand.cs), cli_resource_strings_changed (ConfigSourceStrings.resx), pr_body_has_cli_flag_mention and pr_body_has_user_facing_section (PR body usage section).

Note

This draft PR needs human review before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants