You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Show contextual resource availability in the dashboard sidebar - #21819
Make the resource sidebar explain what is available in the current view without confusing availability, resource health, and selection.
This is the sidebar follow-up to #21792 and targets ievangelist-dashboard-detail-close-buttons. Only the follow-up is included in this diff; the parent PR is unchanged.
Show localized No logs, No traces, No metrics, and Not applicable badges with muted, still-interactive rows. Missing telemetry means no data is currently available, not that the resource cannot support it. Uninstrumented peers remain available in Traces.
Explain why parameters do not produce console logs, structured logs, traces, or metrics, or support terminals. Clicking or keyboard-selecting a parameter opens its overview. Empty resources still open the existing no-data view.
Highlight Select all rather than every row for aggregate selection. Individual, modifier-key, range, and group selection retain their existing selection indicators and metadata.
Availability uses the existing telemetry-resource subscription and a cached snapshot lookup. First-signal arrival and clearing update badges without changing selection. Keep the data query scoped to the selected resources when their first signal arrives, and refresh logs/traces when the layout's initial resource snapshot finishes loading.
User-facing usage
Open Structured logs, Traces, or Metrics and select a resource with a no-data badge: its empty view opens normally. When that resource sends telemetry, the badge disappears and its data becomes visible without selecting it again; clearing that signal restores the badge and empty state. A running resource can therefore be healthy and still have no telemetry.
Hover or keyboard-focus a parameter in a telemetry, Console logs, or Terminal view to see the feature-specific explanation, then press Enter to open the parameter overview. Use Select all for the aggregate view, Ctrl/Cmd-click to add or remove individual resources, or Shift-click for a range.
Screenshots / Recordings
This PR includes UI changes. These 14 screenshots are from this branch's Release build using deterministic synthetic resources and telemetry. They show both themes at desktop (1440 x 900), tablet (768 x 1024), and mobile (390 x 844) sizes. No real credentials or application data are used.
Responsive availability and aggregate selection
Only Select all is highlighted in the aggregate view. Running resources with no telemetry are muted; parameters explain why the current feature is not applicable.
Viewport
Light
Dark
Desktop, 1440 x 900
Tablet, 768 x 1024
Mobile, 390 x 844
First telemetry and clear, with the same resource selected
The gateway already has a log, but the selected catalog view does not show it. Catalog's first log removes its badge and appears without changing selection. Clearing catalog's logs restores the badge and empty state.
Selected resource, no logs yet
First log arrives
Catalog logs cleared
View-specific explanations and selection
Scenario
Screenshot
Traces, dark: selected running resource with no traces
Metrics, light: selected running resource with no metrics
Console logs, light: nonparameters remain available; parameter explains why it produces no console logs
Parameter selection opens Overview and removes the contextual unavailable badge
Explicit multiselection retains individual rails while Select all is not filled
Validation
Run on Windows after .\restore.cmd (passed), with MSBUILDTERMINALLOGGER=false. All commands below use the repository-pinned SDK, Release configuration, and Microsoft.Testing.Platform filters.
Availability and telemetry-page compatibility: passed, 81 cases, including 16 availability cases. This overlaps the layout suite; counts are not additive.
Coverage includes all three signals arriving and being cleared at three widths, unchanged selection and data scope, visible feature-specific parameter explanations and keyboard navigation across five views, tab-dependent labels, synthetic trace peers, long-name disclosure, aggregate/individual/group selection, and Ctrl/Cmd-click from the aggregate set. The initial logs snapshot failure was reproduced before the lifecycle fix; both logs and traces now have passing load/reload coverage. Existing styling/geometry tests were aligned with aggregate selection; no new computed-color-only assertions were added.
git diff --check: passed. Screenshot capture assertions: passed, including that another resource's log never appears in the selected resource's view.
Builds report NU1903 for the repository-pinned Microsoft.DotNet.ILCompiler 11.0.0-rc.2.26504.105 (GHSA-p3jp-9v83-76w9). This PR does not change dependencies or feeds.
Fixes # (issue)
Checklist
Is this feature complete?
Yes. Ready to ship.
No. Follow-up changes expected.
Are you including unit tests for the changes and scenario tests if relevant?
Yes
No
Did you add public API?
Yes
If yes, did you have an API Review for it?
Yes
No
Did you add <remarks /> and <code /> elements on your triple slash comments?
Yes
No
No
Does the change make any security assumptions or guarantees?
Yes
If yes, have you done a threat model and had a security review?
Only Select all is highlighted in the aggregate view. Running resources with no telemetry are muted; parameters explain why the current feature is not applicable.
Viewport
Light
Dark
Desktop, 1440 x 900
Tablet, 768 x 1024
Mobile, 390 x 844
First telemetry and clear, with the same resource selected
The gateway already has a log, but the selected catalog view does not show it. Catalog's first log removes its badge and appears without changing selection. Clearing catalog's logs restores the badge and empty state.
Selected resource, no logs yet
First log arrives
Catalog logs cleared
View-specific explanations and selection
Scenario
Screenshot
Traces, dark: selected running resource with no traces
Metrics, light: selected running resource with no metrics
Console logs, light: nonparameters remain available; parameter explains why it produces no console logs
Parameter selection opens Overview and removes the contextual unavailable badge
Explicit multiselection retains individual rails while Select all is not filled
Explain view-specific resource availability without changing selection or health. Cover telemetry arrival and clear, parameter navigation, responsive disclosure, and aggregate selection. Keep telemetry queries scoped as resources become available and initial snapshots load.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Valid resource keys with colliding composite names can make ToDictionary throw and break layout initialization or updates, while logs/metrics-only peers can incorrectly display a No traces badge despite participating in traces.
This follow-up to #21792 distinguishes telemetry availability from resource health and selection in the dashboard sidebar, while keeping unavailable rows navigable.
Changes:
Adds contextual availability badges and parameter explanations, backed by localization resources.
Highlights only Select all for aggregate selection and refreshes logs/traces when resource snapshots become available.
Extends component and browser coverage for telemetry arrival, clearing, keyboard navigation, and responsive selection.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Outstanding issues cause repeated full-span scans, can make selected badges unreadable in forced-colors mode, and leave availability indicators stale after retention evicts the last telemetry item.
HasLogs and HasTraces remain true after retention evicts a resource's last item: TrimLogsToCapacity and TrimTracesToCapacity only delete data, and TraceTrimming_DoesNotRecalculateResourceFlags explicitly covers this behavior. Consequently, a quiet resource loses all retained telemetry but never regains its No logs/No traces badge, even though its view is empty. Base this snapshot on retained-data availability, separately from these flags, and cover last-item eviction.
Pair selected badge text and background colors in forced-colors mode
In forced-colors mode, a selected row gives this badge HighlightText and inherited forced-color-adjust: none, but the badge keeps its dashboard-neutral background. A light dashboard with white HighlightText can therefore render the availability label white-on-white. Give selected badges a paired system-color foreground and background in forced-colors mode.
Pair selected badge system colors and cover retention eviction and indexed signal probes.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Recalculate resource availability flags when retention evicts the last item
The sidebar now uses a retained-data snapshot instead of changing the existing received-signal flags. New logs and traces regression cases verify that last-item eviction restores the badge without changing selection or navigation.
Pair selected badge text and background colors in forced-colors mode
Selected availability badges now use the paired Highlight/HighlightText system colors, including the border. Normal light/dark styling is unchanged.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Selecting an external telemetry source that shares an app-model resource name resolves the wrong resource, producing an empty key list and hiding its logs and traces.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Same-name app-model resource hides external telemetry data
With an app-model resource named api and an external telemetry source (Name: "api", InstanceId: "external-id"), selecting the external source in the telemetry pane now produces an empty key list and hides its logs/traces. The loop resolves the app-model name first, whose composite-name lookup finds no matching source, rather than resolving the telemetry row named api. Skip app-model lookup in the telemetry pane, retain explicit telemetry keys, and add a same-name regression test.
Read the retained-signal snapshot with a SQLite data reader so dashboard initialization works under Native AOT.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Human assessment is needed because mixed null and non-null instance IDs can make log availability indicators disagree with the logs actually returned by queries.
Added a "Resource availability in the sidebar" section to dashboard/explore.mdx covering the No logs/No traces/No metrics/Not applicable badges, parameter explanations, and Select all highlighting. Signals: dashboard_user_facing_page_changed (StructuredLogs/Traces pages), new_public_type (ResourceSignalAvailability), pr_body_has_user_facing_section.
## Description
The resource list's **Compact** density lost its one-line rows in
#21727. That PR removed the compact branch of the row markup and
switched `.density-compact .resource-row-text` to `flex-direction:
column`, so compact rows became the same two-line rows as Comfortable
("● Running · 1 minute ago"), only shorter. They then also picked up the
"No logs" / "Not applicable" badges added in #21819. #21727 also dropped
**Spacious**'s third detail line. That left the three densities
differing only in row height and font size, although
`ResourceListDensity` still documents one, two and three lines per
resource.
This PR restores the documented densities:
- **Compact**: one line per resource. The icon and name are followed by
aligned type and state-dot columns. In the sidebar, a row's actions
replace the columns while it's hovered or focused, or while its menu is
open, as before #21727. The expand toggle of parent rows stays visible,
and touch screens (`hover: none`) always show the actions. Availability
badges don't fit on one line: an unavailable row is muted, and the
reason stays in its tooltip and accessible description. Unviewed-error
badges sit just before the columns, so the columns stay aligned. A badge
keeps the same place while the row's actions show, so it never moves out
from under the pointer: it takes whichever place is further from the
row's end, clear of the columns or clear of the actions.
- **Comfortable**: unchanged.
- **Spacious**: sidebar rows have a third line again. It shows an
unhealthy health status if there is one, otherwise the primary endpoint,
otherwise the source. When no endpoint can be opened as a link, such as
a `tcp://` endpoint, the first endpoint is used, as in the expanded
list's endpoint column. Query values are masked. The endpoint and source
can take keyboard focus, which shows the full value in a tooltip and
gives it an accessible label.
In the expanded resource list (full canvas), compact rows use the same
single-line identity. From 960px wide, the identity column can grow by
the width of the type and state columns, so names aren't squeezed. That
extra width only raises the column's maximum, never its minimum, so rows
don't overflow the list at narrower widths. Actions there stay visible
all the time.
Persistent types such as "RabbitMQ (persistent)" widen every row's type
column together, so the columns stay aligned. The column is 128px where
rows can be hovered. On touch screens, where the action rail is always
showing, it stays at 64px at the default 420px pane width so names keep
their room.
### Screenshots / Recordings
The resource pane at its default 420px width, using the TestShop
playground, before (main) and after:
- **First row (before):** all three densities are the same two-line row.
- **Second row (after):** Compact is one line with the actions hidden at
rest, Comfortable is unchanged, and Spacious has its third line.
- **Third row:** compact on Structured logs. Before, rows had "No logs"
badges. After, those rows are muted instead. The last panel adds two
unviewed-error badges, injected into the page because the sample app
logs no errors.

Compact rows with an unviewed error, at rest and hovered. On main, the
badge jumped about 62px toward the actions when a row was hovered, with
a persistent type in the list. It now keeps its place:

### Validation
- Updated the `ResourcesLayoutTests` that asserted the two-line compact
row (`CompactDensity_ShowsOneLineWithTypeAndStateColumns`,
`WideRowMetadata_PreservesRuntimeStateAndAccessibleHealthWithRelativeStart`,
`AppHost_ContainerLifetimeQualifiesTypeAndBadgesResourceGlyph`). Added
`ResourceRowAvailabilityTests.CompactDensity_UnavailableRowKeepsReasonWithoutBadge`
and
`ResourcesLayoutTests.SpaciousSidebarDetail_PrefersUnhealthyStatusThenEndpointThenSource`.
- The 264 tests in `ResourcesLayoutTests`,
`ResourceRowAvailabilityTests`, `MainLayoutTests`,
`DashboardViewPreferencesTests` and `SettingsDialogTests` pass.
- Checked manually against the TestShop playground with Playwright at
the default 420px pane width:
- In every density, no row element overlaps another or spills out of its
row.
- Compact: the rest state, hover on a row and on a parent row, keyboard
focus, an open "…" menu, an error badge (simulated) and touch emulation.
- The expanded list in every density.
- Updated `ResourcePaneResponsiveTests` for the restored geometry:
- 32px compact rows, and 22px, 32px and 40px icons for Compact,
Comfortable and Spacious.
- Spacious rows are 76px in the sidebar and 60px in the expanded list.
- Compact sidebar rows show only the expand-toggle column at rest, and
the full action rail on hover or keyboard focus.
- A new horizontal-overflow check, with 960px and 990px stages. With the
previous track minimums it fails at 960px (980px of content).
- Added
`ResourcePaneResponsiveTests.CompactSidebar_ErrorBadgeKeepsItsPlaceWhileActionsShow`.
It seeds error logs and checks five states: at rest, the row hovered,
the badge hovered, the row focused, and the menu open. In each, the
badge must not move or be covered, must line up with its spacer, and
must not overlap a column or an action. It runs with and without a
persistent type in the list, and fails against the previous styles.
- 75 of the 80 `ResourcePaneResponsiveTests` pass locally. 4 failures
come from
`RowComposition_AlignsStatusAndSingleLineDetailsWithAccessibleContrast`
and `Accessibility_PaneAndPopoversHaveNoBlockingWcagViolations` at
390px, which fail the same way on main.
`Resizer_DoubleClickRestoresMinimumAcrossPresentationAndNavigation`
failed once in the full run because a drag didn't take effect, and
passed when rerun on its own.
Fixes # (issue)
## Checklist
- Is this feature complete?
- [x] Yes. Ready to ship.
- [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
- [x] Yes
- [ ] No
- Did you add public API?
- [ ] Yes
- If yes, did you have an API Review for it?
- [ ] Yes
- [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
- [ ] Yes
- [ ] No
- [x] No
- Does the change make any security assumptions or guarantees?
- [ ] Yes
- If yes, have you done a threat model and had a security review?
- [ ] Yes
- [ ] No
- [x] No
---------
Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com>
## Description
The resource list's **Compact** density lost its one-line rows in
#21727. That PR removed the compact branch of the row markup and
switched `.density-compact .resource-row-text` to `flex-direction:
column`, so compact rows became the same two-line rows as Comfortable
("● Running · 1 minute ago"), only shorter. They then also picked up the
"No logs" / "Not applicable" badges added in #21819. #21727 also dropped
**Spacious**'s third detail line. That left the three densities
differing only in row height and font size, although
`ResourceListDensity` still documents one, two and three lines per
resource.
This PR restores the documented densities:
- **Compact**: one line per resource. The icon and name are followed by
aligned type and state-dot columns. In the sidebar, a row's actions
replace the columns while it's hovered or focused, or while its menu is
open, as before #21727. The expand toggle of parent rows stays visible,
and touch screens (`hover: none`) always show the actions. Availability
badges don't fit on one line: an unavailable row is muted, and the
reason stays in its tooltip and accessible description. Unviewed-error
badges sit just before the columns, so the columns stay aligned. A badge
keeps the same place while the row's actions show, so it never moves out
from under the pointer: it takes whichever place is further from the
row's end, clear of the columns or clear of the actions.
- **Comfortable**: unchanged.
- **Spacious**: sidebar rows have a third line again. It shows an
unhealthy health status if there is one, otherwise the primary endpoint,
otherwise the source. When no endpoint can be opened as a link, such as
a `tcp://` endpoint, the first endpoint is used, as in the expanded
list's endpoint column. Query values are masked. The endpoint and source
can take keyboard focus, which shows the full value in a tooltip and
gives it an accessible label.
In the expanded resource list (full canvas), compact rows use the same
single-line identity. From 960px wide, the identity column can grow by
the width of the type and state columns, so names aren't squeezed. That
extra width only raises the column's maximum, never its minimum, so rows
don't overflow the list at narrower widths. Actions there stay visible
all the time.
Persistent types such as "RabbitMQ (persistent)" widen every row's type
column together, so the columns stay aligned. The column is 128px where
rows can be hovered. On touch screens, where the action rail is always
showing, it stays at 64px at the default 420px pane width so names keep
their room.
### Screenshots / Recordings
The resource pane at its default 420px width, using the TestShop
playground, before (main) and after:
- **First row (before):** all three densities are the same two-line row.
- **Second row (after):** Compact is one line with the actions hidden at
rest, Comfortable is unchanged, and Spacious has its third line.
- **Third row:** compact on Structured logs. Before, rows had "No logs"
badges. After, those rows are muted instead. The last panel adds two
unviewed-error badges, injected into the page because the sample app
logs no errors.

Compact rows with an unviewed error, at rest and hovered. On main, the
badge jumped about 62px toward the actions when a row was hovered, with
a persistent type in the list. It now keeps its place:

### Validation
- Updated the `ResourcesLayoutTests` that asserted the two-line compact
row (`CompactDensity_ShowsOneLineWithTypeAndStateColumns`,
`WideRowMetadata_PreservesRuntimeStateAndAccessibleHealthWithRelativeStart`,
`AppHost_ContainerLifetimeQualifiesTypeAndBadgesResourceGlyph`). Added
`ResourceRowAvailabilityTests.CompactDensity_UnavailableRowKeepsReasonWithoutBadge`
and
`ResourcesLayoutTests.SpaciousSidebarDetail_PrefersUnhealthyStatusThenEndpointThenSource`.
- The 264 tests in `ResourcesLayoutTests`,
`ResourceRowAvailabilityTests`, `MainLayoutTests`,
`DashboardViewPreferencesTests` and `SettingsDialogTests` pass.
- Checked manually against the TestShop playground with Playwright at
the default 420px pane width:
- In every density, no row element overlaps another or spills out of its
row.
- Compact: the rest state, hover on a row and on a parent row, keyboard
focus, an open "…" menu, an error badge (simulated) and touch emulation.
- The expanded list in every density.
- Updated `ResourcePaneResponsiveTests` for the restored geometry:
- 32px compact rows, and 22px, 32px and 40px icons for Compact,
Comfortable and Spacious.
- Spacious rows are 76px in the sidebar and 60px in the expanded list.
- Compact sidebar rows show only the expand-toggle column at rest, and
the full action rail on hover or keyboard focus.
- A new horizontal-overflow check, with 960px and 990px stages. With the
previous track minimums it fails at 960px (980px of content).
- Added
`ResourcePaneResponsiveTests.CompactSidebar_ErrorBadgeKeepsItsPlaceWhileActionsShow`.
It seeds error logs and checks five states: at rest, the row hovered,
the badge hovered, the row focused, and the menu open. In each, the
badge must not move or be covered, must line up with its spacer, and
must not overlap a column or an action. It runs with and without a
persistent type in the list, and fails against the previous styles.
- 75 of the 80 `ResourcePaneResponsiveTests` pass locally. 4 failures
come from
`RowComposition_AlignsStatusAndSingleLineDetailsWithAccessibleContrast`
and `Accessibility_PaneAndPopoversHaveNoBlockingWcagViolations` at
390px, which fail the same way on main.
`Resizer_DoubleClickRestoresMinimumAcrossPresentationAndNavigation`
failed once in the full run because a drag didn't take effect, and
passed when rerun on its own.
Fixes # (issue)
## Checklist
- Is this feature complete?
- [x] Yes. Ready to ship.
- [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
- [x] Yes
- [ ] No
- Did you add public API?
- [ ] Yes
- If yes, did you have an API Review for it?
- [ ] Yes
- [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
- [ ] Yes
- [ ] No
- [x] No
- Does the change make any security assumptions or guarantees?
- [ ] Yes
- If yes, have you done a threat model and had a security review?
- [ ] Yes
- [ ] No
- [x] No
---------
Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com>
(cherry picked from commit db27327)
## Description
The resource list's **Compact** density lost its one-line rows in
#21727. That PR removed the compact branch of the row markup and
switched `.density-compact .resource-row-text` to `flex-direction:
column`, so compact rows became the same two-line rows as Comfortable
("● Running · 1 minute ago"), only shorter. They then also picked up the
"No logs" / "Not applicable" badges added in #21819. #21727 also dropped
**Spacious**'s third detail line. That left the three densities
differing only in row height and font size, although
`ResourceListDensity` still documents one, two and three lines per
resource.
This PR restores the documented densities:
- **Compact**: one line per resource. The icon and name are followed by
aligned type and state-dot columns. In the sidebar, a row's actions
replace the columns while it's hovered or focused, or while its menu is
open, as before #21727. The expand toggle of parent rows stays visible,
and touch screens (`hover: none`) always show the actions. Availability
badges don't fit on one line: an unavailable row is muted, and the
reason stays in its tooltip and accessible description. Unviewed-error
badges sit just before the columns, so the columns stay aligned. A badge
keeps the same place while the row's actions show, so it never moves out
from under the pointer: it takes whichever place is further from the
row's end, clear of the columns or clear of the actions.
- **Comfortable**: unchanged.
- **Spacious**: sidebar rows have a third line again. It shows an
unhealthy health status if there is one, otherwise the primary endpoint,
otherwise the source. When no endpoint can be opened as a link, such as
a `tcp://` endpoint, the first endpoint is used, as in the expanded
list's endpoint column. Query values are masked. The endpoint and source
can take keyboard focus, which shows the full value in a tooltip and
gives it an accessible label.
In the expanded resource list (full canvas), compact rows use the same
single-line identity. From 960px wide, the identity column can grow by
the width of the type and state columns, so names aren't squeezed. That
extra width only raises the column's maximum, never its minimum, so rows
don't overflow the list at narrower widths. Actions there stay visible
all the time.
Persistent types such as "RabbitMQ (persistent)" widen every row's type
column together, so the columns stay aligned. The column is 128px where
rows can be hovered. On touch screens, where the action rail is always
showing, it stays at 64px at the default 420px pane width so names keep
their room.
### Screenshots / Recordings
The resource pane at its default 420px width, using the TestShop
playground, before (main) and after:
- **First row (before):** all three densities are the same two-line row.
- **Second row (after):** Compact is one line with the actions hidden at
rest, Comfortable is unchanged, and Spacious has its third line.
- **Third row:** compact on Structured logs. Before, rows had "No logs"
badges. After, those rows are muted instead. The last panel adds two
unviewed-error badges, injected into the page because the sample app
logs no errors.

Compact rows with an unviewed error, at rest and hovered. On main, the
badge jumped about 62px toward the actions when a row was hovered, with
a persistent type in the list. It now keeps its place:

### Validation
- Updated the `ResourcesLayoutTests` that asserted the two-line compact
row (`CompactDensity_ShowsOneLineWithTypeAndStateColumns`,
`WideRowMetadata_PreservesRuntimeStateAndAccessibleHealthWithRelativeStart`,
`AppHost_ContainerLifetimeQualifiesTypeAndBadgesResourceGlyph`). Added
`ResourceRowAvailabilityTests.CompactDensity_UnavailableRowKeepsReasonWithoutBadge`
and
`ResourcesLayoutTests.SpaciousSidebarDetail_PrefersUnhealthyStatusThenEndpointThenSource`.
- The 264 tests in `ResourcesLayoutTests`,
`ResourceRowAvailabilityTests`, `MainLayoutTests`,
`DashboardViewPreferencesTests` and `SettingsDialogTests` pass.
- Checked manually against the TestShop playground with Playwright at
the default 420px pane width:
- In every density, no row element overlaps another or spills out of its
row.
- Compact: the rest state, hover on a row and on a parent row, keyboard
focus, an open "…" menu, an error badge (simulated) and touch emulation.
- The expanded list in every density.
- Updated `ResourcePaneResponsiveTests` for the restored geometry:
- 32px compact rows, and 22px, 32px and 40px icons for Compact,
Comfortable and Spacious.
- Spacious rows are 76px in the sidebar and 60px in the expanded list.
- Compact sidebar rows show only the expand-toggle column at rest, and
the full action rail on hover or keyboard focus.
- A new horizontal-overflow check, with 960px and 990px stages. With the
previous track minimums it fails at 960px (980px of content).
- Added
`ResourcePaneResponsiveTests.CompactSidebar_ErrorBadgeKeepsItsPlaceWhileActionsShow`.
It seeds error logs and checks five states: at rest, the row hovered,
the badge hovered, the row focused, and the menu open. In each, the
badge must not move or be covered, must line up with its spacer, and
must not overlap a column or an action. It runs with and without a
persistent type in the list, and fails against the previous styles.
- 75 of the 80 `ResourcePaneResponsiveTests` pass locally. 4 failures
come from
`RowComposition_AlignsStatusAndSingleLineDetailsWithAccessibleContrast`
and `Accessibility_PaneAndPopoversHaveNoBlockingWcagViolations` at
390px, which fail the same way on main.
`Resizer_DoubleClickRestoresMinimumAcrossPresentationAndNavigation`
failed once in the full run because a drag didn't take effect, and
passed when rerun on its own.
Fixes # (issue)
## Checklist
- Is this feature complete?
- [x] Yes. Ready to ship.
- [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
- [x] Yes
- [ ] No
- Did you add public API?
- [ ] Yes
- If yes, did you have an API Review for it?
- [ ] Yes
- [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
- [ ] Yes
- [ ] No
- [x] No
- Does the change make any security assumptions or guarantees?
- [ ] Yes
- If yes, have you done a threat model and had a security review?
- [ ] Yes
- [ ] No
- [x] No
---------
Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com>
(cherry picked from commit db27327)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make the resource sidebar explain what is available in the current view without confusing availability, resource health, and selection.
This is the sidebar follow-up to #21792 and targets
ievangelist-dashboard-detail-close-buttons. Only the follow-up is included in this diff; the parent PR is unchanged.Availability uses the existing telemetry-resource subscription and a cached snapshot lookup. First-signal arrival and clearing update badges without changing selection. Keep the data query scoped to the selected resources when their first signal arrives, and refresh logs/traces when the layout's initial resource snapshot finishes loading.
User-facing usage
Open Structured logs, Traces, or Metrics and select a resource with a no-data badge: its empty view opens normally. When that resource sends telemetry, the badge disappears and its data becomes visible without selecting it again; clearing that signal restores the badge and empty state. A running resource can therefore be healthy and still have no telemetry.
Hover or keyboard-focus a parameter in a telemetry, Console logs, or Terminal view to see the feature-specific explanation, then press Enter to open the parameter overview. Use Select all for the aggregate view, Ctrl/Cmd-click to add or remove individual resources, or Shift-click for a range.
Screenshots / Recordings
Responsive availability and aggregate selection
Only Select all is highlighted in the aggregate view. Running resources with no telemetry are muted; parameters explain why the current feature is not applicable.
First telemetry and clear, with the same resource selected
The gateway already has a log, but the selected catalog view does not show it. Catalog's first log removes its badge and appears without changing selection. Clearing catalog's logs restores the badge and empty state.
View-specific explanations and selection
Validation
Run on Windows after
.\restore.cmd(passed), withMSBUILDTERMINALLOGGER=false. All commands below use the repository-pinned SDK, Release configuration, and Microsoft.Testing.Platform filters.Layout component suite: passed, 481 cases.
Availability and telemetry-page compatibility: passed, 81 cases, including 16 availability cases. This overlaps the layout suite; counts are not additive.
Focused functional browser suite: passed, 49 cases. Explicitly opted into the selected outerloop browser scenarios; unrelated quarantined tests remain excluded.
Coverage includes all three signals arriving and being cleared at three widths, unchanged selection and data scope, visible feature-specific parameter explanations and keyboard navigation across five views, tab-dependent labels, synthetic trace peers, long-name disclosure, aggregate/individual/group selection, and Ctrl/Cmd-click from the aggregate set. The initial logs snapshot failure was reproduced before the lifecycle fix; both logs and traces now have passing load/reload coverage. Existing styling/geometry tests were aligned with aggregate selection; no new computed-color-only assertions were added.
git diff --check: passed. Screenshot capture assertions: passed, including that another resource's log never appears in the selected resource's view.Builds report NU1903 for the repository-pinned
Microsoft.DotNet.ILCompiler11.0.0-rc.2.26504.105 (GHSA-p3jp-9v83-76w9). This PR does not change dependencies or feeds.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?