Skip to content

Show contextual resource availability in the dashboard sidebar - #21819

Merged
David Pine (IEvangelist) merged 4 commits into
mainfrom
ievangelist-contextual-sidebar-states
Nov 6, 2026
Merged

David Pine (IEvangelist) merged 4 commits into
mainfrom
ievangelist-contextual-sidebar-states

Conversation

@IEvangelist

@IEvangelist David Pine (IEvangelist) commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Description

Make the resource sidebar explain what is available in the current view without confusing availability, resource health, and selection.

This is the sidebar follow-up to #21792 and targets ievangelist-dashboard-detail-close-buttons. Only the follow-up is included in this diff; the parent PR is unchanged.

  • Show localized No logs, No traces, No metrics, and Not applicable badges with muted, still-interactive rows. Missing telemetry means no data is currently available, not that the resource cannot support it. Uninstrumented peers remain available in Traces.
  • Explain why parameters do not produce console logs, structured logs, traces, or metrics, or support terminals. Clicking or keyboard-selecting a parameter opens its overview. Empty resources still open the existing no-data view.
  • Highlight Select all rather than every row for aggregate selection. Individual, modifier-key, range, and group selection retain their existing selection indicators and metadata.

Availability uses the existing telemetry-resource subscription and a cached snapshot lookup. First-signal arrival and clearing update badges without changing selection. Keep the data query scoped to the selected resources when their first signal arrives, and refresh logs/traces when the layout's initial resource snapshot finishes loading.

User-facing usage

Open Structured logs, Traces, or Metrics and select a resource with a no-data badge: its empty view opens normally. When that resource sends telemetry, the badge disappears and its data becomes visible without selecting it again; clearing that signal restores the badge and empty state. A running resource can therefore be healthy and still have no telemetry.

Hover or keyboard-focus a parameter in a telemetry, Console logs, or Terminal view to see the feature-specific explanation, then press Enter to open the parameter overview. Use Select all for the aggregate view, Ctrl/Cmd-click to add or remove individual resources, or Shift-click for a range.

Screenshots / Recordings

This PR includes UI changes. These 14 screenshots are from this branch's Release build using deterministic synthetic resources and telemetry. They show both themes at desktop (1440 x 900), tablet (768 x 1024), and mobile (390 x 844) sizes. No real credentials or application data are used.

Responsive availability and aggregate selection

Only Select all is highlighted in the aggregate view. Running resources with no telemetry are muted; parameters explain why the current feature is not applicable.

Viewport Light Dark
Desktop, 1440 x 900 Desktop light: aggregate selection, no-data badges, and parameter explanation Desktop dark: aggregate selection, no-data badges, and parameter explanation
Tablet, 768 x 1024 Tablet light: sidebar badges and parameter tooltip Tablet dark: sidebar badges and parameter tooltip
Mobile, 390 x 844 Mobile light: interactive muted rows, Select all, and parameter tooltip Mobile dark: interactive muted rows, Select all, and parameter tooltip

First telemetry and clear, with the same resource selected

The gateway already has a log, but the selected catalog view does not show it. Catalog's first log removes its badge and appears without changing selection. Clearing catalog's logs restores the badge and empty state.

Selected resource, no logs yet First log arrives Catalog logs cleared
Catalog selected with No logs and its current-data explanation Catalog remains selected, its badge disappears, and only its new log is shown Catalog remains selected after clearing logs, restoring No logs and the empty view

View-specific explanations and selection

Scenario Screenshot
Traces, dark: selected running resource with no traces Dark Traces view showing No traces badges, selection rail, and existing empty state
Metrics, light: selected running resource with no metrics Light Metrics view showing No metrics badges and existing empty state
Console logs, light: nonparameters remain available; parameter explains why it produces no console logs Console logs parameter explanation and available nonparameter resources
Parameter selection opens Overview and removes the contextual unavailable badge Dark parameter overview reached from Console logs, with no parameter value set
Explicit multiselection retains individual rails while Select all is not filled Dark structured logs view with catalog and orders explicitly selected

Validation

Run on Windows after .\restore.cmd (passed), with MSBUILDTERMINALLOGGER=false. All commands below use the repository-pinned SDK, Release configuration, and Microsoft.Testing.Platform filters.

Layout component suite: passed, 481 cases.

dotnet test --project tests\Aspire.Dashboard.Components.Tests\Aspire.Dashboard.Components.Tests.csproj -c Release --no-launch-profile -- --filter-namespace 'Aspire.Dashboard.Components.Tests.Layout' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Availability and telemetry-page compatibility: passed, 81 cases, including 16 availability cases. This overlaps the layout suite; counts are not additive.

dotnet test --project tests\Aspire.Dashboard.Components.Tests\Aspire.Dashboard.Components.Tests.csproj -c Release --no-launch-profile -- --filter-class '*.ResourceRowAvailabilityTests' --filter-class '*.StructuredLogsTests' --filter-class '*.TracesTests' --filter-class '*.MetricsTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Focused functional browser suite: passed, 49 cases. Explicitly opted into the selected outerloop browser scenarios; unrelated quarantined tests remain excluded.

dotnet test --project tests\Aspire.Dashboard.Playwright.Tests\Aspire.Dashboard.Playwright.Tests.csproj -c Release --no-launch-profile -- --filter-method '*.ExistingTelemetry_RemainsVisibleWhenAllResourcesViewReloads' --filter-method '*.UnavailableRows_RemainInteractiveAndUpdateWhenSignalsArriveAndClear' --filter-method '*.ParameterRows_ExplainEachUnavailableFeatureAndKeyboardSelectionOpensOverview' --filter-method '*.AvailabilityBadges_FollowTabChangesWithoutChangingSelection' --filter-method '*.SelectAll_*' --filter-method '*.AllResourcesRow_ClearsSelectionAndSummarizesAllResources' --filter-method '*.ResourceRowModifierClicks_SelectSeveralResources' --filter-method '*.ExtremeName_RetainsFullAccessibleAndHoverKeyboardDisclosure' --filter-method '*.IconTile_PreservesStylesAcrossPaneModesAndDensities' --filter-method '*.SelectionSurfaces_UseDashboardNeutralTokensAcrossThemes' --filter-method '*.DynamicRows_PreserveTokenGeometryAfterModelAndPresentationChanges' --filter-method '*.RowComposition_AlignsStatusAndSingleLineDetailsWithAccessibleContrast' --filter-method '*.PaneWidth_DisclosesMetadataWithoutChangingSelectionAndKeepsEndpointBehavior' --filter-not-trait 'quarantined=true'

Coverage includes all three signals arriving and being cleared at three widths, unchanged selection and data scope, visible feature-specific parameter explanations and keyboard navigation across five views, tab-dependent labels, synthetic trace peers, long-name disclosure, aggregate/individual/group selection, and Ctrl/Cmd-click from the aggregate set. The initial logs snapshot failure was reproduced before the lifecycle fix; both logs and traces now have passing load/reload coverage. Existing styling/geometry tests were aligned with aggregate selection; no new computed-color-only assertions were added.

git diff --check: passed. Screenshot capture assertions: passed, including that another resource's log never appears in the selected resource's view.

Builds report NU1903 for the repository-pinned Microsoft.DotNet.ILCompiler 11.0.0-rc.2.26504.105 (GHSA-p3jp-9v83-76w9). This PR does not change dependencies or feeds.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@IEvangelist

Copy link
Copy Markdown
Member Author

Responsive availability and aggregate selection

Only Select all is highlighted in the aggregate view. Running resources with no telemetry are muted; parameters explain why the current feature is not applicable.

Viewport Light Dark
Desktop, 1440 x 900 Desktop light: aggregate selection, no-data badges, and parameter explanation Desktop dark: aggregate selection, no-data badges, and parameter explanation
Tablet, 768 x 1024 Tablet light: sidebar badges and parameter tooltip Tablet dark: sidebar badges and parameter tooltip
Mobile, 390 x 844 Mobile light: interactive muted rows, Select all, and parameter tooltip Mobile dark: interactive muted rows, Select all, and parameter tooltip

First telemetry and clear, with the same resource selected

The gateway already has a log, but the selected catalog view does not show it. Catalog's first log removes its badge and appears without changing selection. Clearing catalog's logs restores the badge and empty state.

Selected resource, no logs yet First log arrives Catalog logs cleared
Catalog selected with No logs and its current-data explanation Catalog remains selected, its badge disappears, and only its new log is shown Catalog remains selected after clearing logs, restoring No logs and the empty view

View-specific explanations and selection

Scenario Screenshot
Traces, dark: selected running resource with no traces Dark Traces view showing No traces badges, selection rail, and existing empty state
Metrics, light: selected running resource with no metrics Light Metrics view showing No metrics badges and existing empty state
Console logs, light: nonparameters remain available; parameter explains why it produces no console logs Console logs parameter explanation and available nonparameter resources
Parameter selection opens Overview and removes the contextual unavailable badge Dark parameter overview reached from Console logs, with no parameter value set
Explicit multiselection retains individual rails while Select all is not filled Dark structured logs view with catalog and orders explicitly selected

@github-actions

This comment has been minimized.

@IEvangelist
David Pine (IEvangelist) force-pushed the ievangelist-contextual-sidebar-states branch from 38edb37 to a9231c6 Compare November 5, 2026 21:25
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 21819

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 21819"

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Base automatically changed from ievangelist-dashboard-detail-close-buttons to main November 6, 2026 00:23
Explain view-specific resource availability without changing selection or health. Cover telemetry arrival and clear, parameter navigation, responsive disclosure, and aggregate selection. Keep telemetry queries scoped as resources become available and initial snapshots load.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Valid resource keys with colliding composite names can make ToDictionary throw and break layout initialization or updates, while logs/metrics-only peers can incorrectly display a No traces badge despite participating in traces.

2 open issues
1 file not reviewed
  • src/Aspire.Dashboard/Resources/Layout.Designer.cs: Generated file
What changed in this PR

This follow-up to #21792 distinguishes telemetry availability from resource health and selection in the dashboard sidebar, while keeping unavailable rows navigable.

Changes:

  • Adds contextual availability badges and parameter explanations, backed by localization resources.
  • Highlights only Select all for aggregate selection and refreshes logs/traces when resource snapshots become available.
  • Extends component and browser coverage for telemetry arrival, clearing, keyboard navigation, and responsive selection.
File Description
tests/​Aspire.Dashboard.Playwright.Tests/​Integration/​Playwright/​ResourcePaneResponsiveTests.cs Updates aggregate-selection and tooltip assertions.
tests/​Aspire.Dashboard.Playwright.Tests/​Integration/​Playwright/​ResourcePanelNavigationTests.cs Covers availability transitions, reloads, and parameter navigation.
tests/​Aspire.Dashboard.Playwright.Tests/​Integration/​Playwright/​ResourcePaneInteractionTests.cs Covers aggregate and modifier-key selection.
tests/​Aspire.Dashboard.Components.Tests/​Layout/​ResourcesLayoutTests.cs Updates selection and telemetry-scope expectations.
tests/​Aspire.Dashboard.Components.Tests/​Layout/​ResourceRowAvailabilityTests.cs Adds signal availability and parameter behavior tests.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.zh-Hant.xlf Adds Traditional Chinese localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.zh-Hans.xlf Adds Simplified Chinese localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.tr.xlf Adds Turkish localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.ru.xlf Adds Russian localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.pt-BR.xlf Adds Brazilian Portuguese localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.pl.xlf Adds Polish localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.ko.xlf Adds Korean localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.ja.xlf Adds Japanese localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.it.xlf Adds Italian localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.fr.xlf Adds French localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.es.xlf Adds Spanish localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.de.xlf Adds German localization entries.
src/​Aspire.Dashboard/​Resources/​xlf/​Layout.cs.xlf Adds Czech localization entries.
src/​Aspire.Dashboard/​Resources/​Layout.resx Defines availability labels and explanations.
src/​Aspire.Dashboard/​Resources/​Layout.Designer.cs Exposes the new resource strings.
src/​Aspire.Dashboard/​README.md Documents availability and aggregate-selection behavior.
src/​Aspire.Dashboard/​Components/​Pages/​Traces.razor.cs Refreshes trace scope after layout resource updates.
src/​Aspire.Dashboard/​Components/​Pages/​StructuredLogs.razor.cs Refreshes log scope after layout resource updates.
src/​Aspire.Dashboard/​Components/​Layout/​ResourcesLayout.razor.js Combines availability explanations with clipped-name tooltips.
src/​Aspire.Dashboard/​Components/​Layout/​ResourcesLayout.razor.css Styles availability badges and aggregate selection.
src/​Aspire.Dashboard/​Components/​Layout/​ResourcesLayout.razor.cs Caches telemetry lookups and resolves availability and selection scope.
src/​Aspire.Dashboard/​Components/​Layout/​ResourcesLayout.razor Renders badges, accessible explanations, and explicit row selection.

Review effort: Balanced

@IEvangelist
David Pine (IEvangelist) enabled stacked auto-merge (squash) November 6, 2026 00:32
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Outstanding issues cause repeated full-span scans, can make selected badges unreadable in forced-colors mode, and leave availability indicators stale after retention evicts the last telemetry item.

1 open issue
2 previously missed issues

In code that hasn't changed since last review

Medium severity Recalculate resource availability flags when retention evicts the last item

src/​Aspire.Dashboard/​Components/​Layout/​ResourcesLayout.razor.cs:1899

HasLogs and HasTraces remain true after retention evicts a resource's last item: TrimLogsToCapacity and TrimTracesToCapacity only delete data, and TraceTrimming_DoesNotRecalculateResourceFlags explicitly covers this behavior. Consequently, a quiet resource loses all retained telemetry but never regains its No logs/No traces badge, even though its view is empty. Base this snapshot on retained-data availability, separately from these flags, and cover last-item eviction.

Medium severity Pair selected badge text and background colors in forced-colors mode

src/​Aspire.Dashboard/​Components/​Layout/​ResourcesLayout.razor.css:615

In forced-colors mode, a selected row gives this badge HighlightText and inherited forced-color-adjust: none, but the badge keeps its dashboard-neutral background. A light dashboard with white HighlightText can therefore render the availability label white-on-white. Give selected badges a paired system-color foreground and background in forced-colors mode.

2 resolved since last review
1 file not reviewed
  • src/Aspire.Dashboard/Resources/Layout.Designer.cs: Generated file

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Pair selected badge system colors and cover retention eviction and indexed signal probes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot November 6, 2026 02:22
@IEvangelist

Copy link
Copy Markdown
Member Author

Recalculate resource availability flags when retention evicts the last item

The sidebar now uses a retained-data snapshot instead of changing the existing received-signal flags. New logs and traces regression cases verify that last-item eviction restores the badge without changing selection or navigation.

Pair selected badge text and background colors in forced-colors mode

Selected availability badges now use the paired Highlight/HighlightText system colors, including the border. Normal light/dark styling is unchanged.

@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Selecting an external telemetry source that shares an app-model resource name resolves the wrong resource, producing an empty key list and hiding its logs and traces.

No open issues 🎉

1 previously missed issue

In code that hasn't changed since last review

Medium severity Same-name app-model resource hides external telemetry data

src/​Aspire.Dashboard/​Components/​Layout/​ResourcesLayout.razor.cs:1944

With an app-model resource named api and an external telemetry source (Name: "api", InstanceId: "external-id"), selecting the external source in the telemetry pane now produces an empty key list and hides its logs/traces. The loop resolves the app-model name first, whose composite-name lookup finds no matching source, rather than resolving the telemetry row named api. Skip app-model lookup in the telemetry pane, retain explicit telemetry keys, and add a same-name regression test.

1 resolved since last review
1 file not reviewed
  • src/Aspire.Dashboard/Resources/Layout.Designer.cs: Generated file

Review effort: Balanced

Read the retained-signal snapshot with a SQLite data reader so dashboard initialization works under Native AOT.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Tests selector

14 / 101 PR test projects · 2 PR jobs, from 33 changed files.

Selected PR test projects (14 / 101)

Aspire.Dashboard.Components.Tests, Aspire.Dashboard.Tests, Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.DotnetTool.Tests, Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Radius.Tests, Aspire.Hosting.Testing.Tests, Aspire.Hosting.Tests, Aspire.Playground.Tests, Aspire.Templates.Tests, Infrastructure.Tests

Selected PR jobs (2)

extension-e2e, native-dashboard-validation


How these were chosen — grouped by what changed

⚠️ 10 of the 14 selected test projects come from a single change — src/Aspire.Dashboard/Components/Layout/ResourcesLayout.razor.

🔧 src/Aspire.Dashboard/Components/Layout/ResourcesLayout.razor (changed source)
→ 10 via the project graph: Aspire.Hosting.Azure.Kubernetes.Tests (3 hops), Aspire.Hosting.Azure.Tests (2 hops), Aspire.Hosting.Blazor.Tests (2 hops), Aspire.Hosting.Dotnet.Tests (2 hops), Aspire.Hosting.DotnetTool.Tests (2 hops), Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Radius.Tests (2 hops), Aspire.Hosting.Testing.Tests, Aspire.Hosting.Tests, Aspire.Playground.Tests (2 hops)

📦 affected project Aspire.Dashboard
→ 1 test: Aspire.Templates.Tests

🔧 src/Aspire.Dashboard/Resources/Layout.resx (changed source)
→ 1 directly: Infrastructure.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/Layout/ResourceRowAvailabilityTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/Layout/ResourcesLayoutTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/Shared/TestTelemetryRepository.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Dashboard.Tests/TelemetryRepositoryTests/SqliteTelemetryPersistenceTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Tests

Job reasons

Job Triggered by
extension-e2e • src/Aspire.Dashboard/Components/Layout/ResourcesLayout.razor, src/Aspire.Dashboard/Components/Layout/ResourcesLayout.razor.cs, src/Aspire.Dashboard/Components/Layout/ResourcesLayout.razor.css, src/Aspire.Dashboard/Components/Layout/ResourcesLayout.razor.js, src/Aspire.Dashboard/Components/Pages/StructuredLogs.razor.cs, src/Aspire.Dashboard/Components/Pages/Traces.razor.cs, src/Aspire.Dashboard/Otlp/Model/ResourceSignalAvailability.cs, src/Aspire.Dashboard/Otlp/Storage/ITelemetryRepository.cs, src/Aspire.Dashboard/Otlp/Storage/SqliteTelemetryRepository.Resources.cs, src/Aspire.Dashboard/Resources/Layout.Designer.cs, src/Aspire.Dashboard/Resources/Layout.resx, src/Aspire.Dashboard/Resources/xlf/Layout.cs.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.de.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.es.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.fr.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.it.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.ja.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.ko.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.pl.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.pt-BR.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.ru.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.tr.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.zh-Hans.xlf, src/Aspire.Dashboard/Resources/xlf/Layout.zh-Hant.xlf, src/Aspire.Dashboard/ServiceClient/DashboardSqliteDatabase.cs, src/Aspire.Dashboard/ServiceClient/DatabaseSchema/004.Traces.sql
• affected project Aspire.Dashboard
native-dashboard-validation affected project Aspire.Dashboard

Selection computed for commit 387667b.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Human assessment is needed because mixed null and non-null instance IDs can make log availability indicators disagree with the logs actually returned by queries.

No open issues 🎉

1 file not reviewed
  • src/Aspire.Dashboard/Resources/Layout.Designer.cs: Generated file

Review effort: Balanced

@IEvangelist
David Pine (IEvangelist) disabled stacked auto-merge November 6, 2026 03:20
@IEvangelist
David Pine (IEvangelist) merged commit ba68df2 into main Nov 6, 2026
162 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.0 milestone Nov 6, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #2069

Generated by PR Documentation Check · copilot · auto · 28.3 AIC · ⌖ 1.16 AIC · ⊞ 7.4K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#2069 targeting release/17.0.

Added a "Resource availability in the sidebar" section to dashboard/explore.mdx covering the No logs/No traces/No metrics/Not applicable badges, parameter explanations, and Select all highlighting. Signals: dashboard_user_facing_page_changed (StructuredLogs/Traces pages), new_public_type (ResourceSignalAvailability), pr_body_has_user_facing_section.

Note

This draft PR needs human review before merging.

Ankit Jain (radical) pushed a commit that referenced this pull request Nov 7, 2026
## Description

The resource list's **Compact** density lost its one-line rows in
#21727. That PR removed the compact branch of the row markup and
switched `.density-compact .resource-row-text` to `flex-direction:
column`, so compact rows became the same two-line rows as Comfortable
("● Running · 1 minute ago"), only shorter. They then also picked up the
"No logs" / "Not applicable" badges added in #21819. #21727 also dropped
**Spacious**'s third detail line. That left the three densities
differing only in row height and font size, although
`ResourceListDensity` still documents one, two and three lines per
resource.

This PR restores the documented densities:

- **Compact**: one line per resource. The icon and name are followed by
aligned type and state-dot columns. In the sidebar, a row's actions
replace the columns while it's hovered or focused, or while its menu is
open, as before #21727. The expand toggle of parent rows stays visible,
and touch screens (`hover: none`) always show the actions. Availability
badges don't fit on one line: an unavailable row is muted, and the
reason stays in its tooltip and accessible description. Unviewed-error
badges sit just before the columns, so the columns stay aligned. A badge
keeps the same place while the row's actions show, so it never moves out
from under the pointer: it takes whichever place is further from the
row's end, clear of the columns or clear of the actions.
- **Comfortable**: unchanged.
- **Spacious**: sidebar rows have a third line again. It shows an
unhealthy health status if there is one, otherwise the primary endpoint,
otherwise the source. When no endpoint can be opened as a link, such as
a `tcp://` endpoint, the first endpoint is used, as in the expanded
list's endpoint column. Query values are masked. The endpoint and source
can take keyboard focus, which shows the full value in a tooltip and
gives it an accessible label.

In the expanded resource list (full canvas), compact rows use the same
single-line identity. From 960px wide, the identity column can grow by
the width of the type and state columns, so names aren't squeezed. That
extra width only raises the column's maximum, never its minimum, so rows
don't overflow the list at narrower widths. Actions there stay visible
all the time.

Persistent types such as "RabbitMQ (persistent)" widen every row's type
column together, so the columns stay aligned. The column is 128px where
rows can be hovered. On touch screens, where the action rail is always
showing, it stays at 64px at the default 420px pane width so names keep
their room.

### Screenshots / Recordings

The resource pane at its default 420px width, using the TestShop
playground, before (main) and after:

- **First row (before):** all three densities are the same two-line row.
- **Second row (after):** Compact is one line with the actions hidden at
rest, Comfortable is unchanged, and Spacious has its third line.
- **Third row:** compact on Structured logs. Before, rows had "No logs"
badges. After, those rows are muted instead. The last panel adds two
unviewed-error badges, injected into the page because the sample app
logs no errors.

![Before and after of the resource list in the Compact, Comfortable and
Spacious densities, plus compact rows on Structured
logs](https://github.com/user-attachments/assets/d31996b1-5001-4f8e-9605-8c2b3ae9601f)

Compact rows with an unviewed error, at rest and hovered. On main, the
badge jumped about 62px toward the actions when a row was hovered, with
a persistent type in the list. It now keeps its place:

![Compact rows with an unviewed-error badge at rest and hovered: before,
the badge jumps toward the actions; after, it keeps its place, with and
without a persistent type in the
list](https://github.com/user-attachments/assets/b88ffc0c-fbb0-4cca-b4dd-53e1ccd2c578)

### Validation

- Updated the `ResourcesLayoutTests` that asserted the two-line compact
row (`CompactDensity_ShowsOneLineWithTypeAndStateColumns`,
`WideRowMetadata_PreservesRuntimeStateAndAccessibleHealthWithRelativeStart`,
`AppHost_ContainerLifetimeQualifiesTypeAndBadgesResourceGlyph`). Added
`ResourceRowAvailabilityTests.CompactDensity_UnavailableRowKeepsReasonWithoutBadge`
and
`ResourcesLayoutTests.SpaciousSidebarDetail_PrefersUnhealthyStatusThenEndpointThenSource`.
- The 264 tests in `ResourcesLayoutTests`,
`ResourceRowAvailabilityTests`, `MainLayoutTests`,
`DashboardViewPreferencesTests` and `SettingsDialogTests` pass.
- Checked manually against the TestShop playground with Playwright at
the default 420px pane width:
- In every density, no row element overlaps another or spills out of its
row.
- Compact: the rest state, hover on a row and on a parent row, keyboard
focus, an open "…" menu, an error badge (simulated) and touch emulation.
  - The expanded list in every density.
- Updated `ResourcePaneResponsiveTests` for the restored geometry:
- 32px compact rows, and 22px, 32px and 40px icons for Compact,
Comfortable and Spacious.
  - Spacious rows are 76px in the sidebar and 60px in the expanded list.
- Compact sidebar rows show only the expand-toggle column at rest, and
the full action rail on hover or keyboard focus.
- A new horizontal-overflow check, with 960px and 990px stages. With the
previous track minimums it fails at 960px (980px of content).
- Added
`ResourcePaneResponsiveTests.CompactSidebar_ErrorBadgeKeepsItsPlaceWhileActionsShow`.
It seeds error logs and checks five states: at rest, the row hovered,
the badge hovered, the row focused, and the menu open. In each, the
badge must not move or be covered, must line up with its spacer, and
must not overlap a column or an action. It runs with and without a
persistent type in the list, and fails against the previous styles.
- 75 of the 80 `ResourcePaneResponsiveTests` pass locally. 4 failures
come from
`RowComposition_AlignsStatusAndSingleLineDetailsWithAccessibleContrast`
and `Accessibility_PaneAndPopoversHaveNoBlockingWcagViolations` at
390px, which fail the same way on main.
`Resizer_DoubleClickRestoresMinimumAcrossPresentationAndNavigation`
failed once in the full run because a drag didn't take effect, and
passed when rerun on its own.

Fixes # (issue)

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

---------

Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com>
Mitch Denny (mitchdenny) pushed a commit that referenced this pull request Nov 10, 2026
## Description

The resource list's **Compact** density lost its one-line rows in
#21727. That PR removed the compact branch of the row markup and
switched `.density-compact .resource-row-text` to `flex-direction:
column`, so compact rows became the same two-line rows as Comfortable
("● Running · 1 minute ago"), only shorter. They then also picked up the
"No logs" / "Not applicable" badges added in #21819. #21727 also dropped
**Spacious**'s third detail line. That left the three densities
differing only in row height and font size, although
`ResourceListDensity` still documents one, two and three lines per
resource.

This PR restores the documented densities:

- **Compact**: one line per resource. The icon and name are followed by
aligned type and state-dot columns. In the sidebar, a row's actions
replace the columns while it's hovered or focused, or while its menu is
open, as before #21727. The expand toggle of parent rows stays visible,
and touch screens (`hover: none`) always show the actions. Availability
badges don't fit on one line: an unavailable row is muted, and the
reason stays in its tooltip and accessible description. Unviewed-error
badges sit just before the columns, so the columns stay aligned. A badge
keeps the same place while the row's actions show, so it never moves out
from under the pointer: it takes whichever place is further from the
row's end, clear of the columns or clear of the actions.
- **Comfortable**: unchanged.
- **Spacious**: sidebar rows have a third line again. It shows an
unhealthy health status if there is one, otherwise the primary endpoint,
otherwise the source. When no endpoint can be opened as a link, such as
a `tcp://` endpoint, the first endpoint is used, as in the expanded
list's endpoint column. Query values are masked. The endpoint and source
can take keyboard focus, which shows the full value in a tooltip and
gives it an accessible label.

In the expanded resource list (full canvas), compact rows use the same
single-line identity. From 960px wide, the identity column can grow by
the width of the type and state columns, so names aren't squeezed. That
extra width only raises the column's maximum, never its minimum, so rows
don't overflow the list at narrower widths. Actions there stay visible
all the time.

Persistent types such as "RabbitMQ (persistent)" widen every row's type
column together, so the columns stay aligned. The column is 128px where
rows can be hovered. On touch screens, where the action rail is always
showing, it stays at 64px at the default 420px pane width so names keep
their room.

### Screenshots / Recordings

The resource pane at its default 420px width, using the TestShop
playground, before (main) and after:

- **First row (before):** all three densities are the same two-line row.
- **Second row (after):** Compact is one line with the actions hidden at
rest, Comfortable is unchanged, and Spacious has its third line.
- **Third row:** compact on Structured logs. Before, rows had "No logs"
badges. After, those rows are muted instead. The last panel adds two
unviewed-error badges, injected into the page because the sample app
logs no errors.

![Before and after of the resource list in the Compact, Comfortable and
Spacious densities, plus compact rows on Structured
logs](https://github.com/user-attachments/assets/d31996b1-5001-4f8e-9605-8c2b3ae9601f)

Compact rows with an unviewed error, at rest and hovered. On main, the
badge jumped about 62px toward the actions when a row was hovered, with
a persistent type in the list. It now keeps its place:

![Compact rows with an unviewed-error badge at rest and hovered: before,
the badge jumps toward the actions; after, it keeps its place, with and
without a persistent type in the
list](https://github.com/user-attachments/assets/b88ffc0c-fbb0-4cca-b4dd-53e1ccd2c578)

### Validation

- Updated the `ResourcesLayoutTests` that asserted the two-line compact
row (`CompactDensity_ShowsOneLineWithTypeAndStateColumns`,
`WideRowMetadata_PreservesRuntimeStateAndAccessibleHealthWithRelativeStart`,
`AppHost_ContainerLifetimeQualifiesTypeAndBadgesResourceGlyph`). Added
`ResourceRowAvailabilityTests.CompactDensity_UnavailableRowKeepsReasonWithoutBadge`
and
`ResourcesLayoutTests.SpaciousSidebarDetail_PrefersUnhealthyStatusThenEndpointThenSource`.
- The 264 tests in `ResourcesLayoutTests`,
`ResourceRowAvailabilityTests`, `MainLayoutTests`,
`DashboardViewPreferencesTests` and `SettingsDialogTests` pass.
- Checked manually against the TestShop playground with Playwright at
the default 420px pane width:
- In every density, no row element overlaps another or spills out of its
row.
- Compact: the rest state, hover on a row and on a parent row, keyboard
focus, an open "…" menu, an error badge (simulated) and touch emulation.
  - The expanded list in every density.
- Updated `ResourcePaneResponsiveTests` for the restored geometry:
- 32px compact rows, and 22px, 32px and 40px icons for Compact,
Comfortable and Spacious.
  - Spacious rows are 76px in the sidebar and 60px in the expanded list.
- Compact sidebar rows show only the expand-toggle column at rest, and
the full action rail on hover or keyboard focus.
- A new horizontal-overflow check, with 960px and 990px stages. With the
previous track minimums it fails at 960px (980px of content).
- Added
`ResourcePaneResponsiveTests.CompactSidebar_ErrorBadgeKeepsItsPlaceWhileActionsShow`.
It seeds error logs and checks five states: at rest, the row hovered,
the badge hovered, the row focused, and the menu open. In each, the
badge must not move or be covered, must line up with its spacer, and
must not overlap a column or an action. It runs with and without a
persistent type in the list, and fails against the previous styles.
- 75 of the 80 `ResourcePaneResponsiveTests` pass locally. 4 failures
come from
`RowComposition_AlignsStatusAndSingleLineDetailsWithAccessibleContrast`
and `Accessibility_PaneAndPopoversHaveNoBlockingWcagViolations` at
390px, which fail the same way on main.
`Resizer_DoubleClickRestoresMinimumAcrossPresentationAndNavigation`
failed once in the full run because a drag didn't take effect, and
passed when rerun on its own.

Fixes # (issue)

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

---------

Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com>
(cherry picked from commit db27327)
Mitch Denny (mitchdenny) pushed a commit that referenced this pull request Nov 10, 2026
## Description

The resource list's **Compact** density lost its one-line rows in
#21727. That PR removed the compact branch of the row markup and
switched `.density-compact .resource-row-text` to `flex-direction:
column`, so compact rows became the same two-line rows as Comfortable
("● Running · 1 minute ago"), only shorter. They then also picked up the
"No logs" / "Not applicable" badges added in #21819. #21727 also dropped
**Spacious**'s third detail line. That left the three densities
differing only in row height and font size, although
`ResourceListDensity` still documents one, two and three lines per
resource.

This PR restores the documented densities:

- **Compact**: one line per resource. The icon and name are followed by
aligned type and state-dot columns. In the sidebar, a row's actions
replace the columns while it's hovered or focused, or while its menu is
open, as before #21727. The expand toggle of parent rows stays visible,
and touch screens (`hover: none`) always show the actions. Availability
badges don't fit on one line: an unavailable row is muted, and the
reason stays in its tooltip and accessible description. Unviewed-error
badges sit just before the columns, so the columns stay aligned. A badge
keeps the same place while the row's actions show, so it never moves out
from under the pointer: it takes whichever place is further from the
row's end, clear of the columns or clear of the actions.
- **Comfortable**: unchanged.
- **Spacious**: sidebar rows have a third line again. It shows an
unhealthy health status if there is one, otherwise the primary endpoint,
otherwise the source. When no endpoint can be opened as a link, such as
a `tcp://` endpoint, the first endpoint is used, as in the expanded
list's endpoint column. Query values are masked. The endpoint and source
can take keyboard focus, which shows the full value in a tooltip and
gives it an accessible label.

In the expanded resource list (full canvas), compact rows use the same
single-line identity. From 960px wide, the identity column can grow by
the width of the type and state columns, so names aren't squeezed. That
extra width only raises the column's maximum, never its minimum, so rows
don't overflow the list at narrower widths. Actions there stay visible
all the time.

Persistent types such as "RabbitMQ (persistent)" widen every row's type
column together, so the columns stay aligned. The column is 128px where
rows can be hovered. On touch screens, where the action rail is always
showing, it stays at 64px at the default 420px pane width so names keep
their room.

### Screenshots / Recordings

The resource pane at its default 420px width, using the TestShop
playground, before (main) and after:

- **First row (before):** all three densities are the same two-line row.
- **Second row (after):** Compact is one line with the actions hidden at
rest, Comfortable is unchanged, and Spacious has its third line.
- **Third row:** compact on Structured logs. Before, rows had "No logs"
badges. After, those rows are muted instead. The last panel adds two
unviewed-error badges, injected into the page because the sample app
logs no errors.

![Before and after of the resource list in the Compact, Comfortable and
Spacious densities, plus compact rows on Structured
logs](https://github.com/user-attachments/assets/d31996b1-5001-4f8e-9605-8c2b3ae9601f)

Compact rows with an unviewed error, at rest and hovered. On main, the
badge jumped about 62px toward the actions when a row was hovered, with
a persistent type in the list. It now keeps its place:

![Compact rows with an unviewed-error badge at rest and hovered: before,
the badge jumps toward the actions; after, it keeps its place, with and
without a persistent type in the
list](https://github.com/user-attachments/assets/b88ffc0c-fbb0-4cca-b4dd-53e1ccd2c578)

### Validation

- Updated the `ResourcesLayoutTests` that asserted the two-line compact
row (`CompactDensity_ShowsOneLineWithTypeAndStateColumns`,
`WideRowMetadata_PreservesRuntimeStateAndAccessibleHealthWithRelativeStart`,
`AppHost_ContainerLifetimeQualifiesTypeAndBadgesResourceGlyph`). Added
`ResourceRowAvailabilityTests.CompactDensity_UnavailableRowKeepsReasonWithoutBadge`
and
`ResourcesLayoutTests.SpaciousSidebarDetail_PrefersUnhealthyStatusThenEndpointThenSource`.
- The 264 tests in `ResourcesLayoutTests`,
`ResourceRowAvailabilityTests`, `MainLayoutTests`,
`DashboardViewPreferencesTests` and `SettingsDialogTests` pass.
- Checked manually against the TestShop playground with Playwright at
the default 420px pane width:
- In every density, no row element overlaps another or spills out of its
row.
- Compact: the rest state, hover on a row and on a parent row, keyboard
focus, an open "…" menu, an error badge (simulated) and touch emulation.
  - The expanded list in every density.
- Updated `ResourcePaneResponsiveTests` for the restored geometry:
- 32px compact rows, and 22px, 32px and 40px icons for Compact,
Comfortable and Spacious.
  - Spacious rows are 76px in the sidebar and 60px in the expanded list.
- Compact sidebar rows show only the expand-toggle column at rest, and
the full action rail on hover or keyboard focus.
- A new horizontal-overflow check, with 960px and 990px stages. With the
previous track minimums it fails at 960px (980px of content).
- Added
`ResourcePaneResponsiveTests.CompactSidebar_ErrorBadgeKeepsItsPlaceWhileActionsShow`.
It seeds error logs and checks five states: at rest, the row hovered,
the badge hovered, the row focused, and the menu open. In each, the
badge must not move or be covered, must line up with its spacer, and
must not overlap a column or an action. It runs with and without a
persistent type in the list, and fails against the previous styles.
- 75 of the 80 `ResourcePaneResponsiveTests` pass locally. 4 failures
come from
`RowComposition_AlignsStatusAndSingleLineDetailsWithAccessibleContrast`
and `Accessibility_PaneAndPopoversHaveNoBlockingWcagViolations` at
390px, which fail the same way on main.
`Resizer_DoubleClickRestoresMinimumAcrossPresentationAndNavigation`
failed once in the full run because a drag didn't take effect, and
passed when rerun on its own.

Fixes # (issue)

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

---------

Co-authored-by: Sébastien Ros <1165805+sebastienros@users.noreply.github.com>
(cherry picked from commit db27327)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants