Repository navigation
Complete Go AppHost readiness and add starter frontend - #21870
David Pine (IEvangelist) wants to merge 10 commits into
Conversation
Ship the Vite frontend and resolved Go API dependency checksums so generated projects start without repairing OpenTelemetry imports. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Adds focused Go AppHost E2E coverage for the initialization and package-resolution gaps identified while reviewing the Preview flag-removal PR. - Extends SDK-refresh coverage to interactive init, non-interactive `init --language go` in an empty directory, and non-interactive init alongside an existing Go application. The brownfield case verifies source preservation and wires the existing application through the default Go integration. - Builds and vets the consumer and explicitly vets the generated `.aspire/modules` module, which Go's root `./...` traversal skips. - Adds a separate stable-identity starter restore/build test with an isolated NuGet cache, exact Go/Redis package pins, SDK regeneration, and NuGet metadata assertions proving the packages came from the local hive. - Retains normal-channel starter startup coverage and adds guaranteed stop cleanup after resource assertions. Contributes to #21108 and #21110; companion coverage for #21183. This does not close either readiness issue or include the flag-removal changes. Existing flag-setup calls are unchanged so #21183 can remove them as planned. Initialization, code generation, build/vet, and normal-channel startup run in the existing regular CLI E2E lane. The stable restore/build test requires a stable-shaped local-hive archive and explicitly skips ordinary prerelease PR archives, matching the existing stable-emulation tests. The stabilization job in `ci.yml` is currently hard-disabled; this PR does not enable it or claim automated stable-release gating. The existing runtime-package routes already cover Go, its generator, Redis and SQL Server. The selector attributes the changed test files to `Aspire.Cli.EndToEnd.Tests`; no map changes are required. | Command | Result | | --- | --- | | `.\restore.cmd` | Passed; reported existing dependency-advisory warnings. | | `dotnet build tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-restore -m:2 -v:quiet` | Passed, 0 warnings, 0 errors. | | `dotnet test --project tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-launch-profile -- --filter-class "*.GoCodegenValidationTests" --filter-class "*.GoStarterTemplateTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"` | Initial run: all three init/codegen cases and normal-channel startup passed. An initially broader stable scenario failed at startup, after restore/build/vet passed, because the PR-stamped binary requested its original prerelease SDK from nuget.org. Stable restore/build is now a separate test, scoped to the requested package-resolution coverage. | | `dotnet test --project tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-launch-profile -- --filter-method "*.RestoreAndBuildGoStarterFromStablePackages" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"` | Passed, 1 test, 0 skipped, against the final stable restore/build scenario. | | `.\localhive.ps1 -Version 17.0.99 -Output .\artifacts\go-stable-e2e -Rid linux-x64 -Archive` | Blocked by NU5104 for stable component packages depending on preview .NET 11 packages. The pack excludes the changed test project. A consumer-only retry with `$env:NoWarn='NU5104'` packed the packages, then hit Windows-to-Linux NativeAOT dashboard publishing restrictions. No warning suppression or build-policy changes are committed. | | `git diff --check` | Passed. | For the Docker executions, `ASPIRE_E2E_POLYGLOT_GO_IMAGE=aspire-go-e2e-6972:latest` selected an existing Go 1.26.10 image. `ASPIRE_E2E_ARCHIVE` pointed to a consumer archive assembled from the approved #21183 native CLI (`ecee5b208e`) and real `17.0.99` packages built from this worktree. This validates the consumer scenarios, not a fully rebuilt stable native bundle or stable-identity startup. Linux stable-hive reproduction commands are documented in `docs/contributing.md`. - Is this feature complete? - [x] Yes. Ready to ship. - [ ] No. Follow-up changes expected. - Are you including unit tests for the changes and scenario tests if relevant? - [x] Yes - [ ] No - Did you add public API? - [ ] Yes - If yes, did you have an API Review for it? - [ ] Yes - [ ] No - Did you add `<remarks />` and `<code />` elements on your triple slash comments? - [ ] Yes - [ ] No - [x] No - Does the change make any security assumptions or guarantees? - [ ] Yes - If yes, have you done a threat model and had a security review? - [ ] Yes - [ ] No - [x] No --------- Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
## Description Adds Go AppHost resource parsing for CodeLens and gutter indicators, and offers the existing debugger setup flow before debugging a Go, Java, or Rust AppHost with missing debugger extensions. Selecting Set Up or dismissing the prompt cancels this launch without a duplicate launch-failure notification/history entry. Run Without Debugging remains available. Nested and parenthesized Go resource expressions retain their declaration's CodeLens/gutter anchor. The README documents that golang.go's toolchain settings govern the debugger, while Aspire CLI resolves Go from its environment. Adds Go AppHost-and-resource source-breakpoint coverage to the existing resource-debug E2E shard. Generated AppHosts require Go 1.26, but the old Delve v1.25.2 rejects that toolchain. Provisioning now selects Go 1.26.10 and Delve v1.27.2 without disabling compatibility checks or changing action pins. Go code-generation changes select extension E2E through both affected-project and path-fallback routing. Relates to #21201, #21213, #21114, and #21115. Builds on already-merged #21187 and #18602. #21211 remains open for live restart validation; restart lifecycle/policy changes are intentionally deferred. ### Validation **Latest head `ccded4f4cf`: actual CI logs inspected, not just job conclusions.** | Scenario | Linux | Windows | | --- | --- | --- | | Public Debug-command dismissal of missing Go debugger; no duplicate error, session/process, pending launch, or installer invocation | [Passed; tree-actions 7/7](https://github.com/microsoft/aspire/actions/runs/42153424399/job/127689898330) | [Passed; tree-actions 7/7](https://github.com/microsoft/aspire/actions/runs/42153424399/job/127689898437) | | Next multi-root action-routing scenario after temporary Go fixture cleanup | Passed in the same shard | Passed in the same shard | | Real source breakpoints in both Go AppHost and Go resource using packaged Delve | [Passed, 19.488 seconds; shard 4 passing / 4 pending](https://github.com/microsoft/aspire/actions/runs/42153424399/job/127689898350) | [Passed, 26.818 seconds; shard 5 passing / 3 pending](https://github.com/microsoft/aspire/actions/runs/42153424399/job/127689898325) | | Full extension unit suite | See PR checks | [4151 passing / 9 pending](https://github.com/microsoft/aspire/actions/runs/42153424399/job/127682946315) | All four E2E jobs had an empty advisory-issue setting; these were not masked failures. Both resource-debug shards also cover existing Go resource attach/Run Without Debugging attach behavior. The prior `6be2b99a45` Go breakpoint scenario also passed on [Linux](https://github.com/microsoft/aspire/actions/runs/42116516011/job/127565932765) and [Windows](https://github.com/microsoft/aspire/actions/runs/42116516011/job/127565933063). These results supersede the original unverified-breakpoint statement. The first dismissal E2E revision passed its new scenario on both platforms but failed the next existing multi-root scenario: deleting the temporary Go fixture left its repository selection stale. `ccded4f4cf` refreshes discovery and waits for the primary selection during teardown. Latest-head CI above confirms both consecutive scenarios pass. First added failing regressions reproducing both reviewer findings (nested calls anchored to line 0; setup/dismissal produced `StartDebuggingDeclined`). After fixes, these commands passed from `extension`: ```powershell corepack yarn compile-tests corepack yarn lint corepack yarn compile corepack yarn unit-test --run out/test/goAppHostParser.test.js --run out/test/aspireCodeLensProvider.test.js --run out/test/appHostLaunchService.test.js --run out/test/appHostTreeView.test.js --run out/test/aspireDebugConfigurationProvider.test.js --run out/test/aspireDebugSession.test.js --run out/test/rpc/interactionServiceTests.test.js --timeout 120000 ``` The focused suite passed **833 tests / 2 pending**. It covers the registered public Debug-command callback through the real tree, launch service, and resolver for setup and dismissal, with substituted language-extension lookup, notifications, debugger start, and installer. Assertions cover cancellation telemetry, no duplicate notification/failure-history entry, cleared state, and preserved genuine declined-launch errors after cancellation/token reuse. Parser/lens/gutter coverage includes nested/parenthesized calls and indexed receivers. Bundling passed with the same four pre-existing webpack dependency warnings. For the fixture-cleanup revision, compile-tests and lint passed again; this command passed **463 tests / 2 pending**: ```powershell corepack yarn unit-test --run out/test/appHostLaunchService.test.js --run out/test/appHostTreeView.test.js --run out/test/cliSpawn.test.js --timeout 120000 ``` **Earlier failures disclosed:** initial Windows CI on `4285826199` had 4149 passing / 9 pending / 2 failing global fake-timer-count assertions in unchanged POSIX cleanup tests. An independently initiated same-head [rerun](https://github.com/microsoft/aspire/actions/runs/42149372040/job/127679739644) passed 4151 / 9 pending; latest-head CI also passes all 4151. No process-lifecycle/timer-policy changes were made. A full local Windows `corepack yarn unit-test --timeout 120000` had 4149 passing / 9 pending / 2 failing unchanged download-cache file-identity/symlink timestamp assertions; it is not claimed green. Earlier extension commands also passed: ```powershell corepack yarn generate-schema corepack yarn unit-test --run out/test/goAppHostParser.test.js --run out/test/parsers.test.js --run out/test/aspireCodeLensProvider.test.js --run out/test/aspireDebugConfigurationProvider.test.js --run out/test/goDebugger.test.js --run out/test/debuggerInstallHints.test.js --run out/test/strings.test.js corepack yarn unit-test --run out/test/e2eLaunchProfile.test.js --run out/test/aspireDebugSession.test.js --timeout 120000 ``` The focused commands passed **392** and **318** tests respectively. The second initially had 317 passing / 1 timeout at the default 20-second budget; the explicit slow-host budget passed all 318. Schema generation passed with the current source-built CLI and pinned SDK; unrelated generated drift is excluded. Repository-root commands: ```powershell dotnet build src\Aspire.Cli\Aspire.Cli.csproj --nologo --verbosity quiet dotnet test --project tests\Infrastructure.Tests\Infrastructure.Tests.csproj --no-launch-profile -- --filter-class 'Infrastructure.Tests.TestTriggerMap.TestTriggerMapTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' git diff --check ``` CLI build passed with a NU1903 advisory for the pinned ILCompiler dependency; real-map tests passed **175/175**; whitespace checks passed. A broader selector namespace run was **not green: 355 passed / 22 failed**, including Windows selecting WSL's shim with no `/bin/bash` and access-denied temporary Git cleanup. The comparison-base script/tests are unchanged from `origin/main`, and direct execution of the system Bash shim reproduces the missing-shell error. An isolated Docker control with Go 1.26.10 reproduced the old Delve compatibility failure, then installed v1.27.2 and hit a real `main.main` source breakpoint. **Remaining live limitations:** actual Marketplace installation, missing-Delve UX, and toolbar/keybinding restart across adapters. Successful setup uses a substituted installer in integration coverage rather than contacting Marketplace from offline E2E. No local interactive Go session/screenshots were captured. The installed old Aspire CLI was not used as current-product evidence. Adjacent Python classification, Node/Bun/Deno display-name localization, and download-cache behavior remain outside this PR. Mitch's approved, explicitly non-blocking tree-sitter-go suggestion is a separate follow-up; this PR does not replace its parser or modify dependency manifests for that exploration. ### Screenshots / Recordings > **This PR includes UI changes.** Please add screenshots or screen recordings so reviewers can evaluate the visual changes without running locally. > > - For before/after comparisons, place them side-by-side or label them clearly. > - For interactive changes (animations, transitions, new flows), prefer a short screen recording (GIF or video). > - If you cannot capture visuals now, note what scenario to test and mark this section as TODO. TODO: capture Go resource CodeLens/gutter indicators and the missing-debugger Set Up prompt. Real Linux/Windows CI verifies breakpoints, running CodeLens, and prompt dismissal, but no local interactive screenshot was captured. <!-- Add screenshots/recordings here --> ## Checklist - Is this feature complete? - [ ] Yes. Ready to ship. - [x] No. Follow-up changes expected. - Are you including unit tests for the changes and scenario tests if relevant? - [x] Yes - [ ] No - Did you add public API? - [ ] Yes - If yes, did you have an API Review for it? - [ ] Yes - [ ] No - Did you add `<remarks />` and `<code />` elements on your triple slash comments? - [ ] Yes - [ ] No - [x] No - Does the change make any security assumptions or guarantees? - [ ] Yes - If yes, have you done a threat model and had a security review? - [ ] Yes - [ ] No - [x] No --------- Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
## Description Go AppHost initialization should work in an existing Go repository without replacing its module or requiring edits to its workspace. This creates a separate `aspire-apphost/` module/workspace when the root already contains `go.mod`, preserves the application's files, and records the nested AppHost path in configuration. Contributes to #21115, #21201, #21207 and #21208. These are umbrella issues; this PR does not close their remaining work. Also: - Removes the incomplete language list from `aspire init --help` and updates generated localization resources and the reviewed help snapshot. - Makes the TypeScript doctor check honor a configured non-TypeScript AppHost, while preserving the migration resolver's legacy discovery behavior. - Corrects the Go toolchain warning to acknowledge installed toolchains on PATH, and extends the minimum-version guard to the Go starter modules and hosting fallback. Includes the new runtime-read test-selection edge. - Enables response decompression for both documentation HTTP clients. - Excludes dev-server build output from SDK default items so copied file-based C# sources cannot enter subsequent server compilations. ### User-facing usage From an existing Go repository: ```console aspire init --language go --non-interactive --suppress-agent-init ``` The existing `go.mod`, `go.work` and source files stay unchanged. New AppHost files live in `aspire-apphost/`, and root configuration selects `aspire-apphost/apphost.go`. Its local `go.work` isolates it from an ancestor workspace that does not list the new module. Explicit user `GOWORK` overrides are unchanged. Updated help: ```text --language <language> The programming language for the AppHost ``` ### Validation All commands ran on Windows unless noted. `MSBUILDTERMINALLOGGER=false` was set for .NET validation. - `.\restore.cmd` — passed; restore reported dependency-advisory warnings. - `dotnet build src\Aspire.Cli\Aspire.Cli.csproj --no-restore -t:UpdateXlf -v:quiet` — passed, no warnings/errors. - `dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-restore --no-launch-profile -- --filter-class '*.ScaffoldingServiceTests' --filter-class '*.GoAppHostToolingCheckTests' --filter-class '*.TypeScriptAppHostToolingCheckTests' --filter-class '*.InitCommandTests' --filter-class '*.DotNetBasedAppHostServerScaffoldCacheTests' --filter-class '*.ProgramTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'` — passed, 253 tests. The initial run identified the intended help snapshot change and two new-test setup issues, which were corrected before this passing run. - `dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-restore --no-launch-profile -- --filter-class '*.GoAppHostToolingCheckTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'` — passed, 61 tests after the final guard scope adjustment. - `dotnet test --project tests\Infrastructure.Tests\Infrastructure.Tests.csproj --no-restore --no-launch-profile -- --filter-class 'Infrastructure.Tests.TestTriggerMap.TestTriggerMapTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'` — passed, 174 tests. - The documented full `--filter-namespace 'Infrastructure.Tests.TestTriggerMap'` run did **not** complete successfully and was stopped after shell-dependent failures. Prepending Git Bash did not repair the Windows process launch: the unchanged comparison-base tests still invoked the WSL Bash shim. Control `C:\Windows\System32\bash.exe --version` reproduces the missing `/bin/bash` failure; comparison-base script/test inputs have no diff against `origin/main`. This is not a full selector-suite pass. - `.\.dotnet\dotnet.exe artifacts\bin\Aspire.Cli\Debug\net11.0\aspire.dll init --help --nologo` — passed; confirms updated help. - A scratch Linux Docker smoke with Go 1.26.10, `GOPROXY=off GOTOOLCHAIN=local`, root and nested workspaces, and an AppHost-shaped local SDK replacement passed root/nested module resolution, `go build ./...`, `go vet ./...` and `go run .`. This checks Go workspace semantics, not a full Aspire E2E run. - `.\.dotnet\dotnet.exe msbuild <scratch>\smoke.csproj -getItem:Compile -nologo` — passed: only `Program.cs` was included with an invalid file-based `build/Gateway.cs` present. A full repeated Blazor AppHost restore was not run. - `curl.exe --silent --show-error --location --header 'Accept-Encoding: br' --output NUL --write-out 'sitemap HTTP %{http_code}, downloaded %{size_download} bytes\n' https://aspire.dev/sitemap-0.xml` — HTTP 200, 678,572 bytes. Unit coverage verifies both registered clients enable automatic decompression; this curl measurement is endpoint evidence, not a CLI transfer trace. - `git diff --check` — passed. Not included: Rust workspace behavior; Python/Java/Rust doctor checks; shared language-discovery redesign; bundle-mode performance measurements; changing Go SDK timestamp preservation; GA support/compatibility policy. The existing empty-directory Go toolchain probe is deliberately retained. Separate product PRs cover runtime/export, extension, CI/scenarios and publish validation. Root-module CLI E2E coverage is being added separately and requires this CLI behavior. ## Checklist - Is this feature complete? - [x] Yes. Ready to ship. - [ ] No. Follow-up changes expected. - Are you including unit tests for the changes and scenario tests if relevant? - [x] Yes - [ ] No - Did you add public API? - [ ] Yes - If yes, did you have an API Review for it? - [ ] Yes - [ ] No - Did you add `<remarks />` and `<code />` elements on your triple slash comments? - [ ] Yes - [ ] No - [x] No - Does the change make any security assumptions or guarantees? - [ ] Yes - If yes, have you done a threat model and had a security review? - [ ] Yes - [ ] No - [x] No --------- Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Go starters should build from their shipped files without an initial `aspire run` repairing dependencies, and Go preview validation should exercise the same runtime and native-runner paths as other AppHosts. - Ship a tidy API `go.mod` and generated `go.sum`. Add starter scenarios checking gitignore, readonly API build, tidy stability, health and weather responses; remove the Kubernetes manual-tidy workaround. - Honor the existing `--use-redis-cache false` option for Go. Omitted/true retains Redis; false omits the integration and resource. Cover all three scaffold choices with generated-source snapshots and both HTTP lifecycle variants with Docker E2E. - Add `go vet` to Go polyglot fixtures, an EF Core fixture, and Foundry tool/AKS node-pool parity. Exercise configuration-section list getters in the real Go runtime smoke. - Add Go to all six native starter-validation platforms, with official checksum-verified Go installation, timeout budget, and runtime-only selector edges for Go hosting, Go codegen, and Redis. Linux retains API/Redis readiness; containerless Windows/macOS use the cache-free starter with API readiness unchanged. - Add isolated-local-feed Go/Java scaffolding and restore to the stabilization smoke without rewriting template pins. Use a genuine Release bundled driver outside repository mode, cold consumer caches, and exact hosting-package extraction/provenance checks. Enable Java only in its subprocess. - Select languages by name rather than picker position. Restore stale Java/TypeScript SDK baselines after `aspire add` so the following `aspire restore` genuinely tests regeneration. Establish the TypeScript baseline with an actual restore before reading cache metadata. - Wait for the TypeScript Kubernetes application's actual Ready pod; exercise the Go Helm namespace/chart-version callback. Relates to #21202, #21206, #21209, #21210, #21201, and #21108. ```bash aspire new aspire-go-starter --name GoReady --non-interactive --suppress-agent-init aspire new aspire-go-starter --name GoReady --use-redis-cache false --non-interactive --suppress-agent-init ``` Both variants emit `api/go.sum` and an already-tidy API module. Its API can build with `go build -mod=readonly` without first running the AppHost's tidy resource. This PR is independent of #21823. Root-module brownfield E2E #21825 merged into the #21823 feature branch, not directly into main; its delivery follows #21823. #21806 independently covers other Go init/build/vet/stable-restore scenarios. The existing stabilization gate remains disabled (`STABILIZATION_ENABLED: 'false'`); enabling it needs a separate CI/policy decision. Current `Aspire.Hosting.Java.csproj` still sets `SuppressFinalPackageVersion=true` while the Java starter pins the requested Aspire version. The corrected smoke reaches actual NuGet restore and exposes that mismatch: `Aspire.Hosting.Java (= 17.0.0)` is unavailable, the nearest local package is `17.0.0-dev`, and nuget.org versions are not considered. No pin substitution or Java release-policy change is included. Native Linux validation built the genuine stabilized Release CLI/payload and proved cold Go/Redis package restore and C# restore. This is **not a clean stabilization pass**: the unsuppressed stable pack first reproduced NU5104 on existing .NET 11 preview dependencies. The diagnostic consumer feed downgraded only NU5104 with `WarningsNotAsErrors=NU5104`; that exception is not committed. The final smoke correctly exits 1 with only Java in its failure list. The bounded shared-image fix is separate in #21849; this PR does not modify image Dockerfiles or the image-build implementation. Its `b8274fc8e0` image job and all four uploads passed, Infrastructure passed 2090/2090 including all 13 new image cases, and all 116 CLI archive E2E jobs passed. Earlier Windows extension fake-timer and DCP Docker-startup failures were investigated with same-source passing main controls; the morning live refresh reports its Final Results passing. It remains independently review-gated. Do not infer actual timeout/fallback execution from a healthy-mirror image pass. No action SHA is added or changed. No official Azure DevOps pipeline is modified. Parent's Go-minimum-version map rule/theory and the other owner's extension-e2e map block are untouched. The cache option uses existing embedded CLI inputs; no additional selector rule is required. The stabilization script remains advisory/disabled rather than being presented as a regular-PR gate. This does not close #21108: live Azure Container Apps deployment and real missing/old-toolchain E2E remain uncovered here. Cross-language lifecycle redesigns are deferred. Original-head run [42116644663](https://github.com/microsoft/aspire/actions/runs/42116644663) exposed two causes: - Windows x64/ARM64 and macOS x64/ARM64 starter validation failed because Redis could not start: the Windows Docker engine pipe was absent and macOS had no Docker executable. The API correctly waited on its unhealthy dependency. Those native runners now use the supported cache-free variant; Linux and Docker E2E retain Redis coverage. No readiness assertion was removed. - `TypeScriptCodegenValidationTests` read `.codegen-hash` immediately after init, which supplies SDK sources but not restore-cache metadata. An explicit baseline restore now precedes the snapshot and stale-cache assertions. **Head `1ab3ad1e30`: all six native starter lanes passed**, including both Redis-enabled Ubuntu lanes and all four formerly failing Windows/macOS lanes, in [run 42151619597](https://github.com/microsoft/aspire/actions/runs/42151619597). Packaged CI subsequently passed [GoStarterReadinessTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672515) (both cache choices), [GoStarterTemplateTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672968), [JavaCodegenValidationTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672216), and [TypeScriptCodegenValidationTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721664876). All originally failing targeted lanes/classes therefore have passing coverage. The shared image job first timed out at 45 minutes twice. Attempt 2 fetched 108 MB from Azure Ubuntu in 41 minutes 29 seconds (43.4 kB/s), versus a following GitHub download at 80.1 MB/s; GHA cache import also returned HTTP 400 service-unavailable responses. After #21849's same-input image control passed with all four uploads, one evidence-based product revalidation was started. [Attempt 3's image job passed](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127718680817) and admitted packaged E2E. No blind retries were made. The successful infrastructure control used a healthy primary mirror; it does not demonstrate timeout/fallback execution in that CI run. **Head `bd30794b9e`: historical failures and final outcome are distinct.** In [run 42167868738](https://github.com/microsoft/aspire/actions/runs/42167868738), all six native starter lanes and Go/Java/TypeScript SDK validation passed. The first [shared image job](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127729647462) was canceled after 45 minutes 22 seconds with Azure Ubuntu apt downloads still running and all four uploads skipped; the initial Linux tree-actions attempt also failed on a stale immutable Running snapshot. The morning live refresh subsequently shows [Final Results passing](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127754717945), including [GoStarterReadinessTests](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127747615122). This session did not initiate retries. A passing later attempt does not repair the tree-actions race: its separate test-only fix #21854 still needs independent approval/merge and incorporation before claiming the race fixed in this checkout. **Latest head `0bb6569d91` requires fresh checks**, now running in [42222384609](https://github.com/microsoft/aspire/actions/runs/42222384609). Both new review findings are corrected: SDK selection accepts only exact numeric MAJOR.MINOR.PATCH package filenames, and Go starter startup is inside its existing cleanup scope. Both threads were replied to and resolved with evidence. Earlier-head CI is not presented as latest-head proof. Per the user's explicit authorization, the coordinator enabled normal native **squash auto-merge** at 05:22:46Z on 2026-11-06. It remains enabled behind required fresh checks and review requirements. No admin bypass is authorized or used; the PR is not merged. The smoke now publishes a Release CLI with its real stabilized bundle outside the checkout, propagates stabilization into child payload builds, and clears inherited `ASPIRE_REPO_ROOT` for every consumer invocation. Consumer packages are isolated after the driver build so build-time extraction cannot hide a missing stable package. Successful guest restores must produce metadata for the exact hosting pins, including Redis for Go; provenance is retained in the output. The real run also exposed two stale smoke assumptions: a pre-owned parent feed mapping conflicts with scaffolding's project-local channel policy, and current C# file-based templates use `#:package Aspire.Hosting.AppHost@<version>`, not the obsolete SDK directive. The smoke now lets the CLI establish its own authoritative project-scoped feed mapping and checks the current hosting-package contract. No customer NuGet policy is changed. - `.\restore.cmd` - passed. - `dotnet build tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-restore --nologo -v quiet` - passed, zero warnings/errors; repeated successfully after removing temporary fault injection for `0bb6569d91`. - `dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class '*.NewCommandTemplateConfigPersistenceTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'` - passed, 59 tests including default/true/false Go package and generated-source assertions. Existing ILCompiler NU1903 advisory was emitted. - With `ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new` and `ASPIRE_E2E_DOTNET_IMAGE=aspire-e2e-polyglot-base:latest`, `dotnet test --project tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-launch-profile -- --filter-method '*.RestoreGeneratesSdkFiles_WithConfiguredToolchain' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'` - passed, all four npm/bun/yarn/pnpm cases against exact `1ab3ad1e30` Linux CLI/packages. The corresponding packaged CI class also passed above. - With `ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new` and `ASPIRE_E2E_POLYGLOT_GO_IMAGE=aspire-go-e2e-6972:latest`, `dotnet test --project tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj --no-launch-profile -- --filter-method '*.StarterShipsTidyApiAndServesRequests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'` - 1 passed/1 failed locally against exact `1ab3ad1e30`. Cache-free passed actual scaffolding, readonly API build, tidy check, API-up, health/weather and stop without a Docker socket. Redis timed out locally. The unchanged `2859e199e2` control reproduced the same timeout on this Docker Desktop host; no workaround or weaker assertion was added. **Both cases subsequently passed packaged CI**, linked above. After the cleanup-scope correction, this local command again passed cache-free and failed Redis on API readiness; the independent CLI stop log confirmed successful shutdown, while the shared terminal helper observed the prior ERR prompt. That local run is not claimed green. - Temporary fault-injection validation used that same E2E command with only the cache-free case and a shell wrapper returning HTTP 503 for the Dashboard probe after a real packaged AppHost launch - intentionally failed. Terminal output showed `dashboard-http-failed`, then cleanup invocation; the CLI log confirmed `apphost.go stopped successfully` and exit 0. The wrapper and temporary test edit were removed before the final clean build/commit. This verifies partial-start cleanup, not a successful readiness scenario. - `docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro" aspire-go-e2e-6972:latest -c "sed 's/\r$//' /workspace/artifacts/readiness-ci/validate-stable-sdk-selection.sh | bash"` - passed actual smoke-script preflight cases for missing SDK, prerelease-only, mixed stable/dev/preview/rc/build-metadata/four-component filenames, multi-digit stable versions, and feed paths with spaces. The instrumented driver received `BundleVersion=17.0.0` from the mixed feed. Invalid-only feeds exited 1 with the explicit missing-stable diagnostic. Temporary harness removed after retaining logs; not a new all-language stabilization pass. - `dotnet test --project tests\Infrastructure.Tests\Infrastructure.Tests.csproj --no-launch-profile -- --filter-class '*.TestTriggerMapTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'` - passed, 176 tests. - `dotnet run --project tools\SelectTests -- --changed-files artifacts\readiness-changed-files.txt --explain` - passed against the real graph/map; Go hosting/codegen, Redis, starter checksum and EF Core fixture inputs select starter-validation/polyglot with zero unattributed files. Schedule-only deployment remains advisory. - `$env:DOTNET_ROOT = Join-Path $PWD '.dotnet'; $env:ASPIRE_REPO_ROOT = $PWD; .\artifacts\bin\Aspire.Cli\Debug\net11.0\aspire.exe restore --apphost tests\PolyglotAppHosts\<integration>\Go\apphost.go --non-interactive` - passed separately for `Aspire.Hosting.EntityFrameworkCore`, `Aspire.Hosting.Foundry`, and `Aspire.Hosting`, generating actual SDK bindings. - `docker run --rm --entrypoint bash -v "${PWD}:/workspace" aspire-go-e2e-6972:latest -c 'set -e; for fixture in Aspire.Hosting.EntityFrameworkCore Aspire.Hosting.Foundry Aspire.Hosting; do cd "/workspace/tests/PolyglotAppHosts/$fixture/Go"; gofmt -w apphost.go; go build -buildvcs=false -o /tmp/fixture ./...; go vet ./...; done'` - passed for all three fixtures. - `docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro" aspire-go-e2e-6972:latest -c 'set -e; bash -n /workspace/.github/workflows/polyglot-validation/test-go.sh /workspace/.github/workflows/polyglot-validation/test-go-playground.sh /workspace/eng/scripts/stabilization-smoke-init-restore.sh; work=$(mktemp -d); trap "rm -rf $work" EXIT; cp /workspace/src/Aspire.Cli/Templating/Templates/go-starter/api/* "$work/"; cd "$work"; sed -i "s/{{projectNameLower}}/starter/g" go.mod; go build -mod=readonly -o /tmp/go-ready-api .; go mod tidy -diff; go vet ./...'` - passed without a dependency-repair command. - Native Linux `./restore.sh -p:SkipTestProjects=true -p:SkipPlaygroundProjects=true` - passed with the pinned SDK. - Native Linux `./dotnet.sh pack src/Aspire.Hosting.AppHost/Aspire.Hosting.AppHost.csproj -c Release -p:StabilizePackageVersion=true -p:SkipNativeBuild=true --nologo -v quiet` - failed as expected on existing NU5104 preview dependencies; not counted as a stabilization pass. - To isolate consumer behavior, the diagnostic feed used `for project in Aspire.Hosting Aspire.Hosting.AppHost Aspire.Hosting.Dotnet Aspire.TypeSystem Aspire.Hosting.CodeGeneration.Go Aspire.Hosting.CodeGeneration.Java Aspire.Hosting.Go Aspire.Hosting.Redis Aspire.Hosting.Java Aspire.Hosting.JavaScript Aspire.AppHost.Sdk Aspire.ProjectTemplates; do ./dotnet.sh pack "src/$project/$project.csproj" -c Release -p:StabilizePackageVersion=true -p:SkipNativeBuild=true -p:WarningsNotAsErrors=NU5104 --nologo -v quiet; done` - passed. No suppression is committed; Java remains `17.0.0-dev` by existing policy. - Native Linux `STABILIZATION_SMOKE_CONFIGURATION=Release ASPIRE_REPO_ROOT=/work/source bash eng/scripts/stabilization-smoke-init-restore.sh` - built the genuine stabilized Release driver/payload and completed the consumer flow. **Exit 1 is the expected Java policy failure, not an all-language pass.** Go/Redis `17.0.0` metadata names `/work/source/artifacts/packages/Release/Shipping`; C# `17.0.0` restored; Java reached real NuGet restore and rejected its absent stable pin with no nuget.org fallback. Output assertions confirmed the final failure list is exactly `java`. Sources were `1ab3ad1e30` plus the final smoke correction; no mixed PR-stamped CLI was used. - `bash -n eng/scripts/stabilization-smoke-init-restore.sh`, PowerShell parser validation of `eng\scripts\cli-starter-validation.ps1`, and `git diff --check` - passed. - Full `Infrastructure.Tests.TestTriggerMap` namespace was not passed on this Windows host: WSL's `bash.exe` cannot find `/bin/bash`; a narrowed run also encountered readonly `.git` cleanup failures. Not counted as successful validation. - Is this feature complete? - [ ] Yes. Ready to ship. - [x] No. Follow-up changes expected. - Are you including unit tests for the changes and scenario tests if relevant? - [x] Yes - [ ] No - Did you add public API? - [ ] Yes - If yes, did you have an API Review for it? - [ ] Yes - [ ] No - Did you add `<remarks />` and `<code />` elements on your triple slash comments? - [ ] Yes - [ ] No - [x] No - Does the change make any security assumptions or guarantees? - [ ] Yes - If yes, have you done a threat model and had a security review? - [ ] Yes - [ ] No - [x] No --------- Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Regenerate the two-pass snapshot against main so new browser-origin and resource display-name APIs use synchronized error access. Both CI platforms exposed this merge-combination snapshot mismatch. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep JavaScript hosting in every generated Go starter, refresh the optional Redis snapshots, and exclude the binary logo from text line-ending validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 21870Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 21870" |
Tests selector5 / 101 PR test projects · 5 PR jobs, from 126 changed files. Selected PR test projects (5 / 101)
Selected PR jobs (5)
How these were chosen — grouped by what changed🔧 🔧 📦 affected project 📄 📄 📄 📄 📄 📄 🔧 🔧 🔧 🔧 🔧 🔧 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 🧪 Job reasons
Selection computed for commit |
|
Closing in favor of the standard flow: a focused PR against main, followed by the backport command after review and approval. |
There was a problem hiding this comment.
🟡 Changes recommended
The renamed Go-starter label causes interactive test selection to time out, while the frontend’s build-only configuration lacks an output consumer or standalone publish mode, causing publish/deploy validation to fail.
2 open issues
2 files not reviewed
src/Aspire.Cli/Resources/InitCommandStrings.Designer.cs: Generated filesrc/Aspire.Cli/Templating/Templates/go-starter/frontend/package-lock.json: Generated file
What changed in this PR
Ports post-snapshot Go AppHost readiness work to release/17.0 and adds a React/Vite frontend to the Go starter.
Changes:
- Improves Go initialization, tooling diagnostics, generated SDK synchronization, and typed API export metadata.
- Adds frontend-to-API service discovery while making Redis optional.
- Extends VS Code editor/debugger support, CLI tests, and CI validation.
This pull request requires changes. Two critical findings affect interactive starter selection and frontend publishing/deployment. Two moderate findings require runtime coverage of frontend startup and /api/weatherforecast proxying for both Redis choices.
| File | Description |
|---|---|
tests/PolyglotAppHosts/Aspire.Hosting/Go/apphost.go |
Exercises AKS node pools and persistent volumes. |
tests/PolyglotAppHosts/Aspire.Hosting.Foundry/Go/apphost.go |
Exercises prompt-agent tool references. |
tests/PolyglotAppHosts/Aspire.Hosting.EntityFrameworkCore/Go/go.mod |
Defines the EF Core Go fixture module. |
tests/PolyglotAppHosts/Aspire.Hosting.EntityFrameworkCore/Go/aspire.config.json |
Selects EF Core fixture hosting packages. |
tests/PolyglotAppHosts/Aspire.Hosting.EntityFrameworkCore/Go/apphost.go |
Exercises EF migration APIs from Go. |
tests/Infrastructure.Tests/TestTriggerMap/TestTriggerMapTests.cs |
Covers Go runtime consumer routing. |
tests/Aspire.Hosting.CodeGeneration.Go.Tests/Snapshots/GoApiExportTests.FocusedApiExport.verified.json |
Records field and constant metadata. |
tests/Aspire.Hosting.CodeGeneration.Go.Tests/Snapshots/EscapedMetadataGeneratedAspire.verified.go |
Records synchronized generated accessors. |
tests/Aspire.Hosting.CodeGeneration.Go.Tests/GoScaffoldTests.cs |
Excludes binary assets from newline checks. |
tests/Aspire.Hosting.CodeGeneration.Go.Tests/GoApiExportTests.cs |
Tests declared types and ATS optionality. |
tests/Aspire.Cli.Tests/Templating/GoAppHostTemplateTests.cs |
Checks starter frontend configuration and dependencies. |
tests/Aspire.Cli.Tests/Snapshots/NewCommandTemplateConfigPersistenceTests.GoStarterHonorsRedisChoice_choice=true.verified.go |
Records explicitly enabled Redis output. |
tests/Aspire.Cli.Tests/Snapshots/NewCommandTemplateConfigPersistenceTests.GoStarterHonorsRedisChoice_choice=false.verified.go |
Records cache-free starter output. |
tests/Aspire.Cli.Tests/Snapshots/NewCommandTemplateConfigPersistenceTests.GoStarterHonorsRedisChoice_choice=default.verified.go |
Records default Redis-enabled output. |
tests/Aspire.Cli.Tests/Snapshots/InitCommandTests.InitCommand_Help_ShowsFileBasedOption.verified.txt |
Updates language-option help output. |
tests/Aspire.Cli.Tests/Scaffolding/ScaffoldingServiceTests.cs |
Tests nested Go AppHost placement. |
tests/Aspire.Cli.Tests/Projects/DotNetBasedAppHostServerScaffoldCacheTests.cs |
Checks generated build-output exclusions. |
tests/Aspire.Cli.Tests/ProgramTests.cs |
Verifies documentation-client decompression. |
tests/Aspire.Cli.Tests/Commands/TypeScriptAppHostToolingCheckTests.cs |
Tests configured non-TypeScript AppHosts. |
tests/Aspire.Cli.Tests/Commands/NewCommandTemplateConfigPersistenceTests.cs |
Tests all Redis scaffold choices. |
tests/Aspire.Cli.Tests/Commands/InitCommandTests.cs |
Verifies preservation of existing Go files. |
tests/Aspire.Cli.Tests/Commands/GoAppHostToolingCheckTests.cs |
Extends minimum-version consistency checks. |
tests/Aspire.Cli.EndToEnd.Tests/TypeScriptPublishTests.cs |
Selects the AppHost language by name. |
tests/Aspire.Cli.EndToEnd.Tests/TypeScriptCodegenValidationTests.cs |
Restores stale SDK baselines before regeneration checks. |
tests/Aspire.Cli.EndToEnd.Tests/SecretTypeScriptAppHostTests.cs |
Selects TypeScript by name. |
tests/Aspire.Cli.EndToEnd.Tests/LocalConfigMigrationTests.cs |
Removes positional language selection. |
tests/Aspire.Cli.EndToEnd.Tests/KubernetesDeployTypeScriptTests.cs |
Waits for the deployed application pod. |
tests/Aspire.Cli.EndToEnd.Tests/JavaScriptPublishTests.cs |
Selects the AppHost language by name. |
tests/Aspire.Cli.EndToEnd.Tests/JavaPolyglotTests.cs |
Selects Java independently of picker order. |
tests/Aspire.Cli.EndToEnd.Tests/JavaPolyglotApphostDirectoryTests.cs |
Uses named Java selection. |
tests/Aspire.Cli.EndToEnd.Tests/JavaCodegenValidationTests.cs |
Tests regeneration of a stale Java SDK. |
tests/Aspire.Cli.EndToEnd.Tests/Helpers/KubernetesDeployTestHelpers.cs |
Clarifies tool-installation documentation. |
tests/Aspire.Cli.EndToEnd.Tests/Helpers/CliInstallStrategyTests.cs |
Tests stable-version archive detection. |
tests/Aspire.Cli.EndToEnd.Tests/Helpers/CliE2ETestHelpers.cs |
Detects stable packages in local-hive archives. |
tests/Aspire.Cli.EndToEnd.Tests/Helpers/CliE2EAutomatorHelpers.cs |
Centralizes language-name selection. |
tests/Aspire.Cli.EndToEnd.Tests/GoStarterReadinessTests.cs |
Tests tidy builds and direct API responses for both cache choices. |
tests/Aspire.Cli.EndToEnd.Tests/GoRootModuleInitTests.cs |
Tests initialization beside existing modules and workspaces. |
tests/Aspire.Cli.EndToEnd.Tests/GoKubernetesDeployTests.cs |
Exercises Helm namespace and chart-version callbacks. |
tests/Aspire.Cli.EndToEnd.Tests/GoEmptyAppHostTemplateTests.cs |
Checks generated SDK ignore entries. |
tests/Aspire.Cli.EndToEnd.Tests/GoCodegenValidationTests.cs |
Expands initialization and build/vet scenarios. |
src/Aspire.Hosting.CodeGeneration.Go/GoApiModel.cs |
Adds declared-type and optionality metadata. |
src/Aspire.Hosting.CodeGeneration.Go/GoApiExportWriter.cs |
Serializes field and constant metadata. |
src/Aspire.Hosting.CodeGeneration.Go/AtsGoCodeGenerator.cs |
Synchronizes generated error and collection access. |
src/Aspire.Hosting.CodeGeneration.Go/AtsGoCodeGenerator.ApiProjection.cs |
Projects Go types and ATS optionality. |
src/Aspire.Cli/Utils/EnvironmentChecker/TypeScriptAppHostToolingCheck.cs |
Honors the configured AppHost language. |
src/Aspire.Cli/Utils/EnvironmentChecker/GoAppHostToolingCheck.cs |
Clarifies Go toolchain selection diagnostics. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/vite.config.ts |
Configures development API proxying. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/tsconfig.node.json |
Configures Vite configuration type checking. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/tsconfig.json |
Connects frontend TypeScript projects. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/tsconfig.app.json |
Configures React application type checking. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/src/vite-env.d.ts |
Includes Vite client types. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/src/main.tsx |
Mounts the React application. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/src/index.css |
Adds base and reduced-motion styles. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/public/github.svg |
Supplies the GitHub icon. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/package.json |
Defines frontend dependencies and commands. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/index.html |
Adds the frontend HTML entry point. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/eslint.config.js |
Configures frontend linting. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/.npmrc |
Configures public npm registry resolution. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/.gitignore |
Ignores frontend development artifacts. |
src/Aspire.Cli/Templating/Templates/go-starter/frontend/.dockerignore |
Excludes local build artifacts from containers. |
src/Aspire.Cli/Templating/Templates/go-starter/aspire.config.json |
Includes JavaScript hosting by default. |
src/Aspire.Cli/Templating/Templates/go-starter/apphost.go |
Wires the frontend, API, and optional cache. |
src/Aspire.Cli/Templating/Templates/go-starter/api/go.mod |
Tidies direct and indirect dependency classification. |
src/Aspire.Cli/Templating/KnownTemplateId.cs |
Updates the starter description comment. |
src/Aspire.Cli/Templating/CliTemplateFactory.GoStarterTemplate.cs |
Applies conditional Redis generation. |
src/Aspire.Cli/Templating/CliTemplateFactory.cs |
Updates the starter label and Redis option. |
src/Aspire.Cli/Scaffolding/ScaffoldingService.cs |
Isolates AppHosts from existing Go modules and workspaces. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.zh-Hant.xlf |
Refreshes Traditional Chinese help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.zh-Hans.xlf |
Refreshes Simplified Chinese help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.tr.xlf |
Refreshes Turkish help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.ru.xlf |
Refreshes Russian help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.pt-BR.xlf |
Refreshes Brazilian Portuguese help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.pl.xlf |
Refreshes Polish help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.ko.xlf |
Refreshes Korean help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.ja.xlf |
Refreshes Japanese help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.it.xlf |
Refreshes Italian help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.fr.xlf |
Refreshes French help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.es.xlf |
Refreshes Spanish help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.de.xlf |
Refreshes German help-source metadata. |
src/Aspire.Cli/Resources/xlf/InitCommandStrings.cs.xlf |
Refreshes Czech help-source metadata. |
src/Aspire.Cli/Resources/InitCommandStrings.resx |
Removes the incomplete language list from help. |
src/Aspire.Cli/Resources/InitCommandStrings.Designer.cs |
Synchronizes the generated resource comment. |
src/Aspire.Cli/Projects/DotNetBasedAppHostServerProject.cs |
Excludes copied build output from compilation. |
src/Aspire.Cli/Program.cs |
Enables documentation response decompression. |
extension/src/testing/e2eStateFileBridge.ts |
Captures AppHost CodeLens debug evidence. |
extension/src/test/rpc/interactionServiceTests.test.ts |
Updates the launch-reservation test double. |
extension/src/test/parsers.test.ts |
Verifies Go parser registration. |
extension/src/test/goAppHostParser.test.ts |
Tests Go resource parsing and source anchors. |
extension/src/test/aspireDebugSession.test.ts |
Updates launch-reservation test doubles. |
extension/src/test/aspireDebugConfigurationProvider.test.ts |
Tests debugger setup and no-debug launches. |
extension/src/test/aspireCodeLensProvider.test.ts |
Tests Go CodeLens and gutter state. |
extension/src/test/appHostTreeView.test.ts |
Tests public Debug-command cancellation. |
extension/src/test/appHostLaunchService.test.ts |
Tests cancellation correlation and subsequent launches. |
extension/src/test-e2e/treeActions.e2e.test.ts |
Exercises missing-debugger dismissal and cleanup. |
extension/src/test-e2e/resourceDebugTools.e2e.test.ts |
Exercises Go AppHost and resource breakpoints. |
extension/src/services/AppHostLaunchService.ts |
Distinguishes provider cancellation from launch failure. |
extension/src/loc/strings.ts |
Adds localized AppHost debugger guidance. |
extension/src/editor/parsers/plainTextInactiveOffsets.ts |
Updates scanner documentation comments. |
extension/src/editor/parsers/AppHostResourceParser.ts |
Registers the Go language mapping. |
extension/src/editor/AspireGutterDecorationProvider.ts |
Registers Go parsing for gutter indicators. |
extension/src/editor/AspireCodeLensProvider.ts |
Registers Go parsing for CodeLens. |
extension/src/debugger/debuggerInstallHints.ts |
Resolves AppHost debugger installation hints. |
extension/src/debugger/AspireDebugConfigurationProvider.ts |
Offers setup for missing debugger support. |
extension/README.md |
Documents Go editor and debugger behavior. |
extension/package.nls.json |
Adds debugger-setup localization metadata. |
extension/loc/xlf/aspire-vscode.xlf |
Includes the debugger-setup translation source. |
eng/scripts/cli-starter-validation.ps1 |
Adds platform-aware Go starter validation. |
eng/github-ci/test-trigger-map.yml |
Routes Go runtime changes to their consumers. |
docs/specs/polyglot-apphost.md |
Documents nested Go initialization. |
docs/specs/cli-output-formats.md |
Documents Go member type and optionality metadata. |
docs/contributing.md |
Documents stable-shaped Go E2E prerequisites. |
docs/ci/test-trigger-map.md |
Documents native Go validation lanes. |
.github/workflows/polyglot-validation/test-go.sh |
Exercises configuration-section collection decoding. |
.github/workflows/polyglot-validation/test-go-playground.sh |
Adds Go vet checks to fixture validation. |
.github/workflows/extension-e2e-tests.yml |
Aligns Go and Delve versions. |
.github/workflows/cli-starter-validation.yml |
Provisions Go and expands validation budgets. |
.github/workflows/ci.yml |
Updates stabilization-smoke documentation comments. |
Review effort: Balanced
| new CallbackTemplate( | ||
| KnownTemplateId.GoStarter, | ||
| "Starter App (Go API + Redis, Go AppHost)", | ||
| "Starter App (Go API + React + Redis, Go AppHost)", |
| frontend := builder.AddViteApp("frontend", "./frontend", &aspire.AddViteAppOptions{}). | ||
| WithReference(api). | ||
| WaitFor(api) |

Description
The
release/17.0branch was snapped before the final Go AppHost readiness work landed onmain. This ports the post-snap Go changes so the release includes:aspire-go-starter, wired to the Go API through Aspire service discovery.go.sumfor the starter API soaspire rundoes not need to repair missing OpenTelemetry imports before startup.The final #21827 commit was intentionally excluded because it only refreshes a Kubernetes structured-field snapshot introduced by unrelated #21824, which is not present on
release/17.0.User-facing usage
The generated application now starts
frontend,api, and optionallycache. Vite proxies/apito the Aspire-injected API endpoint.Screenshots / Recordings
TODO: Capture the Go AppHost editor CodeLens/gutter behavior from the release branch.
Validation
dotnet test --project tests\Aspire.Hosting.CodeGeneration.Go.Tests\Aspire.Hosting.CodeGeneration.Go.Tests.csproj --no-launch-profile -- --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"(130 tests).Aspire.Cli.TestsGo template, config persistence, and tooling checks (123 tests).TestTriggerMapTestsfocused infrastructure coverage (184 tests).extension\build.ps1.corepack yarn testfromextension.go mod tidy -diffandgo build -mod=readonly ..npm ciandnpm run build.17.0.0-devtemplate package. The fallback E2E strategy installed stable CLI 13.6.4, which predates the Go starter.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?