Repository navigation
Write the WinUI E2E ready marker atomically so the test never reads an empty file - #21932
Conversation
The WinUI fixture app wrote its ready marker with File.WriteAllText, which creates the file before writing its content. The E2E test returns the first successful read of the marker, so it could observe an empty file and fail /^ready:\d+$/. Write to a temporary file and rename it into place. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 21932Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 21932" |
Tests selector0 / 101 PR test projects · 2 PR jobs, from 2 changed files. Selected PR test projects (0 / 101)none — no PR-gated .NET test projects run for this change. Selected PR jobs (2)
How these were chosen — grouped by what changedJob reasons
Selection computed for commit |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change to publish the readiness marker through a temporary file and rename.
No open issues 🎉
What changed in this PR
Fixes an empty-file race in the VS Code WinUI E2E fixture’s readiness marker without changing polling, assertions, or timeouts.
Changes:
- Writes the complete
ready:<pid>marker to a temporary file, then renames it into place. - Updates the existing unit test to require the write-then-rename pattern and reject direct marker writes.
| File | Description |
|---|---|
extension/src/test/e2eLaunchProfile.test.ts |
Checks that the fixture uses atomic marker publication. |
extension/scripts/run-e2e.js |
Publishes the WinUI readiness marker through a temporary file and rename. |
Review effort: Balanced
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
[automated] Validation report for PR #21932 Disposition: supported for the empty-marker failure; no additional CI run is warranted by the evidence gathered. This is an inspection of existing execution evidence, not a new test run or Revision and scope
Original failure: verified from primary evidenceThe original Windows WinUI job, attempt 1 That job checked out merge commit The original diagnostics artifact
The reader in CI merge-checkout execution: verified, not inferred from green checksThe two Windows jobs below checked out merge commit
The WinUI log explicitly shows Its retained Mocha result independently confirms execution without a test retry. The passing E2E source checks the full Execution environment recorded in the job: Windows x64, VS Code Existing CI commands and outcomes, not commands newly executed by this assignment:
The unit command also ran compilation and lint. Webpack reported four warnings; Routing and failure preventionThe existing The updated unit test would fail if the writer reverted to a direct For the platform implementation, the .NET 10 Limits and CI admission
Evidence sources
Logs were retrieved through Evidence copies are retained in session storage. No repository file was changed, -- AnkitAgent |
Ankit Jain (radical)
left a comment
There was a problem hiding this comment.
[automated] Looks good to me. Writing to a sibling temporary file and moving it into place after the write completes closes the empty-read window in this single-writer test fixture.
One precision on “atomic”: I’d describe this as preventing readers from seeing a partially written marker, rather than as a universal atomicity guarantee. On Windows, .NET’s File.Move uses MoveFileExW (.NET implementation, Windows API documentation). The same-directory move is appropriate here, but this doesn’t imply crash durability or multi-writer coordination.
No blocking issues found; one non-blocking clarification on atomicity scope.
|
✅ No documentation update needed. Proven false positive; skipped (docs_optional → test_only / build_or_ci_only).
|
…n empty file (#21932) **What failed:** `[vscode] Aspire WinUI debug E2E > debugs an unpackaged WinUI project through its generated apphost executable` failed on attempt 1 in [42448442647](https://github.com/microsoft/aspire/actions/runs/42448442647/job/128635064936) (tracker #21600, unowned rank 1): ``` AssertionError [ERR_ASSERTION]: The input did not match the regular expression /^ready:\d+$/. Input: '' ``` **Why:** The generated WinUI fixture app wrote its ready marker with `File.WriteAllText(readyFile, …)`. That call creates the file before it writes the content. `waitForReadyMarker` polls for the file and returns its first successful read, so a poll that landed in that gap returned `''` and failed the assertion. The app had started correctly; the test read the file before the content was written. **How fixed:** The fixture app (`extension/scripts/run-e2e.js`) now writes `ready:<pid>` to `<marker>.tmp` and then `File.Move(…, overwrite: true)` renames it into place. Because the rename is atomic, the marker path is either missing or holds the full content, so the test's first read is always complete. The assertion, timeouts and polling are unchanged. The existing `e2eLaunchProfile` unit test now checks for the atomic write and rejects a direct `File.WriteAllText(readyFile, …)`. ## Failure stats (14d, attempt 1) | Scope | Attempt-1 test failures / runs where the job executed | Rate | Passed on rerun | |---|---|---|---| | PR | 4 / 457 | 0.9% | 4 / 4 | | main | 0 / 99 | 0% | n/a | Main over 30 days: 0 test-level failures in 216 runs (0 / 99 in the last 14d plus 0 / 117 in the 16 days before). This job had 9 other attempt-1 failures that never reached the test and are excluded: 8 were "hosted runner lost communication" and 1 was an `aspire-extension` artifact download failure. Test-level failures (all four): - [42448442647](https://github.com/microsoft/aspire/actions/runs/42448442647/job/128635064936) (PR #21921, unrelated Java debug change): `The input did not match the regular expression /^ready:\d+$/. Input: ''` ← **fixed by this PR** - [42257446455](https://github.com/microsoft/aspire/actions/runs/42257446455/job/128037952447) (PR branch `aspireagent/fix-e2e-notification-dismiss-hover-race`): `Timed out after 120000ms waiting for the C# language server to resolve generated InitializeComponent … Last definitions: []` (the `tree-actions` shard also failed in the same attempt) - [41532732531](https://github.com/microsoft/aspire/actions/runs/41532732531/job/125585902027) (PR #20950): `Timed out after 240000ms waiting for the WinUI OnLaunched marker.` AppHost hosting startup took 1m42s, and 4 other Windows shards failed in the same attempt. - [41501727353](https://github.com/microsoft/aspire/actions/runs/41501727353/job/125481870825) (PR #21183): `The C# definition probe for InitializeComponent … Timed out after 129ms waiting for E2E control revision`. `dotnet --list-runtimes` took 53s, Roslyn never started, and 6 other shards failed in the same attempt. All four are genuine flakes, not caused by their PRs. The last three come from whole-runner slowness on Windows, which is tracked in #21570 with telemetry in #21644. This PR does not address them because fixing them would mean raising timeouts. **Local regression evidence:** A harness ran the fixture's exact before/after C# writer against a Node reader that uses `waitForReadyMarker`'s semantics (first successful read is asserted against `/^ready:\d+$/`), polling tightly, with 500 marker publications per run: - Before (`File.WriteAllText(readyFile, …)`): **10/10 runs** saw an empty marker (475–496 torn first reads out of about 500 per run). - After (write `.tmp`, then `File.Move` with `overwrite: true`): **0/10 runs** saw an empty marker (0 torn reads out of about 4,980 publications). The harness ran on Linux. On Windows, `File.Move(overwrite: true)` maps to `MoveFileEx(MOVEFILE_REPLACE_EXISTING)` within the same directory, which is also atomic for readers. **PR CI** ([run 42472017876](https://github.com/microsoft/aspire/actions/runs/42472017876)): `VS Code extension E2E (Windows, winui-debug)` and the Windows extension unit tests (including the updated `e2eLaunchProfile` test) passed on attempt 1. Three unrelated jobs failed on attempt 1: a GitHub 'Unicorn' outage while downloading Deno in `launch-profiles`, and the known `tree-actions` flakes (`Expected e2e-worker to expose an endpoint URL`, addressed by #21914; `Timed out … waiting for running AppHost` on Linux). After reruns, all 70 checks pass. **Verdict: MODERATE.** The fixed race is proven deterministically (10/10 → 0/10) and matches the newest failure's exact signature. However, it accounts for only 1 of the 4 attempt-1 test failures in 14d. The other 3 belong to the Windows runner-slowness family in #21570. ## Confidence High that this removes the empty-marker failure mode: the gap is inherent to `File.WriteAllText` and the reader returns on its first read. Low that it changes the C# language server / OnLaunched timeout failures, which this PR does not target. **How we stop this recurring:** Fixture processes that publish readiness files for E2E polling should write a temp file and rename it into place. The unit test now enforces this for the WinUI marker. ## Checklist - Is this feature complete? - [x] Yes. Ready to ship. - [ ] No. Follow-up changes expected. - Are you including unit tests for the changes and scenario tests if relevant? - [x] Yes - [ ] No - Did you add public API? - [ ] Yes - [x] No - Does the change make any security assumptions or guarantees? - [ ] Yes - [x] No **🤖 Posted by AspireAgent (AI Agent)** Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 8f00c66)
…n empty file (#21932) **What failed:** `[vscode] Aspire WinUI debug E2E > debugs an unpackaged WinUI project through its generated apphost executable` failed on attempt 1 in [42448442647](https://github.com/microsoft/aspire/actions/runs/42448442647/job/128635064936) (tracker #21600, unowned rank 1): ``` AssertionError [ERR_ASSERTION]: The input did not match the regular expression /^ready:\d+$/. Input: '' ``` **Why:** The generated WinUI fixture app wrote its ready marker with `File.WriteAllText(readyFile, …)`. That call creates the file before it writes the content. `waitForReadyMarker` polls for the file and returns its first successful read, so a poll that landed in that gap returned `''` and failed the assertion. The app had started correctly; the test read the file before the content was written. **How fixed:** The fixture app (`extension/scripts/run-e2e.js`) now writes `ready:<pid>` to `<marker>.tmp` and then `File.Move(…, overwrite: true)` renames it into place. Because the rename is atomic, the marker path is either missing or holds the full content, so the test's first read is always complete. The assertion, timeouts and polling are unchanged. The existing `e2eLaunchProfile` unit test now checks for the atomic write and rejects a direct `File.WriteAllText(readyFile, …)`. ## Failure stats (14d, attempt 1) | Scope | Attempt-1 test failures / runs where the job executed | Rate | Passed on rerun | |---|---|---|---| | PR | 4 / 457 | 0.9% | 4 / 4 | | main | 0 / 99 | 0% | n/a | Main over 30 days: 0 test-level failures in 216 runs (0 / 99 in the last 14d plus 0 / 117 in the 16 days before). This job had 9 other attempt-1 failures that never reached the test and are excluded: 8 were "hosted runner lost communication" and 1 was an `aspire-extension` artifact download failure. Test-level failures (all four): - [42448442647](https://github.com/microsoft/aspire/actions/runs/42448442647/job/128635064936) (PR #21921, unrelated Java debug change): `The input did not match the regular expression /^ready:\d+$/. Input: ''` ← **fixed by this PR** - [42257446455](https://github.com/microsoft/aspire/actions/runs/42257446455/job/128037952447) (PR branch `aspireagent/fix-e2e-notification-dismiss-hover-race`): `Timed out after 120000ms waiting for the C# language server to resolve generated InitializeComponent … Last definitions: []` (the `tree-actions` shard also failed in the same attempt) - [41532732531](https://github.com/microsoft/aspire/actions/runs/41532732531/job/125585902027) (PR #20950): `Timed out after 240000ms waiting for the WinUI OnLaunched marker.` AppHost hosting startup took 1m42s, and 4 other Windows shards failed in the same attempt. - [41501727353](https://github.com/microsoft/aspire/actions/runs/41501727353/job/125481870825) (PR #21183): `The C# definition probe for InitializeComponent … Timed out after 129ms waiting for E2E control revision`. `dotnet --list-runtimes` took 53s, Roslyn never started, and 6 other shards failed in the same attempt. All four are genuine flakes, not caused by their PRs. The last three come from whole-runner slowness on Windows, which is tracked in #21570 with telemetry in #21644. This PR does not address them because fixing them would mean raising timeouts. **Local regression evidence:** A harness ran the fixture's exact before/after C# writer against a Node reader that uses `waitForReadyMarker`'s semantics (first successful read is asserted against `/^ready:\d+$/`), polling tightly, with 500 marker publications per run: - Before (`File.WriteAllText(readyFile, …)`): **10/10 runs** saw an empty marker (475–496 torn first reads out of about 500 per run). - After (write `.tmp`, then `File.Move` with `overwrite: true`): **0/10 runs** saw an empty marker (0 torn reads out of about 4,980 publications). The harness ran on Linux. On Windows, `File.Move(overwrite: true)` maps to `MoveFileEx(MOVEFILE_REPLACE_EXISTING)` within the same directory, which is also atomic for readers. **PR CI** ([run 42472017876](https://github.com/microsoft/aspire/actions/runs/42472017876)): `VS Code extension E2E (Windows, winui-debug)` and the Windows extension unit tests (including the updated `e2eLaunchProfile` test) passed on attempt 1. Three unrelated jobs failed on attempt 1: a GitHub 'Unicorn' outage while downloading Deno in `launch-profiles`, and the known `tree-actions` flakes (`Expected e2e-worker to expose an endpoint URL`, addressed by #21914; `Timed out … waiting for running AppHost` on Linux). After reruns, all 70 checks pass. **Verdict: MODERATE.** The fixed race is proven deterministically (10/10 → 0/10) and matches the newest failure's exact signature. However, it accounts for only 1 of the 4 attempt-1 test failures in 14d. The other 3 belong to the Windows runner-slowness family in #21570. ## Confidence High that this removes the empty-marker failure mode: the gap is inherent to `File.WriteAllText` and the reader returns on its first read. Low that it changes the C# language server / OnLaunched timeout failures, which this PR does not target. **How we stop this recurring:** Fixture processes that publish readiness files for E2E polling should write a temp file and rename it into place. The unit test now enforces this for the WinUI marker. ## Checklist - Is this feature complete? - [x] Yes. Ready to ship. - [ ] No. Follow-up changes expected. - Are you including unit tests for the changes and scenario tests if relevant? - [x] Yes - [ ] No - Did you add public API? - [ ] Yes - [x] No - Does the change make any security assumptions or guarantees? - [ ] Yes - [x] No **🤖 Posted by AspireAgent (AI Agent)** Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> (cherry picked from commit 8f00c66)
#21938) ## Description **What failed:** `[vscode] Aspire Blazor browser debugger E2E > hits a managed breakpoint for hosted-global` in **VS Code extension E2E (Windows, browser-debugger)**, on main in run [42413925421](https://github.com/microsoft/aspire/actions/runs/42413925421) ([job](https://github.com/microsoft/aspire/actions/runs/42413925421/job/128531739772)) and on a PR branch in run [42312596518](https://github.com/microsoft/aspire/actions/runs/42312596518) ([job](https://github.com/microsoft/aspire/actions/runs/42312596518/job/128225566096)). The test reported only the masked bridge error `Failed to apply E2E control revision …: E2E control command failed.` **Why:** `hosted-global` is the only Blazor scenario that uses `closeMode: 'natural'`. The proof continues the breakpoint, asks js-debug for its CDP proxy and sends `Page.close` over that socket. The js-debug traces in both failing runs' diagnostics artifacts (`blazor-debugadapter-*.json`, `proxyActivity`) show the page target detaching before the browser answered. js-debug v1.117.0's `CDPSession._onClose` ([connection.ts#L385-L388](https://github.com/microsoft/vscode-js-debug/blob/v1.117.0/src/cdp/connection.ts#L385-L388)) rejects the pending call with `setCause(0, 'Connection is closed')`, and the proxy (`sendOrDie`) relays it to the client as `{"id":1,"error":{"code":0,"message":"Connection is closed"}}`, keeping the proxy socket open. Passing runs get `{"id":1,"result":{}}`. `closeBrowserPageThroughCdp` already accepted a socket *close* after `Page.close` as "target gone", but treated this equivalent error reply as `Browser CDP Page.close failed`, which fails the proof even though the page, Mono and root sessions then terminate normally (they do in both traces). **Fix:** `closeBrowserPageThroughCdp` now treats the js-debug target-closed reply (`code === 0 && message === 'Connection is closed'`) the same as the socket-close case. This doesn't weaken the proof: the caller still requires every proof session (root, browser, managed) to terminate and `debug-in-browser` to return to `Enabled`. Any other `Page.close` error (e.g. `-32601 Method not found`) still fails. **Regression tests** (`extension/src/test/e2eStateFileBridge.test.ts`, run against the real `executeE2eControlCommand` product path): - `accepts target disconnection (target-closed reply) during Page.close only after all proof sessions terminate`: the CI failure, which fails without the fix with the exact CI error `Browser CDP Page.close failed: {"code":0,"message":"Connection is closed"}`. - `rejects a target-closed Page.close reply while a proof session remains active`: shows the reply is not a bypass, because the proof still fails if the managed session stays alive. - The existing socket-close case is kept, parametrized alongside the new one. Dedupe: no open issue or PR covers `hosted-global`. #21912 covers a different browser-debugger failure (the `maps managed Edge debugging` before-all hook CLI `--version` probe), and none of the AspireAgent PRs #21911–#21932 touch this test. Tracker: #21600. ## Confidence Paired local runs of `e2eStateFileBridge.test.js` under VS Code 1.131.0 (`vscode-test`, xvfb), same machine and commit, toggling only the product change: | | runs green | per-run result | |---|---|---| | before (fix reverted, new tests kept) | **0/10** | 61 passing, 2 failing (the two new tests, with the CI error) | | after | **10/10** | 63 passing, 0 failing | `yarn lint` and `yarn compile-tests` pass. This is a test-harness change only (`extension/src/testing`), so there's no product behavior change and no E2E behavior evidence beyond the CI `browser-debugger` shards on this PR. ## Failure stats (14d, attempt 1) Window 2026-10-25 12:00 → 2026-11-08 12:00 UTC, `ci.yml`, attempt-1 jobs only. The denominator is decided attempt-1 runs (same definition as #21600). Hits are verified from each failed `VS Code extension E2E (Windows, browser-debugger)` job's mocha failure line (48 failed jobs scanned over 30d). - **This signature** (`hits a managed breakpoint for hosted-global` → `Page.close` target-closed reply): **3/1157** decided runs, **2 main / 1 PR** (main 2/160, PR 1/997). - **Any `hosted-global` failure:** 4/1157. The extra one (run 40728167754) is a different cause, `Timed out after 300000ms waiting for browser navigation to 'counter'`, which this PR does **not** claim to fix. - **30d main:** **2** verified hits (both are in the 14d window). Six older or other main browser-debugger failures had expired or unavailable logs and could not be classified. - The two newest failures show only the masked `E2E control command failed.`; the js-debug traces in their diagnostics artifacts show the `{"code":0,"message":"Connection is closed"}` proxy reply. The 10-28 main failure predates the masking and prints the exact error. | Run | Date (UTC) | Branch | Job | Error | |---|---|---|---|---| | [42413925421](https://github.com/microsoft/aspire/actions/runs/42413925421) | 11-07 21:02 | main | [128531739772](https://github.com/microsoft/aspire/actions/runs/42413925421/job/128531739772) | masked; trace shows target-closed reply | | [42312596518](https://github.com/microsoft/aspire/actions/runs/42312596518) | 11-06 23:32 | PR (eerhardt-dashboard-authorize-anonymous-pages) | [128225566096](https://github.com/microsoft/aspire/actions/runs/42312596518/job/128225566096) | masked; trace shows target-closed reply | | [40606196498](https://github.com/microsoft/aspire/actions/runs/40606196498) | 10-28 00:02 | main | [122561450397](https://github.com/microsoft/aspire/actions/runs/40606196498/job/122561450397) | `Browser CDP Page.close failed: {"code":0,"message":"Connection is closed"}` | | [40728167754](https://github.com/microsoft/aspire/actions/runs/40728167754) | 10-28 16:39 | PR (native-bundle-continuation) | [122971965889](https://github.com/microsoft/aspire/actions/runs/40728167754/job/122971965889) | different cause: navigation timeout (not addressed) | ## Verdict **STRONG**: the failure was reproduced deterministically through the product code path, and the before-fix run fails with the exact CI error string (0/10 → 10/10). js-debug traces from both recent failures and the unmasked 10-28 main error point to the same cause. The frequency is low (3/1157), so CI alone will take time to confirm the absence of hits. This PR's own CI (head `bbb5a79f`) was green on both `browser-debugger` shards on attempt 1. The attempt-1 rerun was only for the unrelated `tree-actions` flake (#21796, fix in #21914). **How we stop this recurring:** CDP proxy transport outcomes after `Page.close` (socket close *or* js-debug's target-closed reply) are now classified in one place, `isCdpProxyTargetClosedError`, with unit tests pinning both forms. The proof's real gate stays session termination plus command reset, so future js-debug transport variations can't silently mask a real leak. ## Checklist - Is this feature complete? - [x] Yes. Ready to ship. - [ ] No. Follow-up changes expected. - Are you including unit tests for the changes and scenario tests if relevant? - [x] Yes - [ ] No - Did you add public API? - [ ] Yes - [x] No - Does the change make any security assumptions or guarantees? - [ ] Yes - [x] No **🤖 Posted by AspireAgent (AI Agent)** Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
What failed:
[vscode] Aspire WinUI debug E2E > debugs an unpackaged WinUI project through its generated apphost executablefailed on attempt 1 in 42448442647 (tracker #21600, unowned rank 1):Why: The generated WinUI fixture app wrote its ready marker with
File.WriteAllText(readyFile, …). That call creates the file before it writes the content.waitForReadyMarkerpolls for the file and returns its first successful read, so a poll that landed in that gap returned''and failed the assertion. The app had started correctly; the test read the file before the content was written.How fixed: The fixture app (
extension/scripts/run-e2e.js) now writesready:<pid>to<marker>.tmpand thenFile.Move(…, overwrite: true)renames it into place. Because the rename is atomic, the marker path is either missing or holds the full content, so the test's first read is always complete. The assertion, timeouts and polling are unchanged. The existinge2eLaunchProfileunit test now checks for the atomic write and rejects a directFile.WriteAllText(readyFile, …).Failure stats (14d, attempt 1)
Main over 30 days: 0 test-level failures in 216 runs (0 / 99 in the last 14d plus 0 / 117 in the 16 days before). This job had 9 other attempt-1 failures that never reached the test and are excluded: 8 were "hosted runner lost communication" and 1 was an
aspire-extensionartifact download failure.Test-level failures (all four):
The input did not match the regular expression /^ready:\d+$/. Input: ''← fixed by this PRaspireagent/fix-e2e-notification-dismiss-hover-race):Timed out after 120000ms waiting for the C# language server to resolve generated InitializeComponent … Last definitions: [](thetree-actionsshard also failed in the same attempt)Timed out after 240000ms waiting for the WinUI OnLaunched marker.AppHost hosting startup took 1m42s, and 4 other Windows shards failed in the same attempt.The C# definition probe for InitializeComponent … Timed out after 129ms waiting for E2E control revision.dotnet --list-runtimestook 53s, Roslyn never started, and 6 other shards failed in the same attempt.All four are genuine flakes, not caused by their PRs. The last three come from whole-runner slowness on Windows, which is tracked in #21570 with telemetry in #21644. This PR does not address them because fixing them would mean raising timeouts.
Local regression evidence: A harness ran the fixture's exact before/after C# writer against a Node reader that uses
waitForReadyMarker's semantics (first successful read is asserted against/^ready:\d+$/), polling tightly, with 500 marker publications per run:File.WriteAllText(readyFile, …)): 10/10 runs saw an empty marker (475–496 torn first reads out of about 500 per run)..tmp, thenFile.Movewithoverwrite: true): 0/10 runs saw an empty marker (0 torn reads out of about 4,980 publications).The harness ran on Linux. On Windows,
File.Move(overwrite: true)maps toMoveFileEx(MOVEFILE_REPLACE_EXISTING)within the same directory, which is also atomic for readers.PR CI (run 42472017876):
VS Code extension E2E (Windows, winui-debug)and the Windows extension unit tests (including the updatede2eLaunchProfiletest) passed on attempt 1. Three unrelated jobs failed on attempt 1: a GitHub 'Unicorn' outage while downloading Deno inlaunch-profiles, and the knowntree-actionsflakes (Expected e2e-worker to expose an endpoint URL, addressed by #21914;Timed out … waiting for running AppHoston Linux). After reruns, all 70 checks pass.Verdict: MODERATE. The fixed race is proven deterministically (10/10 → 0/10) and matches the newest failure's exact signature. However, it accounts for only 1 of the 4 attempt-1 test failures in 14d. The other 3 belong to the Windows runner-slowness family in #21570.
Confidence
High that this removes the empty-marker failure mode: the gap is inherent to
File.WriteAllTextand the reader returns on its first read. Low that it changes the C# language server / OnLaunched timeout failures, which this PR does not target.How we stop this recurring: Fixture processes that publish readiness files for E2E polling should write a temp file and rename it into place. The unit test now enforces this for the WinUI marker.
Checklist
🤖 Posted by AspireAgent (AI Agent)