Skip to content

[release/17.0] Bump main to Aspire 17.1 and align release milestones - #22003

Closed
Mitch Denny (mitchdenny) wants to merge 1 commit into
mitchdenny-backport-17-0-05-pr21823from
mitchdenny-backport-17-0-06-pr21850
Closed

Mitch Denny (mitchdenny) wants to merge 1 commit into
mitchdenny-backport-17-0-05-pr21823from
mitchdenny-backport-17-0-06-pr21850

Conversation

@mitchdenny

Copy link
Copy Markdown
Member

Description

Backport of #21850 to release/17.0 (cherry-picked from cb221bf with no modifications). Layer 6 of 55 in the release/17.0 backport stack; stacked on #22002.

Backport recommendation: No — main-specific 17.1 version bump.

Backport of #21850

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

## Description

With `release/17.0` branched for the upcoming release, `main` now
represents the 17.1 development cycle. This PR advances the product
version from 17.0.0 to 17.1.0 and aligns automatic milestone assignment
with those branches.

- Bump `MinorVersion` to `1` in `eng/Versions.props`, preserving
`preview.1` and `StabilizePackageVersion=false`.
- Assign milestone `17.1` to PRs merged into `main`.
- Add a merged-only rule for `release/17.0` that removes any
carried-over milestone before assigning `17.0`. Leave the existing
`release/13.6` rule unchanged.
- Enable the existing dashboard-image override at `17.0`, as requested,
because the nightly registry currently serves `17.0` but not `17.1`.
Remove this override once the `17.1` image is published so generated
Docker Compose and Kubernetes deployments can follow the product version
again.

Milestone assignment is handled by
`.github/policies/milestoneAssignment.prClosed.yml`; the old
milestone-assignment workflow was already removed, so no GitHub Actions
workflow changes are needed. Both target GitHub milestones exist and are
open. This changes future milestone assignment only; it does not retag
existing issues or PRs.

### Validation

- `.\restore.cmd` — passed.
- `dotnet run --file .agents\skills\bump-aspire-version\BumpVersion.cs
-- 17.1 --branch main --milestone 17.1` — passed; rerunning reported
both files unchanged. The initial run emitted the existing SDK
ILCompiler advisory NU1903.
- `dotnet msbuild eng\Versions.props -nologo
-getProperty:MajorVersion,MinorVersion,PatchVersion,VersionPrefix,PreReleaseVersionLabel,StabilizePackageVersion,AspireDashboardImageTag`
— passed; evaluated `17.1.0`, `preview.1`, `false`, and dashboard image
`17.0`.
- `git diff --check` — passed.
- Direct policy-rule checks — passed for `main -> 17.1`, `release/17.0
-> 17.0`, and unchanged `release/13.6 -> 13.6`; verified merged guards
for main and release/17.0 and milestone replacement for release/17.0.
- `curl.exe --silent --show-error --output NUL --write-out '17.1:
%{http_code}\n'
https://mcr.microsoft.com/v2/aspire/nightly/dashboard/manifests/17.1` —
returned HTTP 404.
- `curl.exe --silent --show-error --output NUL --write-out '17.0:
%{http_code}\n'
https://mcr.microsoft.com/v2/aspire/nightly/dashboard/manifests/17.0` —
returned HTTP 200.

No full build or unit/scenario tests were run for this metadata-only
change. Live policy-bot execution will occur after the policy update is
merged.

Fixes # (issue)

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [ ] Yes
  - [x] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit cb221bf)
@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

Selects the full PR test matrix + all PR-gated jobs (ALL) — a rule matching 'eng/Versions.props' selects ALL


Selection computed for commit 487af5a.

@eerhardt

Copy link
Copy Markdown
Member

this should NOT go into release/17.0.Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants