Skip to content

[release/17.0] Add Go AppHost editor support and debugger readiness coverage - #22103

Merged
Jose Perez Rodriguez (joperezr) merged 3 commits into
release/17.0from
backport/pr-21826-to-release/17.0
Nov 11, 2026
Merged

Jose Perez Rodriguez (joperezr) merged 3 commits into
release/17.0from
backport/pr-21826-to-release/17.0

Conversation

@aspire-repo-bot

@aspire-repo-bot aspire-repo-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #21826 to release/17.0

/cc David Pine (@IEvangelist)

Description

Standalone backport of Go AppHost editor support and debugger readiness coverage. Targets release/17.0 directly; the old chained backport #21999 is left untouched.

Relates to #21201, #21213, #21114, and #21115. Does not close their remaining work.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Customer Impact

Go AppHosts gain resource editor navigation and reliable debugger setup/cancellation without duplicate launch errors. Nested and parenthesized Go resource expressions retain their declaration anchors. The missing-debugger setup flow also covers Java and Rust.

Testing

Backport verification: the aggregate diff has the same stable patch ID as merged source commit 54b4929a235f9684a1dab460bbcd59f4f08412e1: 369fc10e9a8193a8b382adb9f0a1fb6b1790390d. The PR targets release/17.0 directly and has no native stack membership.

Source-PR validation, not rerun locally on this backport:

corepack yarn unit-test --run out/test/appHostLaunchService.test.js --run out/test/appHostTreeView.test.js --run out/test/cliSpawn.test.js --timeout 120000

Passed: 463 tests / 2 pending. Source CI also verified real Go AppHost/resource breakpoints and missing-debugger cancellation on Linux and Windows; see source validation run. The source Windows full unit suite passed 4151 tests / 9 pending. The source PR documents earlier failed runs separately.

No local release-branch tests were rerun. Release-branch CI was pending when this section was written; this is not a claim that backport CI has passed.

Risk

Medium. Touches shared extension launch handling and test routing as well as Go editor parsing; source unit and cross-platform debugger coverage exercise those paths.

Regression?

Unknown. The source PR does not identify a released-version regression.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 22103

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 22103"

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

1 / 101 PR test projects · 2 PR jobs, from 25 changed files.

Selected PR test projects (1 / 101)

Infrastructure.Tests

Selected PR jobs (2)

extension-e2e, extension-unit


How these were chosen — grouped by what changed

📄 .github/workflows/extension-e2e-tests.yml (changed)
→ 1 directly: Infrastructure.Tests

📄 eng/github-ci/test-trigger-map.yml (changed)
→ 1 directly: Infrastructure.Tests

🧪 tests/Infrastructure.Tests/TestTriggerMap/TestTriggerMapTests.cs (changed test)
→ 1 directly: Infrastructure.Tests

Job reasons

Job Triggered by
extension-e2e .github/workflows/extension-e2e-tests.yml, extension/loc/xlf/aspire-vscode.xlf, extension/package.nls.json, extension/src/debugger/AspireDebugConfigurationProvider.ts, extension/src/debugger/debuggerInstallHints.ts, extension/src/editor/AspireCodeLensProvider.ts, extension/src/editor/AspireGutterDecorationProvider.ts, extension/src/editor/parsers/AppHostResourceParser.ts, extension/src/editor/parsers/goAppHostParser.ts, extension/src/editor/parsers/plainTextInactiveOffsets.ts, extension/src/loc/strings.ts, extension/src/services/AppHostLaunchService.ts, extension/src/test-e2e/resourceDebugTools.e2e.test.ts, extension/src/test-e2e/treeActions.e2e.test.ts, extension/src/test/appHostLaunchService.test.ts, extension/src/test/appHostTreeView.test.ts, extension/src/test/aspireCodeLensProvider.test.ts, extension/src/test/aspireDebugConfigurationProvider.test.ts, extension/src/test/aspireDebugSession.test.ts, extension/src/test/goAppHostParser.test.ts, extension/src/test/parsers.test.ts, extension/src/test/rpc/interactionServiceTests.test.ts, extension/src/testing/e2eStateFileBridge.ts
extension-unit .github/workflows/extension-e2e-tests.yml, extension/loc/xlf/aspire-vscode.xlf, extension/package.nls.json, extension/src/debugger/AspireDebugConfigurationProvider.ts, extension/src/debugger/debuggerInstallHints.ts, extension/src/editor/AspireCodeLensProvider.ts, extension/src/editor/AspireGutterDecorationProvider.ts, extension/src/editor/parsers/AppHostResourceParser.ts, extension/src/editor/parsers/goAppHostParser.ts, extension/src/editor/parsers/plainTextInactiveOffsets.ts, extension/src/loc/strings.ts, extension/src/services/AppHostLaunchService.ts, extension/src/test-e2e/resourceDebugTools.e2e.test.ts, extension/src/test-e2e/treeActions.e2e.test.ts, extension/src/test/appHostLaunchService.test.ts, extension/src/test/appHostTreeView.test.ts, extension/src/test/aspireCodeLensProvider.test.ts, extension/src/test/aspireDebugConfigurationProvider.test.ts, extension/src/test/aspireDebugSession.test.ts, extension/src/test/goAppHostParser.test.ts, extension/src/test/parsers.test.ts, extension/src/test/rpc/interactionServiceTests.test.ts, extension/src/testing/e2eStateFileBridge.ts

Selection computed for commit ff7d41e.

@joperezr
Jose Perez Rodriguez (joperezr) merged commit 1a70952 into release/17.0 Nov 11, 2026
100 checks passed
@aspire-repo-bot

Copy link
Copy Markdown
Contributor Author

✅ No documentation update needed.

excluded → head_branch_is_backport, title_release_prefix, body_backport_marker (base is release/17.0, title prefixed [release/17.0]). Triggered signals: pr_body_has_cli_flag_mention (a test command in the PR body, not user-facing). Docs belong to the original forward PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants