Skip to content

[release/17.0] Complete Go starter validation and polyglot scenario readiness - #22104

Merged
Jose Perez Rodriguez (joperezr) merged 4 commits into
release/17.0from
backport/pr-21828-to-release/17.0
Nov 11, 2026
Merged

Jose Perez Rodriguez (joperezr) merged 4 commits into
release/17.0from
backport/pr-21828-to-release/17.0

Conversation

@aspire-repo-bot

@aspire-repo-bot aspire-repo-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #21828 to release/17.0

/cc David Pine (@IEvangelist)

Description

Standalone backport of Go starter validation and polyglot scenario readiness. Targets release/17.0 directly; the old chained backport #22007 is left untouched.

Relates to #21202, #21206, #21209, #21210, #21201, and #21108. Does not close their remaining work.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Customer Impact

Go starters ship tidy API dependencies without requiring the first run to repair them, honor Redis exclusion, and gain native starter and polyglot scenario coverage. Cache-free starters can run without a Docker daemon.

Testing

Backport verification: the aggregate diff has the same stable patch ID as merged source commit 5138b2a86ab20b3834b01983382a8b478d6b6a39: 654ff923aac88d60791888affc4885c77b0c09c6. The PR targets release/17.0 directly and has no native stack membership.

Source-PR validation, not rerun locally on this backport:

dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class '*.NewCommandTemplateConfigPersistenceTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Passed: 59 tests, including default/true/false Redis scaffold choices. Source packaged CI passed both Redis choices in GoStarterReadinessTests and all six native starter lanes. The source local Redis readiness run timed out; only the cache-free local case passed, so local Redis validation is not claimed green.

No local release-branch tests were rerun. Release-branch CI was pending when this section was written; this is not a claim that backport CI has passed.

Risk

Medium. Changes starter scaffolding and shared CI/scenario validation, including runtime-only test-selection edges and stabilization smoke coverage.

Regression?

Unknown. The source PR does not identify a regressing release.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Honor the existing Redis opt-out for Go without changing its default. Keep Linux Redis readiness and exercise both generated starter variants. Restore the TypeScript SDK before snapshotting cache metadata.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 22104

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 22104"

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

4 / 101 PR test projects · 4 PR jobs, from 37 changed files.

Selected PR test projects (4 / 101)

Aspire.Cli.EndToEnd.Tests, Aspire.Cli.Tests, Aspire.Hosting.CodeGeneration.Go.Tests, Infrastructure.Tests

Selected PR jobs (4)

cli-starter-validation, extension-e2e, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

📦 affected project Aspire.Cli
→ 1 test: Aspire.Cli.EndToEnd.Tests

📄 .github/workflows/ci.yml (changed)
→ 1 directly: Infrastructure.Tests

📄 .github/workflows/cli-starter-validation.yml (changed)
→ 1 directly: Infrastructure.Tests

📄 .github/workflows/polyglot-validation/test-go-playground.sh (changed)
→ 1 directly: Infrastructure.Tests

📄 .github/workflows/polyglot-validation/test-go.sh (changed)
→ 1 directly: Infrastructure.Tests

📄 eng/github-ci/test-trigger-map.yml (changed)
→ 1 directly: Infrastructure.Tests

🔧 src/Aspire.Cli/Templating/Templates/go-starter/api/go.mod (changed source)
→ 1 via the project graph: Aspire.Hosting.CodeGeneration.Go.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/GoEmptyAppHostTemplateTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/GoKubernetesDeployTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/GoStarterReadinessTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/Helpers/CliE2EAutomatorHelpers.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/Helpers/KubernetesDeployTestHelpers.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/JavaCodegenValidationTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/JavaPolyglotApphostDirectoryTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/JavaPolyglotTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/JavaScriptPublishTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/KubernetesDeployTypeScriptTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/LocalConfigMigrationTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/SecretTypeScriptAppHostTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/TypeScriptCodegenValidationTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.EndToEnd.Tests/TypeScriptPublishTests.cs (changed test)
→ 1 directly: Aspire.Cli.EndToEnd.Tests

🧪 tests/Aspire.Cli.Tests/Commands/NewCommandTemplateConfigPersistenceTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandTemplateConfigPersistenceTests.GoStarterHonorsRedisChoice_choice=default.verified.go (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandTemplateConfigPersistenceTests.GoStarterHonorsRedisChoice_choice=false.verified.go (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Snapshots/NewCommandTemplateConfigPersistenceTests.GoStarterHonorsRedisChoice_choice=true.verified.go (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Infrastructure.Tests/TestTriggerMap/TestTriggerMapTests.cs (changed test)
→ 1 directly: Infrastructure.Tests

Job reasons

Job Triggered by
cli-starter-validation • .github/workflows/cli-starter-validation.yml, eng/scripts/cli-starter-validation.ps1
• affected project Aspire.Cli
extension-e2e • src/Aspire.Cli/Templating/CliTemplateFactory.GoStarterTemplate.cs, src/Aspire.Cli/Templating/CliTemplateFactory.cs, src/Aspire.Cli/Templating/Templates/go-starter/api/go.mod, src/Aspire.Cli/Templating/Templates/go-starter/api/go.sum, src/Aspire.Cli/Templating/Templates/go-starter/apphost.go, src/Aspire.Cli/Templating/Templates/go-starter/aspire.config.json
• affected project Aspire.Cli
polyglot • .github/workflows/polyglot-validation/test-go-playground.sh, .github/workflows/polyglot-validation/test-go.sh, tests/PolyglotAppHosts/Aspire.Hosting.EntityFrameworkCore/Go/apphost.go, tests/PolyglotAppHosts/Aspire.Hosting.EntityFrameworkCore/Go/aspire.config.json, tests/PolyglotAppHosts/Aspire.Hosting.EntityFrameworkCore/Go/go.mod, tests/PolyglotAppHosts/Aspire.Hosting.Foundry/Go/apphost.go, tests/PolyglotAppHosts/Aspire.Hosting/Go/apphost.go
• affected project Aspire.Cli
typescript-api-compat affected project Aspire.Cli

Selection computed for commit 4b8b174.

@joperezr
Jose Perez Rodriguez (joperezr) merged commit 54c1660 into release/17.0 Nov 11, 2026
226 checks passed
@aspire-repo-bot

Copy link
Copy Markdown
Contributor Author

✅ No documentation update needed.

excluded → base_branch_is_release, head_branch_is_backport, title_release_prefix, body_backport_marker. This is a backport of #21828 to release/17.0 (title prefixed [release/17.0]). Docs belong to the original forward PR. Triggered signals: pr_body_has_cli_flag_mention (weak, from the test command in the body).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants