Repository navigation
[release/17.0] Unify CLI source onboarding, presentation, and selection - #22112
Closed
Mitch Denny (mitchdenny) wants to merge 1 commit into
Closed
Mitch Denny (mitchdenny) wants to merge 1 commit into
Mitch Denny (mitchdenny) wants to merge 1 commit into
Conversation
(cherry picked from commit 4954c76) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Mitch Denny (mitchdenny)
requested review from
James Newton-King (JamesNK) and
David Fowler (davidfowl)
as code owners
November 10, 2026 23:26
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #21855 to
release/17.0, layer 3 of 4 in the requested backport stack. This PR targets parent #22111 (mitchdenny-backport-21883-to-17-0), not the release branch directly. Ultimate target:release/17.0.Stack order: #21831 (#22110) → #21883 (#22111) → #21855 (this PR) → #21852 (final quiet-Git layer forthcoming). Take the four layers as a set; this PR does not include the forthcoming quiet-Git patch.
Users get consistent source explanations, trust warnings, documentation links and source-aware template/integration selection. Native C# installation retains dependency feeds and existing package-source-mapping policy, including transactional rollback on failure.
Cherry-picked only source commit
4954c76a62bd091e0edbb02854c0dc2be06e64f5, with-xprovenance. Applied without conflicts; stable patch ID3cfbef28d4f8a064d7da78d58005081dde6b1ecbexactly matches the original. Parent verified unchanged atcb21675ee6951560134f1e2150fb88dbfe873af7before application and after validation. No new dependencies or public library APIs.Fixes # (issue)
User-facing usage
aspire new --use-config-source falsedeclines a proposed configuration source without fetching it. Organizations can setASPIRE_INIT_SOURCE_README_URLto an absolute HTTP(S) documentation URL. Configured source inventories appear inaspire new,aspire agent init, andaspire add.Verified help from this backport build:
Screenshots / Recordings
This exact backport changes CLI presentation. Original PR #21855 contains illustrative source-onboarding and picker screenshots; those are not live terminal captures of this backport. TODO: capture the release-stack build's configured-source onboarding, consent and multi-feed pickers for a live before/after comparison. No new screenshots or recordings were captured for this backport.
Validation
./restore.sh— passed, 0 warnings, 0 errors.MSBUILDTERMINALLOGGER=false ./dotnet.sh build tests/Aspire.Cli.EndToEnd.Tests/Aspire.Cli.EndToEnd.Tests.csproj --configuration Release --no-restore -p:SkipNativeBuild=true— passed, 0 warnings, 0 errors. Terminal E2E scenarios were not executed../dotnet.sh exec artifacts/bin/Aspire.Cli/Release/net11.0/aspire.dll new --help— passed.git diff HEAD^ HEAD --check— reports the same four intentional generated-snapshot EOF blank lines as the original patch; left unchanged to preserve exact output and patch identity. Worktree is clean after validation.Checklist
<remarks />and<code />elements on your triple slash comments?Customer Impact
Users working with organization-provided configuration, templates, skills and integrations receive consistent source details and trust notices, can distinguish identical packages from different feeds, and avoid native installation failures caused by treating feed aliases as paths or excluding SDK/dependency feeds.
Testing
Release-stack validation passed all 1,796 focused CLI tests and built the affected terminal E2E project with no warnings or errors. Help output was checked. Linux terminal E2E scenarios and authenticated demo workflows were not executed locally.
Risk
Medium: changes span source onboarding, interactive selection, package discovery and native NuGet configuration. Existing consent and package-source-mapping policy are retained, rollback paths are covered by focused tests, and the backported patch is identical to the merged original.
Regression?
Unknown — the source PR does not identify a specific regressing release or commit.