Skip to content

Graduate required-command custom validation to stable - #22157

Merged
Maddy Montaquila (maddymontaquila) merged 2 commits into
release/17.0from
maddymontaquila/stabilize-required-command-validation
Nov 15, 2026
Merged

Maddy Montaquila (maddymontaquila) merged 2 commits into
release/17.0from
maddymontaquila/stabilize-required-command-validation

Conversation

@maddymontaquila

@maddymontaquila Maddy Montaquila (maddymontaquila) commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Custom required-command validation can be consumed without opting into ASPIRECOMMAND001. This graduates the existing callback overload of WithRequiredCommand together with IRequiredCommandValidator, RequiredCommandAnnotation, RequiredCommandValidationContext, and RequiredCommandValidationResult; no APIs are deleted or renamed.

The contract remains advisory: missing commands or failed callback validation log warnings and allow resources to attempt startup. This is annotation-driven, run-time app-model validation, already used by .NET tool SDK validation. The startup subscriber awaits validation but does not block startup based on its result. The strengthened regression test verifies that a failed callback logs a warning and completes the startup event while its warning notification is still unanswered.

Removes only this contract's experimental attributes and directly related suppressions, documents the retired diagnostic and advisory semantics, and leaves generated api/* baselines untouched. No runtime behavior, export names, dependencies, or unrelated experimental contracts change. This PR proposes graduation; it does not assert prior maintainer approval.

Checked current main and open PRs for ASPIRECOMMAND001 and WithRequiredCommand; no overlapping graduation PR was found. After retargeting to release/17.0, replayed only the stabilization commit from its verified original-main fork point (793dfe6e254fe050af24cb7bcfba214066dcaab8) onto release commit 9a97ab889bfb731de74ead0280be279ffdd000bf. The release APIs already exist; no conflicts or release-specific adaptations were needed. git range-diff confirms the replayed patch is unchanged. The original replay contained one intended commit and 19 changed files, without unrelated main history. Subsequently merged release/17.0 at a509f094e0ee87d17dc0e1cc9bca84f7ca2623da, preserving both Deno and required-command graduation when resolving conflicts. Refreshed the generated Go/TypeScript documentation snapshots and scoped the advisory-warning regression assertion to the validator logger. Current PR scope: two commits and 21 changed files; generated API compatibility baselines remain untouched.

Original API contributors: cc David Fowler (@davidfowl), verified co-author with Copilot of the initial annotation and callback infrastructure, and Eric Erhardt (@eerhardt), who introduced the context/result callback contract and validator service, all in #11944. Attribution is based on the introducing commits, not the squash author or merge committer. These are mentions, not reviewer assignments.

User-facing usage

Existing callback-based validation no longer needs an ASPIRECOMMAND001 suppression:

builder.AddExecutable("worker", "my-tool", ".")
    .WithRequiredCommand("my-tool", context =>
        Task.FromResult(context.Success()));

Callbacks can return context.Failure("Install a supported tool version.") to report a warning without preventing a startup attempt.

Validation

Latest post-merge validation at 3d5f9c9a5229621c684b8081ae834bf12fd61954: 350 tests passed (complete TypeScript and Go code-generation suites plus focused Hosting, DevTunnels, and JavaScript tests). Exact commands and individual results are in the validation comment. Restore and release-relative diff checks also passed. The earlier release-replay results below are historical, not a substitute for this validation.

Release validation: rerun on macOS arm64 after replaying onto release/17.0, at head d50343937f6cfedf6256f15e40206ad912cab91f:

dotnet test --project tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj --no-launch-profile -- --filter-class '*.RequiredCommandAnnotationTests' --filter-class '*.DotnetToolResourceTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Result: passed, 30 tests, including advisory failure, notification non-blocking behavior, callback context/results, validation coalescing, and .NET SDK validation.

dotnet test --project tests/Aspire.Hosting.DevTunnels.Tests/Aspire.Hosting.DevTunnels.Tests.csproj --no-launch-profile -- --filter-class '*.DevTunnelCliVersionValidationTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Result: passed, 10 tests, exercising a dependent custom-validation consumer.

git diff --check

Result: passed. Both test commands also passed previously on the original main-based commit (30 and 10 tests respectively); those earlier results are separate from the release validation above. Full repository and remaining integration suites were not run.

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 22157

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 22157"

@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 11, 2026
@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot November 11, 2026 19:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the required-command validation API stabilization.

No open issues 🎉

What changed in this PR

Graduates Aspire Hosting’s existing custom required-command validation contract to stable without changing runtime behavior. Validation remains advisory: failures produce warnings but allow resources to attempt startup.

Changes:

  • Removes ASPIRECOMMAND001 attributes and related suppressions while leaving generated API baselines untouched.
  • Documents the retired diagnostic and advisory validation semantics.
  • Strengthens regression coverage to verify startup-event completion while a warning notification remains unanswered.
File Description
tests/​Aspire.Hosting.Tests/​RequiredCommandAnnotationTests.cs Verifies advisory failure and non-blocking notifications; removes suppression.
tests/​Aspire.Hosting.Tests/​DotnetToolResourceTests.cs Removes retired diagnostic suppression.
tests/​Aspire.Hosting.JavaScript.Tests/​RequiredCommandTests.cs Removes retired diagnostic suppression.
tests/​Aspire.Hosting.Go.Tests/​AddGoAppTests.cs Removes retired diagnostic suppression.
tests/​Aspire.Hosting.DotnetTool.Tests/​AddDotnetToolTests.cs Removes suppressions around annotation assertions.
tests/​Aspire.Hosting.DevTunnels.Tests/​DevTunnelResourceBuilderExtensionsTests.cs Removes retired diagnostic suppression.
tests/​Aspire.Hosting.DevTunnels.Tests/​DevTunnelCliVersionValidationTests.cs Removes retired diagnostic suppression.
tests/​Aspire.Hosting.Azure.Tests/​AzureFunctionsTests.cs Removes retired diagnostic suppression.
src/​Aspire.Hosting/​RequiredCommandResourceExtensions.cs Stabilizes the callback overload and removes related suppressions.
src/​Aspire.Hosting/​Lifecycle/​RequiredCommandValidationEventingSubscriber.cs Removes retired diagnostic suppression.
src/​Aspire.Hosting/​DistributedApplicationBuilder.cs Removes suppressions around validator registration.
src/​Aspire.Hosting/​ApplicationModel/​RequiredCommandValidator.cs Removes retired diagnostic suppression.
src/​Aspire.Hosting/​ApplicationModel/​RequiredCommandValidationResult.cs Stabilizes validation results and documents advisory failures.
src/​Aspire.Hosting/​ApplicationModel/​RequiredCommandValidationContext.cs Stabilizes the callback context.
src/​Aspire.Hosting/​ApplicationModel/​RequiredCommandAnnotation.cs Stabilizes the annotation and documents advisory failures.
src/​Aspire.Hosting/​ApplicationModel/​IRequiredCommandValidator.cs Stabilizes the validator interface.
src/​Aspire.Hosting.JavaScript/​JavaScriptHostingExtensions.cs Removes retired diagnostic suppression.
src/​Aspire.Hosting.DevTunnels/​DevTunnelResourceBuilderExtensions.cs Removes retired diagnostic suppression.
docs/​list-of-diagnostics.md Documents diagnostic retirement and unchanged advisory behavior.

Review effort: Balanced

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Retain advisory startup validation, graduate the related contract together, and remove obsolete diagnostic suppressions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

This comment has been minimized.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Removing the experimental attributes leaves the TypeScript documentation snapshot stale, causing a snapshot mismatch in TwoPassScanning_GeneratesWithEnvironmentOnTestRedisBuilder.

1 open issue

Review effort: Balanced

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Preserve the release branch's Deno stabilization while resolving diagnostic documentation and suppression conflicts. Refresh generated Go and TypeScript documentation snapshots for the stable callback contract and scope the advisory-warning assertion to its validator logger.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot
aspire-repo-bot Bot requested a balanced review from Copilot November 15, 2026 15:37
@maddymontaquila

Copy link
Copy Markdown
Collaborator Author

Resolved release/17.0 merge conflicts in 3d5f9c9, preserving both Deno graduation and this PR’s required-command graduation. Regenerated the affected TypeScript and Go snapshots, addressing the latest review finding, and fixed the advisory-warning regression test to select the RequiredCommandValidator logger rather than unrelated hosting warnings. No API baselines or runtime behavior changed.

Validation on macOS arm64 after the merge (all passed):

./restore.sh
# passed

dotnet test --project tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests.csproj --no-launch-profile -- --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
# passed: 156 tests

dotnet test --project tests/Aspire.Hosting.CodeGeneration.Go.Tests/Aspire.Hosting.CodeGeneration.Go.Tests.csproj --no-launch-profile -- --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
# passed: 137 tests

dotnet test --project tests/Aspire.Hosting.Tests/Aspire.Hosting.Tests.csproj --no-launch-profile -- --filter-class "*.RequiredCommandAnnotationTests" --filter-class "*.DotnetToolResourceTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
# passed: 30 tests

dotnet test --project tests/Aspire.Hosting.DevTunnels.Tests/Aspire.Hosting.DevTunnels.Tests.csproj --no-launch-profile -- --filter-class "*.DevTunnelCliVersionValidationTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
# passed: 10 tests

dotnet test --project tests/Aspire.Hosting.JavaScript.Tests/Aspire.Hosting.JavaScript.Tests.csproj --no-launch-profile -- --filter-class "*.RequiredCommandTests" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"
# passed: 17 tests

git diff origin/release/17.0 --check
# passed

Full repository suites were not run locally. New CI validation is required before merging; unrelated CLI staging-channel failures were not worked around in this PR.

🤖 AI-authored reply via Agency Finish PR.

@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

52 / 101 PR test projects · 4 PR jobs, from 20 changed files.

Selected PR test projects (52 / 101)

Aspire.Cli.EndToEnd.Tests, Aspire.Hosting.Analyzers.Tests, Aspire.Hosting.Azure.EntraId.Tests, Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Kusto.Tests, Aspire.Hosting.Azure.Provisioning.Tests, Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Browsers.Tests, Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.CodeGeneration.TypeScript.Tests, Aspire.Hosting.Containers.Tests, Aspire.Hosting.DevTunnels.Tests, Aspire.Hosting.Docker.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.DotnetTool.Tests, Aspire.Hosting.EntityFrameworkCore.Tests, Aspire.Hosting.Foundry.Tests, Aspire.Hosting.Garnet.Tests, Aspire.Hosting.Go.Tests, Aspire.Hosting.Java.Tests, Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Kafka.Tests, Aspire.Hosting.Keycloak.Tests, Aspire.Hosting.Kubernetes.Tests, Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests, Aspire.Hosting.MongoDB.Tests, Aspire.Hosting.MySql.Tests, Aspire.Hosting.Nats.Tests, Aspire.Hosting.OpenAI.Tests, Aspire.Hosting.Oracle.Tests, Aspire.Hosting.Orleans.Tests, Aspire.Hosting.PostgreSQL.Tests, Aspire.Hosting.Python.Tests, Aspire.Hosting.Qdrant.Tests, Aspire.Hosting.RabbitMQ.Tests, Aspire.Hosting.Radius.Tests, Aspire.Hosting.Redis.Tests, Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests, Aspire.Hosting.Seq.Tests, Aspire.Hosting.SqlServer.Tests, Aspire.Hosting.Testing.Tests, Aspire.Hosting.Tests, Aspire.Hosting.Valkey.Tests, Aspire.Hosting.Yarp.Tests, Aspire.Playground.Tests, Aspire.Templates.Tests

Selected PR jobs (4)

cli-starter-validation, extension-e2e, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

⚠️ 37 of the 52 selected test projects come from a single change — src/Aspire.Hosting/ApplicationModel/IRequiredCommandValidator.cs.

🔧 src/Aspire.Hosting/ApplicationModel/IRequiredCommandValidator.cs (changed source)
→ 37 via the project graph

show 37

Aspire.Hosting.Analyzers.Tests (2 hops), Aspire.Hosting.Azure.EntraId.Tests (2 hops), Aspire.Hosting.Azure.Kusto.Tests (2 hops), Aspire.Hosting.Azure.Provisioning.Tests (3 hops), Aspire.Hosting.Browsers.Tests (2 hops), Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.Containers.Tests (2 hops), Aspire.Hosting.Docker.Tests (2 hops), Aspire.Hosting.EntityFrameworkCore.Tests (2 hops), Aspire.Hosting.Foundry.Tests (2 hops), Aspire.Hosting.Garnet.Tests (2 hops), Aspire.Hosting.Java.Tests (2 hops), Aspire.Hosting.Kafka.Tests (2 hops), Aspire.Hosting.Keycloak.Tests (2 hops), Aspire.Hosting.Kubernetes.Tests (2 hops), Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests (2 hops), Aspire.Hosting.MongoDB.Tests (2 hops), Aspire.Hosting.MySql.Tests (2 hops), Aspire.Hosting.Nats.Tests (2 hops), Aspire.Hosting.OpenAI.Tests (2 hops), Aspire.Hosting.Oracle.Tests (2 hops), Aspire.Hosting.Orleans.Tests (2 hops), Aspire.Hosting.PostgreSQL.Tests (2 hops), Aspire.Hosting.Python.Tests (2 hops), Aspire.Hosting.Qdrant.Tests (2 hops), Aspire.Hosting.RabbitMQ.Tests (2 hops), Aspire.Hosting.Redis.Tests (2 hops), Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests (2 hops), Aspire.Hosting.Seq.Tests (2 hops), Aspire.Hosting.SqlServer.Tests (2 hops), Aspire.Hosting.Testing.Tests (2 hops), Aspire.Hosting.Valkey.Tests (2 hops), Aspire.Hosting.Yarp.Tests (2 hops)

🧪 tests/Aspire.Hosting.Tests/DotnetToolResourceTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests
→ 3 via the project graph: Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.Radius.Tests

📦 affected project Aspire.Hosting.Dotnet
→ 2 tests: Aspire.Cli.EndToEnd.Tests, Aspire.Templates.Tests

🔧 src/Aspire.Hosting.JavaScript/JavaScriptHostingExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.JavaScript.Tests
→ 1 via the project graph: Aspire.Playground.Tests

🧪 tests/Aspire.Hosting.Azure.Tests/AzureFunctionsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Azure.Tests
→ 1 via the project graph: Aspire.Hosting.Azure.Kubernetes.Tests

📦 affected project Aspire.Hosting.JavaScript
→ 1 test: Aspire.Cli.EndToEnd.Tests

🔧 src/Aspire.Hosting.DevTunnels/DevTunnelResourceBuilderExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.Go.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.go (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.Go.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/Snapshots/TwoPassScanningGeneratedAspire.verified.ts (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.TypeScript.Tests

🧪 tests/Aspire.Hosting.DevTunnels.Tests/DevTunnelCliVersionValidationTests.cs (changed test)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests

🧪 tests/Aspire.Hosting.DevTunnels.Tests/DevTunnelResourceBuilderExtensionsTests.cs (changed test)
→ 1 directly: Aspire.Hosting.DevTunnels.Tests

🧪 tests/Aspire.Hosting.DotnetTool.Tests/AddDotnetToolTests.cs (changed test)
→ 1 directly: Aspire.Hosting.DotnetTool.Tests

🧪 tests/Aspire.Hosting.Go.Tests/AddGoAppTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Go.Tests

🧪 tests/Aspire.Hosting.JavaScript.Tests/RequiredCommandTests.cs (changed test)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🧪 tests/Aspire.Hosting.Tests/RequiredCommandAnnotationTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

Job reasons

Job Triggered by
cli-starter-validation affected project Aspire.Hosting.JavaScript
extension-e2e • src/Aspire.Hosting.JavaScript/JavaScriptHostingExtensions.cs, src/Aspire.Hosting/ApplicationModel/IRequiredCommandValidator.cs, src/Aspire.Hosting/ApplicationModel/RequiredCommandAnnotation.cs, src/Aspire.Hosting/ApplicationModel/RequiredCommandValidationContext.cs, src/Aspire.Hosting/ApplicationModel/RequiredCommandValidationResult.cs, src/Aspire.Hosting/ApplicationModel/RequiredCommandValidator.cs, src/Aspire.Hosting/DistributedApplicationBuilder.cs, src/Aspire.Hosting/Lifecycle/RequiredCommandValidationEventingSubscriber.cs, src/Aspire.Hosting/RequiredCommandResourceExtensions.cs
• affected project Aspire.Hosting.JavaScript
polyglot • affected project Aspire.Hosting.DevTunnels
• affected project Aspire.Hosting.Azure.Provisioning.KeyVault
typescript-api-compat affected project Aspire.Hosting.DevTunnels

Selection computed for commit 3d5f9c9.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The PR lacks maintainer approval for removing ASPIRECOMMAND001, which would commit the affected public APIs to a stable, long-term support contract.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@maddymontaquila

Copy link
Copy Markdown
Collaborator Author

The original stabilization received an APPROVED review from @eerhardt, who introduced the callback context/result and validator contract. That approval was on the original stabilization commit, before the release replay and latest target merge; it is not a fresh review of the current head. The replay preserved the stabilization patch, and the latest changes resolve release conflicts and repair documentation snapshots and the scoped warning assertion without broadening the API contract. Any required current-head approval remains governed by the repository merge rules.

🤖 AI-authored reply via Agency Finish PR.

@maddymontaquila
Maddy Montaquila (maddymontaquila) merged commit bcb6b84 into release/17.0 Nov 15, 2026
352 of 355 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.0 milestone Nov 15, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #2168

Generated by PR Documentation Check · copilot · auto · 22.2 AIC · ⌖ 1.07 AIC · ⊞ 7.4K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#2168 targeting release/17.0.

Marks ASPIRECOMMAND001 as retired in 17.0 and documents advisory required-command validation semantics. Signals: diagnostic_documentation_changed (docs/list-of-diagnostics.md), pr_body_has_user_facing_section, pr_body_has_cli_flag_mention. Files: diagnostics/aspirecommand001.mdx, diagnostics/overview.mdx.

Note

This draft PR needs human review before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants