Skip to content

Graduate Deno hosting APIs to stable - #22159

Merged
Jose Perez Rodriguez (joperezr) merged 1 commit into
release/17.0from
maddymontaquila/stabilize-deno-hosting
Nov 12, 2026
Merged

Jose Perez Rodriguez (joperezr) merged 1 commit into
release/17.0from
maddymontaquila/stabilize-deno-hosting

Conversation

@maddymontaquila

@maddymontaquila Maddy Montaquila (maddymontaquila) commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Make the existing Deno hosting APIs usable without suppressing ASPIREDENO001, while retaining their functionality and signatures. Remove only Deno's experimental attributes and related consumer suppressions, document the runtime/run/publish contract, and update the regression test to verify both C# attributes and ATS capability metadata are stable. Generated api/*.cs baselines and unrelated experimental contracts are unchanged.

Original API contributor: rickylabs, who introduced AddDenoApp, DenoAppResource, the Deno enums/flag helpers, and WithDeno in #18628 (introducing commit). Attribution was checked against the introducing changes and GitHub's PR/commit author identities; this is a mention, not a claim of approval.

Fixes # (issue)

Contract review

  • Runtime version: Preserve the existing Deno 2.9.0 CI baseline and denoland/deno:2.9.0 generated-image defaults. Local execution uses Deno on PATH; explicit image overrides remain available. No new minimum-version enforcement or claim of compatibility with every older runtime is introduced. Applications must select a runtime supporting their chosen flags. Deno's runtime documentation documents OTEL_DENO=true; no upstream-wide GA claim is needed for this wrapper graduation.
  • Permissions: Preserve local -A versus generated-container network/environment defaults. Explicit grants/denials retain their current semantics, deny-only publishing narrows the baseline, and explicit allow-all remains opt-in for containers.
  • Watch/serve/task: Managed watch/inspector flags remain development-only; serve retains Aspire endpoint/target-port wiring and container 0.0.0.0 binding. Tasks own their permissions and development/production commands, and opaque task module graphs are not inferred for caching.
  • Run/publish parity: Preserve shared flag composition and intentional mode differences, dependency caching, and explicit failures for unsupported generated-Dockerfile options. Stable WithDenoUnstable is a stable flag-forwarding API, not a promise that upstream --unstable-* features are stable.

User-facing usage

Existing calls no longer need ASPIREDENO001 suppressions.

C# AppHost:

builder.AddDenoApp("api", "../api", "main.ts");

TypeScript AppHost:

await builder.addDenoApp("api", "../api", "main.ts");

Release/17.0 replay

Replayed only the stabilization commit onto release/17.0 at 9a97ab889bfb731de74ead0280be279ffdd000bf, using the verified original-main fork point 793dfe6e254fe050af24cb7bcfba214066dcaab8. The branch now contains one intended commit touching 12 files, rather than unrelated main history. git range-diff confirms the stabilization patch is unchanged; there were no conflicts or release-specific adaptations, and no new runtime features were imported.

Validation on release/17.0

The earlier reported 227+1 passing tests were run on the original main-based branch. Both commands below were rerun successfully after the release replay, at a001eb786090310d6d5749a166234dc6b921c7cd.

Passed, 227 tests, covering Deno arguments, permissions, modes, manifests, generated Dockerfiles, and required commands (0 failed, 0 skipped):

dotnet test --project tests/Aspire.Hosting.JavaScript.Tests/Aspire.Hosting.JavaScript.Tests.csproj --no-launch-profile -- --filter-class '*.AddDenoAppTests' --filter-class '*.RequiredCommandTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

Passed, 1 test, covering all Deno public method/type attributes and corresponding ATS capability experimental metadata (0 failed, 0 skipped):

dotnet test --project tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests.csproj --no-launch-profile -- --filter-method '*.DenoPublicApis_AreStable' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'

git diff --check origin/release/17.0...HEAD — passed. Live Deno functional/container execution and VS Code E2E were not run locally; Deno is not installed here. The extension change only removes the now-unnecessary suppression from its generated test AppHost. Existing extension path routing selects its CI jobs; no runtime dependency or test-selection gate changed.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 22159

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 22159"

@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Nov 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the change graduating the Deno hosting APIs to stable.

No open issues 🎉

What changed in this PR

Graduates the existing Deno hosting APIs in Aspire.Hosting.JavaScript to stable without changing their signatures or runtime behavior. Generated API baselines and unrelated experimental contracts remain unchanged.

Changes:

  • Removes Deno experimental attributes and obsolete consumer suppressions.
  • Documents runtime requirements, local/container differences, permissions, and publishing limitations.
  • Updates regression coverage to verify stable C# attributes and Aspire Type System capability metadata.
File Description
tests/​Aspire.Hosting.JavaScript.Tests/​RequiredCommandTests.cs Removes the Deno warning suppression.
tests/​Aspire.Hosting.JavaScript.Tests/​DenoFunctionalTests.cs Removes the Deno warning suppression.
tests/​Aspire.Hosting.JavaScript.Tests/​DenoAppFixture.cs Removes the fixture’s Deno warning suppression.
tests/​Aspire.Hosting.JavaScript.Tests/​AddDenoAppTests.cs Removes the Deno suppression while retaining the separate JavaScript suppression.
tests/​Aspire.Hosting.CodeGeneration.TypeScript.Tests/​AtsTypeScriptCodeGeneratorTests.cs Verifies Deno APIs and capability metadata are non-experimental.
src/​Aspire.Hosting.JavaScript/​README.md Documents stable status and Deno runtime/publishing behavior.
src/​Aspire.Hosting.JavaScript/​JavaScriptHostingExtensions.cs Graduates AddDenoApp and WithDeno to stable.
src/​Aspire.Hosting.JavaScript/​DenoHostingExtensions.cs Removes experimental attributes from Deno configuration methods.
src/​Aspire.Hosting.JavaScript/​DenoCommandLineAnnotation.cs Removes experimental attributes from public Deno enums.
src/​Aspire.Hosting.JavaScript/​DenoAppResource.cs Removes the resource’s experimental attribute.
extension/​src/​test-e2e/​denoDebugger.e2e.test.ts Removes the generated AppHost’s Deno warning suppression.
docs/​list-of-diagnostics.md Marks ASPIREDENO001 as retired and links to the runtime contract.

Review effort: Balanced

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

Remove ASPIREDENO001 markers and consumer suppressions while preserving Deno behavior. Document runtime and publishing contracts and verify stable C# and ATS metadata.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@maddymontaquila
Maddy Montaquila (maddymontaquila) force-pushed the maddymontaquila/stabilize-deno-hosting branch from 5dfe156 to a001eb7 Compare November 11, 2026 22:28
@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

10 / 101 PR test projects · 5 PR jobs, from 10 changed files.

Selected PR test projects (10 / 101)

Aspire.Cli.EndToEnd.Tests, Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.CodeGeneration.TypeScript.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Radius.Tests, Aspire.Hosting.Tests, Aspire.Playground.Tests

Selected PR jobs (5)

cli-starter-validation, extension-e2e, extension-unit, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

⚠️ 8 of the 10 selected test projects come from a single change — src/Aspire.Hosting.JavaScript/DenoAppResource.cs.

🔧 src/Aspire.Hosting.JavaScript/DenoAppResource.cs (changed source)
→ 1 directly: Aspire.Hosting.JavaScript.Tests
→ 7 via the project graph: Aspire.Hosting.Azure.Kubernetes.Tests (2 hops), Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests (2 hops), Aspire.Hosting.Dotnet.Tests (2 hops), Aspire.Hosting.Radius.Tests (2 hops), Aspire.Hosting.Tests, Aspire.Playground.Tests

📦 affected project Aspire.Hosting.JavaScript
→ 1 test: Aspire.Cli.EndToEnd.Tests

🔧 src/Aspire.Hosting.JavaScript/DenoCommandLineAnnotation.cs (changed source)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🔧 src/Aspire.Hosting.JavaScript/DenoHostingExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🔧 src/Aspire.Hosting.JavaScript/JavaScriptHostingExtensions.cs (changed source)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🧪 tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/AtsTypeScriptCodeGeneratorTests.cs (changed test)
→ 1 directly: Aspire.Hosting.CodeGeneration.TypeScript.Tests

🧪 tests/Aspire.Hosting.JavaScript.Tests/AddDenoAppTests.cs (changed test)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🧪 tests/Aspire.Hosting.JavaScript.Tests/DenoAppFixture.cs (changed test)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🧪 tests/Aspire.Hosting.JavaScript.Tests/DenoFunctionalTests.cs (changed test)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

🧪 tests/Aspire.Hosting.JavaScript.Tests/RequiredCommandTests.cs (changed test)
→ 1 directly: Aspire.Hosting.JavaScript.Tests

Job reasons

Job Triggered by
cli-starter-validation affected project Aspire.Hosting.JavaScript
extension-e2e • extension/src/test-e2e/denoDebugger.e2e.test.ts, src/Aspire.Hosting.JavaScript/DenoAppResource.cs, src/Aspire.Hosting.JavaScript/DenoCommandLineAnnotation.cs, src/Aspire.Hosting.JavaScript/DenoHostingExtensions.cs, src/Aspire.Hosting.JavaScript/JavaScriptHostingExtensions.cs
• affected project Aspire.Hosting.JavaScript
extension-unit extension/src/test-e2e/denoDebugger.e2e.test.ts
polyglot affected project Aspire.Hosting.JavaScript
typescript-api-compat affected project Aspire.Hosting.JavaScript

Selection computed for commit a001eb7.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The README’s WithRunScript guidance omits the conditions required for Deno task mode and should clarify them or recommend WithDenoTask for explicit task selection.

1 open issue

Review effort: Balanced

| Permissions | `WithDenoAllow` and `WithDenoDeny` configure explicit permissions; `WithDenoAllowAll(false)` disables the blanket grant. | Explicit permissions are preserved; deny-only configuration narrows the network/environment defaults. `WithDenoAllowAll(true)` explicitly grants all permissions in both modes. |
| Watch and inspector | `WithDenoWatch` and `WithDenoInspect` enable development flags for run/serve modes. | Managed watch and inspector flags are omitted. |
| Serve mode | `WithDenoServe` runs `deno serve` with an Aspire-managed HTTP endpoint. | Binds to `0.0.0.0` and the endpoint's target port (8000 by default). |
| Task mode | `WithDenoTask` or `WithRunScript` runs `deno task`; the task defines its own permissions and development flags. | Runs the selected task without inferring or pre-caching its module graph. Tasks must provide their own production-appropriate command. |
@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@github-actions

Copy link
Copy Markdown
Contributor

Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt.

@joperezr
Jose Perez Rodriguez (joperezr) merged commit 18b1348 into release/17.0 Nov 12, 2026
950 of 963 checks passed
@microsoft-github-policy-service microsoft-github-policy-service Bot added this to the 17.0 milestone Nov 12, 2026
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Pull request created: #2127

Generated by PR Documentation Check · copilot · auto · 29.3 AIC · ⌖ 1.17 AIC · ⊞ 7.4K

@aspire-repo-bot

Copy link
Copy Markdown
Contributor

📝 Documentation has been drafted in microsoft/aspire.dev#2127 targeting release/17.0.

Added a "Deno hosting APIs are stable" entry to whats-new/aspire-17.mdx. Triggered signals: integration_readme_changed (Aspire.Hosting.JavaScript/README.md), diagnostic_documentation_changed (docs/list-of-diagnostics.md, ASPIREDENO001 removed), pr_body_has_user_facing_section, pr_body_has_cli_flag_mention (--unstable-*).

Note

This draft PR needs human review before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants