Repository navigation
Graduate Deno hosting APIs to stable - #22159
Jose Perez Rodriguez (joperezr) merged 1 commit into
Conversation
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 22159Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 22159" |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change graduating the Deno hosting APIs to stable.
No open issues 🎉
What changed in this PR
Graduates the existing Deno hosting APIs in Aspire.Hosting.JavaScript to stable without changing their signatures or runtime behavior. Generated API baselines and unrelated experimental contracts remain unchanged.
Changes:
- Removes Deno experimental attributes and obsolete consumer suppressions.
- Documents runtime requirements, local/container differences, permissions, and publishing limitations.
- Updates regression coverage to verify stable C# attributes and Aspire Type System capability metadata.
| File | Description |
|---|---|
tests/Aspire.Hosting.JavaScript.Tests/RequiredCommandTests.cs |
Removes the Deno warning suppression. |
tests/Aspire.Hosting.JavaScript.Tests/DenoFunctionalTests.cs |
Removes the Deno warning suppression. |
tests/Aspire.Hosting.JavaScript.Tests/DenoAppFixture.cs |
Removes the fixture’s Deno warning suppression. |
tests/Aspire.Hosting.JavaScript.Tests/AddDenoAppTests.cs |
Removes the Deno suppression while retaining the separate JavaScript suppression. |
tests/Aspire.Hosting.CodeGeneration.TypeScript.Tests/AtsTypeScriptCodeGeneratorTests.cs |
Verifies Deno APIs and capability metadata are non-experimental. |
src/Aspire.Hosting.JavaScript/README.md |
Documents stable status and Deno runtime/publishing behavior. |
src/Aspire.Hosting.JavaScript/JavaScriptHostingExtensions.cs |
Graduates AddDenoApp and WithDeno to stable. |
src/Aspire.Hosting.JavaScript/DenoHostingExtensions.cs |
Removes experimental attributes from Deno configuration methods. |
src/Aspire.Hosting.JavaScript/DenoCommandLineAnnotation.cs |
Removes experimental attributes from public Deno enums. |
src/Aspire.Hosting.JavaScript/DenoAppResource.cs |
Removes the resource’s experimental attribute. |
extension/src/test-e2e/denoDebugger.e2e.test.ts |
Removes the generated AppHost’s Deno warning suppression. |
docs/list-of-diagnostics.md |
Marks ASPIREDENO001 as retired and links to the runtime contract. |
Review effort: Balanced
This comment has been minimized.
This comment has been minimized.
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
Remove ASPIREDENO001 markers and consumer suppressions while preserving Deno behavior. Document runtime and publishing contracts and verify stable C# and ATS metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
5dfe156 to
a001eb7
Compare
Tests selector10 / 101 PR test projects · 5 PR jobs, from 10 changed files. Selected PR test projects (10 / 101)
Selected PR jobs (5)
How these were chosen — grouped by what changed
🔧 📦 affected project 🔧 🔧 🔧 🧪 🧪 🧪 🧪 🧪 Job reasons
Selection computed for commit |
| | Permissions | `WithDenoAllow` and `WithDenoDeny` configure explicit permissions; `WithDenoAllowAll(false)` disables the blanket grant. | Explicit permissions are preserved; deny-only configuration narrows the network/environment defaults. `WithDenoAllowAll(true)` explicitly grants all permissions in both modes. | | ||
| | Watch and inspector | `WithDenoWatch` and `WithDenoInspect` enable development flags for run/serve modes. | Managed watch and inspector flags are omitted. | | ||
| | Serve mode | `WithDenoServe` runs `deno serve` with an Aspire-managed HTTP endpoint. | Binds to `0.0.0.0` and the endpoint's target port (8000 by default). | | ||
| | Task mode | `WithDenoTask` or `WithRunScript` runs `deno task`; the task defines its own permissions and development flags. | Runs the selected task without inferring or pre-caching its module graph. Tasks must provide their own production-appropriate command. | |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
|
Retrying the failed CI jobs for this pull request from the CI run attempt. The rerun is being tracked in the rerun attempt. |
18b1348
into
release/17.0
|
Pull request created: #2127
|
|
📝 Documentation has been drafted in microsoft/aspire.dev#2127 targeting Added a "Deno hosting APIs are stable" entry to Note This draft PR needs human review before merging. |

Description
Make the existing Deno hosting APIs usable without suppressing
ASPIREDENO001, while retaining their functionality and signatures. Remove only Deno's experimental attributes and related consumer suppressions, document the runtime/run/publish contract, and update the regression test to verify both C# attributes and ATS capability metadata are stable. Generatedapi/*.csbaselines and unrelated experimental contracts are unchanged.Original API contributor: rickylabs, who introduced
AddDenoApp,DenoAppResource, the Deno enums/flag helpers, andWithDenoin #18628 (introducing commit). Attribution was checked against the introducing changes and GitHub's PR/commit author identities; this is a mention, not a claim of approval.Fixes # (issue)
Contract review
denoland/deno:2.9.0generated-image defaults. Local execution uses Deno onPATH; explicit image overrides remain available. No new minimum-version enforcement or claim of compatibility with every older runtime is introduced. Applications must select a runtime supporting their chosen flags. Deno's runtime documentation documentsOTEL_DENO=true; no upstream-wide GA claim is needed for this wrapper graduation.-Aversus generated-container network/environment defaults. Explicit grants/denials retain their current semantics, deny-only publishing narrows the baseline, and explicit allow-all remains opt-in for containers.0.0.0.0binding. Tasks own their permissions and development/production commands, and opaque task module graphs are not inferred for caching.WithDenoUnstableis a stable flag-forwarding API, not a promise that upstream--unstable-*features are stable.User-facing usage
Existing calls no longer need
ASPIREDENO001suppressions.C# AppHost:
TypeScript AppHost:
Release/17.0 replay
Replayed only the stabilization commit onto
release/17.0at9a97ab889bfb731de74ead0280be279ffdd000bf, using the verified original-main fork point793dfe6e254fe050af24cb7bcfba214066dcaab8. The branch now contains one intended commit touching 12 files, rather than unrelated main history.git range-diffconfirms the stabilization patch is unchanged; there were no conflicts or release-specific adaptations, and no new runtime features were imported.Validation on release/17.0
The earlier reported 227+1 passing tests were run on the original main-based branch. Both commands below were rerun successfully after the release replay, at
a001eb786090310d6d5749a166234dc6b921c7cd.Passed, 227 tests, covering Deno arguments, permissions, modes, manifests, generated Dockerfiles, and required commands (0 failed, 0 skipped):
Passed, 1 test, covering all Deno public method/type attributes and corresponding ATS capability experimental metadata (0 failed, 0 skipped):
git diff --check origin/release/17.0...HEAD— passed. Live Deno functional/container execution and VS Code E2E were not run locally; Deno is not installed here. The extension change only removes the now-unnecessary suppression from its generated test AppHost. Existing extension path routing selects its CI jobs; no runtime dependency or test-selection gate changed.Checklist
<remarks />and<code />elements on your triple slash comments?