Skip to content

Merge release/13.6 into release/17.0 after 13.6.5 security release - #22367

Open
Jose Perez Rodriguez (joperezr) wants to merge 8 commits into
release/17.0from
joperezr/merge-release13.6-into-release17.0
Open

Jose Perez Rodriguez (joperezr) wants to merge 8 commits into
release/17.0from
joperezr/merge-release13.6-into-release17.0

Conversation

@joperezr

Copy link
Copy Markdown
Member

Description

Merge release/13.6 forward into release/17.0 after the 13.6.5 security release so the servicing security fixes also ship in 17.0.

Replaces #22365, whose source was the protected release branch itself. This temporary source branch starts at exactly the same release/13.6 commit, 2150dde35623f6754e98af77ca930d1c8fecb313, so conflicts can be resolved without modifying release/13.6. No cherry-picks or additional code changes have been made.

Includes the dashboard not-found authentication fix, OTLP-only automatic dashboard tunnelling, CLI SDK build/temporary-directory isolation, deprecated MCP scanner log cleanup, and stable installer preparation for internal release branches. The deprecated scanner has already been removed in 17.0; preserve that removal during conflict resolution.

Conflict resolution is still pending. Once resolved and pushed to this temporary branch, PR CI can validate the combined code. Existing checks attached to the starting commit are historical release/13.6 push checks, not merge-result validation.

Relates to #22366: SDK response-file test isolation and test-selection routing are intentionally non-blocking 17.0 servicing follow-ups, not changes to make in this merge PR.

Fixes # (issue)

Validation

No new tests run for this replacement PR. The temporary branch initially points to the exact original PR head. Fresh merge-result CI is required after resolving conflicts.

Screenshots / Recordings

This PR includes UI changes. Please add screenshots or screen recordings so reviewers can evaluate the visual changes without running locally.

  • For before/after comparisons, place them side-by-side or label them clearly.
  • For interactive changes (animations, transitions, new flows), prefer a short screen recording (GIF or video).
  • If you cannot capture visuals now, note what scenario to test and mark this section as TODO.

TODO after conflict resolution: capture the dashboard's unauthenticated unknown-route behavior. No merged build is available yet.

Security considerations

Carries forward previously released security fixes affecting dashboard authentication, automatic tunnel exposure, scanner logging, and CLI SDK build isolation. Conflict resolution must preserve these protections. Security-review completion has not been independently verified here.

cc Jose Perez Rodriguez (@joperezr)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

James Newton-King and others added 7 commits October 20, 2026 18:01
## Description

Fix dashboard authentication when an unauthenticated user navigates to a missing route. The router's not-found content previously bypassed `AuthorizeRouteView` and could render the main layout and its UI infrastructure.

Missing routes now enforce the frontend authorization policy before rendering dashboard UI. In browser-token mode, unauthenticated users are redirected to login with the original route preserved as the return URL.

Add defense-in-depth authentication checks before initializing the main layout, dialog provider, interaction provider, and standalone terminal window. Preserve unsecured mode and the release branch's terminal route-change lifecycle.

Targets `release/13.6`.

Fixes # (issue)

### User-facing usage

With browser-token authentication enabled, navigating from the login page to `/this-page-does-not-exist` redirects back to `/login?returnUrl=%2Fthis-page-does-not-exist` instead of rendering the dashboard layout. Authenticated users can still access the not-found page.

### Validation

- Focused dashboard component tests: 106 passed, including browser-token redirects, layouts, interactions, and terminal windows.
- Authenticated and unauthenticated initialization tests cover browser-token and OpenID Connect modes.
- Dashboard integration-test project build: 0 warnings and 0 errors.
- Added a Playwright regression test for navigation from login to a missing route. Compiled but not executed because it is an outerloop test.
- `git diff --check` passed.

### Security considerations

This changes frontend authentication/authorization handling. The route authorization policy remains the primary control; the additional initialization checks reject unauthenticated users in secured modes before starting UI infrastructure. Security review is requested; no threat model or security review has been completed for this change.

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
    - Did you add `<remarks />` and `<code />` elements on your triple slash comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [x] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [x] No
  - [ ] No


----
#### AI description  (iteration 1)
#### PR Classification
Bug fix: unauthenticated users hitting a missing (not-found) route in the dashboard bypassed authentication, exposing the NotFound page without login enforcement.

#### PR Summary
This PR fixes an authentication bypass where navigating to a non-existent route would skip authorization checks, and adds a defense-in-depth authentication guard across key Blazor components.
- `src/Aspire.Dashboard/Components/R...
## Description

Bring the internal 13.6 release branch up to date with public `release/13.6` while preserving its internal-only history. This PR exists only in Azure DevOps; no internal commits or branches were pushed to GitHub.

At preparation, `internal/release/13.6` was **5 commits behind and 1 commit ahead** of public `release/13.6`. The Azure DevOps `release/13.6` branch exactly matches the public tip, `6cfe6b409805bb21775623d501aa1475cb9ee25c`; the target tip is `0b6bfe2f538d4eed8a9ae7e11651c09dbbe886b8`.

The five incoming public commits contain:
- DCP 0.26.6 update.
- Shared CLI log-creation helper.
- Ambiguous DCP create recovery and configurable timeouts.
- TypeScript Bicep parameter-expression fix for enum Azure properties.
- .NET servicing dependency updates for Aspire 13.6.5.

This is a branch synchronization with no manual code changes or conflict resolutions. Existing tests are carried with the upstream commits; no new API or security guarantees are introduced by the merge itself. No additional dependencies beyond those already in the public branch are introduced.

Complete using **Merge (no fast-forward)** to retain both histories, not squash or rebase. **Do not delete `release/13.6`**, which is a shared branch.

### Validation

- `git rev-list --left-right --count refs/remotes/InternalFork/internal/release/13.6...refs/remotes/origin/release/13.6` returned `1 5`.
- `git merge-tree --write-tree refs/remotes/InternalFork/internal/release/13.6 refs/remotes/origin/release/13.6` passed without conflicts; result tree: `a6e7760090e982bec37daf3ff9c50d3ee6c36016`.
- `git diff --check refs/remotes/InternalFork/internal/release/13.6 a6e7760` passed.
- Rechecked both remote tips before creating the PR; the public and Azure DevOps source tips match.
- Local build and tests were not run for this merge-only synchronization. Internal PR validation is required before completion.

Fixes # (issue)

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
    - Did you add `<remarks />` and `<code />` elements on your triple slash comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No
…anner

## Description

Stop `DeprecatedMcpCommandScanner` from unconditionally writing agent configuration paths, configuration content, and scan diagnostics to the shared temporary file `aspire-deprecated-scan.log`.

Remove only the temporary-file diagnostic logging. Preserve the existing structured `ILogger` debug messages, deprecated-command detection, configuration migration prompts, and configuration updates. This is a focused fix for `internal/release/13.6`, not a backport of the broader agent-client selection changes.

No new dependencies.

Fixes # (issue)

### User-facing usage

Running `aspire agent init` continues to detect and offer to update deprecated `aspire mcp start` configurations, without writing the scan diagnostics or configuration content to `aspire-deprecated-scan.log`.

### Validation

- `./restore.sh` — passed.
- `MSBUILDTERMINALLOGGER=false dotnet test --project tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class '*.AgentEnvironmentDetectorTests' --filter-class '*.AgentInitCommandTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'` — passed, 49 tests.
- `git diff --check` — passed.

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if relevant?
  - [ ] Yes
  - [x] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
    - Did you add `<remarks />` and `<code />` elements on your triple slash comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

----
#### AI description  (iteration 1)
#### PR Classification
Code cleanup: removal of leftover debug/temporary-file logging code.

#### PR Summary
Removes debug logging statements that wrote diagnostic information to a temporary file in the deprecated MCP command scanner.
- `src/Aspire.Cli/Agents/DeprecatedMcpCommandScanner.cs`: Removed all `File.AppendAllText` debug logging calls to a temp file, keeping only existing `_logger.LogDebug` calls for error handling.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
Preserves explicit dashboard endpoint references and ordinary host-resource tunneling. Normalizes legacy host URLs into endpoint references at the dependency-discovery boundary.

----
#### AI description  (iteration 1)
#### PR Classification
Bug fix / feature refinement: restricts automatic dashboard container tunnelling to only OTLP endpoints instead of all dashboard endpoints.

#### PR Summary
Adds extensive test coverage validating that dashboard tunnelling only exposes OTLP endpoints automatically while preserving explicit endpoint references and legacy tunnel behavior, along with new dashboard routing tests for authentication/authorization layout behavior.
- `DcpExecutorTests.cs`: Adds many new test cases verifying `DashboardTunnelAutomaticallyExposesOnlyOtlpEndpoints` only tunnels OTLP gRPC/HTTP endpoints, not all dashboard endpoints.
- `DcpExecutorTests.cs`: Adds tests ensuring explicit references (environment, arguments, expressions, properties, host-url, reference) to non-OTLP dashboard endpoints are preserved and tunneled correctly.
- `DcpExecutorTests.cs`: Adds tests for caching behavior, legacy container tunnel mode compatibility, and multi-consumer endpoint accumulation.
- `RoutesTests.cs` (new file): Adds tests validating dashboard routing/layout behavior under various authentication states (browser token, OpenID Connect, unsecured, pending authorization) ensuring correct layout and redirect behavior.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…temporary directories

## Description

Prevent automatic MSBuild response files from affecting CLI-generated server/integration builds without changing user-authored builds. SDK command working directories move to `<ASPIRE_HOME>/tmp/sdk/<unique-id>`, with owner-only Unix permissions, local configuration isolation, and cleanup on completion or preparation failure. Normal AppHost caches are unchanged.

### User-facing usage

```bash
aspire sdk generate ./MyIntegration.csproj --language typescript --output ./generated
aspire sdk dump ./MyIntegration.csproj --format json --output capabilities.json
aspire sdk export --language typescript > api.json
```

### Validation

Manual validation to check that the `/tmp` folder was not used, all all projects for in `/tmp/sdk`.

- `./restore.sh` — passed; existing dependency vulnerability warnings were reported.
- Command below — passed, 54 tests, no failures/skips. Includes real SDK commands with adjacent/parent response files.

```bash
MSBUILDTERMINALLOGGER=false dotnet test --project tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj \
--no-launch-profile -- --filter-method '*.SdkCommandTests.*' \
--filter-method '*.SdkDumpCommandTests.*' \
--filter-method '*.SdkResponseFileTests.*' \
--filter-method '*.ProcessInvocationOptionsTests.*' \
--filter-method '*.DotNetCliRunnerTests.RestoreAsyncRunsDotnetRestoreCommand' \
--filter-method '*.DotNetCliRunnerTests.BuildAndRestoreAsync_ControlAutomaticResponseFiles' \
--filter-method '*.DotNetCliRunnerTests.BuildAsyncRunsDotnetBuildCommand' \
--filter-method '*.AppHostServerProjectTests.BuildAsync_DisablesAutomaticResponseFiles' \
--filter-method '*.PrebuiltAppHostServerTests.PrepareAsync_WithProjectReferencesAndExplicitChannelButNoOverride_UsesAdditionalSourcesNotRestoreConfigFile' \
--filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'
```

- `git diff --check` — passed.
- Full suite and internal pipelines not run.

### Security considerations

Changes generated-process execution and temp placement. Local configuration keeps caches inside the cleanup boundary. Response suppression applies only to generated builds; explicit response files remain supported. Forced termination/cleanup failure can leave directories; no periodic cleanup. Dedicated security review not performed.

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
    - Did you add `<remarks />` and `<code />` elements on your triple slash comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [x] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [x] No
  - [ ] No
…l release branches

## Description

Stable source builds from `internal/release/*` currently skip Prepare Installers, unlike `release/*` builds. Include the internal release prefix in the official and unofficial installer-stage conditions so internal servicing builds produce the same WinGet manifests, Homebrew cask, and npm installation validation results.

Preserve the existing PR behavior, main/release eligibility, prerelease behavior, and dependency-success requirements. Signing and production-branch recognition already include internal release branches and require no changes.

Prepare Installers only generates/validates files and uploads internal build artifacts. It does not submit WinGet manifests, push a Homebrew tap, or publish npm packages. Public publishing remains in the separate, manual release-publish pipeline; this change does not modify it.

Fixes # (issue)

### Validation

- `git -C 'C:\Users\joperezr\.copilot\session-state\b41fa7f3-1764-4a40-baab-cd20c93df4a7\files\internal-release-installer-fix' diff --check` — passed.
- `node 'C:\Users\joperezr\.copilot\session-state\b41fa7f3-1764-4a40-baab-cd20c93df4a7\files\check-installer-gates.cjs' 'C:\Users\joperezr\.copilot\session-state\b41fa7f3-1764-4a40-baab-cd20c93df4a7\files\internal-release-installer-fix'` — passed 168 diagnostic cases using the extracted conditions: branch, channel, reason, and dependency-success combinations. This session-only diagnostic is not an Azure Pipelines integration test.
- Official definition 1602 run [3130747](https://dev.azure.com/dnceng/internal/_build/results?buildId=3130747), revision `8f7d36254f531a80f95074b0011de97b2a695c12`, stable CLI override — queued through the ADO pipeline API and currently running. Requested `stagesToSkip: [assemble]` to exclude Assemble + Publish. Initial timeline inspected; no artifacts yet.
- Stable installer execution is **unvalidated**: contributor-branch gating still intentionally excludes this personal branch. Verify the installer jobs, logs, and artifacts on `internal/release/13.6` after merge. No public release/publishing run was queued. Unofficial pipeline execution was not run.

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if relevant?
  - [ ] Yes
  - [x] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
    - Did you add `<remarks />` and `<code />` elements on your triple slash comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No
[release/13.6] Merge internal/release/13.6 into release/13.6
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 22367

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 22367"

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Pending security-sensitive merge conflicts, missing fresh merge-result CI, and unavailable pipeline 1602 timeline/artifact validation require human verification of combined protections, scanner removal, and installer gating.

No open issues 🎉

1 file not reviewed
  • src/Aspire.Dashboard/Resources/Routes.Designer.cs: Generated file
What changed in this PR

Carries the 13.6.5 security fixes forward into Aspire 17.0, covering dashboard authentication, container tunnelling, and CLI build isolation. This replaces #22365 with a temporary source branch that permits conflict resolution without changing release/13.6.

Changes:

  • Protect dashboard routes and layouts, with localized authorization messages and regression tests.
  • Restrict automatic dashboard tunnels to OTLP endpoints while preserving explicit references.
  • Isolate CLI SDK working directories and generated builds, remove scanner temporary-file logging, and extend installer preparation to internal release branches.

The PR description records conflict resolution and fresh merge-result CI as pending. The deprecated scanner must remain removed in 17.0; SDK test-isolation and selection-routing follow-ups remain separately tracked in #22366.

File Description
tests/​Aspire.Hosting.Tests/​ExecutionConfigurationGathererTests.cs Tests endpoint discovery and legacy URL normalization.
tests/​Aspire.Hosting.Tests/​Dcp/​DcpExecutorTests.cs Tests restricted dashboard tunnels and explicit references.
tests/​Aspire.Dashboard.Tests/​Integration/​Playwright/​BrowserTokenAuthenticationTests.cs Tests anonymous navigation and login redirects.
tests/​Aspire.Dashboard.Components.Tests/​Shared/​TestNavigationManager.cs Captures navigation options for redirect assertions.
tests/​Aspire.Dashboard.Components.Tests/​RoutesTests.cs Tests route authorization and layout selection.
tests/​Aspire.Dashboard.Components.Tests/​Pages/​TerminalWindowTests.cs Tests terminal authentication guards.
tests/​Aspire.Dashboard.Components.Tests/​Layout/​WindowLayoutTests.cs Tests protected window layout initialization.
tests/​Aspire.Dashboard.Components.Tests/​Layout/​MainLayoutTests.cs Tests rejection of unauthenticated layout initialization.
tests/​Aspire.Dashboard.Components.Tests/​Layout/​DashboardDialogProviderTests.cs Tests dialog-provider authentication enforcement.
tests/​Aspire.Dashboard.Components.Tests/​Interactions/​InteractionsProviderTests.cs Tests interaction-provider authentication enforcement.
tests/​Aspire.Dashboard.Components.Tests/​Controls/​DashboardNotAuthorizedTests.cs Tests localized denial messages and safe redirects.
tests/​Aspire.Cli.Tests/​TestServices/​TestAppHostServerProjectFactory.cs Supports SDK-specific factory calls in tests.
tests/​Aspire.Cli.Tests/​Projects/​PrebuiltAppHostServerTests.cs Verifies automatic response files are disabled.
tests/​Aspire.Cli.Tests/​Projects/​AppHostServerProjectTests.cs Tests generated server build isolation.
tests/​Aspire.Cli.Tests/​DotNet/​ProcessInvocationOptionsTests.cs Covers cloning the response-file option.
tests/​Aspire.Cli.Tests/​DotNet/​DotNetCliRunnerTests.cs Tests response-file control for build and restore.
tests/​Aspire.Cli.Tests/​Commands/​SdkDumpCommandTests.cs Updates expected scanner configuration files.
tests/​Aspire.Cli.Tests/​Commands/​SdkCommandTests.cs Tests private working directories and failure cleanup.
tests/​Aspire.Cli.Tests/​Commands/​Sdk/​SdkResponseFileTests.cs Adds SDK command response-file regression scenarios.
src/​Aspire.Hosting/​Dcp/​ContainerCreator.cs Limits implicit dashboard tunnelling to OTLP endpoints.
src/​Aspire.Hosting/​ApplicationModel/​ResourceExtensions.cs Collects endpoint references from unresolved configuration.
src/​Aspire.Hosting/​ApplicationModel/​HostUrl.cs Extracts shared host-endpoint lookup logic.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.zh-Hant.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.zh-Hans.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.tr.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.ru.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.pt-BR.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.pl.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.ko.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.ja.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.it.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.fr.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.es.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.de.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​xlf/​Routes.cs.xlf Adds authorization-message translation placeholder.
src/​Aspire.Dashboard/​Resources/​Routes.resx Defines the authorization-denied message.
src/​Aspire.Dashboard/​Resources/​Routes.Designer.cs Exposes the authorization-message resource.
src/​Aspire.Dashboard/​Components/​Routes.razor.cs Moves viewport state into code-behind.
src/​Aspire.Dashboard/​Components/​Routes.razor Gates protected layouts and missing routes on authorization.
src/​Aspire.Dashboard/​Components/​Pages/​TerminalWindow.razor Uses the protected window layout.
src/​Aspire.Dashboard/​Components/​Layout/​WindowLayout.razor.cs Enforces window-layout authentication.
src/​Aspire.Dashboard/​Components/​Layout/​WindowLayout.razor Provides minimal window content and tooltips.
src/​Aspire.Dashboard/​Components/​Layout/​MainLayout.razor.cs Checks authentication before layout initialization.
src/​Aspire.Dashboard/​Components/​Layout/​DashboardDialogProvider.cs Checks authentication before subscribing to navigation.
src/​Aspire.Dashboard/​Components/​Interactions/​InteractionsProvider.cs Checks authentication before enabling interactions.
src/​Aspire.Dashboard/​Components/​Controls/​DashboardNotAuthorized.razor.cs Redirects browser-token users to login.
src/​Aspire.Dashboard/​Components/​Controls/​DashboardNotAuthorized.razor Renders the localized authorization-denied message.
src/​Aspire.Dashboard/​Authentication/​DashboardAuthenticationState.cs Centralizes defensive authentication checks.
src/​Aspire.Cli/​Utils/​CliPathHelper.cs Creates private SDK working directories under Aspire home.
src/​Aspire.Cli/​Projects/​PrebuiltAppHostServer.cs Disables response files for generated integration builds.
src/​Aspire.Cli/​Projects/​DotNetBasedAppHostServerProject.cs Disables response files for generated server builds.
src/​Aspire.Cli/​Projects/​AppHostServerProject.cs Keeps temporary SDK server artifacts within cleanup scope.
src/​Aspire.Cli/​DotNet/​DotNetCliRunner.cs Adds response-file suppression to build and restore.
src/​Aspire.Cli/​Commands/​Sdk/​SdkGenerateCommand.cs Uses isolated SDK directories and server creation.
src/​Aspire.Cli/​Commands/​Sdk/​SdkExportCommand.cs Uses isolated SDK directories and server creation.
src/​Aspire.Cli/​Commands/​Sdk/​SdkDumpCommand.cs Uses isolated directories for both dump modes.
src/​Aspire.Cli/​Agents/​DeprecatedMcpCommandScanner.cs Removes temporary-file diagnostic logging.
eng/​pipelines/​azure-pipelines.yml Includes internal release branches in installer preparation.
eng/​pipelines/​azure-pipelines-unofficial.yml Applies the same internal-release installer condition.
docs/​specs/​cli-output-formats.md Documents SDK working-directory isolation and cleanup.

Review effort: Balanced

Preserve the 13.6.5 security fixes alongside 17.0 workload identity, dashboard routing, and terminal behavior. Resolve overlapping regression tests without dropping either branch coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Tests selector

56 / 101 PR test projects · 5 PR jobs, from 57 changed files.

Selected PR test projects (56 / 101)

Aspire.Cli.EndToEnd.Tests, Aspire.Cli.Tests, Aspire.Dashboard.Components.Tests, Aspire.Dashboard.Tests, Aspire.Hosting.Analyzers.Tests, Aspire.Hosting.Azure.EntraId.Tests, Aspire.Hosting.Azure.Kubernetes.Tests, Aspire.Hosting.Azure.Kusto.Tests, Aspire.Hosting.Azure.Provisioning.Tests, Aspire.Hosting.Azure.Tests, Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Browsers.Tests, Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.CodeGeneration.TypeScript.Tests, Aspire.Hosting.Containers.Tests, Aspire.Hosting.DevTunnels.Tests, Aspire.Hosting.Docker.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.DotnetTool.Tests, Aspire.Hosting.EntityFrameworkCore.Tests, Aspire.Hosting.Foundry.Tests, Aspire.Hosting.Garnet.Tests, Aspire.Hosting.Go.Tests, Aspire.Hosting.Java.Tests, Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Kafka.Tests, Aspire.Hosting.Keycloak.Tests, Aspire.Hosting.Kubernetes.Tests, Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests, Aspire.Hosting.MongoDB.Tests, Aspire.Hosting.MySql.Tests, Aspire.Hosting.Nats.Tests, Aspire.Hosting.OpenAI.Tests, Aspire.Hosting.Oracle.Tests, Aspire.Hosting.Orleans.Tests, Aspire.Hosting.PostgreSQL.Tests, Aspire.Hosting.Python.Tests, Aspire.Hosting.Qdrant.Tests, Aspire.Hosting.RabbitMQ.Tests, Aspire.Hosting.Radius.Tests, Aspire.Hosting.Redis.Tests, Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests, Aspire.Hosting.Seq.Tests, Aspire.Hosting.SqlServer.Tests, Aspire.Hosting.Testing.Tests, Aspire.Hosting.Tests, Aspire.Hosting.Valkey.Tests, Aspire.Hosting.Yarp.Tests, Aspire.Playground.Tests, Aspire.Templates.Tests, Infrastructure.Tests

Selected PR jobs (5)

cli-starter-validation, extension-e2e, native-dashboard-validation, polyglot, typescript-api-compat


How these were chosen — grouped by what changed

⚠️ 43 of the 56 selected test projects come from a single change — src/Aspire.Hosting/ApplicationModel/HostUrl.cs.

🔧 src/Aspire.Hosting/ApplicationModel/HostUrl.cs (changed source)
→ 43 via the project graph

show 43

Aspire.Hosting.Analyzers.Tests (2 hops), Aspire.Hosting.Azure.EntraId.Tests (2 hops), Aspire.Hosting.Azure.Kubernetes.Tests (2 hops), Aspire.Hosting.Azure.Kusto.Tests (2 hops), Aspire.Hosting.Azure.Provisioning.Tests (3 hops), Aspire.Hosting.Azure.Tests, Aspire.Hosting.Browsers.Tests (2 hops), Aspire.Hosting.CodeGeneration.Go.Tests, Aspire.Hosting.CodeGeneration.Java.Tests, Aspire.Hosting.CodeGeneration.Python.Tests, Aspire.Hosting.CodeGeneration.Rust.Tests, Aspire.Hosting.CodeGeneration.TypeScript.Tests, Aspire.Hosting.Containers.Tests (2 hops), Aspire.Hosting.DevTunnels.Tests (2 hops), Aspire.Hosting.Docker.Tests (2 hops), Aspire.Hosting.EntityFrameworkCore.Tests (2 hops), Aspire.Hosting.Foundry.Tests (2 hops), Aspire.Hosting.Garnet.Tests (2 hops), Aspire.Hosting.Go.Tests (2 hops), Aspire.Hosting.Java.Tests (2 hops), Aspire.Hosting.Kafka.Tests (2 hops), Aspire.Hosting.Keycloak.Tests (2 hops), Aspire.Hosting.Kubernetes.Tests (2 hops), Aspire.Hosting.Maui.Tests, Aspire.Hosting.Milvus.Tests (2 hops), Aspire.Hosting.MongoDB.Tests (2 hops), Aspire.Hosting.MySql.Tests (2 hops), Aspire.Hosting.Nats.Tests (2 hops), Aspire.Hosting.OpenAI.Tests (2 hops), Aspire.Hosting.Oracle.Tests (2 hops), Aspire.Hosting.Orleans.Tests (2 hops), Aspire.Hosting.PostgreSQL.Tests (2 hops), Aspire.Hosting.Python.Tests (2 hops), Aspire.Hosting.Qdrant.Tests (2 hops), Aspire.Hosting.RabbitMQ.Tests (2 hops), Aspire.Hosting.Redis.Tests (2 hops), Aspire.Hosting.RemoteHost.Tests, Aspire.Hosting.Rust.Tests (2 hops), Aspire.Hosting.Seq.Tests (2 hops), Aspire.Hosting.SqlServer.Tests (2 hops), Aspire.Hosting.Valkey.Tests (2 hops), Aspire.Hosting.Yarp.Tests (2 hops), Aspire.Playground.Tests

🔧 src/Aspire.Dashboard/Authentication/DashboardAuthenticationState.cs (changed source)
→ 4 via the project graph: Aspire.Dashboard.Tests, Aspire.Hosting.DotnetTool.Tests (2 hops), Aspire.Hosting.JavaScript.Tests, Aspire.Hosting.Testing.Tests

🧪 tests/Aspire.Hosting.Tests/Dcp/DcpExecutorTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests
→ 3 via the project graph: Aspire.Hosting.Blazor.Tests, Aspire.Hosting.Dotnet.Tests, Aspire.Hosting.Radius.Tests

📦 affected project Aspire.Hosting.Dotnet
→ 2 tests: Aspire.Cli.EndToEnd.Tests, Aspire.Templates.Tests

📦 affected project Aspire.Cli
→ 1 test: Aspire.Cli.EndToEnd.Tests

📦 affected project Aspire.Dashboard
→ 1 test: Aspire.Templates.Tests

📄 eng/pipelines/azure-pipelines-unofficial.yml (changed)
→ 1 directly: Infrastructure.Tests

📄 eng/pipelines/azure-pipelines.yml (changed)
→ 1 directly: Infrastructure.Tests

🔧 src/Aspire.Dashboard/Resources/Routes.resx (changed source)
→ 1 directly: Infrastructure.Tests

🧪 tests/Aspire.Cli.Tests/Commands/Sdk/SdkResponseFileTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/SdkCommandTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Commands/SdkDumpCommandTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/DotNet/DotNetCliRunnerTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/DotNet/ProcessInvocationOptionsTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Projects/AppHostServerProjectTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/Projects/PrebuiltAppHostServerTests.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Cli.Tests/TestServices/TestAppHostServerProjectFactory.cs (changed test)
→ 1 directly: Aspire.Cli.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/Controls/DashboardNotAuthorizedTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/Interactions/InteractionsProviderTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/Layout/DashboardDialogProviderTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/Layout/MainLayoutTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/Layout/WindowLayoutTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/Pages/TerminalWindowTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Dashboard.Components.Tests/RoutesTests.cs (changed test)
→ 1 directly: Aspire.Dashboard.Components.Tests

🧪 tests/Aspire.Hosting.Tests/ExecutionConfigurationGathererTests.cs (changed test)
→ 1 directly: Aspire.Hosting.Tests

Job reasons

Job Triggered by
cli-starter-validation affected project Aspire.Cli
extension-e2e • src/Aspire.Cli/Commands/Sdk/SdkDumpCommand.cs, src/Aspire.Cli/Commands/Sdk/SdkExportCommand.cs, src/Aspire.Cli/Commands/Sdk/SdkGenerateCommand.cs, src/Aspire.Cli/DotNet/DotNetCliRunner.cs, src/Aspire.Cli/Projects/AppHostServerProject.cs, src/Aspire.Cli/Projects/DotNetBasedAppHostServerProject.cs, src/Aspire.Cli/Projects/PrebuiltAppHostServer.cs, src/Aspire.Cli/Utils/CliPathHelper.cs, src/Aspire.Dashboard/Authentication/DashboardAuthenticationState.cs, src/Aspire.Dashboard/Components/Controls/DashboardNotAuthorized.razor, src/Aspire.Dashboard/Components/Controls/DashboardNotAuthorized.razor.cs, src/Aspire.Dashboard/Components/Interactions/InteractionsProvider.cs, src/Aspire.Dashboard/Components/Layout/DashboardDialogProvider.cs, src/Aspire.Dashboard/Components/Layout/MainLayout.razor.cs, src/Aspire.Dashboard/Components/Layout/WindowLayout.razor, src/Aspire.Dashboard/Components/Layout/WindowLayout.razor.cs, src/Aspire.Dashboard/Components/Pages/TerminalWindow.razor, src/Aspire.Dashboard/Components/Routes.razor, src/Aspire.Dashboard/Components/Routes.razor.cs, src/Aspire.Dashboard/Resources/Routes.Designer.cs, src/Aspire.Dashboard/Resources/Routes.resx, src/Aspire.Dashboard/Resources/xlf/Routes.cs.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.de.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.es.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.fr.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.it.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.ja.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.ko.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.pl.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.pt-BR.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.ru.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.tr.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.zh-Hans.xlf, src/Aspire.Dashboard/Resources/xlf/Routes.zh-Hant.xlf, src/Aspire.Hosting/ApplicationModel/HostUrl.cs, src/Aspire.Hosting/ApplicationModel/ResourceExtensions.cs, src/Aspire.Hosting/Dcp/ContainerCreator.cs
• affected project Aspire.Cli
native-dashboard-validation affected project Aspire.Dashboard
polyglot • affected project Aspire.Cli
• affected project Aspire.Hosting.Azure.Provisioning.KeyVault
typescript-api-compat affected project Aspire.Cli

Selection computed for commit ac8f0e8.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The security-sensitive forward merge still requires maintainer review of conflict resolutions, fresh merge-result CI, and internal installer-stage validation that historical release-branch checks cannot provide.

No open issues 🎉

1 file not reviewed
  • src/Aspire.Dashboard/Resources/Routes.Designer.cs: Generated file

Review effort: Balanced

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants