Change systemd fsck device dependencies to Wants - #18791
Draft
Pawel Winogrodzki (PawelWMS) wants to merge 1 commit into
Draft
Change systemd fsck device dependencies to Wants#18791Pawel Winogrodzki (PawelWMS) wants to merge 1 commit into
Pawel Winogrodzki (PawelWMS) wants to merge 1 commit into
Conversation
Avoid stopping root and template filesystem checks solely because a filesystem UUID alias disappears during probing. Preserve device ordering, root mount dependencies, and the generated usr checker binding. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: bb0e6716-4886-4e95-9efe-71dcde8687d6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
BindsTo=withWants=in the generated initrdsystemd-fsck-root.serviceand the staticsystemd-fsck@.servicetemplate.After=ordering, the generatedsystemd-fsck-usr.servicebinding, and the UUID-based source and dependencies ofsysroot.mount.systemdandsystemd-boot-signedtogether to release 255-35.Why
A transient filesystem probe failure can remove the root UUID alias and cause
BindsTo=to stop a filesystem check, canceling dependent boot jobs. This dependency-only alternative lets the checker finish despite loss of the alias.Related issue: systemd/systemd#43695
This is an alternative to #18653, not an additional patch to combine with it.
Risk
Wants=does not propagate device activation failure and does not automatically stop the checker when the device disappears. The static template change applies to all instances, including non-root filesystem checks.This change does not recreate UUID links, retry failed mounts, or rebuild canceled boot transactions.
sysroot.mountcan still fail if its UUID path is absent when the mount runs. The draft remains experimental.Verification
BindsTo=, the expected UUIDWants=, unchanged root-mount dependencies, and verbose serial logging.