Skip to content

fix: Upgrade Node.js version - #721

Merged
Roopan-Microsoft merged 1 commit into
mainfrom
psl-upgrade-nodejs
Oct 28, 2026
Merged

Roopan-Microsoft merged 1 commit into
mainfrom
psl-upgrade-nodejs

Conversation

@KanchanN-Microsoft

Copy link
Copy Markdown
Contributor

Purpose

This pull request upgrades all Node.js environments in the project to Node.js 24, ensuring consistency across development containers, Dockerfiles, CI workflows, and engine constraints. This update helps maintain compatibility with the latest Node.js features and security updates.

Node.js version upgrades:

  • .devcontainer/Dockerfile: Updated Node.js installation from version 20 to 24 by changing the NodeSource setup script.
  • .github/workflows/test.yml: Updated the commented-out Node.js version in the GitHub Actions workflow from 20 to 24.
  • src/ContentProcessorWeb/.devcontainer/Dockerfile, src/ContentProcessorWeb/.devcontainer/base.Dockerfile, src/ContentProcessorWeb/.devcontainer/devcontainer.json: Changed the Node.js variant from latest or version 22 to 24-bookworm for dev containers. [1] [2] [3]
  • src/ContentProcessorWeb/Dockerfile, src/ContentProcessorWeb/package.json: Updated the Node.js base image and engine constraints from version 22 to 24. [1] [2]
  • src/ContentProcessorWorkflow/.devcontainer/devcontainer.json, src/ContentProcessorWorkflow/Dockerfile: Updated Node.js feature and installation from version 22 to 24. [1] [2]

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL122516786% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
244 0 💤 0 ❌ 0 🔥 2.602s ⏱️

@Roopan-Microsoft
Roopan-Microsoft merged commit f397463 into main Oct 28, 2026
13 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The lockfile still restricts the self-dependency to Node 22, so frozen installs with strict engine checking can fail on Node 24.

1 open issue
What changed in this PR

This PR moves the project’s Node.js configurations to version 24 across development containers and application images.

Changes:

  • Updates the web build image and workflow runtime to Node.js 24.22.1, and adjusts the web package’s engine requirement.
  • Switches development containers to Node.js 24 and updates the web dev-container image namespace.
  • Updates the commented-out CI setup example to Node.js 24; active CI behavior is unchanged.
File Description
src/​ContentProcessorWorkflow/​Dockerfile Installs Node.js 24.22.1 for MCP tools.
src/​ContentProcessorWorkflow/​.devcontainer/​devcontainer.json Selects the Node.js 24 feature.
src/​ContentProcessorWeb/​package.json Requires Node.js >=24.22.1 <25.
src/​ContentProcessorWeb/​Dockerfile Uses the Node.js 24.22.1 Bookworm build image.
src/​ContentProcessorWeb/​.devcontainer/​Dockerfile Selects the current TypeScript dev-container image namespace and Node.js 24 variant.
src/​ContentProcessorWeb/​.devcontainer/​devcontainer.json Passes the 24-bookworm build variant.
src/​ContentProcessorWeb/​.devcontainer/​base.Dockerfile Selects the current JavaScript dev-container image namespace and Node.js 24 variant.
.github/​workflows/​test.yml Updates only the commented Node.js setup example.
.devcontainer/​Dockerfile Installs Node.js 24 through NodeSource.

Review effort: Balanced

"private": true,
"engines": {
"node": ">=22.22.0 <23"
"node": ">=24.22.1 <25"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants