Repository navigation
fix: Upgrade Node.js version - #721
Merged
Merged
Conversation
Roopan-Microsoft
approved these changes
Oct 28, 2026
Roopan-Microsoft
approved these changes
Oct 28, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The lockfile still restricts the self-dependency to Node 22, so frozen installs with strict engine checking can fail on Node 24.
1 open issue
What changed in this PR
This PR moves the project’s Node.js configurations to version 24 across development containers and application images.
Changes:
- Updates the web build image and workflow runtime to Node.js 24.22.1, and adjusts the web package’s engine requirement.
- Switches development containers to Node.js 24 and updates the web dev-container image namespace.
- Updates the commented-out CI setup example to Node.js 24; active CI behavior is unchanged.
| File | Description |
|---|---|
src/ContentProcessorWorkflow/Dockerfile |
Installs Node.js 24.22.1 for MCP tools. |
src/ContentProcessorWorkflow/.devcontainer/devcontainer.json |
Selects the Node.js 24 feature. |
src/ContentProcessorWeb/package.json |
Requires Node.js >=24.22.1 <25. |
src/ContentProcessorWeb/Dockerfile |
Uses the Node.js 24.22.1 Bookworm build image. |
src/ContentProcessorWeb/.devcontainer/Dockerfile |
Selects the current TypeScript dev-container image namespace and Node.js 24 variant. |
src/ContentProcessorWeb/.devcontainer/devcontainer.json |
Passes the 24-bookworm build variant. |
src/ContentProcessorWeb/.devcontainer/base.Dockerfile |
Selects the current JavaScript dev-container image namespace and Node.js 24 variant. |
.github/workflows/test.yml |
Updates only the commented Node.js setup example. |
.devcontainer/Dockerfile |
Installs Node.js 24 through NodeSource. |
Review effort: Balanced
| "private": true, | ||
| "engines": { | ||
| "node": ">=22.22.0 <23" | ||
| "node": ">=24.22.1 <25" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose
This pull request upgrades all Node.js environments in the project to Node.js 24, ensuring consistency across development containers, Dockerfiles, CI workflows, and engine constraints. This update helps maintain compatibility with the latest Node.js features and security updates.
Node.js version upgrades:
.devcontainer/Dockerfile: Updated Node.js installation from version 20 to 24 by changing the NodeSource setup script..github/workflows/test.yml: Updated the commented-out Node.js version in the GitHub Actions workflow from 20 to 24.src/ContentProcessorWeb/.devcontainer/Dockerfile,src/ContentProcessorWeb/.devcontainer/base.Dockerfile,src/ContentProcessorWeb/.devcontainer/devcontainer.json: Changed the Node.js variant fromlatestor version 22 to24-bookwormfor dev containers. [1] [2] [3]src/ContentProcessorWeb/Dockerfile,src/ContentProcessorWeb/package.json: Updated the Node.js base image and engine constraints from version 22 to 24. [1] [2]src/ContentProcessorWorkflow/.devcontainer/devcontainer.json,src/ContentProcessorWorkflow/Dockerfile: Updated Node.js feature and installation from version 22 to 24. [1] [2]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information