Repository navigation
fix: Upgrade Node.js version - #375
Closed
KanchanN-Microsoft wants to merge 1 commit into
Closed
KanchanN-Microsoft wants to merge 1 commit into
KanchanN-Microsoft wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
No concrete defects were identified, but successful frontend container builds and devcontainer creation remain unverified for this major Node.js upgrade.
No open issues 🎉
What changed in this PR
Standardizes the development environment and frontend container builds on Node.js 24 LTS for both applications.
Changes:
- Pins the devcontainer Node.js version to 24 instead of the moving LTS alias.
- Updates all three frontend Docker build stages from Node.js 20 to 24.
- Aligns both frontend READMEs with the Node.js 24 LTS prerequisite.
| File | Description |
|---|---|
scenario-app/frontend/README.md |
Documents Node.js 24 LTS as a prerequisite. |
scenario-app/frontend/Dockerfile |
Updates widget and application builders to Node.js 24. |
chat-app/frontend/README.md |
Documents Node.js 24 LTS as a prerequisite. |
chat-app/frontend/Dockerfile |
Updates the frontend builder to Node.js 24. |
.devcontainer/devcontainer.json |
Pins the Node.js feature to version 24. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the Node.js version used across the development environment, Dockerfiles, and documentation for both the chat and scenario frontend applications. The main goal is to standardize on Node.js 24 LTS, ensuring consistency and compatibility throughout the project.
Node.js Version Upgrade:
.devcontainer/devcontainer.jsonfrom"lts"to"24"to align the development environment with the new standard.chat-app/frontend/Dockerfileto usenodejs:24instead ofnodejs:20.scenario-app/frontend/Dockerfilefor bothwidget-builderandapp-builderstages to usenodejs:24instead ofnodejs:20.Documentation Updates:
chat-app/frontend/README.mdto specify Node.js 24 LTS.scenario-app/frontend/README.mdto specify Node.js 24 LTS.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information