Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def evaluate(expression: str, state: PipelineRunState) -> Union[str, int, float,

variables = {variable.name: variable.value for variable in state.variables}

state_iter_item_json = json.dumps(state.iteration_item) if state.iteration_item else None
state_iter_item_json = json.dumps(state.iteration_item) if state.iteration_item is not None else None

result = evaluator.EvaluateExpression(
expression,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,11 @@
),
p("@item()", PipelineRunState(iteration_item="value"), "@item()", "value", id="item_reference"),
p("@item() ", PipelineRunState(iteration_item="value"), "@item() ", "value", id="item_reference_with_ws"),
p("@item()", PipelineRunState(iteration_item=0), "@item()", 0, id="item_reference_zero"),
p("@item()", PipelineRunState(iteration_item=""), "@item()", "", id="item_reference_empty_string"),
p("@item()", PipelineRunState(iteration_item=False), "@item()", False, id="item_reference_false"),
p("@item()", PipelineRunState(iteration_item=[]), "@item()", [], id="item_reference_empty_list"),
p("@item()", PipelineRunState(iteration_item={}), "@item()", {}, id="item_reference_empty_dict"),
p("@concat('a', 'b' )", PipelineRunState(), "@concat('a', 'b' )", "ab", id="function_call"),
p(
"@concat('https://example.com/jobs/', '123''', concat('&', 'abc,'))",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,37 @@ def test_evaluated_raises_error_when_evaluated_value_is_not_a_list(evaluated_val
ex_info.value.args[0]
== "Iteration expression of Activity: 'ForEachActivity' does not evaluate to the expected type: 'list'."
)


def test_when_evaluate_child_activities_then_falsy_items_are_passed_as_item() -> None:
# Arrange
test_framework = TestFramework(TestFrameworkType.Fabric)
for_each_activity = ForEachActivity(
name="ForEachActivity",
typeProperties={
"items": DataFactoryElement("@range(0, 3)"),
},
activities=[
SetVariableActivity(
name="setVariable",
typeProperties={
"variableName": "variable",
"value": DataFactoryElement("@item()"),
},
depends_on=[],
),
],
depends_on=[],
)
state = PipelineRunState(
variables=[
PipelineRunVariable(name="variable", default_value=0),
],
)

# Act
activities = test_framework.evaluate_activity(for_each_activity, state)

# Assert
items = [activity.type_properties["value"].result for activity in activities]
assert items == [0, 1, 2]
Loading