Repository navigation
Harden Psi4 workflows and add genuine molToolkit UMAP support - #274
Open
preetibayasMS wants to merge 3 commits into
Open
preetibayasMS wants to merge 3 commits into
preetibayasMS wants to merge 3 commits into
Conversation
Add explicit dipole extraction, validated spin references, isolated calculation workers and artifacts, and bounded optimization recovery with focused regression tests and runtime smoke coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 87cf205e-4bdc-4491-9fdd-cbec1660935f
Install umap-learn in molenv, require a real ten-candidate precomputed-distance embedding during image builds, and document algorithm fidelity, reproducibility, and coordinated image/agent updates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 87cf205e-4bdc-4491-9fdd-cbec1660935f
Keep Linux launcher shebangs and the full branch whitespace check valid without changing script behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 87cf205e-4bdc-4491-9fdd-cbec1660935f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden Psi4 screening and charged-state workflows, and add explicit, executable UMAP support to molToolkit. These changes prevent incomplete scientific outputs from being reported as fully successful and prevent a different dimensionality-reduction algorithm from being mislabeled as UMAP.
umap-learnto the existing Python 3.11 mamba environment transaction and run a real ten-candidate Tanimoto-distance embedding during image builds.Type of change
agents/<name>/)starter-kits/<name>/)docs/schemas/**).github/**)Tool-runtime implementation, dependency, regression-test, and smoke-check updates under the existing Psi4 and molToolkit agents.
Related issue / tracking
n/a
Schema impact
breaking-changelabel and link the rollout plan belowNo catalog schema change. The updated Psi4 tool command requires the matching image's new launcher and workflow helpers; update the image before the deployed tool/agent. Likewise, do not deploy molToolkit instructions claiming UMAP support against an older image without that dependency.
Validation checklist
README.md, schemas) is updated to match the change..auto-registry/**(it is generated post-merge)..DS_Store,.env,*.swp,.idea/,.vs/, etc.).No model weights are added. Existing README links have not been comprehensively revalidated; this change adds no external Markdown links.
Reviewer notes (optional)
Recorded focused checks:
agents/psi4/tools/psi4,python -m unittest -v test_psi4_reliability— passed earlier: 23 mocked-Psi4 tests. A final publication-time rerun was blocked by the local command-approval gate; no new successful rerun is claimed.python agents/mol-toolkit/tools/mol-toolkit/app/smoke_umap.pyin an isolated UMAP-capable environment (the executed command used absolute interpreter/checkout paths) — passed, reportingUMAP_SMOKE_OK,umap-learn=0.5.12, and ten finite 2D coordinates.python -m pip_audit --progress-spinner off --format json --output umap-dependency-audit.json(the executed output path was in the local session directory) — passed: no known vulnerabilities in that isolated environment.git --no-pager diff origin/main...HEAD --check— passed after normalizing the new molToolkit/Psi4 scripts' CRLF line endings to LF. The normalization-only follow-up commit changes no script behavior.The local UMAP execution used Python 3.14.8 with NumPy 2.5.4, SciPy 1.18.1, Numba 0.68.0, and scikit-learn 1.9.1. It is not verification of the full conda-resolved Python 3.11 container. The new Dockerfile gate must pass in the approved target build.
Not run: container builds, real Psi4 numerical smoke, or end-to-end scientific candidate workflows. Mocked Psi4 tests do not establish numerical convergence, basis availability, resource sufficiency, or the cause of an earlier PSIO failure. No subprocess wall-clock timeout was added.
No image was built, published, retagged, replaced, or deployed during this preparation. Obtain deployment approval, build and scan matching images, execute the documented real-runtime checks, then update deployed tools and agents together.