Skip to content

Fix Microsoft Discovery onboarding workload region alignment - #275

Merged
leijgao merged 1 commit into
mainfrom
fix/onboarding-workload-region-alignment
Oct 28, 2026
Merged

leijgao merged 1 commit into
mainfrom
fix/onboarding-workload-region-alignment

Conversation

@leijgao

@leijgao leijgao commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Validate the existing VNet and deployment subnet regions against workloadRegion, not controlPlaneRegion.
  • Allow Discovery control-plane resources to use a different region while keeping the VNet/subnets and all managed-resource-group resources in the workload region.
  • Stop deployment before Bicep or ARM submission when a subnet VNet is in the wrong region or its region cannot be read.
  • Update remediation guidance, schema/template descriptions, documentation, and regression tests.

Validation

  • 61 Pester tests passed across Stage1Config, Stage4State, DryRun, and DeploymentRegression suites.
  • Bicep build completed and the generated ARM template was refreshed.
  • PowerShell parser checks, config schema validation, and git diff --check passed.
  • No live Azure deployment performed.

Validate VNet and subnet regions against workloadRegion while allowing controlPlaneRegion to differ. Update region remediation, template descriptions, documentation, and regression coverage.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f99a2809-9734-417e-aa6d-0eed6b1372e8
@leijgao
leijgao requested a review from a team as a code owner October 28, 2026 19:44
@github-actions github-actions Bot added the pr-validation-passed The pr-review workflow's validator passed. Other status checks report separately. label Oct 28, 2026
@leijgao
leijgao merged commit a325cd7 into main Oct 28, 2026
14 checks passed
@leijgao
leijgao deleted the fix/onboarding-workload-region-alignment branch October 28, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validation-passed The pr-review workflow's validator passed. Other status checks report separately.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants