Skip to content

[Open Data] Update commitment discount eligibility (October 2026) - #2343

Merged
Roland Krummenacher (RolandKrummenacher) merged 2 commits into
devfrom
opendata/commitment-eligibility-20261012-38
Oct 14, 2026
Merged

Roland Krummenacher (RolandKrummenacher) merged 2 commits into
devfrom
opendata/commitment-eligibility-20261012-38

Conversation

@RolandKrummenacher

@RolandKrummenacher Roland Krummenacher (RolandKrummenacher) commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Automated update of commitment discount eligibility data from the Azure Retail Prices API, produced by the Update Commitment Discount Eligibility workflow (run 38214571289).

Net +6,322 meters (92,893 → 99,215), composed of:

Change Count
Meters added 6,433
Meters removed 111
Eligibility changed on retained meters 24
Retained unchanged 92,758

Resulting distribution:

Spend / Usage eligibility dev This PR
Eligible / Eligible 56,392 61,990
Eligible / Not Eligible 26,735 27,177
Not Eligible / Eligible 9,766 10,048

Both fetch passes returned identical meter sets (0% drift) for reservations (72,038) and savings plans (89,167), and the historical guards passed.

Why the jump is so large

Almost all of the growth arrived in a single week: the 21 and 28 September runs saw 92,877 and 92,905 meters, the 5 October run saw 99,116. A random sample of 60 added meters, looked up against the live API, all exist and all have an earliest effectiveStartDate of 2026-10-01 — an Azure price list update, not a fetch artifact. 51 of the 60 are Virtual Machines, mainly:

  • New VM series: Dpsv7, Dpdsv7, Dpldsv7, Dplsv7, Epsv7, Epdsv7, Mpsv4/Mpdsv4, Lpsv5, Falsv6, NCdsxl RTX 6000 v6
  • New regions: taiwannorth, taiwannorthwest, southeastasia3 (19 of the 60), which also adds meters for existing series such as Easv4 and ESv3

The rest are spread across MySQL, PostgreSQL, Cosmos DB, SQL Database, SQL Managed Instance, and App Service.

Non-additive rows, verified against the live API

Checked with api-version=2023-01-01-preview and meterRegion='primary', the same parameters the fetch script uses.

  • 24 eligibility changes: all are Eligible / Not Eligible → Eligible / Eligible, and all 24 are Virtual Machines HBrsv5 Linux meters. The live API now returns savings plan pricing (1Y, 3Y) alongside reservations (1Y, 3Y, 5Y), so dev is stale.
  • 111 removals (105 Eligible / Not Eligible, 6 Not Eligible / Eligible): a sample of 15 returns no items from the live API. These are retired meters, dropped by design so they age out instead of accumulating.

Notes

The Open Data CI added a commit that regenerates src/powershell/Private/Get-OpenDataCommitmentDiscountEligibility.ps1 from the updated CSV, so the PowerShell lookup stays in sync with the data.

This PR is opened from the 12 October branch. The 21 September, 28 September, and 5 October branches are snapshots that this one supersedes (each run is a full fetch) and have been deleted. GitHub Actions can't open PRs in this org, which is why those weeks never got a PR.

Test plan

  • Open Data CI passes
  • Review the diff for unexpected changes (large drops in meter count, etc.)
  • Spot-check new, changed, and removed meter IDs against the live Retail Prices API

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings October 12, 2026 14:27
@RolandKrummenacher Roland Krummenacher (RolandKrummenacher) added Needs: Review 👀 PR that is ready to be reviewed Status: ▶️ Ready Issue is ready for a dev to start work Tool: Open data Datasets to normalize and enhance FinOps reports labels Oct 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Generated outputs are internally consistent; only a nonblocking summary-count correction remains.

1 open finding
What changed in this PR

Updates commitment discount eligibility data from the Azure Retail Prices API.

Changes:

  • Updates eligibility for 99,215 meters.
  • Regenerates the PowerShell lookup.
  • Refreshes per-family completeness baselines.
File Description
src/​open-data/​CommitmentDiscountEligibility.csv Updates meter eligibility data.
src/​open-data/​CommitmentDiscountEligibility.familycounts.json Refreshes family-level baseline counts.
src/​powershell/​Private/​Get-OpenDataCommitmentDiscountEligibility.ps1 Mirrors the updated CSV data in PowerShell.

🧠 Review effort: Balanced


💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/open-data/CommitmentDiscountEligibility.familycounts.json
@RolandKrummenacher
Roland Krummenacher (RolandKrummenacher) merged commit 1db5378 into dev Oct 14, 2026
7 checks passed
@RolandKrummenacher
Roland Krummenacher (RolandKrummenacher) deleted the opendata/commitment-eligibility-20261012-38 branch October 14, 2026 15:14
@microsoft-github-policy-service

Copy link
Copy Markdown

@allcontributors

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service[bot]

Roland Krummenacher (@RolandKrummenacher) already contributed before to code

This branch was successfully deployed

1 active deployment
ftk-pr — d071716c Deployed Oct 14, 2026 by RolandKrummenacher via Clean up PR resources #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Status: ▶️ Ready Issue is ready for a dev to start work Tool: Open data Datasets to normalize and enhance FinOps reports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants