feat: preserve DOCX table structure as HTML#2111
Open
gyx09212214-prog wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docx_table_format="html"mode for DOCX conversion.<table>output when DOCX tables contain structure that Markdown pipe tables cannot represent, such as merged cells and nested tables.docx_markdownify_optionsforwarding for DOCX conversions and expose--docx-table-format markdown|htmlin the CLI.Why
Markdown pipe tables cannot represent
rowspan,colspan, or nested table structure. For document ingestion workflows, especially financial or research documents, merged headers and nested table regions often carry important meaning that should survive conversion.Related issues: #1211, #1217, #1248, #167.
Tests
python -m pytest packages\markitdown\tests\test_docx_tables.py packages\markitdown\tests\test_module_misc.py::test_docx_comments packages\markitdown\tests\test_module_misc.py::test_docx_equations packages\markitdown\tests\test_cli_misc.py -qpython -m black --check packages\markitdown\src\markitdown\converters\_markdownify.py packages\markitdown\src\markitdown\converters\_docx_converter.py packages\markitdown\src\markitdown\_markitdown.py packages\markitdown\src\markitdown\__main__.py packages\markitdown\tests\test_docx_tables.pyNote: I also tried
test_cli_vectors.py::test_output_to_stdout; failures were due to the local environment only having[docx]installed and missing optional[xls],[outlook], and[pdf]dependencies, not this change.