feat: add query() time_unit option, list_streams(), list_alerts(), docs fix - #937
Julien (juju4) wants to merge 10 commits into
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Ian Hellen (ianhelle)
left a comment
Ian Hellen (ianhelle)
left a comment
There was a problem hiding this comment.
The feature additions look reasonable, but the PR currently fails tests and introduces invalid notebook/documentation content. Please address the inline findings before merge.
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "execution_count": 1, |
There was a problem hiding this comment.
This adds execution_count to a Markdown cell, which is invalid under the notebook schema. nbformat.validate() raises NotebookValidationError: Additional properties are not allowed. Please remove this property from the Markdown cell.
There was a problem hiding this comment.
On notebook, I think that I created the issue when I sanitized the file but current file (https://github.com/microsoft/msticpy/blob/main/docs/notebooks/Openobserve-DataConnector.ipynb) is seen as invalid in github.
The updated file is readable both in github (https://github.com/juju4/msticpy/blob/c3d8e82b10bfbbfd23ac0bfcd04ab09514d273e8/docs/notebooks/Openobserve-DataConnector.ipynb but not anymore) and in jupyter lab even if still issue: vscode/codium also returns an error ("Cannot read properties of undefined (reading 'toString')"). unclear why.
2 participants
No description provided.