Skip to content

[CI] Add nightly ARM64 tests for Process Containers and Isolation Session - #1241

Open
Elliot (theelliotm) wants to merge 15 commits into
mainfrom
user/emichlin/adjust-for-floweval
Open

Elliot (theelliotm) wants to merge 15 commits into
mainfrom
user/emichlin/adjust-for-floweval

Conversation

@theelliotm

@theelliotm Elliot (theelliotm) commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

📖 Description

This PR adds jobs that run Process Container and Isolation Session tests in ARM64 images during the nightly CI Scheduled Validation workflow. They mirror their corresponding Windows x64 jobs, with the exception of 23H2 which does not have an ARM image available for testing currently.

Other Changes

  • Powershell 7, Node, and Python 3 now install during each job via winget. This helps for compat with FlowEval.
  • Removed Hyperlight mentions
  • Documentation brought up-to-date

🔗 References

🔍 Validation

Tested in CI: https://github.com/microsoft/mxc/actions/runs/35917329987/job/107378599796
Process Container and Isolation Session tests function identically.

✅ Checklist

📋 Issue Type

  • Bug fix
  • Feature
  • Task
Microsoft Reviewers: Open in CodeFlow

Copilot AI balanced review requested due to automatic review settings September 23, 2026 00:40
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Incorrect WinGet installer filters can prevent required tooling installation and fail CI jobs.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 High severity · 2 Low severity

Open (3)
What changed in this PR

Adds nightly Windows ARM64 validation for Process Container and Isolation Session workloads.

Changes:

  • Enables eligible ARM64 Windows matrix jobs.
  • Installs PowerShell, Node, and Python through WinGet.
  • Removes Hyperlight validation support and updates documentation.
File Review
scripts/​ci/​validation-test-matrix.json Adds ARM64 Windows pools and capabilities.
scripts/​ci/​run_backend_validation_tests.sh Removes Hyperlight dispatch, but usage text still advertises it (nit).
scripts/​ci/​run_backend_validation_tests.ps1 Removes Hyperlight dispatch, but referenced documentation remains stale (nit).
scripts/​ci/​resolve-validation-test-matrix.mjs Enables eligible ARM64 matrix expansion.
scripts/​ci/​prepare-windows-host.ps1 Adds tooling installation; incorrect WinGet installer filters block PowerShell (critical), Node, and Python (moderate).
scripts/​ci/​prepare-linux-host.sh Removes Hyperlight preparation, but referenced documentation remains stale (nit).
docs/​ci-validation-infrastructure.md Contains inaccurate timeouts, capabilities, ARM64 pools/availability, and WSLC behavior (nits).
.github/​workflows/​Validation.Tests.Matrix.Job.yml Changes Windows preparation behavior and timeout; documentation remains inconsistent (nit).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/ci/prepare-windows-host.ps1
Comment thread docs/ci-validation-infrastructure.md Outdated
Comment thread scripts/ci/run_backend_validation_tests.sh
Copilot AI review requested due to automatic review settings September 23, 2026 00:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

CI documentation remains inconsistent with the matrix, timeout, and removed Hyperlight dispatcher support.

Review effort: Balanced
Findings: None

Resolved since last review (3)
Previously missed (1)

In code that hasn't changed since last review

Low severity Document accurate x64 capabilities for 25H2 and 24H2

docs/​ci-validation-infrastructure.md:112

The documented capabilities for 25H2 and 24H2 do not match the catalog: their x64 backends arrays contain process-t1, wslc, windows-sandbox, and microvm, with no isolation-session; only the ARM64 arrays add isolation-session. Replacing same as above with the actual lists is necessary so this table does not advertise an unsupported x64 capability.

Copilot AI review requested due to automatic review settings September 23, 2026 01:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

CI documentation remains inconsistent with the backend catalog and dispatcher behavior.

Review effort: Balanced
Findings: 1 Low severity

Open (1)
Previously missed (1)

In code that hasn't changed since last review

Low severity Update CI docs after removing hyperlight backend

scripts/​ci/​run_backend_validation_tests.ps1:18

This removes hyperlight from the dispatcher, but tests/scripts/README.md:98-99 still documents hyperlight as an accepted CI backend for these two dispatchers. That leaves the CI documentation contradictory: following the documented backend id now fails validation before any suite runs. Update the dispatcher documentation in the same change.

Comment thread docs/ci-validation-infrastructure.md Outdated
Copilot AI review requested due to automatic review settings September 23, 2026 19:39

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The capability documentation contradicts the validation catalog and related dispatch documentation remains stale.

Review effort: Balanced
Findings: 1 Low severity

Open (1)

Updated the infrastructure documentation to include new configurations for Windows 25h2 and 24h2 with additional features.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 23, 2026 21:10
@theelliotm
Elliot (theelliotm) marked this pull request as ready for review September 23, 2026 21:12
@theelliotm
Elliot (theelliotm) requested a review from a team as a code owner September 23, 2026 21:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The Python installation failure and inaccurate ARM64 documentation must be corrected before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 High severity

Open (1)
Resolved since last review (1)
Previously missed (1)

In code that hasn't changed since last review

Low severity Remove hyperlight from dispatcher documentation

scripts/​ci/​run_backend_validation_tests.ps1:18

After removing hyperlight from both validation dispatchers, tests/scripts/README.md still advertises it as a supported backend for each dispatcher. That documentation now causes users to select an ID rejected by these entry points; please update the dispatcher table in the same change.

Comment thread scripts/ci/prepare-windows-host.ps1
Copilot AI review requested due to automatic review settings September 23, 2026 21:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The ARM64 capability documentation must list only the supported backends.

Review effort: Balanced
Findings: None

Resolved since last review (1)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants