Conversation
Delegate self-contained Linux curl/mbedTLS construction to 1DS, use Apple system SQLite/libz with host-owned process lifecycle, and use minimal private SQLite on other non-Windows platforms. Preserve static-package dependency targets and the released-SDK compatibility patch. Files changed: - cmake/CMakeLists.txt - cmake/deps.txt - cmake/external/onnxruntime_external_deps.cmake - cmake/external/telemetry_linux_http.cmake - cmake/onnxruntime_common.cmake - cmake/patches/cpp_client_telemetry/cpp_client_telemetry.patch - cmake/vcpkg-ports/cpp-client-telemetry/vcpkg.json - onnxruntime/core/platform/posix/telemetry.cc Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The delegated curl path loses required CA-path sanitization and static-package export normalization.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Standardizes non-Windows telemetry dependencies across Linux and Apple platforms.
Changes:
- Delegates Linux curl/mbedTLS construction to 1DS.
- Uses system SQLite/zlib on Apple and private dependencies elsewhere.
- Preserves static-package targets and adds pthread-safe mbedTLS configuration.
| File | Description |
|---|---|
onnxruntime/core/platform/posix/telemetry.cc |
Avoids process-global SQLite shutdown on Apple. |
cmake/vcpkg-ports/cpp-client-telemetry/vcpkg.json |
Excludes SQLite/zlib packages on Apple. |
cmake/patches/cpp_client_telemetry/cpp_client_telemetry.patch |
Enables pthread-safe fetched mbedTLS. |
cmake/onnxruntime_common.cmake |
Links Apple system SQLite and zlib. |
cmake/external/telemetry_linux_http.cmake |
Removes the duplicate Linux dependency builder. |
cmake/external/onnxruntime_external_deps.cmake |
Selects platform-specific 1DS dependency providers. |
cmake/deps.txt |
Reclassifies curl and mbedTLS as transitive inventory entries. |
cmake/CMakeLists.txt |
Recreates Apple dependency targets for static packages. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| set(MATSDK_SQLITE_PROVIDER VENDORED CACHE STRING "Use bundled 1DS SQLite" FORCE) | ||
| set(MATSDK_ZLIB_PROVIDER VENDORED CACHE STRING "Use bundled 1DS zlib" FORCE) | ||
| if(CMAKE_SYSTEM_NAME STREQUAL "Linux") | ||
| set(MATSDK_CURL_PROVIDER FETCH CACHE STRING "Build the SDK's pinned curl with mbedTLS" FORCE) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
MINIMALSQLite, vendored zlib, and HTTP-only curl 8.21 with mbedTLS 3.6.7onnxruntime_commonbuilt successfully, including POSIX telemetrygit diff --checkRelated SDK cleanup: microsoft/cpp_client_telemetry#1537