Repository navigation
feat(a365): add explicit skill and command tool refinements - #278
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fd700275-811e-4578-92c1-7e60cbde6f7f
Nikhil Navakiran (nikhilNava)
requested review from
Jackson Weber (JacksonWeber),
Nev (MSNev),
ajmfehr,
Pujarini Mohapatra (biswapm),
Grant Harris (gwharris7),
Hector Hernandez (hectorhdzg),
Jeremy Voss (jeremydvoss),
Julio Carlos Menendez (juliomenendez),
Leighton Chen (lzchen) and
Radhika Gupta (rads-1996)
as code owners
November 4, 2026 21:13
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are blocking approval of the opt-in skill and command metadata changes.
No open issues 🎉
What changed in this PR
Adds opt-in skill and command metadata to Agent365’s ExecuteToolScope, preserving ordinary tool behavior and existing transfer metadata.
Changes:
- Introduces typed refinements for skill loading, resource reading, and command execution, with corresponding attributes and span names.
- Adds
recordProcessExitCode()to record or update exit codes without changing error status. - Exports the new API types and constants, adds coverage, and documents caller privacy responsibilities.
| File | Description |
|---|---|
test/internal/unit/a365/scopes.test.ts |
Tests refinement types, span names, attributes, validation, and exit-code behavior. |
src/index.ts |
Exports refinement types from the package root. |
src/a365/scopes/ExecuteToolScope.ts |
Implements refinement metadata, span naming, and exit-code recording. |
src/a365/index.ts |
Exports refinement types from the Agent365 entry point. |
src/a365/contracts.ts |
Defines skill and command refinement contracts. |
src/a365/constants.ts |
Adds skill and process attribute keys. |
CHANGELOG.md |
Records the new refinement functionality. |
A365_DOCUMENTATION.md |
Documents usage, naming rules, exit-code semantics, and privacy responsibilities. |
Review effort: Balanced
Jackson Weber (JacksonWeber)
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refinementDetailsfor skill loading, skill-resource reading, and command execution onExecuteToolScope.recordProcessExitCode()to record or update the reported exit code, including zero, without inferring failure or clearing an explicit error.Validation