Skip to content

feat(a365): add explicit skill and command tool refinements - #278

Merged
Nikhil Navakiran (nikhilNava) merged 1 commit into
mainfrom
feature/a365-tool-refinements
Nov 4, 2026
Merged

Nikhil Navakiran (nikhilNava) merged 1 commit into
mainfrom
feature/a365-tool-refinements

Conversation

@nikhilNava

Copy link
Copy Markdown
Collaborator

Summary

  • Add typed, opt-in refinementDetails for skill loading, skill-resource reading, and command execution on ExecuteToolScope.
  • Record explicit skill/process attributes and refinement-aware span names while preserving ordinary tool behavior and existing transfer metadata.
  • Add recordProcessExitCode() to record or update the reported exit code, including zero, without inferring failure or clearing an explicit error.
  • Export the new types and constants, document metadata privacy responsibilities, and update the changelog.

Validation

  • 268 targeted scope, post-initialization, and exporter tests passed; 5 existing tests skipped.
  • ESM and CommonJS builds passed.
  • Focused source/test type-check, changed-file ESLint, Prettier, and diff checks passed.
  • The full test type-check has 83 pre-existing errors, identical on the unchanged baseline; this change adds none.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: fd700275-811e-4578-92c1-7e60cbde6f7f

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are blocking approval of the opt-in skill and command metadata changes.

No open issues 🎉

What changed in this PR

Adds opt-in skill and command metadata to Agent365’s ExecuteToolScope, preserving ordinary tool behavior and existing transfer metadata.

Changes:

  • Introduces typed refinements for skill loading, resource reading, and command execution, with corresponding attributes and span names.
  • Adds recordProcessExitCode() to record or update exit codes without changing error status.
  • Exports the new API types and constants, adds coverage, and documents caller privacy responsibilities.
File Description
test/​internal/​unit/​a365/​scopes.test.ts Tests refinement types, span names, attributes, validation, and exit-code behavior.
src/​index.ts Exports refinement types from the package root.
src/​a365/​scopes/​ExecuteToolScope.ts Implements refinement metadata, span naming, and exit-code recording.
src/​a365/​index.ts Exports refinement types from the Agent365 entry point.
src/​a365/​contracts.ts Defines skill and command refinement contracts.
src/​a365/​constants.ts Adds skill and process attribute keys.
CHANGELOG.md Records the new refinement functionality.
A365_DOCUMENTATION.md Documents usage, naming rules, exit-code semantics, and privacy responsibilities.

Review effort: Balanced

@nikhilNava
Nikhil Navakiran (nikhilNava) merged commit 724400e into main Nov 4, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants