Repository navigation
Fix Agent365 non-chat inference export and cross-tenant replay - #316
Merged
Nikhil Navakiran (nikhilNava) merged 3 commits intoNov 5, 2026
Merged
Conversation
Allow canonical non-chat inference spans through the Agent365 exporter. Continue replay after retryable failures and scan up to 100 records while limiting each pass to ten attempts, preserving backoff and lease cleanup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a5430c45-2827-45bb-8b18-7ee88f4bec61
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a5430c45-2827-45bb-8b18-7ee88f4bec61
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changes improving Agent365 inference-span export and durable replay isolation.
No open issues 🎉
What changed in this PR
This PR fixes two Agent365 export gaps: canonical non-chat inference spans are now accepted, and durable replay can continue processing healthy identities when another identity is retrying or blocked.
Changes:
- Accept
text_completionandgenerate_contentwhile preserving legacy-name filtering. - Scan up to 100 queued records and attempt at most 10 deliveries per replay pass, releasing unattempted leases.
- Add regression coverage for identity isolation, replay limits, backoff, shutdown, and persisted backlogs.
No actionable findings. No validation commands were run during this review.
| File | Description |
|---|---|
tests/a365/test_utils.py |
Tests canonical inference-operation filtering. |
tests/a365/test_replay_coordinator.py |
Tests cross-tenant recovery, replay bounds, backoff, and lease cleanup. |
tests/a365/test_exporter.py |
Verifies canonical operations export unchanged and legacy names remain filtered. |
tests/a365/test_durable_restart.py |
Tests multi-pass replay of a real-file backlog. |
src/microsoft/opentelemetry/a365/core/exporters/utils.py |
Adds canonical non-chat inference operations to accepted spans. |
src/microsoft/opentelemetry/a365/core/exporters/replay_coordinator.py |
Separates scan and attempt limits and continues past retryable failures. |
CHANGELOG.md |
Documents both Agent365 fixes and replay limits. |
Review effort: Balanced
Performance comparisonThreshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.
|
Nikhil Navakiran (nikhilNava)
enabled auto-merge (squash)
November 4, 2026 21:11
Radhika Gupta (rads-1996)
approved these changes
Nov 5, 2026
Nikhil Navakiran (nikhilNava)
deleted the
copilot/a365-export-replay-parity
branch
November 5, 2026 16:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
text_completionandgenerate_contentinference spans through Agent365; retain existing identity requirements, unrelated-operation filtering, and legacy-name behavior.Gate eviction is intentionally out of scope. The 100-record scan window is bounded, not an unbounded fairness guarantee.
Validation
Executed locally on Windows with Python 3.11, using this branch's
srconPYTHONPATH:python -m pytest -q tests\a365 --ignore=tests\a365\integration: 711 passed, 21 skipped, 54 subtests passed.tests\a365\test_utils.py,test_exporter.py,test_replay_coordinator.py, andtest_durable_restart.py: 140 passed, 2 skipped, 17 subtests passed.python -m black --checkon all six modified Python files: passed.python -m pylint --output-format=parseableon both modified source files and all four modified test files (using the test allowances fromtox.ini): passed, 10.00/10.python -m mypy --python-version 3.10 --show-error-codes --ignore-missing-importson modified source files, plus--check-untyped-defs --follow-imports=silenton modified test files: passed.git diff --check: passed.The full Agent365 run reports one pre-existing
PytestUnhandledThreadExceptionWarningfromA365EnrichingBatchSpanProcessor(cannot release un-acquired lock). Reproduced the identical warning on unchanged main: 704 passed, 21 skipped, 49 subtests passed. No unrelated processor changes are included.Not run locally: other Python interpreters, Linux/macOS, or credential-dependent live-service integration tests.