Skip to content

Require current PR link in changelog CI - #323

Merged
Radhika Gupta (rads-1996) merged 2 commits into
microsoft:mainfrom
rads-1996:fail-for-missing-pr-link
Nov 6, 2026
Merged

Radhika Gupta (rads-1996) merged 2 commits into
microsoft:mainfrom
rads-1996:fail-for-missing-pr-link

Conversation

@rads-1996

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Performance comparison

Threshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.

Scenario Gating Baseline (ops/s) Candidate (ops/s) Δ % Status
azure_monitor_log yes 35,917.0 36,270.0 -0.97% ✅
azure_monitor_span yes 203,355.4 209,073.8 -2.74% ✅
otel_log no 41,259.2 42,130.1 -2.07% ✅
otel_span no 60,698.0 60,884.7 -0.31% ✅

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The added changelog entry lacks this PR’s link, causing the new changelog validation step to fail whenever the job runs.

1 open issue
What changed in this PR

This PR strengthens changelog validation by requiring newly added CHANGELOG.md content to include a link to the current pull request.

Changes:

  • Passes the PR number and URL into the validation step.
  • Checks added changelog lines for the expected PR link and reports an error when it is missing.
  • Adds a placeholder changelog entry.

Validation was limited to the supplied diffs; the repository snapshot was unavailable, and no checks were executed.

File Description
CHANGELOG.md Adds a placeholder entry for testing validation.
.github/​workflows/​pr-validation.yml Requires the current PR link in added changelog content.

Review effort: Balanced

Comment thread CHANGELOG.md Resolved
@rads-1996 Radhika Gupta (rads-1996) added the skip-changelog Not required for changes to test files, github actions, etc. label Nov 6, 2026
Copilot AI balanced review requested due to automatic review settings November 6, 2026 17:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active issues are recorded for the changelog-link validation change, although review was limited to the supplied diff and CI was not run.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@rads-1996
Radhika Gupta (rads-1996) merged commit 5659158 into microsoft:main Nov 6, 2026
16 checks passed
@rads-1996
Radhika Gupta (rads-1996) deleted the fail-for-missing-pr-link branch November 6, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Not required for changes to test files, github actions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants