Repository navigation
Require current PR link in changelog CI - #323
Merged
Radhika Gupta (rads-1996) merged 2 commits intoNov 6, 2026
Merged
Radhika Gupta (rads-1996) merged 2 commits into
Radhika Gupta (rads-1996) merged 2 commits into
Conversation
Performance comparisonThreshold: regressions >15.0% on gating scenarios fail the build. Higher ops/s is better; positive Δ means the PR is slower.
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The added changelog entry lacks this PR’s link, causing the new changelog validation step to fail whenever the job runs.
1 open issue
What changed in this PR
This PR strengthens changelog validation by requiring newly added CHANGELOG.md content to include a link to the current pull request.
Changes:
- Passes the PR number and URL into the validation step.
- Checks added changelog lines for the expected PR link and reports an error when it is missing.
- Adds a placeholder changelog entry.
Validation was limited to the supplied diffs; the repository snapshot was unavailable, and no checks were executed.
| File | Description |
|---|---|
| CHANGELOG.md | Adds a placeholder entry for testing validation. |
| .github/workflows/pr-validation.yml | Requires the current PR link in added changelog content. |
Review effort: Balanced
Jackson Weber (JacksonWeber)
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.