consommé: improve tcp tracing

[Daman Mulye (damanm24)]

This PR ensures all connection traces include structured src/dst details and that TcpError(s) carry the FourTuple with the error so that the traces can be related to a specific TCP flow; thus, making debugging the tcp state machine easier.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

vm/devices/net/net_consomme/consomme/src/tcp.rs:128

• TcpErrorKind is itself an Error, but it isn't marked as the source of TcpError, so TcpError::source() will return None and error-chain reporting will lose the underlying kind. Mark kind with #[source] to preserve the error chain while keeping the structured flow context in the top-level message.

#[error("{kind} for flow {flow}")]
pub struct TcpError {
    flow: FourTuple,
    kind: TcpErrorKind,
}