DO NOT COMMIT: IDE test

[Alex Landau (alandau)]

No description provided.

[Copilot]

Pull request overview

Adds temporary IDE “divergence probes” (log/counter instrumentation) and new metamorphic/property-style unit tests intended to detect Hyper-V compatibility differences and guard against enlightened-command interference/TOCTOU regressions.

Changes:

• Introduces IRQ divergence probes (A/B) and per-opcode dedup probing for unknown commands (C), plus additional IDEPROBE warnings (D/E/F).
• Extends IDE channel/drive logic with probe helpers for “pending IRQ while unselected” and “raw pending IRQ”.
• Adds new metamorphic tests to assert enlightened reads are invariant to non-target drive state, including a generated-interference property test.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
vm/devices/storage/ide/src/lib.rs	Adds probe counters/dedup helpers, hooks probe logic into I/O paths/IRQ updates, and adds metamorphic/property tests.
vm/devices/storage/ide/src/drive/hard_drive.rs	Adds probe helpers and several IDEPROBE warnings (non-512 sector, mid-command drive change, SET_FEATURES cache, unknown opcode).
vm/devices/storage/ide/src/drive/atapi_drive.rs	Adds probe helpers and unknown-opcode dedup warning for ATAPI.
vm/devices/storage/ide/src/drive.rs	Adds DiskDrive probe forwarding methods used by channel-level probe logic.

Suppressed comments (2)

vm/devices/storage/ide/src/lib.rs:1352

• This warning is guest-triggerable (interrupt behavior depends on guest I/O timing/state) and may be hit repeatedly. To avoid log spam in CI/production, prefer tracelimit::warn_ratelimited! here (the message is already edge-triggered, but can still oscillate).

            tracing::warn!(

vm/devices/storage/ide/src/drive/hard_drive.rs:975

• SET_FEATURES is guest-controlled and may be invoked frequently (e.g., polling drivers). Emitting an unbounded tracing::warn! here can flood logs; use tracelimit::warn_ratelimited! instead.

                    tracing::warn!(
                        subcommand = sub,
                        "IDEPROBE_D_SET_FEATURES_CACHE guest toggled write cache; UH ignores"
                    );
                }