Skip to content

feat(rallocator_cli): scroll long stack frames instead of wrapping - #667

Open
martintmk wants to merge 3 commits into
mainfrom
fix/snapshot-stack-scroll
Open

feat(rallocator_cli): scroll long stack frames instead of wrapping#667
martintmk wants to merge 3 commits into
mainfrom
fix/snapshot-stack-scroll

Conversation

@martintmk

@martintmk martintmk commented Aug 13, 2026

Copy link
Copy Markdown
Member

Before:

image

After:

image

@martintmk
martintmk marked this pull request as ready for review August 13, 2026 12:32
Copilot AI lite review requested due to automatic review settings August 13, 2026 12:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the rallocator_cli HTML snapshot template styling so long stack-frame lines scroll horizontally instead of wrapping, improving readability of stack traces in generated reports.

Changes:

  • Switch .stack rendering from wrap-anywhere to horizontal scrolling (overflow-x: auto) and prevent per-frame wrapping (white-space: nowrap).
  • Add thin/custom scrollbar styling for .stack (Firefox scrollbar-* and WebKit pseudo-elements).
  • Ensure grid children in .hotspot-stacks can shrink (min-width: 0) to avoid overflow issues.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (a650c15) to head (400db8a).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #667   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         503      503           
  Lines       57407    57407           
=======================================
  Hits        57407    57407           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@martintmk martintmk added the agency-rocket Touched by a rocket skill label Aug 13, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 80ca15a7-29b1-45d6-851f-501e3c6c9f0d
Copilot AI review requested due to automatic review settings August 13, 2026 15:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

justfiles/anvil/checks/doc-test.just:25

  • cargo metadata is being invoked without --locked, which can allow Cargo to update Cargo.lock (or otherwise resolve outside the locked set) before the subsequent cargo test --doc --locked runs. Other repository scripts use cargo metadata ... --locked to keep the workspace state deterministic (e.g. justfiles/extended.just:27). Consider adding --locked here as well.
        $meta = cargo metadata --no-deps --format-version 1 | ConvertFrom-Json

Comment thread justfiles/anvil/checks/doc-test.just Outdated
Keep PR #667 scoped to the snapshot template update.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 80ca15a7-29b1-45d6-851f-501e3c6c9f0d
Copilot AI review requested due to automatic review settings August 14, 2026 06:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agency-rocket Touched by a rocket skill

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants