fix(mcp): surface the missing executable path when a browser isn't installed#41941
Conversation
…stalled when a browser binary is missing, `throwIfExecutableMissing` caught playwright-core's `Executable doesn't exist at <path>` and rethrew a generic `Browser "<name>" is not installed`, dropping the path that path holds the version-specific directory (e.g. `firefox-1534`), which is what tells a genuinely missing install apart from a version mismatch — browsers from a standalone `playwright install` land in a differently-versioned directory than the bundled `playwright-core` expects keep the path in the rethrown message so the mismatch is diagnosable
Test results for "MCP"1 failed 7794 passed, 1266 skipped Merge workflow run. |
|
Hi, I'm the Playwright bot and I took a first look at the CI failures here. 🟢 The one failure is a pre-existing flake — this PR is clear
DetailsPre-existing flake / infra
Triaged by the Playwright bot - agent run |
when a browser binary is missing,
throwIfExecutableMissingcaught playwright-core'sExecutable doesn't exist at <path>and rethrew a genericBrowser "<name>" is not installed, dropping the paththat path holds the version-specific directory (e.g.
firefox-1534), which is what tells a genuinely missing install apart from a version mismatchbrowsers from a standalone
playwright installland in a differently-versioned directory than the bundledplaywright-coreexpectskeep the path in the rethrown message so the mismatch is diagnosable
this is a further improvement for #40867
referenced in #41871